Add specific specification for CmHandlePropertyChangeDetector

- Test will help with introducing V2 of LCM events
- Deliberately added test for unchanged attribute (to see legacy behavior)

Issue-ID: CPS-3072
Change-Id: I0ae568e370b11b2ed14ab59b7f11da1b892750ec
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>

diff --git a/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/sync/lcm/CmHandlePropertyChangeDetectorSpec.groovy b/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/sync/lcm/CmHandlePropertyChangeDetectorSpec.groovy
new file mode 100644 (file)
index 0000000..20e7b95
--- /dev/null
+++ b/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/sync/lcm/CmHandlePropertyChangeDetectorSpec.groovy
@@ -0,0 +1,140 @@
+/*
+ * ============LICENSE_START=======================================================
+ * Copyright (C) 2026 OpenInfra Foundation Europe. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.cps.ncmp.impl.inventory.sync.lcm
+
+import org.onap.cps.ncmp.api.inventory.models.CmHandleState
+import org.onap.cps.ncmp.api.inventory.models.CompositeState
+import org.onap.cps.ncmp.api.inventory.models.NcmpServiceCmHandle
+import org.onap.cps.ncmp.events.lcm.Values
+import spock.lang.Specification
+
+class CmHandlePropertyChangeDetectorSpec extends Specification {
+
+    def 'Determine updates for create operation.'() {
+        given: 'a new cm handle'
+            def ncmpServiceCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.READY),
+                publicProperties: ['prop1': 'value1']
+            )
+        when: 'updates are determined for create'
+            def result = CmHandlePropertyChangeDetector.determineUpdatesForCreate(ncmpServiceCmHandle)
+        then: 'new values are populated'
+            assert result.newValues.dataSyncEnabled == true
+            assert result.newValues.cmHandleState == Values.CmHandleState.READY
+            assert result.newValues.cmHandleProperties == [['prop1': 'value1']]
+        and: 'old values are not set'
+            assert result.oldValues == null
+    }
+
+    def 'Determine updates when no changes detected.'() {
+        given: 'current and target cm handles with same properties'
+            def currentCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.READY),
+                publicProperties: ['prop1': 'value1']
+            )
+            def targetCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.READY),
+                publicProperties: ['prop1': 'value1']
+            )
+        when: 'updates are determined'
+            def result = CmHandlePropertyChangeDetector.determineUpdates(currentCmHandle, targetCmHandle)
+        then: 'no updates are detected'
+            assert result.oldValues == null
+            assert result.newValues == null
+    }
+
+    def 'Determine updates when data sync flag changes.'() {
+        given: 'current and target cm handles with different data sync flags'
+            def currentCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: false, cmHandleState: CmHandleState.READY),
+                publicProperties: [:]
+            )
+            def targetCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.READY),
+                publicProperties: [:]
+            )
+        when: 'updates are determined'
+            def result = CmHandlePropertyChangeDetector.determineUpdates(currentCmHandle, targetCmHandle)
+        then: 'data sync flag change is detected'
+            assert result.oldValues.dataSyncEnabled == false
+            assert result.newValues.dataSyncEnabled == true
+    }
+
+    def 'Determine updates when cm handle state changes.'() {
+        given: 'current and target cm handles with different states'
+            def currentCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.ADVISED),
+                publicProperties: [:]
+            )
+            def targetCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.READY),
+                publicProperties: [:]
+            )
+        when: 'updates are determined'
+            def result = CmHandlePropertyChangeDetector.determineUpdates(currentCmHandle, targetCmHandle)
+        then: 'state change is detected'
+            assert result.oldValues.cmHandleState == Values.CmHandleState.ADVISED
+            assert result.newValues.cmHandleState == Values.CmHandleState.READY
+    }
+
+    def 'Determine updates when public properties change.'() {
+        given: 'current and target cm handles with different properties'
+            def currentCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.READY),
+                publicProperties: ['prop1': 'value1', 'prop2': 'value2', 'unchanged': 'sameValue']
+            )
+            def targetCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.READY),
+                publicProperties: ['prop1': 'newValue1', 'prop3': 'value3', 'unchanged': 'sameValue']
+            )
+        when: 'updates are determined'
+            def result = CmHandlePropertyChangeDetector.determineUpdates(currentCmHandle, targetCmHandle)
+        then: 'property changes are detected'
+            assert result.oldValues.cmHandleProperties[0]['prop1'] == 'value1'
+            assert result.oldValues.cmHandleProperties[0]['prop2'] == 'value2'
+            assert result.newValues.cmHandleProperties[0]['prop1'] == 'newValue1'
+            assert result.newValues.cmHandleProperties[0]['prop3'] == 'value3'
+        and: 'unchanged property is not included in the result'
+            assert !result.oldValues.cmHandleProperties[0].containsKey('unchanged')
+            assert !result.newValues.cmHandleProperties[0].containsKey('unchanged')
+    }
+
+    def 'Determine updates when multiple changes occur.'() {
+        given: 'current and target cm handles with multiple differences'
+            def currentCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: false, cmHandleState: CmHandleState.ADVISED),
+                publicProperties: ['prop1': 'value1']
+            )
+            def targetCmHandle = new NcmpServiceCmHandle(
+                compositeState: new CompositeState(dataSyncEnabled: true, cmHandleState: CmHandleState.READY),
+                publicProperties: ['prop1': 'newValue1']
+            )
+        when: 'updates are determined'
+            def result = CmHandlePropertyChangeDetector.determineUpdates(currentCmHandle, targetCmHandle)
+        then: 'all changes are detected'
+            assert result.oldValues.dataSyncEnabled == false
+            assert result.newValues.dataSyncEnabled == true
+            assert result.oldValues.cmHandleState == Values.CmHandleState.ADVISED
+            assert result.newValues.cmHandleState == Values.CmHandleState.READY
+            assert result.oldValues.cmHandleProperties[0]['prop1'] == 'value1'
+            assert result.newValues.cmHandleProperties[0]['prop1'] == 'newValue1'
+    }
+}