"orchStatus": "Active",
"modelInavariantId": "6b528779-44a3-4472-bdff-9cd15ec93450",
"testApi": "VNF_API"
-}
\ No newline at end of file
+}
const vnfNodeName = 'node-2017-488_PASQUALE-vPE 0';
cy.drawingBoardPressAddButtonByElementName(vnfNodeName).get('i').should('have.class', 'fa-plus-circle');
cy.drawingBoardPressAddButtonByElementName(vnfNodeName).click({force: true});
- cy.fillVnfPopup(true).then(() => {
+ cy.fillVnfPopup().then(() => {
cy.drawingBoardPressAddButtonByElementName(vnfNodeName).click({force: true});
cy.fillVnfPopup().then(() => {
cy.drawingBoardPressAddButtonByElementName(vnfNodeName).click({force: true});
cy.openIframe('app/ui/#/servicePlanning?serviceModelId=2f80c596-27e5-4ca9-b5bb-e03a7fd4c0fd');
cy.drawingBoardPressAddButtonByElementName('node-2017-488_PASQUALE-vPE 0').get('i').should('have.class', 'fa-plus-circle');
cy.drawingBoardPressAddButtonByElementName('node-2017-488_PASQUALE-vPE 0').click({force: true});
- cy.fillVnfPopup(true).then(() => {
+ cy.fillVnfPopup().then(() => {
cy.drawingBoardPressAddButtonByElementName('node-2017-488_PASQUALE-vPE 0').click({force: true});
cy.fillVnfPopup().then(() => {
cy.drawingBoardNumberOfExistingElementsShouldContains(2);
cy.openIframe('app/ui/#/servicePlanning?serviceModelId=2f80c596-27e5-4ca9-b5bb-e03a7fd4c0fd');
cy.drawingBoardPressAddButtonByElementName('node-2017-488_PASQUALE-vPE 0').get('i').should('have.class', 'fa-plus-circle')
.drawingBoardPressAddButtonByElementName('node-2017-488_PASQUALE-vPE 0').click({force: true});
- cy.fillVnfPopup(true).then(() => {
+ cy.fillVnfPopup().then(() => {
cy.drawingBoardTreeOpenContextMenuByElementDataTestId('node-69e09f68-8b63-4cc9-b9ff-860960b5db09-2017-488_PASQUALE-vPE 0')
.drawingBoardTreeClickOnContextMenuOptionByName('Duplicate')
.get('.quantity-select option').should('have.length', 9)
// add a vnf on update mode
cy.drawingBoardPressAddButtonByElementName('node-2017-388_PASQUALE-vPE 0').click({force: true});
cy.selectDropdownOptionByText('rollback', 'Rollback');
- cy.fillVnfPopup(true);
+ cy.fillVnfPopup();
// delete VNF
cy.drawingBoardTreeOpenContextMenuByElementDataTestId('node-69e09f68-8b63-4cc9-b9ff-860960b5db09-2017-488_PASQUALE-vPE 0', 0)
cy.wait('@expectedPostAsyncInstantiation').then(xhr => {
cy.readFile('../vid-automation/src/test/resources/asyncInstantiation/vidRequestDelete1Create1Vnf.json').then((expectedResult) => {
expectedResult.vnfs["2017-388_PASQUALE-vPE 0_1"].trackById = vnf.trackById;
- expectedResult.vnfs["2017-388_PASQUALE-vPE 0_1"].platformName = 'platform,xxx1';
+ expectedResult.vnfs["2017-388_PASQUALE-vPE 0_1"].instanceName = '2017-388_PASQUALE-vPE';
cy.deepCompare(expectedResult, xhr.request.body);
});
});
duplicateVnf: typeof DuplicateVnf,
}
}
-function FillVnfPopup(
changePlatformValue?: boolean): Chainable<any> {
+function FillVnfPopup(): Chainable<any> {
cy.selectDropdownOptionByText('productFamily', 'Emanuel');
cy.selectDropdownOptionByText('lcpRegion', 'hvf6');
cy.selectDropdownOptionByText('tenant', 'AIN Web Tool-15-D-STTest2');
cy.selectDropdownOptionByText('lineOfBusiness', 'zzz1');
- if(changePlatformValue === true){
- cy.selectPlatformValue('xxx1')
- }
+ cy.selectPlatformValue('xxx1');
return cy.getElementByDataTestsId('form-set').click({force : true}).then((done)=>{
return done;
});
import {getTestBed, TestBed} from '@angular/core/testing';
import {AaiService} from "../../../services/aaiService/aai.service";
-import {FormControlModel, ValidatorModel, ValidatorOptions} from "../../../models/formControlModels/formControl.model";
+import {FormControlModel} from "../../../models/formControlModels/formControl.model";
import {FeatureFlagsService} from "../../../services/featureFlag/feature-flags.service";
import {BasicControlGenerator} from "./basic.control.generator";
import {NgRedux} from '@angular-redux/store';
+import each from "jest-each";
import {HttpClientTestingModule, HttpTestingController} from '@angular/common/http/testing';
import {FileFormControl} from "../../../models/formControlModels/fileFormControl.model";
"supplementaryFile_hidden_content"
]);
});
-});
+ each([
+ [null, false],
+ [{}, true]
+ ]).
+ test('retrieveInstanceIfUpdateMode returns %s if update mode is %s', (expected, isUpdateModalMode) => {
+ //given
+ const store= <any>{
+ getState() {
+ return {
+ global: {
+ isUpdateModalMode
+ }
+ }}};
+ const instance = {};
+
+ //when
+ let retrievedInstance = service.retrieveInstanceIfUpdateMode (store, instance);
+ //then
+ expect(retrievedInstance).toEqual(expected);
+
+ });
+
+});
})
};
+ retrieveInstanceIfUpdateMode(store: NgRedux<AppState>, instance: any): any{
+ return store.getState().global.isUpdateModalMode ? instance : null;
+ }
+
private getOnDeleteForSupplementaryFile() {
return (form: FormGroup) => {
form.controls[SUPPLEMENTARY_FILE + "_hidden"].setValue(null);
this._logService.error('should provide serviceId, networkName, networkStoreKey', serviceId);
return [];
}
-
- const networkInstance = this.getNetworkInstance(serviceId, networkStoreKey, isUpdateMode);
+ const networkInstance = this._basicControlGenerator.retrieveInstanceIfUpdateMode(this.store, this.getNetworkInstance(serviceId, networkStoreKey, isUpdateMode));
const networkModel = new NetworkModel(this.store.getState().service.serviceHierarchy[serviceId].networks[networkName]);
let result: FormControlModel[] = [];
}
let result: FormControlModel[] = [];
- const networkInstance = this.getNetworkInstance(serviceId, networkStoreKey, isUpdateMode);
+ const networkInstance = this._basicControlGenerator.retrieveInstanceIfUpdateMode(this.store, this.getNetworkInstance(serviceId, networkStoreKey, isUpdateMode));
const networkModel = new NetworkModel(this.store.getState().service.serviceHierarchy[serviceId].networks[networkName]);
if (!_.isNil(networkModel)) {
}
}
- const vfModuleInstance = this.getVfModuleInstance(serviceId, vnfStoreKey, uuidData, isUpdateMode);
+ const vfModuleInstance = this._basicControlGenerator.retrieveInstanceIfUpdateMode(this.store, this.getVfModuleInstance(serviceId, vnfStoreKey, uuidData, isUpdateMode));
const vfModuleModel = this.vfModuleModel;
const vnf: VnfInstance = this.store.getState().service.serviceInstance[serviceId].vnfs[vnfStoreKey];
const vnfModelName: string = vnf.originalName;
return [];
}
}
- const vnf: VnfInstance = this.store.getState().service.serviceInstance[serviceId].vnfs[vnfStoreKey];
+ const vnf: VnfInstance = this.store.getState().service.serviceInstance[serviceId].vnfs[vnfStoreKey] ;
const vnfModelName: string = vnf.originalName;
const vnfModel = new VNFModel(this.store.getState().service.serviceHierarchy[serviceId].vnfs[vnfModelName]);
- const vfModuleInstance = this.getVfModuleInstance(serviceId, vnfStoreKey, uuidData, isUpdateMode);
+ const vfModuleInstance = this._basicControlGenerator.retrieveInstanceIfUpdateMode(this.store, this.getVfModuleInstance(serviceId, vnfStoreKey, uuidData, isUpdateMode));
let result: FormControlModel[] = [];
this.pushInstanceAndVGToForm(result, vfModuleInstance, serviceId, vnfModel, true);
result.push(this.getLcpRegionControl(serviceId, vfModuleInstance, result));
this._logService.error('should provide serviceId, vnfName, vnfStoreKey', serviceId);
return [];
}
-
- const vnfInstance = this.getVnfInstance(serviceId, vnfStoreKey);
+ const vnfInstance = this._basicControlGenerator.retrieveInstanceIfUpdateMode(this.store,this.getVnfInstance(serviceId, vnfStoreKey));
const vnfModel = new VNFModel(this.store.getState().service.serviceHierarchy[serviceId].vnfs[vnfName]);
let result: FormControlModel[] = [];
const flags = this.store.getState().global.flags;
}
let result: FormControlModel[] = [];
- const vnfInstance = this.getVnfInstance(serviceId, vnfStoreKey);
+ const vnfInstance = this._basicControlGenerator.retrieveInstanceIfUpdateMode(this.store,this.getVnfInstance(serviceId, vnfStoreKey));
const vnfModel = new VNFModel(this.store.getState().service.serviceHierarchy[serviceId].vnfs[vnfName]);
if (!_.isNil(vnfModel)) {
return [];
}
- const vnfGroupInstance = this.getVnfGroupInstance(serviceId, vnfGroupStoreKey);
+ const vnfGroupInstance = this._basicControlGenerator.retrieveInstanceIfUpdateMode(this.store, this.getVnfGroupInstance(serviceId, vnfGroupStoreKey));
const vnfGroupModel = new VnfGroupModel(this.store.getState().service.serviceHierarchy[serviceId].vnfGroups[vnfGroupName]);
let result: FormControlModel[] = [];
}
let result: FormControlModel[] = [];
- const vnfGroupInstance = this.getVnfGroupInstance(serviceId, vnfGroupStoreKey);
+ const vnfGroupInstance = this._basicControlGenerator.retrieveInstanceIfUpdateMode(this.store, this.getVnfGroupInstance(serviceId, vnfGroupStoreKey));
const vnfGroupModel = new VnfGroupModel(this.store.getState().service.serviceHierarchy[serviceId].vnfGroups[vnfGroupName]);
if (!_.isNil(vnfGroupModel)) {
<div class="modal-header">
<button type="button"
class="close"
- (click)="formPopupDetails?.onCancel(formPopupDetails.that,dynamicForm)">×
+ (click)="formPopupDetails?.onCancel(formPopupDetails.that,dynamicForm);clearModalIsUpdateMode()">×
</button>
<span [attr.data-tests-id]="'create-modal-title'"
class="modal-title">{{formPopupDetails?.title}}
<button
[attr.data-tests-id]="'cancelButton'"
type="button" class="btn btn-default cancel"
- (click)="formPopupDetails.onCancel(formPopupDetails.that, dynamicForm)"><span>Cancel</span></button>
+ (click)="formPopupDetails.onCancel(formPopupDetails.that, dynamicForm); clearModalIsUpdateMode()"><span>Cancel</span></button>
<input type="submit"
value="Set"
data-tests-id="form-set"
class="btn btn-success submit"
[disabled]="!dynamicForm?.valid"
- (click)="formPopupDetails.onSubmit(formPopupDetails.that, dynamicForm, servicesQty)">
+ (click)="formPopupDetails.onSubmit(formPopupDetails.that, dynamicForm, servicesQty);clearModalIsUpdateMode()">
</div>
</div>
</div>
import {FormGeneralErrorsService} from "../formGeneralErrors/formGeneralErrors.service";
import {FeatureFlagsService, Features} from "../../services/featureFlag/feature-flags.service";
import {InstantiationTemplatesModalComponent} from "./instantiationTemplatesModal/instantiation.templates.modal.component";
+import {updateCurrentModalModeAction} from "../../storeUtil/utils/global/global.actions";
export interface PopupModel {
return this.formPopupDetails && this.formPopupDetails.UUIDData['bulkSize'] > 1
}
+ clearModalIsUpdateMode() : void {
+ this._store.dispatch(updateCurrentModalModeAction(null));
+ }
+
ngOnInit(): void {
+ this._store.dispatch(updateCurrentModalModeAction(this.isUpdateMode));
this._route
.queryParams
.subscribe(params => {
UPDATE_GENERIC_MODAL_TABLE_DATA_HELPER = 'UPDATE_GENERIC_MODAL_TABLE_DATA_HELPER',
DELETE_GENERIC_MODAL_TABLE_DATA_HELPER = 'DELETE_GENERIC_MODAL_TABLE_DATA_HELPER',
UPDATE_GENERIC_CURRNT_VRF_HELPER = 'UPDATE_GENERIC_CURRNT_VRF_HELPER',
- DELETE_GENERIC_CURRNT_VRF_HELPER = 'DELETE_GENERIC_CURRNT_VRF_HELPER'
+ DELETE_GENERIC_CURRNT_VRF_HELPER = 'DELETE_GENERIC_CURRNT_VRF_HELPER',
+ UPDATE_CURRENT_MODAL_MODE = 'UPDATE_CURRENT_MODAL_MODE'
}
+export interface UpdateCurrentModalModeAction extends Action {
+ isUpdateModalMode?: boolean;
+}
+
+
export interface UpdateGlobalAction extends Action {
name?: string;
}
export const clearAllGenericModalhelper: ActionCreator<ClearGenericModalHelper> = (field, uniqObjectField) => ({
type : GlobalActions.CLEAR_ALL_GENERIC_MODAL_HELPER
});
+
+export const updateCurrentModalModeAction: ActionCreator<UpdateCurrentModalModeAction> = (isUpdateModalMode? :boolean) => ({
+ type : GlobalActions.UPDATE_CURRENT_MODAL_MODE,
+ isUpdateModalMode
+});
UpdateGenericModalHelper,
DeleteGenericModalHelper,
ClearGenericModalHelper,
- UpdateGenericModalTableDataHelper
+ UpdateGenericModalTableDataHelper, UpdateCurrentModalModeAction
} from "./global.actions";
import {globalReducer} from "./global.reducers";
expect(globalDrawingBoardState.genericModalHelper[keyName]).toBeUndefined();
});
+
+
+ test('#UPDATE_CURRENT_MODAL_MODE : should update current modal mode: true', ()=> {
+ let globalDrawingBoardState = globalReducer(<any>{global : {},genericModalHelper : {
+ isUpdateModalMode : null
+ }},
+ <UpdateCurrentModalModeAction>{
+ type: GlobalActions.UPDATE_CURRENT_MODAL_MODE,
+ isUpdateModalMode : true
+ });
+ expect(globalDrawingBoardState.isUpdateModalMode).toBeTruthy();
+ });
+
+
+ test('#UPDATE_CURRENT_MODAL_MODE : should update current modal mode: false', ()=> {
+ let globalDrawingBoardState = globalReducer(<any>{global : {},genericModalHelper : {
+ isUpdateModalMode : true
+ }},
+ <UpdateCurrentModalModeAction>{
+ type: GlobalActions.UPDATE_CURRENT_MODAL_MODE,
+ isUpdateModalMode : false
+ });
+ expect(globalDrawingBoardState.isUpdateModalMode).toBeFalsy();
+ });
+
+ test('#UPDATE_CURRENT_MODAL_MODE : should delete modal mode if value is null', ()=> {
+ let globalDrawingBoardState = globalReducer(<any>{global : {},genericModalHelper : {
+ isUpdateModalMode : true
+ }},
+ <UpdateCurrentModalModeAction>{
+ type: GlobalActions.UPDATE_CURRENT_MODAL_MODE,
+ isUpdateModalMode : null
+ });
+ expect(globalDrawingBoardState.isUpdateModalMode).toBeUndefined();
+ });
+
+
});
UpdateGenericModalHelper,
DeleteGenericModalHelper,
DeleteGenericModalTabelDataHelper,
- UpdateGenericModalTableDataHelper
+ UpdateGenericModalTableDataHelper, UpdateCurrentModalModeAction
} from "./global.actions";
import * as _ from "lodash";
drawingBoardStatus : string;
genericModalCriteria : { [key: string]: any };
genericModalHelper : { [key: string]: any };
+ isUpdateModalMode?: boolean;
}
genericModalCriteria : {
roles : []
},
- genericModalHelper : {}
+ genericModalHelper : {},
+ isUpdateModalMode : null
};
export const globalReducer =
newState.genericModalHelper[(<UpdateGenericModalTableDataHelper>action).field] = (<UpdateGenericModalTableDataHelper>action).values ;
return newState;
}
+ case GlobalActions.UPDATE_CURRENT_MODAL_MODE : {
+ let newState = {...state};
+ if ((<UpdateCurrentModalModeAction>action).isUpdateModalMode === null){
+ delete newState.isUpdateModalMode;
+ } else {
+ newState.isUpdateModalMode = (<UpdateCurrentModalModeAction>action).isUpdateModalMode;
+ }
+ return newState;
+ }
default:
return state;
}
Code Review / vid.git / commitdiff