Merge "VfModule and VolumeGroup RequestParameters: introduce objects hierarchy"
authorAmichai Hemli <amichai.hemli@intl.att.com>
Mon, 25 Nov 2019 08:44:19 +0000 (08:44 +0000)
committerGerrit Code Review <gerrit@onap.org>
Mon, 25 Nov 2019 08:44:19 +0000 (08:44 +0000)
29 files changed:
vid-app-common/src/main/java/org/onap/vid/properties/Features.java
vid-app-common/src/main/webapp/WEB-INF/conf/dev.features.properties
vid-app-common/src/main/webapp/WEB-INF/conf/onap.features.properties
vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js
vid-app-common/src/main/webapp/app/vid/scripts/controller/aaiSubscriberController.js
vid-automation/src/main/java/vid/automation/test/infra/Features.java
vid-automation/src/main/java/vid/automation/test/test/CreateNewInstanceTest.java
vid-automation/src/main/resources/NewServiceInstanceTest/createNewServiceInstance_macro_validPopupDataAndUI__dynamicFieldsEcompNamingFalse.json
vid-automation/src/test/resources/features.properties
vid-webpack-master/cypress/integration/iFrames/collectionResource.e2e.ts
vid-webpack-master/cypress/integration/iFrames/drawingBoard.e2e.ts
vid-webpack-master/cypress/integration/iFrames/network.popup.e2e.ts
vid-webpack-master/cypress/integration/iFrames/pnf.e2e.ts
vid-webpack-master/cypress/integration/iFrames/vnf.popup.e2e.ts
vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/flags.cypress.json
vid-webpack-master/src/app/drawingBoard/service-planning/objectsToTree/models/vrf/vrfModal/networkStep/network.step.service.spec.ts
vid-webpack-master/src/app/drawingBoard/service-planning/objectsToTree/shared.tree.service.spec.ts
vid-webpack-master/src/app/shared/components/genericForm/formControlsServices/networkGenerator/network.control.generator.spec.ts
vid-webpack-master/src/app/shared/components/genericForm/formControlsServices/service.control.generator.spec.ts
vid-webpack-master/src/app/shared/components/genericForm/formControlsServices/vfModuleGenerator/vfModule.control.generator.spec.ts
vid-webpack-master/src/app/shared/components/genericForm/formControlsServices/vnfGenerator/vnf.control.generator.spec.ts
vid-webpack-master/src/app/shared/components/genericForm/formControlsServices/vnfGroupGenerator/vnfGroup.control.generator.spec.ts
vid-webpack-master/src/app/shared/components/genericFormPopup/generic-form-popup.service.spec.ts
vid-webpack-master/src/app/shared/components/genericFormPopup/genericFormServices/basic.popup.service.spec.ts
vid-webpack-master/src/app/shared/components/genericFormPopup/genericFormServices/network/network.popup.service.spec.ts
vid-webpack-master/src/app/shared/components/genericFormPopup/genericFormServices/service/service.popup.service.spec.ts
vid-webpack-master/src/app/shared/components/genericFormPopup/genericFormServices/vfModule/vfModule.popuop.service.spec.ts
vid-webpack-master/src/app/shared/components/genericFormPopup/genericFormServices/vnf/vnf.popup.service.spec.ts
vid-webpack-master/src/app/shared/components/genericFormPopup/genericFormServices/vnfGroup/vnfGroup.popup.service.spec.ts

index 5bf4fbd..232484b 100644 (file)
@@ -29,7 +29,6 @@ public enum Features implements Feature {
      * Use /docs/feature-flags.md for details
      */
 
-    CREATE_INSTANCE_TEST,
     EMPTY_DRAWING_BOARD_TEST,
     FLAG_ADD_MSO_TESTAPI_FIELD,
     FLAG_SERVICE_MODEL_CACHE,
index 7152d91..d5d2ead 100644 (file)
@@ -1,6 +1,5 @@
 FLAG_ENABLE_WEBPACK_MODERN_UI = true
 FLAG_ASYNC_JOBS = true
-CREATE_INSTANCE_TEST = false
 EMPTY_DRAWING_BOARD_TEST = false
 FLAG_ADD_MSO_TESTAPI_FIELD = true
 FLAG_UNASSIGN_SERVICE = true
@@ -10,7 +9,6 @@ FLAG_SERVICE_MODEL_CACHE = true
 FLAG_SHOW_ASSIGNMENTS = true
 FLAG_HANDLE_SO_WORKFLOWS = true
 FLAG_CREATE_ERROR_REPORTS = true
-
 FLAG_SHOW_VERIFY_SERVICE = true
 FLAG_DUPLICATE_VNF = true
 FLAG_DEFAULT_VNF = true
index 709de95..29672bc 100644 (file)
@@ -1,6 +1,5 @@
 FLAG_PNP_INSTANTIATION = true
 
-CREATE_INSTANCE_TEST = false
 FLAG_ADD_MSO_TESTAPI_FIELD = true
 FLAG_UNASSIGN_SERVICE = true
 FLAG_SERVICE_MODEL_CACHE = true
index 6d8dde8..4b6b0f4 100755 (executable)
             var isVfc = false;\r
 \r
             _.map($scope.service.model.vnfs, function (value, key) {\r
-                if (value.uuid == vnf.uuid) {\r
-                    if (!_.isEmpty(value.vfcInstanceGroups)) {\r
+                if (value.uuid == vnf.uuid && !_.isEmpty(value.vfcInstanceGroups)) {\r
                         isVfc = true;\r
                         var queryData = {\r
                             serviceModelId: $scope.service.model.service.uuid,\r
                         $scope.$broadcast(COMPONENT.IFRAME_DIALOG, queryData);\r
                         return;\r
                     }\r
-                }\r
             });\r
 \r
             DataService.setSubscriberName($scope.service.instance.subscriberName);\r
index bf3d54a..110f24e 100755 (executable)
@@ -489,8 +489,7 @@ appDS2.controller("aaiSubscriberController", ["COMPONENT", "FIELD", "PARAMETER",
             if (model && model.vnfs && !_.isEmpty(model.vnfs)) {\r
                 Object.keys(model.vnfs).forEach(function (key) {\r
                     var vnf = model.vnfs[key];\r
-                    if (vnf.vfcInstanceGroups && !_.isEmpty(vnf.vfcInstanceGroups)) {\r
-                        if (vnf.uuid === genericVnf.modelVersionId) {\r
+                    if (vnf.vfcInstanceGroups && !_.isEmpty(vnf.vfcInstanceGroups) && vnf.uuid === genericVnf.modelVersionId) {\r
                             AaiService.getInstanceGroupsByVNFInstanceId(genericVnf.nodeId,\r
                                 function (response) { //success\r
                                     handleGetRelatedInstanceGroupsResponseForVnf(response, genericVnf);\r
@@ -502,7 +501,6 @@ appDS2.controller("aaiSubscriberController", ["COMPONENT", "FIELD", "PARAMETER",
                                 }\r
                             )\r
                         }\r
-                    }\r
                 });\r
             }\r
         }\r
@@ -797,11 +795,9 @@ appDS2.controller("aaiSubscriberController", ["COMPONENT", "FIELD", "PARAMETER",
         };\r
 \r
         $scope.isShowAssignmentsEnabled = function () {\r
-            if (featureFlags.isOn(COMPONENT.FEATURE_FLAGS.FLAG_SHOW_ASSIGNMENTS)) {\r
-                if ($scope.serviceOrchestrationStatus) {\r
+            if (featureFlags.isOn(COMPONENT.FEATURE_FLAGS.FLAG_SHOW_ASSIGNMENTS) && $scope.serviceOrchestrationStatus) {\r
                     return $scope.serviceOrchestrationStatus.toLowerCase() === 'assigned';\r
                 }\r
-            }\r
             return false;\r
         };\r
 \r
index a2892e5..5a3026a 100644 (file)
@@ -5,7 +5,6 @@ import org.togglz.core.context.FeatureContext;
 
 public enum Features implements Feature {
 
-    CREATE_INSTANCE_TEST,
     EMPTY_DRAWING_BOARD_TEST,
     FLAG_ADD_MSO_TESTAPI_FIELD,
     FLAG_SERVICE_MODEL_CACHE,
index b57d187..be96e69 100644 (file)
@@ -1,11 +1,12 @@
 package vid.automation.test.test;
 
+import java.io.IOException;
+import java.util.List;
 import org.onap.sdc.ci.tests.utilities.GeneralUIUtils;
 import org.openqa.selenium.WebElement;
 import org.testng.Assert;
 import org.testng.annotations.Test;
 import vid.automation.test.Constants;
-import vid.automation.test.infra.Features;
 import vid.automation.test.infra.Get;
 import vid.automation.test.infra.SelectOption;
 import vid.automation.test.model.Service;
@@ -16,24 +17,15 @@ import vid.automation.test.services.BulkRegistration;
 import vid.automation.test.services.ServicesService;
 import vid.automation.test.services.SimulatorApi;
 
-import java.io.IOException;
-import java.util.List;
-
 public class CreateNewInstanceTest extends CreateInstanceDialogBaseTest {
     private ServicesService servicesService = new ServicesService();
 
     public CreateNewInstanceTest() throws IOException {
     }
 
-    @Test
+    @Test(groups = { "underDevelopment" })
     private void testCreateNewServiceInstance() throws Exception {
 
-        if (!Features.CREATE_INSTANCE_TEST.isActive()) {
-
-            // time bomb, as it fails on pipeline and I don't know how to fix it
-            return;
-        }
-
         SimulatorApi.clearAll();
         BulkRegistration.createNewServiceInstance("SILVIA ROBBINS");
 
index 25725db..0a8e09f 100644 (file)
@@ -11,7 +11,6 @@
       "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
       "FLAG_ASYNC_ALACARTE_VNF": true,
       "FLAG_SERVICE_MODEL_CACHE": true,
-      "CREATE_INSTANCE_TEST": false,
       "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": true,
       "FLAG_SUPPLEMENTARY_FILE": true,
       "EMPTY_DRAWING_BOARD_TEST": false,
     },
     "type": "[LCP_REGIONS_AND_TENANTS] Update"
   }
-}
\ No newline at end of file
+}
index 1324403..f3ed491 100644 (file)
@@ -1,4 +1,3 @@
-CREATE_INSTANCE_TEST = false
 EMPTY_DRAWING_BOARD_TEST = false
 FLAG_ADD_MSO_TESTAPI_FIELD = true
 FLAG_NETWORK_TO_ASYNC_INSTANTIATION = false
index a9649fa..adc142a 100644 (file)
@@ -1602,7 +1602,6 @@ describe('Drawing board : Collection resource', function () {
           "FLAG_SERVICE_MODEL_CACHE": true,
           "FLAG_1902_RETRY_JOB": true,
           "FLAG_EXP_ANY_ALACARTE_NEW_INSTANTIATION_UI": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": true,
           "FLAG_1906_AAI_SUB_DETAILS_REDUCE_DEPTH": true,
           "FLAG_VF_MODULE_RESUME_STATUS_CREATE": true,
index e379f78..ac9d690 100644 (file)
@@ -582,7 +582,6 @@ describe('Drawing board', function () {
           "FLAG_NETWORK_TO_ASYNC_INSTANTIATION": false,
           "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
           "FLAG_SERVICE_MODEL_CACHE": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "FLAG_1906_COMPONENT_INFO" : false
         },
@@ -2211,7 +2210,6 @@ describe('Drawing board', function () {
           "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": true,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true
@@ -3864,7 +3862,6 @@ describe('Drawing board', function () {
           "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": true,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true
@@ -5603,7 +5600,6 @@ describe('Drawing board', function () {
         "name": null,
         "type": "UPDATE_DRAWING_BOARD_STATUS",
         "flags": {
-          "CREATE_INSTANCE_TEST": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_NETWORK_TO_ASYNC_INSTANTIATION": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true,
@@ -6303,7 +6299,6 @@ describe('Drawing board', function () {
           "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true,
index 8768e34..059c8b7 100644 (file)
@@ -213,7 +213,6 @@ describe('Network popup', function () {
             "FLAG_SHOW_VERIFY_SERVICE": false,
             "FLAG_SERVICE_MODEL_CACHE": true,
             "FLAG_ADVANCED_PORTS_FILTER": true,
-            "CREATE_INSTANCE_TEST": false,
             "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
             "FLAG_REGION_ID_FROM_REMOTE": true,
             "EMPTY_DRAWING_BOARD_TEST": false,
index 0e10618..c3b4026 100644 (file)
@@ -1463,7 +1463,6 @@ function initDrawingBoardWithFourPnf(serviceModelId: string, pnfName: string) {
           "FLAG_SERVICE_MODEL_CACHE": true,
           "FLAG_1902_RETRY_JOB": true,
           "FLAG_EXP_ANY_ALACARTE_NEW_INSTANTIATION_UI": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": true,
           "FLAG_1906_AAI_SUB_DETAILS_REDUCE_DEPTH": true,
           "FLAG_VF_MODULE_RESUME_STATUS_CREATE": true,
index a014400..2335411 100644 (file)
@@ -96,7 +96,6 @@ describe('Vnf popup', function () {
             "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
             "FLAG_SHOW_VERIFY_SERVICE": false,
             "FLAG_SERVICE_MODEL_CACHE": true,
-            "CREATE_INSTANCE_TEST": false,
             "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
             "EMPTY_DRAWING_BOARD_TEST": false,
             "FLAG_ADD_MSO_TESTAPI_FIELD": true
index 40b37cb..d9561f1 100644 (file)
@@ -1,5 +1,4 @@
 {
-  "CREATE_INSTANCE_TEST": false,
   "EMPTY_DRAWING_BOARD_TEST": false,
   "FLAG_NETWORK_TO_ASYNC_INSTANTIATION": false,
   "FLAG_ADD_MSO_TESTAPI_FIELD": true,
index c7c8d07..5d502c2 100644 (file)
@@ -84,7 +84,6 @@ describe('Network step service', () => {
         "genericModalCriteria": {"roles": ["-- select an option --", "network role 1", "network role 2", "network role 3", "network role 4", "network role 5"]},
         "name": null,
         "flags": {
-          "CREATE_INSTANCE_TEST": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_NETWORK_TO_ASYNC_INSTANTIATION": false,
           "FLAG_ENABLE_WEBPACK_MODERN_UI": true,
index 1412faa..53854ac 100644 (file)
@@ -467,7 +467,6 @@ function getStore() {
     "global": {
       "name": null,
       "flags": {
-        "CREATE_INSTANCE_TEST": false,
         "EMPTY_DRAWING_BOARD_TEST": false,
         "FLAG_NETWORK_TO_ASYNC_INSTANTIATION": false,
         "FLAG_ADD_MSO_TESTAPI_FIELD": true,
index 5b64aea..4d6d847 100644 (file)
@@ -25,7 +25,6 @@ class MockAppStore<T> {
       "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
       "FLAG_SHOW_VERIFY_SERVICE": false,
       "FLAG_SERVICE_MODEL_CACHE": true,
-      "CREATE_INSTANCE_TEST": false,
       "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
       "EMPTY_DRAWING_BOARD_TEST": false,
       "FLAG_ADD_MSO_TESTAPI_FIELD": true
index a6a29d1..510508c 100644 (file)
@@ -25,7 +25,6 @@ class MockAppStore<T> {
           "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true
index f8a2da7..f11cc6b 100644 (file)
@@ -27,7 +27,6 @@ class MockAppStore<T> {
           "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true
index 66afac9..eb16f9c 100644 (file)
@@ -28,7 +28,6 @@ class MockAppStore<T> {
           "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true
index 71d6611..73fd878 100644 (file)
@@ -25,7 +25,6 @@ class MockAppStore<T> {
         "type": "UPDATE_DRAWING_BOARD_STATUS",
         "drawingBoardStatus": "CREATE",
         "flags": {
-          "CREATE_INSTANCE_TEST": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_NETWORK_TO_ASYNC_INSTANTIATION": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true,
index ab70ea3..605f4f7 100644 (file)
@@ -33,7 +33,6 @@ class MockAppStore<T>{
           "FLAG_FABRIC_CONFIGURATION_ASSIGNMENTS": true,
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true
index 54af063..4976032 100644 (file)
@@ -33,7 +33,6 @@ class MockReduxStore<T> {
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
           "FLAG_ADVANCED_PORTS_FILTER": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "FLAG_REGION_ID_FROM_REMOTE": true,
           "EMPTY_DRAWING_BOARD_TEST": false,
index eb094ab..801ec3b 100644 (file)
@@ -30,7 +30,6 @@ class MockReduxStore<T> {
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
           "FLAG_ADVANCED_PORTS_FILTER": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "FLAG_REGION_ID_FROM_REMOTE": true,
           "EMPTY_DRAWING_BOARD_TEST": false,
index 5b5acd3..74eb649 100644 (file)
@@ -31,7 +31,6 @@ class MockReduxStore<T> {
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
           "FLAG_ADVANCED_PORTS_FILTER": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "FLAG_REGION_ID_FROM_REMOTE": true,
           "EMPTY_DRAWING_BOARD_TEST": false,
index 5b27b6e..bc8a851 100644 (file)
@@ -30,7 +30,6 @@ class MockReduxStore<T> {
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
           "FLAG_ADVANCED_PORTS_FILTER": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "FLAG_REGION_ID_FROM_REMOTE": true,
           "EMPTY_DRAWING_BOARD_TEST": false,
index b1bbc92..14faff0 100644 (file)
@@ -30,7 +30,6 @@ class MockReduxStore<T> {
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
           "FLAG_ADVANCED_PORTS_FILTER": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "FLAG_REGION_ID_FROM_REMOTE": true,
           "EMPTY_DRAWING_BOARD_TEST": false,
index 075c972..80c8539 100644 (file)
@@ -30,7 +30,6 @@ class MockReduxStore<T> {
           "FLAG_SHOW_VERIFY_SERVICE": false,
           "FLAG_SERVICE_MODEL_CACHE": true,
           "FLAG_ADVANCED_PORTS_FILTER": true,
-          "CREATE_INSTANCE_TEST": false,
           "FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD": false,
           "FLAG_REGION_ID_FROM_REMOTE": true,
           "EMPTY_DRAWING_BOARD_TEST": false,