Refactor and complete MR UTs

The Message Router Unit tests were incomplete, this change add news
for covering all its functions.

Change-Id: I02738798e358527ed2b710a192d0a796814b5d69
Signed-off-by: Victor Morales <victor.morales@intel.com>
Issue-Id: INT-104

diff --git a/bootstrap/vagrant-onap/lib/mr b/bootstrap/vagrant-onap/lib/mr
index 869994d..76b27b1 100755 (executable)
--- a/bootstrap/vagrant-onap/lib/mr
+++ b/bootstrap/vagrant-onap/lib/mr
@@ -3,23 +3,32 @@
 set -o xtrace
 
 source /var/onap/functions
-source /var/onap/asserts
 
 src_folder=$git_src_folder/dcae/message-router
 
-# install_message_router() - Downloads and configure message router source code
-function _install_message_router {
+# clone_mr_repos() - Function that clones the Message Router repositories
+function clone_mr_repos {
     clone_repo dcae/demo/startup/message-router $src_folder
-    pushd $src_folder
+}
+
+# get_mr_images() - Function that retrieves the Message Router Docker images
+function get_mr_images {
     pull_docker_image attos/dmaap
     pull_docker_image wurstmeister/zookeeper
+}
+
+# install_message_router() - Downloads and configure message router source code
+function install_message_router {
     install_docker_compose
+
+    pushd $src_folder
     bash deploy.sh
-    asserts_image dockerfiles_kafka
     popd
 }
 
 # init_mr() - Function that initialize Message Router services
 function init_mr {
-    _install_message_router
+    clone_mr_repos
+    get_mr_images
+    install_message_router
 }

diff --git a/bootstrap/vagrant-onap/tests/test_mr b/bootstrap/vagrant-onap/tests/test_mr
index 6fad083..d8db849 100644 (file)
--- a/bootstrap/vagrant-onap/tests/test_mr
+++ b/bootstrap/vagrant-onap/tests/test_mr
@@ -4,19 +4,33 @@ source /var/onap_tests/_test_base
 source /var/onap/mr
 
 covered_functions=(
-"init_mr"
+"clone_mr_repos" "get_mr_images" "install_message_router"
 )
 
-# test_init_mr() - Verify the built and start of Message Router services
-function test_init_mr {
-    init_mr
+# test_clone_mr_repos() - Verify that Message Router repositories are cloned properly
+function test_clone_mr_repos {
+    clone_mr_repos
+
+    asserts_file_exist $src_folder/deploy.sh
+}
+
+# test_get_mr_images() - Verify that Message Router Docker images are retrieved
+function test_get_mr_images {
+    get_mr_images
 
-    asserts_image dockerfiles_kafka
-    asserts_image anapsix/alpine-java
     asserts_image attos/dmaap
     asserts_image wurstmeister/zookeeper
 }
 
+# test_install_message_router() - Verify the built and start of Message Router services
+function test_install_message_router {
+    clone_mr_repos
+    get_mr_images
+    install_message_router
+
+    asserts_image_running dockerfiles_kafka
+}
+
 if [ "$1" != '*' ]; then
     unset covered_functions
     covered_functions=$1