Merge this if statement with the enclosing one. 90/98090/2
authoranushadasari <danush10@in.ibm.com>
Thu, 7 Nov 2019 07:22:51 +0000 (12:52 +0530)
committerIttay Stern <ittay.stern@att.com>
Sun, 24 Nov 2019 16:35:14 +0000 (16:35 +0000)
Merging collapsible if statements increases the code's readability.

Issue-ID: VID-699
Change-Id: I9460c6b621815339f873761c0e7ba0bf9c479578
Signed-off-by: anushadasari <danush10@in.ibm.com>
vid-app-common/src/main/webapp/app/vid/scripts/controller/aaiSubscriberController.js

index bf3d54a..517f072 100755 (executable)
@@ -489,8 +489,7 @@ appDS2.controller("aaiSubscriberController", ["COMPONENT", "FIELD", "PARAMETER",
             if (model && model.vnfs && !_.isEmpty(model.vnfs)) {\r
                 Object.keys(model.vnfs).forEach(function (key) {\r
                     var vnf = model.vnfs[key];\r
-                    if (vnf.vfcInstanceGroups && !_.isEmpty(vnf.vfcInstanceGroups)) {\r
-                        if (vnf.uuid === genericVnf.modelVersionId) {\r
+                    if (vnf.vfcInstanceGroups && !_.isEmpty(vnf.vfcInstanceGroups) && vnf.uuid === genericVnf.modelVersionId) {\r
                             AaiService.getInstanceGroupsByVNFInstanceId(genericVnf.nodeId,\r
                                 function (response) { //success\r
                                     handleGetRelatedInstanceGroupsResponseForVnf(response, genericVnf);\r
@@ -502,7 +501,6 @@ appDS2.controller("aaiSubscriberController", ["COMPONENT", "FIELD", "PARAMETER",
                                 }\r
                             )\r
                         }\r
-                    }\r
                 });\r
             }\r
         }\r