Add Semicolon at the end 26/95126/1
authoranushadasari <danush10@in.ibm.com>
Fri, 6 Sep 2019 09:54:14 +0000 (15:24 +0530)
committeranushadasari <danush10@in.ibm.com>
Fri, 6 Sep 2019 09:54:28 +0000 (15:24 +0530)
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-607
Change-Id: I40df40c69bf7de18eeafbf640b4ebe1d0efe6def
Signed-off-by: anushadasari <danush10@in.ibm.com>
vid-app-common/src/main/webapp/app/vid/scripts/modals/new-change-management/new-change-management.controller.js

index d9bc828..528d3d5 100644 (file)
@@ -97,7 +97,7 @@
                 .catch(function (error) {
                     $log.error(error);
                     vm.errorMsg = err;
-                })
+                });      
         };
 
         var registerVNFNamesWatcher = function () {
                             source: vnf.availableVersions[0].requestInfo.source,
                             suppressRollback: vnf.availableVersions[0].requestInfo.suppressRollback,
                             requestorId: vnf.availableVersions[0].requestInfo.requestorId
-                        }
+                        };
 
                         if(workflowType=='Update'){
                             requestParametersData = {
                                 usePreload: vnf.availableVersions[0].requestParameters.usePreload
-                            }
+                            };
                         }else if(workflowType=="Replace"){
                             requestParametersData = {
                                 rebuildVolumeGroups: vnf.availableVersions[0].requestParameters.usePreload
-                            }
+                            };
                         }else if(workflowType=="VNF In Place Software Update"){
                             var payloadObj = {
                                 'existing_software_version':vm.getInternalWorkFlowParameter(workflowType, 'text', 'Existing software version').value,
                             };
                             requestParametersData = {
                                 payload: JSON.stringify(payloadObj)
-                            }
+                            };
                         }else if(workflowType=="VNF Config Update"){
                             requestParametersData = {
                                 payload: vm.getInternalWorkFlowParameter("VNF Config Update", "FILE", "Attach configuration file").value
-                            }
+                            };
                         }else if(workflowType=="VNF Scale Out"){
                             if(!moduleToScale) return null;
 
                                 requestParametersData = {
                                     userParams: moduleToScale.userParams
                                     //,usePreload: true
-                                }
+                                };
                             }else{
                                 requestParametersData = {
                                     userParams: []
                                     //,usePreload: false
-                                }
+                                };
                             }
                         }
                         $log.info('SchedulerWidgetCtrl:extractChangeManagementCallbackDataStr info:: workflowType '+ workflowType);
                         };
                         requestParametersData = {
                             payload: JSON.stringify(payloadObj)
-                        }
+                        };
                     }else if(workflowType=="VNF Config Update"){
                         requestParametersData = {
                             payload: vm.getInternalWorkFlowParameter("VNF Config Update", "FILE", "Attach configuration file").value
-                        }
+                        };
                     }
 
                     var data;
                                 const nodeType = vnfsData[i]['node-type'];
                                 if (nodeType === "generic-vnf") {
                                     if (_.find(vnfsData[i]['related-to'], function (node) {
-                                        return node['node-type'] === 'vserver'
+                                        return node['node-type'] === 'vserver';
                                     }) !== undefined) {
                                         vm.vnfs.push(vnfsData[i]);
                                     }
                         });
 
                         _.forEach(filteredVnfs, function (vnf) {
-                            vm.vnfTypes.push(vnf.properties['nf-role'])
+                            vm.vnfTypes.push(vnf.properties['nf-role']);
                         });
                     }
                 }
 
                         vm.fromVNFVersions = _.uniqBy(fromVNFVersions, 'value');
                     }
-                })
+                });
             }
         };
 
                     .then(vm.loadLocalWorkFlowsParameters)
                     .then(function () {
                         vm.workflows = vm.localWorkflows;
-                    })
+                    });
             }
         };
 
             let parameters = [];
             workflow.workflowInputParameters
                 .filter( function (param) {
-                    return param.soPayloadLocation === "userParams"
+                    return param.soPayloadLocation === "userParams";
                 })
                 .forEach(function (param) {
                         let workflowParams = vm.repackAttributes(param);
                 soFieldName: workflowParam.soFieldName,
                 maxLength: '500',
                 pattern: '.*'
-            }
+            };
         };
 
         vm.getRemoteWorkFlowParameters = function (workflow) {
             if (workflow && vm.remoteWorkflowsParameters.has(workflow)) {
-                return vm.remoteWorkflowsParameters.get(workflow)
+                return vm.remoteWorkflowsParameters.get(workflow);
             }
             return [];
         };
 
         vm.hasPatternError = function(form, itemName){
             return form[itemName].$error.pattern;
-        }
+        };
 
         vm.hasAsyncFnError = function(form, itemName){
             return form[itemName].$error.validateAsyncFn;
-        }
+        };
 
         vm.getIdFor = function(type, id, name){
             return "internal-workflow-parameter-" + type + "-" + id + "-" + (name ? name.split(' ').join('-').toLowerCase() : "");
-        }
+        };
 
         vm.getInternalWorkFlowParameters = function (workflow, type) {
             if (workflow && vm.localWorkflowsParameters.has(workflow) && vm.localWorkflowsParameters.get(workflow).filter(parameter => parameter.type==type) != []) {