Remove modification of Http Headers 77/82677/1
authorMarcin Migdal <marcin.migdal@nokia.com>
Tue, 19 Mar 2019 13:29:18 +0000 (14:29 +0100)
committerMarcin Migdal <marcin.migdal@nokia.com>
Tue, 19 Mar 2019 13:29:26 +0000 (14:29 +0100)
Change-Id: I62c6750995e8b88bbd65018e4532192cfc678d6b
Issue-ID: DCAEGEN2-1310
Signed-off-by: Marcin Migdal <marcin.migdal@nokia.com>
rest-services/aai-client/src/main/java/org/onap/dcaegen2/services/sdk/rest/services/aai/client/service/AaiHttpClientFactory.java
rest-services/aai-client/src/main/java/org/onap/dcaegen2/services/sdk/rest/services/aai/client/service/http/get/AaiHttpGetClient.java
rest-services/aai-client/src/main/java/org/onap/dcaegen2/services/sdk/rest/services/aai/client/service/http/patch/AaiHttpPatchClient.java

index 5e11745..d2e109e 100644 (file)
@@ -73,10 +73,6 @@ public class AaiHttpClientFactory {
         return Try.of(() -> Paths.get(Passwords.class.getResource(resource).toURI()));
     }
 
-    public static String performBasicAuthentication(String userName, String password) {
-        return Base64.getEncoder().encodeToString((userName + ":" + password).getBytes());
-    }
-
     public static RequestDiagnosticContext createRequestDiagnosticContext() {
         return ImmutableRequestDiagnosticContext.builder()
                 .invocationId(UUID.randomUUID()).requestId(UUID.randomUUID()).build();
index 07987d2..4ff500a 100644 (file)
@@ -28,8 +28,6 @@ import org.onap.dcaegen2.services.sdk.rest.services.uri.URI;
 import reactor.core.publisher.Mono;
 
 import static org.onap.dcaegen2.services.sdk.rest.services.aai.client.service.AaiHttpClientFactory.createRequestDiagnosticContext;
-import static org.onap.dcaegen2.services.sdk.rest.services.aai.client.service.AaiHttpClientFactory.performBasicAuthentication;
-
 
 public final class AaiHttpGetClient implements AaiHttpClient<String> {
 
@@ -39,7 +37,6 @@ public final class AaiHttpGetClient implements AaiHttpClient<String> {
 
     public AaiHttpGetClient(AaiClientConfiguration configuration) {
         this.configuration = configuration;
-        addAuthorizationBasicHeader();
     }
 
     @Override
@@ -60,8 +57,4 @@ public final class AaiHttpGetClient implements AaiHttpClient<String> {
                 .path(configuration.aaiBasePath() + configuration.aaiPnfPath() + "/" + pnfName).build().toString();
     }
 
-    private void addAuthorizationBasicHeader() {
-        configuration.aaiHeaders().put("Authorization",
-                "Basic " + performBasicAuthentication(configuration.aaiUserName(), configuration.aaiUserPassword()));
-    }
 }
index ef60155..2059219 100644 (file)
@@ -30,8 +30,6 @@ import reactor.core.publisher.Mono;
 import reactor.netty.http.client.HttpClientResponse;
 
 import static org.onap.dcaegen2.services.sdk.rest.services.aai.client.service.AaiHttpClientFactory.createRequestDiagnosticContext;
-import static org.onap.dcaegen2.services.sdk.rest.services.aai.client.service.AaiHttpClientFactory.performBasicAuthentication;
-
 
 public final class AaiHttpPatchClient implements AaiHttpClient<HttpClientResponse> {
 
@@ -43,7 +41,6 @@ public final class AaiHttpPatchClient implements AaiHttpClient<HttpClientRespons
     public AaiHttpPatchClient(final AaiClientConfiguration configuration, JsonBodyBuilder jsonBodyBuilder) {
         this.configuration = configuration;
         this.jsonBodyBuilder = jsonBodyBuilder;
-        addAuthorizationBasicHeader();
     }
 
     public Mono<HttpClientResponse> getAaiResponse(AaiModel aaiModel) {
@@ -64,8 +61,4 @@ public final class AaiHttpPatchClient implements AaiHttpClient<HttpClientRespons
                 .path(configuration.aaiBasePath() + configuration.aaiPnfPath() + "/" + pnfName).build().toString();
     }
 
-    private void addAuthorizationBasicHeader() {
-        configuration.aaiHeaders().put("Authorization",
-                "Basic " + performBasicAuthentication(configuration.aaiUserName(), configuration.aaiUserPassword()));
-    }
 }