In package-repository-check was changed command module to service module due to lint failing.
Failing was caused by errors:
[301] Commands should not change things if nothing needs doing
[303] service used in place of service module
Added molecule test.
Issue-ID: OOM-2395
Signed-off-by: Jan Benedikt <j.benedikt@partner.samsung.com>
Change-Id: I6cfdfe920eabfb9a0c43cc9ba4ffcd81df1d6852
--- /dev/null
+extends: default
+
+rules:
+ braces:
+ max-spaces-inside: 1
+ level: error
+ brackets:
+ max-spaces-inside: 1
+ level: error
+ line-length: disable
+ truthy: disable
--- /dev/null
+---
+dependency:
+ name: galaxy
+driver:
+ name: docker
+lint:
+ name: yamllint
+platforms:
+ - name: infra_host
+ image: molecule-${PREBUILD_PLATFORM_DISTRO:-centos}:${PREBUILD_DISTRO_VERSION:-centos7.6}
+ pre_build_image: True
+ privileged: true
+ volume_mounts:
+ - "/sys/fs/cgroup:/sys/fs/cgroup:ro"
+ override_command: False
+ groups:
+ - infrastructure
+ - name: node0
+ image: molecule-${PREBUILD_PLATFORM_DISTRO:-centos}:${PREBUILD_DISTRO_VERSION:-centos7.6}
+ pre_build_image: True
+ privileged: true
+ volume_mounts:
+ - "/sys/fs/cgroup:/sys/fs/cgroup:ro"
+ override_command: False
+ groups:
+ - kubernetes
+provisioner:
+ name: ansible
+ lint:
+ name: ansible-lint
+ env:
+ ANSIBLE_ROLES_PATH: ../../../../test/roles
+scenario:
+ name: default
+ test_sequence:
+ - lint
+ - cleanup
+ - destroy
+ - dependency
+ - syntax
+ - create
+ - prepare
+ - converge
+ # - idempotence
+ # --> Action: 'idempotence'
+ # ERROR: Idempotence test failed because of the following tasks:
+ # * [infra_host] => package-repository-check : Clean yum cache
+ # * [node0] => package-repository-check : Clean yum cache
+ - side_effect
+ - verify
+ - cleanup
+ - destroy
+verifier:
+ name: testinfra
+ lint:
+ name: flake8
+ options:
+ v: 1
--- /dev/null
+---
+- name: Activate repository on node host
+ hosts: all
+ roles:
+ - package-repository-check
--- /dev/null
+# Molecule managed
+
+{% if item.registry is defined %}
+FROM {{ item.registry.url }}/{{ item.image }}
+{% else %}
+FROM {{ item.image }}
+{% endif %}
+
+RUN apt-get update && apt-get install -y python sudo bash ca-certificates && apt-get clean
+
+# /etc/resolv.conf cannot be edited in docker container
+# due to cannot be installed resolvconf
+# https://github.com/moby/moby/issues/1297
+RUN echo "resolvconf resolvconf/linkify-resolvconf boolean false" | debconf-set-selections
--- /dev/null
+---
+dependency:
+ name: galaxy
+driver:
+ name: docker
+lint:
+ name: yamllint
+platforms:
+ - name: infrastructure-server
+ image: ${PLATFORM_DISTRO:-ubuntu}:${DISTRO_VERSION:-18.04}
+ groups:
+ - infrastructure
+
+ - name: kubernetes-node-1
+ image: ${PLATFORM_DISTRO:-ubuntu}:${DISTRO_VERSION:-18.04}
+ groups:
+ - kubernetes
+
+provisioner:
+ name: ansible
+ lint:
+ name: ansible-lint
+ playbooks:
+ converge: ../default/playbook.yml
+ inventory:
+ host_vars:
+ infrastructure-server:
+ cluster_ip: 6.5.4.3
+scenario:
+ name: ubuntu
+ test_sequence:
+ - lint
+ - cleanup
+ - destroy
+ - dependency
+ - syntax
+ - create
+ - prepare
+ - converge
+ # - idempotence
+ # --> Action: 'idempotence'
+ # ERROR: Idempotence test failed because of the following tasks:
+ # * [infra_host] => package-repository-check : Clean yum cache
+ # * [node0] => package-repository-check : Clean yum cache
+ - side_effect
+ - verify
+ - cleanup
+ - destroy
+verifier:
+ name: testinfra
+ lint:
+ name: flake8
+ options:
+ v: 1
--- /dev/null
+import os
+import pytest
+
+import testinfra.utils.ansible_runner
+
+testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(
+ os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all')
+
+
+@pytest.mark.parametrize('distro,pkg', [
+ ('ubuntu', 'resolvconf')
+])
+def test_pkg(host, distro, pkg):
+ os = host.system_info.distribution
+ if distro == os:
+ package = host.package(pkg)
+ assert package.is_installed
update_cache: yes
state: latest
tags:
- - skip_ansible_lint # Prevent '[403] Package installs should not use latest' ansible lint task rule
+ - skip_ansible_lint # Prevent '[403] Package installs should not use latest' ansible lint task rule
rescue:
- name: Fail if apt cache updating failed
fail:
create: yes
- name: Make DNS settings permanent
- command: service resolvconf restart
+ service:
+ name: resolvconf
+ state: restarted
update_cache: yes
state: latest
tags:
- - skip_ansible_lint # Prevent '[403] Package installs should not use latest' ansible lint task rule
+ - skip_ansible_lint # Prevent '[403] Package installs should not use latest' ansible lint task rule
rescue:
- name: Fail if yum cache updating failed
fail:
# Successfull prior invocation of 'package-repository' and 'nginx' role on infrastructure hosts
# is prerequisite for playing this one on 'kubernetes' group.
-#Set of tasks designated to failing fast if configured repos are not functioning properly
+# Set of tasks designated to failing fast if configured repos are not functioning properly
- include_tasks: "{{ ansible_os_family }}.yml"