DBMap.java - Sonar Fix

DBMap.java - Sonar Fix

Issue-ID: DMAAP-1071
Change-Id: I6f1be61ac8ccd337fea1af11659807f1d7bf4046
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>

diff --git a/src/main/java/org/onap/dmaap/dbcapi/database/DBMap.java b/src/main/java/org/onap/dmaap/dbcapi/database/DBMap.java
index 6f63848..b3282ed 100644 (file)
--- a/src/main/java/org/onap/dmaap/dbcapi/database/DBMap.java
+++ b/src/main/java/org/onap/dmaap/dbcapi/database/DBMap.java
@@ -59,7 +59,7 @@ public class DBMap<C> extends TableHandler<C> implements Map<String, C>       {
                return(2);
        }
        public Collection<C> values() {
-               Collection<C> ret = new Vector<>();
+               Collection<C> ret = new ArrayList<>();
                for (Map.Entry<String, C> x: list()) {
                        ret.add(x.getValue());
                }
@@ -110,7 +110,6 @@ public class DBMap<C> extends TableHandler<C> implements Map<String, C>     {
                } catch (Exception e) {
                        throw new DBException(e);
                }
-               PreparedStatement ps = null;
                return((new ConnWrapper<C, C>() {
                        protected C run(C val) throws Exception {
                                ps = c.prepareStatement(insorreplstmt);