if (event.getAai().get(VSERVER_IS_CLOSED_LOOP_DISABLED) != null
|| event.getAai().get(GENERIC_VNF_IS_CLOSED_LOOP_DISABLED) != null) {
- if(isClosedLoopDisabled(event)) {
+ if (isClosedLoopDisabled(event)) {
throw new AaiException("is-closed-loop-disabled is set to true on VServer or VNF");
}
return;
}
- if(vnfResponse != null || vserverResponse != null) {
+ if (vnfResponse != null || vserverResponse != null) {
// query has already been performed
return;
}
* limitations under the License.
* ============LICENSE_END=========================================================
*/
+
package org.onap.policy.drools.apps.controlloop.feature.amsterdam;
import static org.junit.Assert.assertTrue;
* limitations under the License.
* ============LICENSE_END=========================================================
*/
+
package org.onap.policy.drools.apps.controlloop.feature.casablanca;
import static org.junit.Assert.assertEquals;
import org.slf4j.LoggerFactory;
/**
- * Control Loop Metrics Tracker
+ * Control Loop Metrics Tracker.
*/
public interface ControlLoopMetrics {
/**
- * gets all transaction identifiers being monitored
+ * Gets all transaction identifiers being monitored.
*
* @return transaction id list
*/
List<UUID> getTransactionIds();
/**
- * gets all detailed transactions
+ * Gets all detailed transactions.
*
* @return list of transactions
*/
List<VirtualControlLoopNotification> getTransactions();
/**
- * track controller's notification events
+ * Track controller's notification events.
*
* @param controller policy controller sending out notification
* @param notification notification
void transactionEvent(PolicyController controller, VirtualControlLoopNotification notification);
/**
- * gets an in-progress transaction
+ * Gets an in-progress transaction.
*
* @param requestId request ID
* @return in progress notification
VirtualControlLoopNotification getTransaction(UUID requestId);
/**
- * removes an in-progress transaction
+ * Removes an in-progress transaction.
*
* @param requestId request ID
*/
void removeTransaction(UUID requestId);
/**
- * get cache size
+ * Get cache size.
*
* @return cache size
*/
long getCacheSize();
/**
- * get cache size
+ * Get cache size.
*
* @return cache size
*/
long getCacheOccupancy();
/**
- * sets cache size
+ * Sets cache size.
*
* @param cacheSize cache size
*/
void setMaxCacheSize(long cacheSize);
/**
- * cached transaction expiration timeout in seconds
+ * Cached transaction expiration timeout in seconds.
*
* @return transaction timeout in seconds
*/
long getTransactionTimeout();
/**
- * sets transaction timeout in seconds
+ * Sets transaction timeout in seconds.
*
* @param transactionTimeout transaction timeout in seconds
*/
void setTransactionTimeout(long transactionTimeout);
/**
- * reset cache
+ * Reset cache.
*
* @param cacheSize new cache size
* @param transactionTimeout new transaction timeout in seconds
void resetCache(long cacheSize, long transactionTimeout);
/**
- * refresh underlying transaction management
+ * Refresh underlying transaction management.
*/
void refresh();
/**
- * singleton manager object
+ * Singleton manager object.
*/
ControlLoopMetrics manager = new CacheBasedControlLoopMetricsManager();
}
/**
- * Control Loop Metrics Tracker Implementation
+ * Control Loop Metrics Tracker Implementation.
*/
class CacheBasedControlLoopMetricsManager implements ControlLoopMetrics {
CacheLoader<UUID, VirtualControlLoopNotification> loader =
new CacheLoader<UUID, VirtualControlLoopNotification>() {
- @Override
- public VirtualControlLoopNotification load(UUID key) throws Exception {
- return null;
- }
- };
+ @Override
+ public VirtualControlLoopNotification load(UUID key) throws Exception {
+ return null;
+ }
+ };
RemovalListener<UUID, VirtualControlLoopNotification> listener =
new RemovalListener<UUID, VirtualControlLoopNotification>() {
- @Override
- public void onRemoval(RemovalNotification<UUID, VirtualControlLoopNotification> notification) {
- if (notification.wasEvicted()) {
- evicted(notification.getValue());
- } else {
- logger.info("REMOVAL: {} because of {}", notification.getValue().getRequestId(),
+ @Override
+ public void onRemoval(RemovalNotification<UUID, VirtualControlLoopNotification> notification) {
+ if (notification.wasEvicted()) {
+ evicted(notification.getValue());
+ } else {
+ logger.info("REMOVAL: {} because of {}", notification.getValue().getRequestId(),
notification.getCause().name());
- }
- }
- };
+ }
+ }
+ };
synchronized (this) {
if (this.cache != null) {
}
/**
- * tracks an in progress control loop transaction
+ * Tracks an in progress control loop transaction.
*
* @param notification control loop notification
*/
}
/**
- * end of a control loop transaction
+ * End of a control loop transaction.
*
* @param notification control loop notification
*/
}
this.transaction(notification, startTime);
- if (startNotification != null)
+ if (startNotification != null) {
cache.invalidate(startNotification);
+ }
}
protected void evicted(VirtualControlLoopNotification notification) {
public class ControlLoopMetricsFeature implements PolicyControllerFeatureAPI {
/**
- * Feature Sequence Priority
+ * Feature Sequence Priority.
*/
public final static int FEATURE_SEQUENCE_PRIORITY = 100000;
/**
- * Properties Configuration Name
+ * Properties Configuration Name.
*/
public static final String CONFIGURATION_PROPERTIES_NAME = "feature-controlloop-trans";
/**
- * maximum number of transaction cache entries
+ * Maximum number of transaction cache entries.
*/
public static final String CL_CACHE_TRANS_SIZE_PROPERTY = "controlloop.cache.transactions.size";
public static final int CL_CACHE_TRANS_SIZE_DEFAULT = 100;
/**
- * transaction timeout in minutes
+ * Transaction timeout in minutes.
*/
public static final String CL_CACHE_TRANS_TIMEOUT_SECONDS_PROPERTY =
"controllop.cache.transactions.timeout.seconds";
}
/**
- * Logger
+ * Logger.
*/
private static Logger logger = LoggerFactory.getLogger(ControlLoopMetricsFeature.class);
/**
- * Intercept Control Loop Notifications
+ * Intercept Control Loop Notifications.
*
* @param controller - controller
* @param protocol - protocol
import org.onap.policy.drools.system.PolicyEngine;
/**
- * ControlLoopMetrics Tests
+ * ControlLoopMetrics Tests.
*/
public class ControlLoopMetricsFeatureTest {
private static final Path configPath = SystemPersistence.manager.getConfigurationPath();
private static PolicyController testController;
+ /**
+ * Setup method.
+ */
@BeforeClass
public static void setUp() {
SystemPersistence.manager.setConfigurationDir("src/test/resources");
}
/**
+ * Get the factory.
+ *
* @return the factory used to access various objects
*/
protected static Factory getFactory() {
/**
* Sets the factory to be used by junit tests.
- * @param factory
+ * @param factory factory
*/
protected static void setFactory(Factory factory) {
PolicyGuard.factory = factory;
String owner = makeOwner(targetType, requestID);
boolean result = factory.getManager().lock(targetInstance, owner, holdSec);
- if(!result) {
+ if (!result) {
return LockResult.createLockResult(GuardResult.LOCK_DENIED, null);
}
boolean result = factory.getManager().refresh(lock.getTargetInstance(), owner, holdSec);
logger.debug("Lock {} extend {}", lock, result);
- return(result ? GuardResult.LOCK_ACQUIRED : GuardResult.LOCK_DENIED);
+ return (result ? GuardResult.LOCK_ACQUIRED : GuardResult.LOCK_DENIED);
}
/**
String owner = makeOwner(lock.getTargetType(), lock.getRequestID());
boolean result = factory.getManager().unlock(lock.getTargetInstance(), owner);
- if(result) {
+ if (result) {
logger.debug("Unlocked {}", lock);
return true;
}
/**
* Combines the target type and request ID to yield a single, "owner" string.
- * @param targetType
- * @param requestID
+ * @param targetType target type
+ * @param requestID request id
* @return the "owner" of a resource
* @throws IllegalArgumentException if either argument is null
*/
private static String makeOwner(TargetType targetType, UUID requestID) {
- if(targetType == null) {
+ if (targetType == null) {
throw new IllegalArgumentException("null targetType for lock request id " + requestID);
}
- if(requestID == null) {
+ if (requestID == null) {
throw new IllegalArgumentException("null requestID for lock type " + targetType);
}
public static class Factory {
/**
+ * Get the manager.
+ *
* @return the lock manager to be used
*/
public PolicyResourceLockManager getManager() {
/**
* Sets Guard Properties.
*
- * @see /guard/src/test/java/org/onap/policy/guard/UtilTest.java for setting test properties
+ * <p>see /guard/src/test/java/org/onap/policy/guard/UtilTest.java for setting test properties
*/
public static void setGuardEnvProps(String url, String username, String password, String clientName,
String clientPassword, String environment) {
emf.close();
}
+ /**
+ * Setup method.
+ */
@Before
public void setUp() {
// clear the table
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
+
import java.util.UUID;
import org.junit.AfterClass;
import org.junit.Before;
PolicyGuard.setFactory(saveFactory);
}
+ /**
+ * Setup method.
+ */
@Before
public void setUp() {
mgr = spy(new PolicyResourceLockManager() {
// acquired
result = PolicyGuard.lockTarget(type, INSTANCENAME, uuid, dlcb, LOCK_SEC);
- verify(mgr).lock(INSTANCENAME, type+":"+uuid, LOCK_SEC);
+ verify(mgr).lock(INSTANCENAME, type + ":" + uuid, LOCK_SEC);
assertEquals(GuardResult.LOCK_ACQUIRED, result.getA());
assertEquals(VMTargetLock.class, result.getB().getClass());
// diff owner - denied
UUID uuid2 = UUID.randomUUID();
- result = PolicyGuard.lockTarget(type, INSTANCENAME, uuid2, dlcb, LOCK_SEC+10);
- verify(mgr).lock(INSTANCENAME, type+":"+uuid2, LOCK_SEC+10);
+ result = PolicyGuard.lockTarget(type, INSTANCENAME, uuid2, dlcb, LOCK_SEC + 10);
+ verify(mgr).lock(INSTANCENAME, type + ":" + uuid2, LOCK_SEC + 10);
assertEquals(GuardResult.LOCK_DENIED, result.getA());
assertNull(result.getB());
}
// acquired
result = PolicyGuard.lockTarget(type, INSTANCENAME, uuid, dlcb, LOCK_SEC);
- verify(mgr).lock(INSTANCENAME, type+":"+uuid, LOCK_SEC);
+ verify(mgr).lock(INSTANCENAME, type + ":" + uuid, LOCK_SEC);
assertEquals(GuardResult.LOCK_ACQUIRED, result.getA());
assertEquals(VMTargetLock.class, result.getB().getClass());
TargetLock lock = result.getB();
// refresh - re-acquired
- assertEquals(GuardResult.LOCK_ACQUIRED, PolicyGuard.lockTarget(lock, LOCK_SEC+1));
- verify(mgr).refresh(INSTANCENAME, type+":"+uuid, LOCK_SEC+1);
+ assertEquals(GuardResult.LOCK_ACQUIRED, PolicyGuard.lockTarget(lock, LOCK_SEC + 1));
+ verify(mgr).refresh(INSTANCENAME, type + ":" + uuid, LOCK_SEC + 1);
// unlock
PolicyGuard.unlockTarget(lock);
// refresh - denied, as we no longer own the lock
- assertEquals(GuardResult.LOCK_DENIED, PolicyGuard.lockTarget(lock, LOCK_SEC+2));
+ assertEquals(GuardResult.LOCK_DENIED, PolicyGuard.lockTarget(lock, LOCK_SEC + 2));
}
@Test(expected = IllegalArgumentException.class)
private static final long serialVersionUID = 1L;
private static final Logger LOGGER = LoggerFactory.getLogger(ControlLoopCompiler.class.getName());
+ /**
+ * Compiles the policy from an object.
+ */
public static ControlLoopPolicy compile(ControlLoopPolicy policy,
ControlLoopCompilerCallback callback) throws CompilerException {
//
return policy;
}
+ /**
+ * Compiles the policy from an input stream.
+ *
+ * @param yamlSpecification the yaml input stream
+ * @param callback method to callback during compilation
+ * @return
+ *
+ * @throws CompilerException throws any compile exception found
+ */
public static ControlLoopPolicy compile(InputStream yamlSpecification,
ControlLoopCompilerCallback callback) throws CompilerException {
Yaml yaml = new Yaml(new Constructor(ControlLoopPolicy.class));
if (controlLoop == null && callback != null) {
callback.onError("controlLoop cannot be null");
}
- if (controlLoop!=null){
+ if (controlLoop != null) {
if ((controlLoop.getControlLoopName() == null || controlLoop.getControlLoopName().length() < 1)
&& callback != null) {
callback.onError("Missing controlLoopName");
Code Review / policy / drools-applications.git / commitdiff