Fix sonar critical issue in common-app-api 20/72420/2
authorParshad Patel <pars.patel@samsung.com>
Mon, 12 Nov 2018 12:02:13 +0000 (21:02 +0900)
committerTal Gitelman <tal.gitelman@att.com>
Mon, 19 Nov 2018 16:12:25 +0000 (16:12 +0000)
Fix use "isAssignableFrom" instead issue

Issue-ID: SDC-1895
Change-Id: Ifb51c4bca8df5dd7cdb95bbf5baa1b39004dd1ea
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
common-app-api/src/main/java/org/openecomp/sdc/common/log/elements/LoggerFactory.java

index de02c06..d294f41 100644 (file)
@@ -15,19 +15,19 @@ public class LoggerFactory {
     @SuppressWarnings("unchecked")
     public static <T, V> V getLogger(Class<T> type, Logger logger) {
 
-        if (type.getName().equals(LoggerAudit.class.getName())) {
+        if (type.isAssignableFrom(LoggerAudit.class)) {
             return (V) new LoggerAudit(new LogFieldsMdcHandler(), logger);
         }
 
-        if (type.getName().equals(LoggerDebug.class.getName())) {
+        if (type.isAssignableFrom(LoggerDebug.class)) {
             return (V) new LoggerDebug(new LogFieldsMdcHandler(), logger);
         }
 
-        if (type.getName().equals(LoggerMetric.class.getName())) {
+        if (type.isAssignableFrom(LoggerMetric.class)) {
             return (V) new LoggerMetric(new LogFieldsMdcHandler(), logger);
         }
 
-        if (type.getName().equals(LoggerError.class.getName())) {
+        if (type.isAssignableFrom(LoggerError.class)) {
             return (V) new LoggerError(new LogFieldsMdcHandler(), logger);
         }
 
@@ -37,19 +37,19 @@ public class LoggerFactory {
     @SuppressWarnings("unchecked")
     public static <T, V> V getMdcLogger(Class<T> type, Logger logger) {
 
-        if (type.getName().equals(LoggerAudit.class.getName())) {
+        if (type.isAssignableFrom(LoggerAudit.class)) {
             return (V) new LoggerAudit(LogFieldsMdcHandler.getInstance(), logger);
         }
 
-        if (type.getName().equals(LoggerDebug.class.getName())) {
+        if (type.isAssignableFrom(LoggerDebug.class)) {
             return (V) new LoggerDebug(LogFieldsMdcHandler.getInstance(), logger);
         }
 
-        if (type.getName().equals(LoggerMetric.class.getName())) {
+        if (type.isAssignableFrom(LoggerMetric.class)) {
             return (V) new LoggerMetric(LogFieldsMdcHandler.getInstance(), logger);
         }
 
-        if (type.getName().equals(LoggerError.class.getName())) {
+        if (type.isAssignableFrom(LoggerError.class)) {
             return (V) new LoggerError(LogFieldsMdcHandler.getInstance(), logger);
         }