Fix new checkstyle issues in drools-apps

The new version of checkstyle identified new issues.  Fixed those.

Issue-ID: POLICY-3290
Change-Id: I26a14fb6f0823f9836bc5b62222e4e2cb01977ae
Signed-off-by: Jim Hahn <jrh3@att.com>

diff --git a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ClEventManagerWithSteps.java b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ClEventManagerWithSteps.java
index db0bfae..a449366 100644 (file)
--- a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ClEventManagerWithSteps.java
+++ b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ClEventManagerWithSteps.java
@@ -254,7 +254,6 @@ public abstract class ClEventManagerWithSteps<T extends Step> extends ControlLoo
      * Makes the step associated with the given parameters.
      *
      * @param params operation's parameters
-     * @return a new step
      */
     protected abstract void loadPolicyStep(ControlLoopOperationParams params);
 

diff --git a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/ophistory/OperationHistoryDataManagerImpl.java b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/ophistory/OperationHistoryDataManagerImpl.java
index 8e8b1e5..2e18e83 100644 (file)
--- a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/ophistory/OperationHistoryDataManagerImpl.java
+++ b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/ophistory/OperationHistoryDataManagerImpl.java
@@ -249,7 +249,7 @@ public class OperationHistoryDataManagerImpl implements OperationHistoryDataMana
     /**
      * Stores a record.
      *
-     * @param entityManager entity manager
+     * @param entityMgr entity manager
      * @param rec record to be stored
      */
     private void storeRecord(EntityManager entityMgr, Record rec) {

diff --git a/controlloop/common/rules-test/src/main/java/org/onap/policy/controlloop/common/rules/test/BaseTest.java b/controlloop/common/rules-test/src/main/java/org/onap/policy/controlloop/common/rules/test/BaseTest.java
index 4e4fb82..3bfa971 100644 (file)
--- a/controlloop/common/rules-test/src/main/java/org/onap/policy/controlloop/common/rules/test/BaseTest.java
+++ b/controlloop/common/rules-test/src/main/java/org/onap/policy/controlloop/common/rules/test/BaseTest.java
@@ -467,8 +467,6 @@ public abstract class BaseTest {
      * @param policyFile file containing the ToscaPolicy to be loaded
      * @param onsetFile file containing the ONSET to be injected
      * @param operation expected APPC operation request
-     * @param checkOperation flag to determine whether or not to wait for operation
-     *        timeout
      */
     protected void appcLegacyRainyDay(String policyFile, String onsetFile, String operation) {
         policyClMgt = createNoficationTopicListener();
@@ -581,7 +579,6 @@ public abstract class BaseTest {
      *
      * @param policyFile file containing the ToscaPolicy to be loaded
      * @param onsetFile file containing the ONSET to be injected
-     * @param operation expected APPC operation request
      */
     protected void httpSunnyDay(String policyFile, String onsetFile) {
         policyClMgt = createNoficationTopicListener();
@@ -609,7 +606,6 @@ public abstract class BaseTest {
      *
      * @param policyFile file containing the ToscaPolicy to be loaded
      * @param onsetFile file containing the ONSET to be injected
-     * @param operation expected APPC operation request
      */
     protected void httpRainyDay(String policyFile, String onsetFile) {
         policyClMgt = createNoficationTopicListener();