increasing code coverage in catalog fe

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: Ica194c87def27163e20b2802100d9f296586a6ed

diff --git a/catalog-fe/src/test/java/org/openecomp/sdc/fe/impl/PluginStatusBLTest.java b/catalog-fe/src/test/java/org/openecomp/sdc/fe/impl/PluginStatusBLTest.java
new file mode 100644 (file)
index 0000000..3a8bb34
--- /dev/null
+++ b/catalog-fe/src/test/java/org/openecomp/sdc/fe/impl/PluginStatusBLTest.java
@@ -0,0 +1,68 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2019 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.sdc.fe.impl;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mock;
+import org.openecomp.sdc.exception.InvalidArgumentException;
+import org.openecomp.sdc.fe.config.ConfigurationManager;
+
+import static com.google.code.beanmatchers.BeanMatchers.hasValidBeanConstructor;
+import static org.hamcrest.CoreMatchers.allOf;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.mockito.Mockito.when;
+import static org.mockito.MockitoAnnotations.initMocks;
+
+public class PluginStatusBLTest {
+
+
+    @Mock
+    private ConfigurationManager mockedConfigurationManager;
+
+    @Before
+    public void setUp() {
+        initMocks(this);
+    }
+
+    @Test
+    public void validateBean() {
+        assertThat(PluginStatusBL.class,  allOf(
+                hasValidBeanConstructor()
+        ));
+    }
+    @Test(expected = InvalidArgumentException.class)
+    public void validateGetPluginsListWithNoConfigurationWillThrowException() {
+        ConfigurationManager.setTestInstance(mockedConfigurationManager);
+        when(mockedConfigurationManager.getPluginsConfiguration()).thenReturn(null);
+        PluginStatusBL pluginStatusBL = new PluginStatusBL();
+
+        pluginStatusBL.getPluginsList();
+    }
+    @Test(expected = InvalidArgumentException.class)
+    public void validateGetPluginAvailabilityWithNoConfigurationWillThrowException() {
+        ConfigurationManager.setTestInstance(mockedConfigurationManager);
+        when(mockedConfigurationManager.getPluginsConfiguration()).thenReturn(null);
+        PluginStatusBL pluginStatusBL = new PluginStatusBL();
+
+        pluginStatusBL.getPluginAvailability("testPlugin");
+    }
+}

diff --git a/catalog-fe/src/test/java/org/openecomp/sdc/fe/servlets/ConfigServletTest.java b/catalog-fe/src/test/java/org/openecomp/sdc/fe/servlets/ConfigServletTest.java
new file mode 100644 (file)
index 0000000..7f54fc0
--- /dev/null
+++ b/catalog-fe/src/test/java/org/openecomp/sdc/fe/servlets/ConfigServletTest.java
@@ -0,0 +1,126 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2019 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.sdc.fe.servlets;
+
+import org.apache.http.HttpStatus;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mock;
+import org.openecomp.sdc.common.api.Constants;
+import org.openecomp.sdc.fe.impl.PluginStatusBL;
+
+import javax.servlet.ServletContext;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpSession;
+import javax.ws.rs.core.Response;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.when;
+import static org.mockito.MockitoAnnotations.initMocks;
+
+public class ConfigServletTest {
+
+    private ConfigServlet configServlet;
+
+    @Mock
+    private HttpServletRequest httpServletRequest;
+    @Mock
+    private HttpSession httpSession;
+    @Mock
+    private ServletContext mockedContext;
+    @Mock
+    private PluginStatusBL pluginStatusBL;
+
+    @Before
+    public void setUp() {
+        initMocks(this);
+        configServlet = new ConfigServlet();
+    }
+
+    @Test
+    public void validateGetPluginsConfigurationReturnsCorrectConfiguration() {
+
+        final String expectedEntity = "testPluginsList";
+        prepareMocks();
+        when(pluginStatusBL.getPluginsList()).thenReturn(expectedEntity);
+
+        Response response = configServlet.getPluginsConfiguration(httpServletRequest);
+
+        assertEquals(response.getEntity().toString(),expectedEntity);
+        assertEquals(response.getStatus(), HttpStatus.SC_OK);
+    }
+    @Test
+    public void validateGetPluginsConfigurationResponsesWithServerErrorIfExceptionIsThrown() {
+
+        prepareMocks();
+        when(pluginStatusBL.getPluginsList()).thenThrow(new RuntimeException());
+
+        Response response = configServlet.getPluginsConfiguration(httpServletRequest);
+
+        assertEquals(response.getStatus(), HttpStatus.SC_INTERNAL_SERVER_ERROR);
+    }
+    @Test
+    public void validateGetPluginOnlineStateReturnsCorrectState() {
+
+        final String testPluginName = "testPlugin";
+        final String pluginAvailability = "forTesting";
+        prepareMocks();
+        when(pluginStatusBL.getPluginAvailability(eq(testPluginName))).thenReturn(pluginAvailability);
+
+        Response response = configServlet.getPluginOnlineState(testPluginName,httpServletRequest);
+
+        assertEquals(response.getEntity().toString(),pluginAvailability);
+        assertEquals(response.getStatus(), HttpStatus.SC_OK);
+    }
+    @Test
+    public void validateGetPluginOnlineStateResponsesWithServerErrorIfExceptionIsThrown() {
+
+        final String testPluginName = "testPlugin";
+        prepareMocks();
+        when(pluginStatusBL.getPluginAvailability(any(String.class))).thenThrow(new RuntimeException());
+
+        Response response = configServlet.getPluginOnlineState(testPluginName, httpServletRequest);
+
+        assertEquals(response.getStatus(), HttpStatus.SC_INTERNAL_SERVER_ERROR);
+    }
+    @Test
+    public void validateGetPluginOnlineStateResponsesWithNotFoundIfThereIsNoPlugin() {
+
+        final String testPluginName = "testPlugin";
+        prepareMocks();
+        when(pluginStatusBL.getPluginAvailability(any(String.class))).thenReturn(null);
+
+        Response response = configServlet.getPluginOnlineState(testPluginName, httpServletRequest);
+
+        assertEquals(response.getStatus(), HttpStatus.SC_NOT_FOUND);
+        assertTrue(response.getEntity().toString().contains(testPluginName));
+    }
+
+    private void prepareMocks() {
+        when(httpServletRequest.getSession()).thenReturn(httpSession);
+        when(httpSession.getServletContext()).thenReturn(mockedContext);
+        when(mockedContext.getAttribute(Constants.PLUGIN_BL_COMPONENT)).thenReturn(pluginStatusBL);
+    }
+
+}