update code 53/12253/1
authorMichael Lando <ml636r@intl.att.com>
Wed, 13 Sep 2017 17:50:26 +0000 (20:50 +0300)
committerMichael Lando <ml636r@att.com>
Wed, 13 Sep 2017 17:52:39 +0000 (20:52 +0300)
Change-Id: I9661c01f9c16247b52b770a91c6dde47f9506be7
Issue-ID: SDC-235
Signed-off-by: Michael Lando <ml636r@att.com>
86 files changed:
asdc-tests/src/main/java/org/openecomp/sdc/ci/tests/execute/artifacts/ArtifactServletTest.java
asdc-tests/src/main/java/org/openecomp/sdc/ci/tests/execute/artifacts/DownloadComponentArt.java
asdc-tests/src/main/java/org/openecomp/sdc/ci/tests/execute/devCI/CRUDExternalAPI.java
asdc-tests/src/main/java/org/openecomp/sdc/ci/tests/execute/distribution/DistributionDownloadArtifactTest.java
asdc-tests/src/main/java/org/openecomp/sdc/ci/tests/execute/imports/ImportNewResourceCITest.java
asdc-tests/src/main/java/org/openecomp/sdc/ci/tests/utils/rest/ResourceRestUtils.java
asdc-tests/src/main/java/org/openecomp/sdc/ci/tests/utils/rest/ResourceRestUtilsExternalAPI.java
catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/ArtifactsBusinessLogic.java
catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/CsarValidationUtils.java
catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/ResourceBusinessLogic.java
catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/ServiceBusinessLogic.java
catalog-be/src/main/java/org/openecomp/sdc/be/externalapi/servlet/ArtifactExternalServlet.java
catalog-be/src/main/java/org/openecomp/sdc/be/externalapi/servlet/AssetsDataServlet.java
catalog-be/src/main/java/org/openecomp/sdc/be/servlets/AbstractValidationsServlet.java
catalog-be/src/main/java/org/openecomp/sdc/be/tosca/CapabiltyRequirementConvertor.java
catalog-be/src/main/java/org/openecomp/sdc/be/tosca/CsarUtils.java
catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ResourceBusinessLogicTest.java
catalog-be/src/test/java/org/openecomp/sdc/be/servlets/ResourceServletTest.java
catalog-model/src/main/java/org/openecomp/sdc/be/model/jsontitan/operations/NodeTypeOperation.java
catalog-model/src/main/java/org/openecomp/sdc/be/model/jsontitan/operations/ToscaOperationFacade.java
catalog-ui/src/app/models/component-metadata.ts
catalog-ui/src/app/models/components/service.ts
catalog-ui/src/app/view-models/workspace/tabs/general/general-view-model.ts
catalog-ui/src/app/view-models/workspace/tabs/general/general-view.html
catalog-ui/src/app/view-models/workspace/tabs/general/general.less
catalog-ui/src/app/view-models/workspace/workspace-view.html
catalog-ui/src/app/view-models/workspace/workspace.less
common-app-api/src/main/java/org/openecomp/sdc/common/util/GeneralUtility.java
common-be/src/main/java/org/openecomp/sdc/be/datatypes/elements/CapabilityDataDefinition.java
common-be/src/main/java/org/openecomp/sdc/be/datatypes/elements/RequirementDataDefinition.java
common-be/src/main/java/org/openecomp/sdc/be/datatypes/enums/JsonPresentationFields.java
pom.xml
test-apis-ci/pom.xml
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/api/Urls.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/ResourceReqDetails.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/ServiceReqDetails.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/artifacts/ArtifactServletTest.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/artifacts/DownloadComponentArt.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/distribution/DistributionDownloadArtifactTest.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/imports/ImportNewResourceCITest.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaDefinition.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaGroupsTopologyTemplateDefinition.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaImportsDefinition.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaInputsTopologyTemplateDefinition.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaMetadataDefinition.java [new file with mode: 0644]
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaServiceGroupsMetadataDefinition.java [moved from test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaGroupsMetadataDefinition.java with 96% similarity]
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/model/ToscaMetadataFieldsPresentationEnum.java [new file with mode: 0644]
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/ToscaParserUtils.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/AtomicOperationUtils.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/ElementFactory.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/rest/ResourceRestUtils.java
test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/rest/ResourceRestUtilsExternalAPI.java
test-apis-ci/src/main/java/org/openecomp/sdc/externalApis/CRUDExternalAPI.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/US/AddComponentInstancesArtifactsInCsar.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/US/MIBsArtifactsOnResourceInstance.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/US/NewArtifactTypeGuide.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/US/RemoveRestrictionOfDeploymentArtifacts.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/US/Testing.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/US/VfModule.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/US/Vf_Tests_UI.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/US/extendNode_TemplatePropertiesWithDefaultValues.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProvider/OnbordingDataProviders.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/DataTestIdEnum.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/VendorSoftwareProductObject.java [new file with mode: 0644]
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/AdminUserManagment.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/CatalogLeftPanelTest.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/Categories.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/CustomizationUUID.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/OnboardViaApis.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/PNF.java [new file with mode: 0644]
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/Service.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/ToscaValidation.java [deleted file]
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/ToscaValidationTest.java [new file with mode: 0644]
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/Vf.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/VfArtifacts.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/setup/SetupCDTest.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/pages/HomePage.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/ArtifactUIUtils.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/DownloadManager.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/FileHandling.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/OnboardingUtillViaApis.java [new file with mode: 0644]
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/OnboardingUtils.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/ResourceUIUtils.java
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/verificator/ToscaValidation.java [new file with mode: 0644]
ui-ci/src/main/java/org/openecomp/sdc/ci/tests/verificator/VfModuleVerificator.java
ui-ci/src/main/resources/ci/testSuites/toscaValidationSuite.xml [new file with mode: 0644]

index 7e36320..1f578d1 100644 (file)
@@ -311,7 +311,7 @@ public class ArtifactServletTest extends ComponentBaseTest {
                httppost.addHeader(HttpHeaderEnum.ACCEPT.getValue(), acceptHeaderDate);
                httppost.addHeader(HttpHeaderEnum.USER_ID.getValue(), sdncUserDetails.getUserId());
                if (addMd5Header) {
-                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5ByString(jsonBody));
+                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5Base64EncodedByString(jsonBody));
                }
                StringEntity input = new StringEntity(jsonBody);
                input.setContentType("application/json");
index e4c89be..65c0bba 100644 (file)
@@ -620,7 +620,7 @@ artifact.setArtifactLabel("configure");*/
                httppost.addHeader(HttpHeaderEnum.ACCEPT.getValue(), acceptHeaderDate);
                httppost.addHeader(HttpHeaderEnum.USER_ID.getValue(), sdncUserDetails.getUserId());
                if (addMd5Header) {
-                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5ByString(jsonBody));
+                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5Base64EncodedByString(jsonBody));
                }
                StringEntity input = new StringEntity(jsonBody);
                input.setContentType("application/json");
index 4a4e5a4..45dbf31 100644 (file)
@@ -3474,7 +3474,7 @@ public class CRUDExternalAPI extends ComponentBaseTest {
                httppost.addHeader(HttpHeaderEnum.ACCEPT.getValue(), acceptHeaderDate);
                httppost.addHeader(HttpHeaderEnum.USER_ID.getValue(), sdncUserDetails.getUserId());
                if (addMd5Header) {
-                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5ByString(jsonBody));
+                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5Base64EncodedByString(jsonBody));
                }
                StringEntity input = new StringEntity(jsonBody);
                input.setContentType("application/json");
index 255dfd9..4dbc374 100644 (file)
@@ -213,7 +213,7 @@ public class DistributionDownloadArtifactTest extends ComponentBaseTest {
                AssertJUnit.assertEquals(artifactDetails.getPayload(), Base64.encodeBase64String(actualContents.getBytes()));
 
                // validating checksum
-               String actualPayloadChecksum = GeneralUtility.calculateMD5ByByteArray(actualContents.getBytes());
+               String actualPayloadChecksum = GeneralUtility.calculateMD5Base64EncodedByByteArray(actualContents.getBytes());
                AssertJUnit.assertEquals(expectedPayloadChecksum, actualPayloadChecksum);
 
                // validate audit
@@ -381,7 +381,7 @@ public class DistributionDownloadArtifactTest extends ComponentBaseTest {
 
                // validating checksum
                byte[] bytes = actualContents.getBytes();
-               String actualPayloadChecksum = GeneralUtility.calculateMD5ByByteArray(bytes);
+               String actualPayloadChecksum = GeneralUtility.calculateMD5Base64EncodedByByteArray(bytes);
                assertEquals(expectedPayloadChecksum, actualPayloadChecksum);
 
                // validating valid zip
@@ -576,7 +576,7 @@ public class DistributionDownloadArtifactTest extends ComponentBaseTest {
 
                // validating checksum
                byte[] bytes = actualContents.getBytes();
-               String actualPayloadChecksum = GeneralUtility.calculateMD5ByByteArray(bytes);
+               String actualPayloadChecksum = GeneralUtility.calculateMD5Base64EncodedByByteArray(bytes);
                AssertJUnit.assertEquals(expectedPayloadChecksum, actualPayloadChecksum);
 
                // validating valid zip
index 56841e1..61c8462 100644 (file)
@@ -184,7 +184,7 @@ public class ImportNewResourceCITest extends ComponentBaseTest {
                                + "  \"icon\": \"router\",\r\n" + "  \"tags\": [\r\n" + "    \"importResource4test\"\r\n" + "  ],\r\n"
                                + "  \"payloadData\": \"" + encodedPayload + "\"\r\n" + "}";
 
-               String md5 = GeneralUtility.calculateMD5ByString(json);
+               String md5 = GeneralUtility.calculateMD5Base64EncodedByString(json);
 
                Map<String, String> headers = new HashMap<String, String>();
                headers.put(Constants.MD5_HEADER, md5);
index b17deb3..a47477f 100644 (file)
@@ -86,7 +86,7 @@ public class ResourceRestUtils extends BaseRestUtils {
 
                Gson gson = new Gson();
                String userBodyJson = gson.toJson(resourceDetails);
-               String calculateMD5 = GeneralUtility.calculateMD5ByString(userBodyJson);
+               String calculateMD5 = GeneralUtility.calculateMD5Base64EncodedByString(userBodyJson);
                headersMap.put(HttpHeaderEnum.Content_MD5.getValue(), calculateMD5);
                HttpRequest http = new HttpRequest();
                // System.out.println(url);
@@ -508,7 +508,7 @@ public class ResourceRestUtils extends BaseRestUtils {
 
                Gson gson = new Gson();
                String userBodyJson = gson.toJson(resourceDetails);
-               String calculateMD5 = GeneralUtility.calculateMD5ByString(userBodyJson);
+               String calculateMD5 = GeneralUtility.calculateMD5Base64EncodedByString(userBodyJson);
                headersMap.put(HttpHeaderEnum.Content_MD5.getValue(), calculateMD5);
                HttpRequest http = new HttpRequest();
                RestResponse updateResourceResponse = http.httpSendPut(url, userBodyJson, headersMap);
index 10f573c..19d7d72 100644 (file)
@@ -48,7 +48,7 @@ public class ResourceRestUtilsExternalAPI extends BaseRestUtils {
 
                Gson gson = new Gson();
                String userBodyJson = gson.toJson(resourceDetails);
-               String calculateMD5 = GeneralUtility.calculateMD5ByString(userBodyJson);
+               String calculateMD5 = GeneralUtility.calculateMD5Base64EncodedByString(userBodyJson);
                headersMap.put(HttpHeaderEnum.Content_MD5.getValue(), calculateMD5);
                headersMap.put(HttpHeaderEnum.AUTHORIZATION.getValue(), authorizationHeader);
                headersMap.put(HttpHeaderEnum.X_ECOMP_INSTANCE_ID.getValue(), "ci");
index 61f0c02..74bb55b 100644 (file)
@@ -355,7 +355,7 @@ public class ArtifactsBusinessLogic extends BaseBusinessLogic {
                }
                byte[] decodedPayload = artifactDefinition.getPayloadData();
                artifactDefinition.setEsId(artifactDefinition.getUniqueId());
-               artifactDefinition.setArtifactChecksum(GeneralUtility.calculateMD5ByByteArray(decodedPayload));
+               artifactDefinition.setArtifactChecksum(GeneralUtility.calculateMD5Base64EncodedByByteArray(decodedPayload));
                return lockComponentAndUpdateArtifact(component.getUniqueId(), artifactDefinition, AuditingActionEnum.ARTIFACT_PAYLOAD_UPDATE, artifactDefinition.getUniqueId(), user, component.getComponentType(), component, decodedPayload, null, null,
                                shouldLock, inTransaction);
 
@@ -1007,7 +1007,7 @@ public class ArtifactsBusinessLogic extends BaseBusinessLogic {
        private Either<Boolean, ResponseFormat> validateMd5(String origMd5, String originData, byte[] payload, ArtifactOperationInfo operation) {
 
                if (origMd5 != null) {
-                       String encodeBase64Str = GeneralUtility.calculateMD5ByString(originData);
+                       String encodeBase64Str = GeneralUtility.calculateMD5Base64EncodedByString(originData);
 
                        if (false == encodeBase64Str.equals(origMd5)) {
                                log.debug("The calculated md5 is different then the received one");
@@ -2754,7 +2754,7 @@ public class ArtifactsBusinessLogic extends BaseBusinessLogic {
                                return Either.right(responseFormat);
                        }
 
-                       String checkSum = GeneralUtility.calculateMD5ByByteArray(decodedPayload);
+                       String checkSum = GeneralUtility.calculateMD5Base64EncodedByByteArray(decodedPayload);
                        artifactInfo.setArtifactChecksum(checkSum);
                        log.trace("Calculated checksum, base64 payload: {},  checksum: {}", payload, checkSum);
 
@@ -3642,7 +3642,7 @@ public class ArtifactsBusinessLogic extends BaseBusinessLogic {
 
                                return Either.right(artifactDataRes.right().value());
                        }
-                       String newCheckSum = GeneralUtility.calculateMD5ByByteArray(artifactData.getDataAsArray());
+                       String newCheckSum = GeneralUtility.calculateMD5Base64EncodedByByteArray(artifactData.getDataAsArray());
                        String oldCheckSum;
                        String esArtifactId = artifactDefinition.getEsId();
                        Either<ESArtifactData, CassandraOperationStatus> artifactfromES;
@@ -3657,7 +3657,7 @@ public class ArtifactsBusinessLogic extends BaseBusinessLogic {
                                        return Either.right(componentsUtils.getResponseFormatByArtifactId(actionStatus, artifactDefinition.getArtifactDisplayName()));
                                }
                                esArtifactData = artifactfromES.left().value();
-                               oldCheckSum = GeneralUtility.calculateMD5ByByteArray(esArtifactData.getDataAsArray());
+                               oldCheckSum = GeneralUtility.calculateMD5Base64EncodedByByteArray(esArtifactData.getDataAsArray());
                        } else {
                                oldCheckSum = artifactDefinition.getArtifactChecksum();
 
@@ -4696,7 +4696,7 @@ public class ArtifactsBusinessLogic extends BaseBusinessLogic {
                try {
                        for (ArtifactDefinition artifact : artifactsToHandle) {
                                originData = buildJsonStringForCsarVfcArtifact(artifact);
-                               origMd5 = GeneralUtility.calculateMD5ByString(originData);
+                               origMd5 = GeneralUtility.calculateMD5Base64EncodedByString(originData);
                                actionResult = handleArtifactRequest(component.getUniqueId(), user.getUserId(), componentType, operation, artifact.getUniqueId(), artifact, origMd5, originData, null, null, null, null, shouldLock, inTransaction);
                                if (actionResult.isRight()) {
                                        log.debug("Failed to upload artifact to component with type {} and name {}. Status is {}. ", componentType, component.getName(), actionResult.right().value());
index 3d280ab..8198ef3 100644 (file)
@@ -307,7 +307,7 @@ public class CsarValidationUtils {
                        return Either.right(toscaYamlRes.right().value());
                }
 
-               String newCheckSum = GeneralUtility.calculateMD5ByByteArray(toscaYamlRes.left().value().getRight().getBytes());
+               String newCheckSum = GeneralUtility.calculateMD5Base64EncodedByByteArray(toscaYamlRes.left().value().getRight().getBytes());
                return Either.left(newCheckSum);
 
        }
index 8fd28e1..ba26576 100644 (file)
@@ -82,12 +82,12 @@ import org.openecomp.sdc.be.model.ComponentInstance;
 import org.openecomp.sdc.be.model.ComponentInstanceInput;
 import org.openecomp.sdc.be.model.ComponentInstanceProperty;
 import org.openecomp.sdc.be.model.ComponentParametersView;
+import org.openecomp.sdc.be.model.CsarInfo;
 import org.openecomp.sdc.be.model.DataTypeDefinition;
 import org.openecomp.sdc.be.model.GroupDefinition;
 import org.openecomp.sdc.be.model.GroupProperty;
 import org.openecomp.sdc.be.model.GroupTypeDefinition;
 import org.openecomp.sdc.be.model.HeatParameterDefinition;
-import org.openecomp.sdc.be.model.CsarInfo;
 import org.openecomp.sdc.be.model.InputDefinition;
 import org.openecomp.sdc.be.model.InterfaceDefinition;
 import org.openecomp.sdc.be.model.LifeCycleTransitionEnum;
@@ -148,13 +148,13 @@ import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.web.context.WebApplicationContext;
 import org.yaml.snakeyaml.DumperOptions;
 import org.yaml.snakeyaml.Yaml;
+import org.yaml.snakeyaml.parser.ParserException;
 
 import com.google.gson.Gson;
 import com.google.gson.JsonElement;
 import com.google.gson.JsonObject;
 
 import fj.data.Either;
-import org.yaml.snakeyaml.parser.ParserException;
 
 @org.springframework.stereotype.Component("resourceBusinessLogic")
 public class ResourceBusinessLogic extends ComponentBusinessLogic {
@@ -624,7 +624,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                                }
                                preparedResource = createResourcesInstancesEither.left().value();
                                
-                               createResourcesInstancesEither = createResourceInstancesRelations(csarInfo.getModifier(), yamlFileName, preparedResource, instances, inTransaction, shouldLock);
+                               createResourcesInstancesEither = createResourceInstancesRelations(csarInfo.getModifier(), yamlFileName, preparedResource, instances);
                                if (createResourcesInstancesEither.isRight()) {
                                        log.debug("failed to create relation between resource instances status is {}", createResourcesInstancesEither.right().value());
                                        result = Either.right(createResourcesInstancesEither.right().value());
@@ -779,7 +779,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                                                                if (!foundArtifact.getArtifactChecksum().equals(currNewArtifact.getArtifactChecksum())) {
                                                                        foundArtifact.setPayload(currNewArtifact.getPayloadData());
                                                                        foundArtifact.setPayloadData(Base64.encodeBase64String(currNewArtifact.getPayloadData()));
-                                                                       foundArtifact.setArtifactChecksum(GeneralUtility.calculateMD5ByByteArray(currNewArtifact.getPayloadData()));
+                                                                       foundArtifact.setArtifactChecksum(GeneralUtility.calculateMD5Base64EncodedByByteArray(currNewArtifact.getPayloadData()));
                                                                        artifactsToUpdate.add(foundArtifact);
                                                                }
                                                                existingArtifacts.remove(foundArtifact.getArtifactLabel());
@@ -1461,7 +1461,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                String nameWithouNamespacePrefix = nodeName.substring(Constants.USER_DEFINED_RESOURCE_NAMESPACE_PREFIX.length());
                String[] findTypes = nameWithouNamespacePrefix.split("\\.");
                String resourceType = findTypes[0];
-               return resourceVfName + "-" + nameWithouNamespacePrefix.substring(resourceType.length() + 1);
+               return resourceVfName + "-" + nameWithouNamespacePrefix.substring(resourceType.length() + 1) + "Cvfc";
        }
 
        private Either<Resource, ResponseFormat> createResourceAndRIsFromYaml(String yamlName, Resource resource, ParsedToscaYamlInfo parsedToscaYamlInfo, AuditingActionEnum actionEnum, boolean isNormative,
@@ -1633,7 +1633,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                        List<GroupDefinition> groupsToCreate = new ArrayList<GroupDefinition>();
                        if (groupsFromResource != null && !groupsFromResource.isEmpty()) {
                                for (GroupDefinition group : groupsAsList) {
-                                       Optional<GroupDefinition> op = groupsFromResource.stream().filter(p -> p.getName().equals(group.getName())).findAny();
+                                       Optional<GroupDefinition> op = groupsFromResource.stream().filter(p -> p.getName().equalsIgnoreCase(group.getName())).findAny();
                                        if (op.isPresent()) {
                                                GroupDefinition groupToUpdate = op.get();
                                                groupToUpdate.setMembers(group.getMembers());
@@ -1643,7 +1643,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                                        }
                                }
                                for (GroupDefinition group : groupsFromResource) {
-                                       Optional<GroupDefinition> op = groupsAsList.stream().filter(p -> p.getName().equals(group.getName())).findAny();
+                                       Optional<GroupDefinition> op = groupsAsList.stream().filter(p -> p.getName().equalsIgnoreCase(group.getName())).findAny();
                                        if (!op.isPresent() && (group.getArtifacts() == null || group.getArtifacts().isEmpty())) {
 
                                                groupsToDelete.add(group);
@@ -1651,7 +1651,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
 
                                }
                        } else
-                               groupsToCreate.addAll(groupsAsList);
+                       groupsToCreate.addAll(groupsAsList);
                        Either<List<GroupDefinition>, ResponseFormat> prepareGroups = null;
                        if (!groupsToCreate.isEmpty()) {
 
@@ -1886,7 +1886,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                }
                resource = createResourcesInstancesEither.left().value();
                log.debug("************* Going to create all relations {}", yamlName);
-               createResourcesInstancesEither = createResourceInstancesRelations(csarInfo.getModifier(), yamlName, resource, uploadComponentInstanceInfoMap, true, false);
+               createResourcesInstancesEither = createResourceInstancesRelations(csarInfo.getModifier(), yamlName, resource, uploadComponentInstanceInfoMap);
 
                log.debug("************* Finished to create all relations {}", yamlName);
 
@@ -2087,7 +2087,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
 
                String jsonStr = gson.toJson(json);
 
-               String origMd5 = GeneralUtility.calculateMD5ByString(jsonStr);
+               String origMd5 = GeneralUtility.calculateMD5Base64EncodedByString(jsonStr);
                ArtifactDefinition artifactDefinitionFromJson = RepresentationUtils.convertJsonToArtifactDefinition(jsonStr, ArtifactDefinition.class);
                String artifactUniqueId = artifactDefinitionFromJson == null ? null : artifactDefinitionFromJson.getUniqueId();
                Either<Either<ArtifactDefinition, Operation>, ResponseFormat> uploadArtifactToService = artifactsBusinessLogic.validateAndHandleArtifact(resource.getUniqueId(), ComponentTypeEnum.RESOURCE, operation, artifactUniqueId,
@@ -2416,7 +2416,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                                for (ArtifactDefinition createdArtifact : createdDeplymentArtifactsAfterDelete) {
                                        if (artifactTemplate.getFileName().equalsIgnoreCase(createdArtifact.getArtifactName())) {
                                                arifactsUids.add(createdArtifact.getUniqueId());
-                                               arifactsUuids.add(createdArtifact.getUniqueId());
+                                               arifactsUuids.add(createdArtifact.getArtifactUUID());
                                                isCreate = false;
                                                String heatEnvId = checkAndGetHeatEnvId(createdArtifact);
                                                if (!heatEnvId.isEmpty()) {
@@ -2436,7 +2436,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                                        for (ArtifactDefinition createdNewArtifact : createdNewArtifacts) {
                                                if (artifactTemplate.getFileName().equalsIgnoreCase(createdNewArtifact.getArtifactName())) {
                                                        arifactsUids.add(createdNewArtifact.getUniqueId());
-                                                       arifactsUuids.add(createdNewArtifact.getUniqueId());
+                                                       arifactsUuids.add(createdNewArtifact.getArtifactUUID());
                                                        isCreate = false;
                                                        String heatEnvId = checkAndGetHeatEnvId(createdNewArtifact);
                                                        if (!heatEnvId.isEmpty()) {
@@ -2455,7 +2455,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                                        }
                                        ArtifactDefinition createdArtifact = createArtifactEither.left().value();
                                        arifactsUids.add(createdArtifact.getUniqueId());
-                                       arifactsUuids.add(createdArtifact.getUniqueId());
+                                       arifactsUuids.add(createdArtifact.getArtifactUUID());
                                        ArtifactTypeEnum artifactType = ArtifactTypeEnum.findType(createdArtifact.getArtifactType());
                                        if (artifactType == ArtifactTypeEnum.HEAT || artifactType == ArtifactTypeEnum.HEAT_NET || artifactType == ArtifactTypeEnum.HEAT_VOL) {
                                                Either<ArtifactDefinition, ResponseFormat> createHeatEnvPlaceHolder = artifactsBusinessLogic.createHeatEnvPlaceHolder(createdArtifact, ArtifactsBusinessLogic.HEAT_VF_ENV_NAME, resource.getUniqueId(), NodeTypeEnum.Resource,
@@ -3532,7 +3532,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                return Either.left(artifactTemplateInfoList);
        }
 
-       private Either<Resource, ResponseFormat> createResourceInstancesRelations(User user, String yamlName, Resource resource, Map<String, UploadComponentInstanceInfo> uploadResInstancesMap, boolean inTransaction, boolean needLock) {
+       private Either<Resource, ResponseFormat> createResourceInstancesRelations(User user, String yamlName, Resource resource, Map<String, UploadComponentInstanceInfo> uploadResInstancesMap) {
                log.debug("createResourceInstancesRelations try to create relations ");
                List<ComponentInstance> componentInstancesList = resource.getComponentInstances();
                if (uploadResInstancesMap == null) {
@@ -3590,7 +3590,7 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                                return Either.right(responseFormat);
                        }
                        String resourceInstanceId = currentCompInstance.getUniqueId();
-                       Resource originResource = null;
+                       Resource originResource;
                        if (!originCompMap.containsKey(currentCompInstance.getComponentUid())) {
                                Either<Resource, StorageOperationStatus> getOriginResourceRes = toscaOperationFacade.getToscaFullElement(currentCompInstance.getComponentUid());
                                if (getOriginResourceRes.isRight()) {
@@ -3603,38 +3603,10 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                        } else {
                                originResource = originCompMap.get(currentCompInstance.getComponentUid());
                        }
-                       if (originResource.getCapabilities() != null && !originResource.getCapabilities().isEmpty()) {
-                               Map<String, List<CapabilityDefinition>> originCapabilities ;
-                               if (MapUtils.isNotEmpty(uploadComponentInstanceInfo.getCapabilitiesNamesToUpdate()) && resource.getResourceType() == ResourceTypeEnum.CVFC) {
-                                       originCapabilities = new HashMap<>(); 
-                                       originResource.getCapabilities().entrySet().stream().forEach(e ->{
-                                               List<CapabilityDefinition> list =  e.getValue().stream().map(l -> new CapabilityDefinition(l)).collect(Collectors.toList()); 
-                                               originCapabilities.put(e.getKey(), list);
-                                       });
-                                       for (List<CapabilityDefinition> capabilities : originCapabilities.values()) {
-                                               capabilities.stream().filter(c -> uploadComponentInstanceInfo.getCapabilitiesNamesToUpdate().containsKey(c.getName())).forEach(c -> c.setName(uploadComponentInstanceInfo.getCapabilitiesNamesToUpdate().get(c.getName())));
-                                       }
-                               }else{
-                                       originCapabilities = originResource.getCapabilities();
-                               }
-                               instCapabilties.put(currentCompInstance, originCapabilities);
-                       }
-                       if (originResource.getRequirements() != null && !originResource.getRequirements().isEmpty()) {
-                               Map<String, List<RequirementDefinition>> originRequirements; 
-                               if (MapUtils.isNotEmpty(uploadComponentInstanceInfo.getRequirementsNamesToUpdate()) && resource.getResourceType() == ResourceTypeEnum.CVFC) {
-                                       originRequirements = new HashMap<>();
-                                       originResource.getRequirements().entrySet().stream().forEach(e ->{
-                                               List<RequirementDefinition> list =  e.getValue().stream().map(l -> new RequirementDefinition(l)).collect(Collectors.toList()); 
-                                               originRequirements.put(e.getKey(), list);
-                                       });
-                                       for (List<RequirementDefinition> requirements : originRequirements.values()) {
-                                               requirements.stream().filter(r -> uploadComponentInstanceInfo.getRequirementsNamesToUpdate().containsKey(r.getName())).forEach(r -> r.setName(uploadComponentInstanceInfo.getRequirementsNamesToUpdate().get(r.getName())));
-                                       }
-                               }else{
-                                       originRequirements = originResource.getRequirements();
-                               }
-                               instRequirements.put(currentCompInstance, originRequirements);
-                       }
+                       if (originResource.getCapabilities() != null && !originResource.getCapabilities().isEmpty())
+                               instCapabilties.put(currentCompInstance, originResource.getCapabilities());
+                       if (originResource.getRequirements() != null && !originResource.getRequirements().isEmpty())
+                               instRequirements.put(currentCompInstance, originResource.getRequirements());
                        if (originResource.getDeploymentArtifacts() != null && !originResource.getDeploymentArtifacts().isEmpty())
                                instDeploymentArtifacts.put(resourceInstanceId, originResource.getDeploymentArtifacts());
                        if (originResource.getArtifacts() != null && !originResource.getArtifacts().isEmpty())
@@ -3711,16 +3683,16 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
                parametersView.setIgnoreCapabilities(false);
                parametersView.setIgnoreRequirements(false);
 
-               Either<Resource, StorageOperationStatus> eitherGerResource = toscaOperationFacade.getToscaElement(resource.getUniqueId(), parametersView);
+               Either<Resource, StorageOperationStatus> eitherGetResource = toscaOperationFacade.getToscaElement(resource.getUniqueId(), parametersView);
 
-               if (eitherGerResource.isRight()) {
-                       ResponseFormat responseFormat = componentsUtils.getResponseFormatByResource(componentsUtils.convertFromStorageResponse(eitherGerResource.right().value()), resource);
+               if (eitherGetResource.isRight()) {
+                       ResponseFormat responseFormat = componentsUtils.getResponseFormatByResource(componentsUtils.convertFromStorageResponse(eitherGetResource.right().value()), resource);
 
                        return Either.right(responseFormat);
 
                }
 
-               resource = eitherGerResource.left().value();
+               resource = eitherGetResource.left().value();
 
                for (Entry<String, UploadComponentInstanceInfo> entry : uploadResInstancesMap.entrySet()) {
                        UploadComponentInstanceInfo uploadComponentInstanceInfo = entry.getValue();
@@ -3755,15 +3727,88 @@ public class ResourceBusinessLogic extends ComponentBusinessLogic {
 
                log.debug("************* in create relations, getResource start");
 
-               eitherGerResource = toscaOperationFacade.getToscaElement(resource.getUniqueId());
+               eitherGetResource = toscaOperationFacade.getToscaElement(resource.getUniqueId());
                log.debug("************* in create relations, getResource end");
-               if (eitherGerResource.isRight()) {
-                       ResponseFormat responseFormat = componentsUtils.getResponseFormatByResource(componentsUtils.convertFromStorageResponse(eitherGerResource.right().value()), resource);
+               if (eitherGetResource.isRight()) {
+                       ResponseFormat responseFormat = componentsUtils.getResponseFormatByResource(componentsUtils.convertFromStorageResponse(eitherGetResource.right().value()), resource);
 
                        return Either.right(responseFormat);
 
                }
-               return Either.left(eitherGerResource.left().value());
+               resource = eitherGetResource.left().value();
+               if(resource.getResourceType() == ResourceTypeEnum.CVFC){
+                       eitherGetResource = updateCalculatedCapReqWithSubstitutionMappings(resource, uploadResInstancesMap);
+                       if (eitherGetResource.isRight()) {
+                               ResponseFormat responseFormat = componentsUtils.getResponseFormatByResource(componentsUtils.convertFromStorageResponse(eitherGetResource.right().value()), resource);
+                               return Either.right(responseFormat);
+                       }
+               }
+               return Either.left(eitherGetResource.left().value());
+       }
+
+       private Either<Resource, StorageOperationStatus> updateCalculatedCapReqWithSubstitutionMappings(Resource resource, Map<String, UploadComponentInstanceInfo> uploadResInstancesMap) {
+               Either<Resource, StorageOperationStatus> updateRes = null;
+               Map<ComponentInstance, Map<String, List<CapabilityDefinition>>> updatedInstCapabilities = new HashMap<>();
+               Map<ComponentInstance, Map<String, List<RequirementDefinition>>> updatedInstRequirements = new HashMap<>();
+               StorageOperationStatus status = toscaOperationFacade.deleteAllCalculatedCapabilitiesRequirements( resource.getUniqueId());
+               if(status != StorageOperationStatus.OK && status != StorageOperationStatus.NOT_FOUND){
+                       log.debug("Failed to delete all calculated capabilities and requirements of resource {} upon update. Status is {}", resource.getUniqueId(), status);
+                       updateRes =  Either.right(status);
+               }
+               if(updateRes == null){
+                       fillUpdatedInstCapabilitiesRequirements(resource.getComponentInstances(), uploadResInstancesMap, updatedInstCapabilities, updatedInstRequirements);
+                       status = toscaOperationFacade.associateCalculatedCapReq(updatedInstCapabilities, updatedInstRequirements,  resource.getUniqueId());
+                       if (status != StorageOperationStatus.OK && status != StorageOperationStatus.NOT_FOUND) {
+                               log.debug("Failed to associate capabilities and requirementss of resource {}, updated according to a substitution mapping. Status is {}",  resource.getUniqueId(), status);
+                               updateRes = Either.right(status);
+                       }
+               }
+               if(updateRes == null){
+                       updateRes = toscaOperationFacade.getToscaElement( resource.getUniqueId());
+               }
+               return updateRes;
+       }
+
+
+       private void fillUpdatedInstCapabilitiesRequirements(List<ComponentInstance> componentInstances, Map<String, UploadComponentInstanceInfo> uploadResInstancesMap,
+                       Map<ComponentInstance, Map<String, List<CapabilityDefinition>>> updatedInstCapabilities, Map<ComponentInstance, Map<String, List<RequirementDefinition>>> updatedInstRequirements) {
+               
+               componentInstances.stream().forEach( i -> {
+                       fillUpdatedInstCapabilities(updatedInstCapabilities, i, uploadResInstancesMap.get(i.getName()).getCapabilitiesNamesToUpdate());
+                       fillUpdatedInstRequirements(updatedInstRequirements, i, uploadResInstancesMap.get(i.getName()).getRequirementsNamesToUpdate());
+               });
+       }
+
+       private void fillUpdatedInstRequirements(Map<ComponentInstance, Map<String, List<RequirementDefinition>>> updatedInstRequirements, ComponentInstance instance, Map<String, String> requirementsNamesToUpdate) {
+               Map<String, List<RequirementDefinition>> updatedRequirements = new HashMap<>();
+               Set<String> updatedReqNames = new HashSet<>();
+               if(MapUtils.isNotEmpty(requirementsNamesToUpdate)){
+                       for (Map.Entry<String, List<RequirementDefinition>> requirements : instance.getRequirements().entrySet()) {
+                               updatedRequirements.put(requirements.getKey(), requirements.getValue().stream()
+                                               .filter(r -> requirementsNamesToUpdate.containsKey(r.getName()) && !updatedReqNames.contains(requirementsNamesToUpdate.get(r.getName())))
+                                               .map(r ->{r.setParentName(r.getName()); r.setName(requirementsNamesToUpdate.get(r.getName())); updatedReqNames.add(r.getName()); return r;})
+                                               .collect(Collectors.toList()));
+                       }
+               }
+               if(MapUtils.isNotEmpty(updatedRequirements)){
+                       updatedInstRequirements.put(instance, updatedRequirements);
+               }
+       }
+
+       private void fillUpdatedInstCapabilities(Map<ComponentInstance, Map<String, List<CapabilityDefinition>>> updatedInstCapabilties, ComponentInstance instance, Map<String, String> capabilitiesNamesToUpdate) {
+               Map<String, List<CapabilityDefinition>> updatedCapabilities = new HashMap<>();
+               Set<String> updatedCapNames = new HashSet<>();
+               if(MapUtils.isNotEmpty(capabilitiesNamesToUpdate)){
+                       for (Map.Entry<String, List<CapabilityDefinition>> requirements : instance.getCapabilities().entrySet()) {
+                               updatedCapabilities.put(requirements.getKey(), requirements.getValue().stream()
+                                               .filter(c -> capabilitiesNamesToUpdate.containsKey(c.getName()) && !updatedCapNames.contains(capabilitiesNamesToUpdate.get(c.getName())))
+                                               .map(c -> {c.setParentName(c.getName()); c.setName(capabilitiesNamesToUpdate.get(c.getName())); updatedCapNames.add(c.getName()); return c;})
+                                               .collect(Collectors.toList()));
+                       }
+               }
+               if(MapUtils.isNotEmpty(updatedCapabilities)){
+                       updatedInstCapabilties.put(instance, updatedCapabilities);
+               }
        }
 
        private ResponseFormat addRelationToRI(String yamlName, Resource resource, UploadComponentInstanceInfo nodesInfoValue, List<RequirementCapabilityRelDef> relations) {
index 85db9a2..89c444b 100644 (file)
@@ -1616,7 +1616,7 @@ public class ServiceBusinessLogic extends ComponentBusinessLogic {
                vfModuleArtifactDefinition.setArtifactName(currVF.getNormalizedName() + "_modules.json");
                vfModuleArtifactDefinition.setPayloadData(vfModulePayloadString);
                if (vfModulePayloadString != null) {
-                       newCheckSum = GeneralUtility.calculateMD5ByByteArray(vfModulePayloadString.getBytes());
+                       newCheckSum = GeneralUtility.calculateMD5Base64EncodedByByteArray(vfModulePayloadString.getBytes());
                }
                vfModuleArtifactDefinition.setArtifactChecksum(newCheckSum);
 
index 32293ca..1c2f175 100644 (file)
@@ -166,7 +166,7 @@ public class ArtifactExternalServlet extends AbstractValidationsServlet {
                                } else {
                                        Object representation = RepresentationUtils.toRepresentation(uploadArtifactEither.left().value());
                                        Map<String, String> headers = new HashMap<>();
-                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5ByString((String) representation));
+                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5Base64EncodedByString((String) representation));
                                        responseWrapper.setInnerElement(getComponentsUtils().getResponseFormat(ActionStatus.OK));
                                        response = buildOkResponse(getComponentsUtils().getResponseFormat(ActionStatus.OK), representation, headers);
                                }
@@ -263,7 +263,7 @@ public class ArtifactExternalServlet extends AbstractValidationsServlet {
                                } else {
                                        Object representation = RepresentationUtils.toRepresentation(uploadArtifactEither.left().value());
                                        Map<String, String> headers = new HashMap<>();
-                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5ByString((String) representation));
+                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5Base64EncodedByString((String) representation));
                                        responseFormat = getComponentsUtils().getResponseFormat(ActionStatus.OK);
                                        responseWrapper.setInnerElement(buildOkResponse(getComponentsUtils().getResponseFormat(ActionStatus.OK), representation, headers));
                                }
@@ -363,7 +363,7 @@ public class ArtifactExternalServlet extends AbstractValidationsServlet {
                                } else {
                                        Object representation = RepresentationUtils.toRepresentation(uploadArtifactEither.left().value());
                                        Map<String, String> headers = new HashMap<>();
-                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5ByString((String) representation));
+                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5Base64EncodedByString((String) representation));
                                        responseFormat = getComponentsUtils().getResponseFormat(ActionStatus.OK);
                                        responseWrapper.setInnerElement(buildOkResponse(getComponentsUtils().getResponseFormat(ActionStatus.OK), representation, headers));
                                }
@@ -459,7 +459,7 @@ public class ArtifactExternalServlet extends AbstractValidationsServlet {
                                } else {
                                        Object representation = RepresentationUtils.toRepresentation(uploadArtifactEither.left().value());
                                        Map<String, String> headers = new HashMap<>();
-                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5ByString((String) representation));
+                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5Base64EncodedByString((String) representation));
                                        responseFormat = getComponentsUtils().getResponseFormat(ActionStatus.OK);
                                        responseWrapper.setInnerElement(buildOkResponse(getComponentsUtils().getResponseFormat(ActionStatus.OK), representation, headers));
                                }
@@ -550,7 +550,7 @@ public class ArtifactExternalServlet extends AbstractValidationsServlet {
                                } else {
                                        Object representation = RepresentationUtils.toRepresentation(uploadArtifactEither.left().value());
                                        Map<String, String> headers = new HashMap<>();
-                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5ByString((String) representation));
+                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5Base64EncodedByString((String) representation));
                                        responseFormat = getComponentsUtils().getResponseFormat(ActionStatus.OK);
                                        responseWrapper.setInnerElement(buildOkResponse(getComponentsUtils().getResponseFormat(ActionStatus.OK), representation, headers));
                                }
@@ -641,7 +641,7 @@ public class ArtifactExternalServlet extends AbstractValidationsServlet {
                                } else {
                                        Object representation = RepresentationUtils.toRepresentation(uploadArtifactEither.left().value());
                                        Map<String, String> headers = new HashMap<>();
-                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5ByString((String) representation));
+                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5Base64EncodedByString((String) representation));
                                        responseFormat = getComponentsUtils().getResponseFormat(ActionStatus.OK);
                                        responseWrapper.setInnerElement(buildOkResponse(getComponentsUtils().getResponseFormat(ActionStatus.OK), representation, headers));
                                }
@@ -719,7 +719,7 @@ public class ArtifactExternalServlet extends AbstractValidationsServlet {
                                        byte[] value = downloadComponentArtifactEither.left().value();
                                        InputStream is = new ByteArrayInputStream(value);
                                        Map<String, String> headers = new HashMap<>();
-                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5ByByteArray(value));
+                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5Base64EncodedByByteArray(value));
                                        responseFormat = getComponentsUtils().getResponseFormat(ActionStatus.OK);
                                        responseWrapper.setInnerElement(buildOkResponse(responseFormat, is, headers));
                                }
@@ -800,7 +800,7 @@ public class ArtifactExternalServlet extends AbstractValidationsServlet {
                                        byte[] value = downloadResourceArtifactEither.left().value();
                                        InputStream is = new ByteArrayInputStream(value);
                                        Map<String, String> headers = new HashMap<>();
-                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5ByByteArray(value));
+                                       headers.put(Constants.MD5_HEADER, GeneralUtility.calculateMD5Base64EncodedByByteArray(value));
                                        responseFormat = getComponentsUtils().getResponseFormat(ActionStatus.OK);
                                        responseWrapper.setInnerElement(buildOkResponse(responseFormat, is, headers));
                                }
index f96e226..6e971f2 100644 (file)
@@ -352,7 +352,7 @@ public class AssetsDataServlet extends AbstractValidationsServlet {
                        } else {
                                byte[] value = csarArtifact.left().value().getRight();
                                InputStream is = new ByteArrayInputStream(value);
-                               String contenetMD5 = GeneralUtility.calculateMD5ByByteArray(value);
+                               String contenetMD5 = GeneralUtility.calculateMD5Base64EncodedByByteArray(value);
                                Map<String, String> headers = new HashMap<>();
                                headers.put(Constants.CONTENT_DISPOSITION_HEADER, getContentDispositionValue(csarArtifact.left().value().getLeft()));
                                headers.put(Constants.MD5_HEADER, contenetMD5);
index 55ad44d..f1dd153 100644 (file)
@@ -458,7 +458,7 @@ public abstract class AbstractValidationsServlet extends BeGenericServlet {
                if (recievedMD5 == null) {
                        isValid = false;
                } else {
-                       String calculateMD5 = GeneralUtility.calculateMD5ByString(resourceInfoJsonString);
+                       String calculateMD5 = GeneralUtility.calculateMD5Base64EncodedByString(resourceInfoJsonString);
                        isValid = calculateMD5.equals(recievedMD5);
                }
                if (!isValid) {
index 6c4c5fa..006c5c2 100644 (file)
@@ -187,7 +187,7 @@ public class CapabiltyRequirementConvertor {
                                        String sourceCapName;
                                        if(ToscaUtils.isComplexVfc(component)){
                                                fullReqName = r.getName();
-                                               sourceCapName = getSourceCvfcDataTypeName(r.getName(), r.getOwnerName());
+                                               sourceCapName = r.getParentName();
                                        } else {
                                                fullReqName = getRequirementPath(r);
                                                sourceCapName = getSubPathByFirstDelimiterAppearance(fullReqName);
@@ -205,13 +205,6 @@ public class CapabiltyRequirementConvertor {
                return toscaRequirements;
        }
 
-       private String getSourceCvfcDataTypeName(String name, String ownerName) {
-               if(name.contains(ownerName)){
-                       return name.substring(0, name.length() - ownerName.length() - 1);
-               }
-               return null;
-       }
-
        private String getRequirementPath(RequirementDefinition r) {
                List<String> pathArray = Lists.reverse(r.getPath().stream()
                                .map(path -> ValidationUtils.normalizeComponentInstanceName(getSubPathByLastDelimiterAppearance(path)))
@@ -275,7 +268,7 @@ public class CapabiltyRequirementConvertor {
                                        String sourceReqName;
                                        if(ToscaUtils.isComplexVfc(component)){
                                                fullCapName = c.getName();
-                                               sourceReqName = getSourceCvfcDataTypeName(c.getName(), c.getOwnerName());
+                                               sourceReqName = c.getParentName();
                                        } else {
                                                fullCapName = getCapabilityPath(c);
                                                sourceReqName = getSubPathByFirstDelimiterAppearance(fullCapName);
index 85b1927..6662708 100644 (file)
@@ -633,7 +633,7 @@ public class CsarUtils {
 
                for (ArtifactDefinition artDef : generatedArtifactsDefinitions) {
                        String data = gson.toJson(artDef);
-                       String dataMD5 = GeneralUtility.calculateMD5ByString(data);
+                       String dataMD5 = GeneralUtility.calculateMD5Base64EncodedByString(data);
                        String artifactUniqueId = null;
 
                        if ((operationType.getArtifactOperationEnum() == ArtifactOperationEnum.Update) || (operationType.getArtifactOperationEnum() == ArtifactOperationEnum.Delete)) {
@@ -941,7 +941,7 @@ public class CsarUtils {
                artifact.setArtifactDisplayName(artifact.getArtifactName().lastIndexOf('.') > 0 ? artifact.getArtifactName().substring(0, artifact.getArtifactName().lastIndexOf('.')) : artifact.getArtifactName());
                artifact.setArtifactLabel(ValidationUtils.normalizeArtifactLabel(artifact.getArtifactName()));
                artifact.setDescription(ARTIFACT_CREATED_FROM_CSAR);
-               artifact.setArtifactChecksum(GeneralUtility.calculateMD5ByByteArray(entry.getValue()));
+               artifact.setArtifactChecksum(GeneralUtility.calculateMD5Base64EncodedByByteArray(entry.getValue()));
                return artifact;
        }
 
@@ -971,7 +971,7 @@ public class CsarUtils {
                        this.artifactLabel = ValidationUtils.normalizeArtifactLabel(artifactName);
                        if (payloadData != null) {
                                this.payloadData = Base64.encodeBase64String(payloadData);
-                               this.artifactChecksum = GeneralUtility.calculateMD5ByByteArray(payloadData);
+                               this.artifactChecksum = GeneralUtility.calculateMD5Base64EncodedByByteArray(payloadData);
                        }
                        this.artifactUniqueId = artifactUniqueId;
                }
index f3c7a7d..c47400b 100644 (file)
@@ -1498,14 +1498,14 @@ public class ResourceBusinessLogicTest {
                deploymentArtifactToUpdate.setArtifactName(deploymentArtifactToUpdateFileName);
                deploymentArtifactToUpdate.setArtifactType("SNMP_POLL");
                deploymentArtifactToUpdate.setPayload(oldPayloadData);
-               deploymentArtifactToUpdate.setArtifactChecksum(GeneralUtility.calculateMD5ByByteArray(oldPayloadData));
+               deploymentArtifactToUpdate.setArtifactChecksum(GeneralUtility.calculateMD5Base64EncodedByByteArray(oldPayloadData));
                
                ArtifactDefinition deploymentArtifactToDelete = new ArtifactDefinition();
                deploymentArtifactToDelete.setMandatory(false);
                deploymentArtifactToDelete.setArtifactName(deploymentArtifactToDeleteFileName);
                deploymentArtifactToDelete.setArtifactType("SNMP_TRAP");
                deploymentArtifactToDelete.setPayload(oldPayloadData);
-               deploymentArtifactToDelete.setArtifactChecksum(GeneralUtility.calculateMD5ByByteArray(oldPayloadData));
+               deploymentArtifactToDelete.setArtifactChecksum(GeneralUtility.calculateMD5Base64EncodedByByteArray(oldPayloadData));
                
                ArtifactDefinition deploymentArtifactToIgnore = new ArtifactDefinition();
                
@@ -1520,14 +1520,14 @@ public class ResourceBusinessLogicTest {
                artifactToUpdate.setArtifactName(artifactInfoToUpdateFileName);
                artifactToUpdate.setArtifactType("SNMP_POLL");
                artifactToUpdate.setPayload(oldPayloadData);
-               artifactToUpdate.setArtifactChecksum(GeneralUtility.calculateMD5ByByteArray(oldPayloadData));
+               artifactToUpdate.setArtifactChecksum(GeneralUtility.calculateMD5Base64EncodedByByteArray(oldPayloadData));
                
                ArtifactDefinition artifactToDelete = new ArtifactDefinition();
                artifactToDelete.setMandatory(false);
                artifactToDelete.setArtifactName(artifactInfoToDeleteFileName);
                artifactToDelete.setArtifactType("SNMP_TRAP");
                artifactToDelete.setPayload(oldPayloadData);
-               artifactToDelete.setArtifactChecksum(GeneralUtility.calculateMD5ByByteArray(oldPayloadData));
+               artifactToDelete.setArtifactChecksum(GeneralUtility.calculateMD5Base64EncodedByByteArray(oldPayloadData));
                
                ArtifactDefinition artifactToIgnore = new ArtifactDefinition();
                
index 3afb5d6..107163c 100644 (file)
@@ -229,7 +229,7 @@ public class ResourceServletTest extends JerseyTest {
        }
 
        private void setMD5OnRequest(boolean isValid, UploadResourceInfo json) {
-               String md5 = (isValid) ? GeneralUtility.calculateMD5ByString(gson.toJson(json)) : "stam=";
+               String md5 = (isValid) ? GeneralUtility.calculateMD5Base64EncodedByString(gson.toJson(json)) : "stam=";
                when(request.getHeader(Constants.MD5_HEADER)).thenReturn(md5);
 
        }
index d52aa03..27b9ba2 100644 (file)
@@ -54,6 +54,7 @@ import org.springframework.beans.factory.annotation.Qualifier;
 
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.List;
@@ -584,11 +585,11 @@ public class NodeTypeOperation extends ToscaElementOperation {
                                                return Either.right(StorageOperationStatus.PARENT_RESOURCE_NOT_FOUND);
                                        } else {
                                                if (resources.size() > 1) {
-                                                       log.error("Multiple parent resources called {} found in the graph.", parentResource);
-                                                       return Either.right(StorageOperationStatus.MULTIPLE_PARENT_RESOURCE_FOUND);
+                                                       return handleMultipleParent(parentResource, derivedResources, resources);
+                                               } else {
+                                                       GraphVertex parentResourceData = resources.get(0);
+                                                       derivedResources.add(parentResourceData);
                                                }
-                                               GraphVertex parentResourceData = resources.get(0);
-                                               derivedResources.add(parentResourceData);
                                        }
 
                                }
@@ -597,6 +598,47 @@ public class NodeTypeOperation extends ToscaElementOperation {
                }
                return Either.left(derivedResources);
        }
+       
+       Either<List<GraphVertex>, StorageOperationStatus> handleMultipleParent(String parentResource, List<GraphVertex> derivedResource, List<GraphVertex> fetchedDerivedResources){
+               
+               Either<List<GraphVertex>, StorageOperationStatus> result = Either.left(derivedResource);
+               try{
+                       fetchedDerivedResources.sort((d1,d2)->{
+                               return new Double(Double.parseDouble((String)d1.getMetadataProperty(GraphPropertyEnum.VERSION)))
+                                               .compareTo(Double.parseDouble((String)d2.getMetadataProperty(GraphPropertyEnum.VERSION)));
+                       });
+                       
+                       int actualHighestIndex = fetchedDerivedResources.size() - 1;
+                       derivedResource.add(fetchedDerivedResources.get(actualHighestIndex));
+                       fetchedDerivedResources.remove(actualHighestIndex);
+                       
+                       StorageOperationStatus status = fixMultipleParent(fetchedDerivedResources);
+                       if(status != StorageOperationStatus.OK){
+                               result = Either.right(status);
+                       }
+               } catch (Exception e){
+                       CommonUtility.addRecordToLog(log, LogLevelEnum.DEBUG, "Exception occured during handle multiple parent {}. Exception is  {}",
+                                       parentResource, e.getMessage());
+                       result = Either.right(StorageOperationStatus.GENERAL_ERROR);
+               }
+               return result;
+       }
+
+       private StorageOperationStatus fixMultipleParent(List<GraphVertex> fetchedDerivedResources) {
+               StorageOperationStatus result = StorageOperationStatus.OK;
+               for(GraphVertex fetchedDerivedResource : fetchedDerivedResources){
+                       fetchedDerivedResource.addMetadataProperty(GraphPropertyEnum.IS_HIGHEST_VERSION, false);
+                       Either<GraphVertex, TitanOperationStatus> updateVertexRes = titanDao.updateVertex(fetchedDerivedResource);
+                       if (updateVertexRes.isRight()) {
+                               TitanOperationStatus titatStatus = updateVertexRes.right().value();
+                               CommonUtility.addRecordToLog(log, LogLevelEnum.DEBUG, "Failed to set highest version of node type {} to false. Status is  {}",
+                                               fetchedDerivedResource.getMetadataProperty(GraphPropertyEnum.TOSCA_RESOURCE_NAME), titatStatus);
+                               result = DaoStatusConverter.convertTitanStatusToStorageStatus(titatStatus);
+                               break;
+                       }
+               }
+               return result;
+       }
 
        private GraphVertex fillMetadata(GraphVertex nodeTypeVertex, NodeType nodeType) {
                nodeTypeVertex.setLabel(VertexTypeEnum.NODE_TYPE);
index 3cc80ea..b11036d 100644 (file)
@@ -2207,5 +2207,13 @@ public class ToscaOperationFacade {
        public StorageOperationStatus deleteComponentInstanceInputsFromTopologyTemplate(Component containerComponent, ComponentTypeEnum componentType, List<InputDefinition> inputsToDelete) {
                return topologyTemplateOperation.deleteToscaDataElements(containerComponent.getUniqueId(), EdgeLabelEnum.INPUTS, inputsToDelete.stream().map(i -> i.getName()).collect(Collectors.toList()));
        }
+       
+       public StorageOperationStatus deleteAllCalculatedCapabilitiesRequirements(String topologyTemplateId) {
+               StorageOperationStatus status = topologyTemplateOperation.removeToscaData(topologyTemplateId, EdgeLabelEnum.CALCULATED_CAPABILITIES, VertexTypeEnum.CALCULATED_CAPABILITIES);
+               if(status == StorageOperationStatus.OK){
+                       status = topologyTemplateOperation.removeToscaData(topologyTemplateId, EdgeLabelEnum.CALCULATED_REQUIREMENTS, VertexTypeEnum.CALCULATED_REQUIREMENTS);
+               }
+               return status;
+       }
 
 }
index 8c6ed55..1545739 100644 (file)
@@ -65,6 +65,7 @@ export class ComponentMetadata {
     public namingPolicy: string;
     public serviceType:string;
     public serviceRole:string;
+    public environmentContext:string;
 
 
     //backend lifecycleState
@@ -101,7 +102,7 @@ export class ComponentMetadata {
         this.projectCode = response.projectCode;
         this.resourceType = response.resourceType;
         this.csarUUID = response.csarUUID;
-        this.csarVersion = response.version;
+        this.csarVersion = response.csarVersion;
         this.state = response.state;
         this.ecompGeneratedNaming = response.ecompGeneratedNaming;
         this.namingPolicy = response.namingPolicy;
@@ -109,6 +110,7 @@ export class ComponentMetadata {
         this.resourceVendorModelNumber = response.resourceVendorModelNumber;
         this.serviceType = response.serviceType;
         this.serviceRole = response.serviceRole;
+        this.environmentContext = response.environmentContext;
         return this;
     }
 
index 90a38e8..ce6921b 100644 (file)
@@ -36,6 +36,7 @@ export class Service extends Component {
     public namingPolicy:string;
     public serviceType:string;
     public serviceRole:string;
+    public environmentContext:string;
 
     constructor(componentService:IServiceService, $q:ng.IQService, component?:Service) {
         super(componentService, $q, component);
@@ -47,6 +48,7 @@ export class Service extends Component {
             this.namingPolicy = component.namingPolicy;
             this.serviceType = component.serviceType;
             this.serviceRole = component.serviceRole;
+            this.environmentContext = component.environmentContext;
             if (component.categories && component.categories[0]) {
                 this.mainCategory = component.categories[0].name;
                 this.selectedCategory = this.mainCategory;
@@ -161,6 +163,7 @@ export class Service extends Component {
         this.namingPolicy = componentMetadata.namingPolicy;
         this.serviceType = componentMetadata.serviceType;
         this.serviceRole = componentMetadata.serviceRole;
+        this.environmentContext = componentMetadata.environmentContext;
         this.setComponentDisplayData();
     }
 
index 48fc9db..c60a490 100644 (file)
@@ -20,7 +20,7 @@
 
 'use strict';
 import {ModalsHandler, ValidationUtils, EVENTS, CHANGE_COMPONENT_CSAR_VERSION_FLAG, ComponentType, DEFAULT_ICON,
-    ResourceType} from "app/utils";
+    ResourceType, ComponentState} from "app/utils";
 import {CacheService, EventListenerService, ProgressService, OnboardingService} from "app/services";
 import {IAppConfigurtaion, IValidate, IMainCategory, Resource, ISubCategory,Service, ICsarComponent} from "app/models";
 import {IWorkspaceViewModelScope} from "app/view-models/workspace/workspace-view-model";
@@ -41,6 +41,7 @@ export class componentCategories {//categories field bind to this obj in order t
     selectedCategory:string;
 }
 
+
 export interface IGeneralScope extends IWorkspaceViewModelScope {
     validation:Validation;
     editForm:ng.IFormController;
@@ -56,7 +57,7 @@ export interface IGeneralScope extends IWorkspaceViewModelScope {
     browseFileLabel:string;
     componentCategories:componentCategories;
 
-    onToscaFileChange():void
+    onToscaFileChange():void;
     validateField(field:any):boolean;
     validateName(isInit:boolean):void;
     calculateUnique(mainCategory:string, subCategory:string):string; // Build unique string from main and sub category
@@ -146,21 +147,24 @@ export class GeneralViewModel {
             (<Resource>this.$scope.component).resourceType == ResourceType.VF &&
             (<Resource>this.$scope.component).csarUUID) {
             this.$scope.isShowOnboardingSelectionBrowse = true;
-            let onboardCsarFilesMap:Dictionary<string> = this.cacheService.get('onboardCsarFilesMap');
+            let onboardCsarFilesMap:Dictionary<Dictionary<string>> = this.cacheService.get('onboardCsarFilesMap');
             // The onboardCsarFilesMap in cache contains map of [packageId]:[vsp display name for brows]
             // if the map is empty - Do request to BE
             if(onboardCsarFilesMap) {
-                this.$scope.importedToscaBrowseFileText = onboardCsarFilesMap[(<Resource>this.$scope.component).csarUUID];
+                if (onboardCsarFilesMap[(<Resource>this.$scope.component).csarUUID]){
+                    this.$scope.importedToscaBrowseFileText = onboardCsarFilesMap[(<Resource>this.$scope.component).csarUUID][(<Resource>this.$scope.component).csarVersion];
+                }
             }
             if(!onboardCsarFilesMap || !this.$scope.importedToscaBrowseFileText){
 
                 let onSuccess = (vsps:Array<ICsarComponent>): void =>{
                     onboardCsarFilesMap = {};
                     _.each(vsps, (vsp:ICsarComponent)=>{
-                        onboardCsarFilesMap[vsp.packageId] = vsp.vspName + " (" + vsp.version + ")";
+                        onboardCsarFilesMap[vsp.packageId] = onboardCsarFilesMap[vsp.packageId] || {};
+                        onboardCsarFilesMap[vsp.packageId][vsp.version] = vsp.vspName + " (" + vsp.version + ")";
                     });
                     this.cacheService.set('onboardCsarFilesMap', onboardCsarFilesMap);
-                    this.$scope.importedToscaBrowseFileText = onboardCsarFilesMap[(<Resource>this.$scope.component).csarUUID];
+                    this.$scope.importedToscaBrowseFileText = onboardCsarFilesMap[(<Resource>this.$scope.component).csarUUID][(<Resource>this.$scope.component).csarVersion];
                 };
 
                 let onError = (): void =>{
index d362680..3a3b2d3 100644 (file)
                         </div>
                     </div>
                     <!--------------------- Service Role -------------------->
+
                     <div class="meta-data" data-ng-if="component.creationDate">
                         <div>
                             <b>Created:</b>
index 9633ec5..b9b59de 100644 (file)
@@ -34,7 +34,7 @@
         }
 
         .description{
-            height: 300px;
+            height: 360px;
         }
 
         .i-sdc-form-item.description-field{
index 19ebefe..a7c9da0 100644 (file)
 
                 </div>
             </div>
-            <div class="tab-title" data-ng-if="!isComposition && !isDeployment">
-                {{getTabTitle()}}
+            <div class="w-sdc-main-container-body-content-wrapper">
+                <div class="tab-title" data-ng-if="!isComposition && !isDeployment">
+                    {{getTabTitle()}}
+                </div>
+                <div class="w-sdc-main-container-body-content" data-ng-class="{'third-party':thirdParty}" data-ui-view></div>
             </div>
-            <div class="w-sdc-main-container-body-content" data-ng-class="{'third-party':thirdParty}" data-ui-view></div>
         </div>
     </div>
     <top-nav search-bind="search.filterTerm" hide-search="true" menu-model="breadcrumbsModel" version="{{version}}"></top-nav>
index d0799f4..8b8b6d6 100644 (file)
             height: calc(~'100% - @{action_nav_height}'); //composition is the only tab without a tab title. need to exclude from calculation.
         }
         .w-sdc-main-container-body-content {
-            height:calc(~'100% - @{action_nav_height} - @{tab_title}');
+            // height:calc(~'100% - @{action_nav_height} - @{tab_title}');
             align-items: center;
             padding: 0 100px 20px 100px;
             &.third-party {
                 bottom: 0;
             }
         }
+        .w-sdc-main-container-body-content-wrapper {
+            overflow: auto;
+            height: calc(~'100% - @{action_nav_height}')
+        }
     }
 }
 
index 0b55fd1..8890b14 100644 (file)
@@ -134,7 +134,7 @@ public class GeneralUtility {
                return res;
        }
 
-       public static String calculateMD5ByByteArray(byte[] payload) {
+       public static String calculateMD5Base64EncodedByByteArray(byte[] payload) {
                String decodedMd5 = org.apache.commons.codec.digest.DigestUtils.md5Hex(payload);
                byte[] encodeMd5 = Base64.encodeBase64(decodedMd5.getBytes());
                return new String(encodeMd5);
@@ -146,7 +146,7 @@ public class GeneralUtility {
         * @param data
         * @return
         */
-       public static String calculateMD5ByString(String data) {
+       public static String calculateMD5Base64EncodedByString(String data) {
                String calculatedMd5 = org.apache.commons.codec.digest.DigestUtils.md5Hex(data);
 
                // encode base-64 result
index 8ec5a89..fd04f47 100644 (file)
@@ -52,6 +52,7 @@ public class CapabilityDataDefinition extends ToscaDataDefinition implements Ser
                this.setType(a.getType());              
                this.setDescription (  a.getDescription());
                this.setName(  a.getName());
+               this.setParentName(  a.getParentName());
                this.setValidSourceTypes( a.getValidSourceTypes());
                this.setCapabilitySources( a.getCapabilitySources());
                this.setOwnerId( a.getOwnerId());
@@ -128,6 +129,14 @@ public class CapabilityDataDefinition extends ToscaDataDefinition implements Ser
        public void setName(String name) {
                setToscaPresentationValue(JsonPresentationFields.NAME, name);
        }
+       
+       public String getParentName() {
+               return (String) getToscaPresentationValue(JsonPresentationFields.PARENT_NAME);
+       }
+
+       public void setParentName(String parentName) {
+               setToscaPresentationValue(JsonPresentationFields.PARENT_NAME, parentName);
+       }
 
        public String getType() {
                return (String) getToscaPresentationValue(JsonPresentationFields.TYPE);
index b32f65f..4a6f770 100644 (file)
@@ -47,6 +47,7 @@ public class RequirementDataDefinition extends ToscaDataDefinition implements Se
        public RequirementDataDefinition(RequirementDataDefinition other) {
                this.setUniqueId(other.getUniqueId());
                this.setName(other.getName());
+               this.setParentName(other.getParentName());
                this.setCapability(other.getCapability());
                this.setNode(other.getNode());
                this.setRelationship(other.getRelationship());
@@ -78,6 +79,14 @@ public class RequirementDataDefinition extends ToscaDataDefinition implements Se
        public void setName(String name) {
                setToscaPresentationValue(JsonPresentationFields.NAME, name);
        }
+       
+       public String getParentName() {
+               return (String) getToscaPresentationValue(JsonPresentationFields.PARENT_NAME);
+       }
+       
+       public void setParentName(String parentName) {
+               setToscaPresentationValue(JsonPresentationFields.PARENT_NAME, parentName);
+       }
 
        /**
         * specify the capability type
index fd028c0..8634ac8 100644 (file)
@@ -134,7 +134,7 @@ public enum JsonPresentationFields {
        RELATIONSHIP                                    ("relationship",                                null),
        VALID_SOURCE_TYPES                              ("validSourceTypes",                    null),
        REQUIREMENT_ID                                  ("requirementId",                               null),
-       
+       PARENT_NAME                                             ("parentName",                                  null),
        //Relation
        CAPABILTY_OWNER_ID                              ("capabilityOwnerId",                   null),
        REQUIREMENT_OWNER_ID                    ("requirementOwnerId",                  null),
diff --git a/pom.xml b/pom.xml
index 17bf79a..eab52ef 100644 (file)
--- a/pom.xml
+++ b/pom.xml
                        
                        <properties>
                                <ecomp.version>1.2.7</ecomp.version>
-                               <artifact-generator-api.version>1710.0.0-SNAPSHOT</artifact-generator-api.version>
-                               <artifact-generator-core.version>1710.0.0-SNAPSHOT</artifact-generator-core.version>
-                               <dox-common-lib.version>1710.0.0-SNAPSHOT</dox-common-lib.version>
+                               <artifact-generator-api.version>1710.0.0</artifact-generator-api.version>
+                               <artifact-generator-core.version>1710.0.0</artifact-generator-core.version>
+                               <dox-common-lib.version>1710.0.0</dox-common-lib.version>
                                <sdc-tosca-parser.version>1.1.14</sdc-tosca-parser.version>
                        </properties>   
                        
index a86358a..14e1fc3 100644 (file)
                        <artifactId>json</artifactId>
                        <version>20090211</version>
                </dependency>
-               <dependency>
+                <!-- <dependency>
                    <groupId>org.openecomp.sdc.sdc-distribution-client</groupId>
                    <artifactId>sdc-tosca-parser</artifactId>
-                   <version>${sdc-tosca-parser.version}</version>
+       <version>${sdc-tosca-parser.version}</version>
+                   <scope>compile</scope>
+               </dependency> -->
+               <dependency>
+                   <groupId>org.openecomp.sdc.sdc-tosca</groupId>
+                   <artifactId>sdc-tosca</artifactId>
+                       <version>1.1.32-SNAPSHOT</version>
                    <scope>compile</scope>
                </dependency>
        </dependencies>
index ea1c9ef..15a1eb7 100644 (file)
@@ -364,5 +364,7 @@ public interface Urls {
        final String ONBOARD_VERSION = "http://%s:%s/onboarding-api/docs/build-info.json";
        final String OS_VERSION = "http://%s:%s/sdc2/rest/version";
        
+//     amdocs APIs
+       final String GET_VENDOR_SOFTWARE_PRODUCT = "http://%s:%s/onboarding-api/v1.0/vendor-software-products/packages/%s";
        
 }
index 8456e5b..5a80fd1 100644 (file)
@@ -35,8 +35,10 @@ public class ResourceReqDetails extends ComponentReqDetails {
        Boolean isAbstract;
        Boolean isHighestVersion;
        String cost;
+
        String licenseType;
        String toscaResourceName;
+       String resourceVendorModelNumber;
 
        private String resourceType = ResourceTypeEnum.VFC.toString(); // Default
                                                                                                                                        // value
@@ -45,6 +47,21 @@ public class ResourceReqDetails extends ComponentReqDetails {
                super();
        }
 
+       public ResourceReqDetails(List<String> derivedFrom, String vendorName, String vendorRelease, Boolean isAbstract, Boolean isHighestVersion, String cost, String licenseType, String toscaResourceName, String resourceVendorModelNumber,
+                       String resourceType) {
+               super();
+               this.derivedFrom = derivedFrom;
+               this.vendorName = vendorName;
+               this.vendorRelease = vendorRelease;
+               this.isAbstract = isAbstract;
+               this.isHighestVersion = isHighestVersion;
+               this.cost = cost;
+               this.licenseType = licenseType;
+               this.toscaResourceName = toscaResourceName;
+               this.resourceVendorModelNumber = resourceVendorModelNumber;
+               this.resourceType = resourceType;
+       }
+
        public ResourceReqDetails(Resource resource) {
                super();
                this.resourceType = resource.getResourceType().toString();
@@ -68,6 +85,7 @@ public class ResourceReqDetails extends ComponentReqDetails {
                this.UUID = resource.getUUID();
                this.categories = resource.getCategories();
                this.importedToscaChecksum = resource.getImportedToscaChecksum();
+               this.resourceVendorModelNumber = resource.getResourceVendorModelNumber();
 
        }
 
@@ -136,6 +154,13 @@ public class ResourceReqDetails extends ComponentReqDetails {
                this.toscaResourceName = resourceName;
        }
 
+       public String getResourceVendorModelNumber() {
+               return resourceVendorModelNumber;
+       }
+       
+       public void setResourceVendorModelNumber(String resourceVendorModelNumber) {
+               this.resourceVendorModelNumber = resourceVendorModelNumber;
+       }
        public String getToscaResourceName() {
                return toscaResourceName;
        }
index e33183c..2f3d648 100644 (file)
@@ -26,6 +26,43 @@ import org.openecomp.sdc.be.model.Service;
 import org.openecomp.sdc.be.model.category.CategoryDefinition;
 
 public class ServiceReqDetails extends ComponentReqDetails {
+       
+       protected String serviceType;
+       protected String serviceRole;
+       protected String namingPolicy;
+       protected Boolean ecompGeneratedNaming;
+
+       public String getServiceType() {
+               return serviceType;
+       }
+
+       public void setServiceType(String serviceType) {
+               this.serviceType = serviceType;
+       }
+
+       public String getServiceRole() {
+               return serviceRole;
+       }
+
+       public void setServiceRole(String serviceRole) {
+               this.serviceRole = serviceRole;
+       }
+
+       public String getNamingPolicy() {
+               return namingPolicy;
+       }
+
+       public void setNamingPolicy(String namingPolicy) {
+               this.namingPolicy = namingPolicy;
+       }
+
+       public Boolean getEcompGeneratedNaming() {
+               return ecompGeneratedNaming;
+       }
+
+       public void setEcompGeneratedNaming(Boolean ecompGeneratedNaming) {
+               this.ecompGeneratedNaming = ecompGeneratedNaming;
+       }
 
        public ServiceReqDetails(String serviceName, String category, ArrayList<String> tags, String description,
                        String contactId, String icon) {
index 7e36320..1f578d1 100644 (file)
@@ -311,7 +311,7 @@ public class ArtifactServletTest extends ComponentBaseTest {
                httppost.addHeader(HttpHeaderEnum.ACCEPT.getValue(), acceptHeaderDate);
                httppost.addHeader(HttpHeaderEnum.USER_ID.getValue(), sdncUserDetails.getUserId());
                if (addMd5Header) {
-                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5ByString(jsonBody));
+                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5Base64EncodedByString(jsonBody));
                }
                StringEntity input = new StringEntity(jsonBody);
                input.setContentType("application/json");
index bb2b662..5f1230f 100644 (file)
@@ -624,7 +624,7 @@ artifact.setArtifactLabel("configure");*/
                httppost.addHeader(HttpHeaderEnum.ACCEPT.getValue(), acceptHeaderDate);
                httppost.addHeader(HttpHeaderEnum.USER_ID.getValue(), sdncUserDetails.getUserId());
                if (addMd5Header) {
-                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5ByString(jsonBody));
+                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5Base64EncodedByString(jsonBody));
                }
                StringEntity input = new StringEntity(jsonBody);
                input.setContentType("application/json");
index 7ba705f..2586192 100644 (file)
@@ -212,7 +212,7 @@ public class DistributionDownloadArtifactTest extends ComponentBaseTest {
                AssertJUnit.assertEquals(artifactDetails.getPayload(), Base64.encodeBase64String(actualContents.getBytes()));
 
                // validating checksum
-               String actualPayloadChecksum = GeneralUtility.calculateMD5ByByteArray(actualContents.getBytes());
+               String actualPayloadChecksum = GeneralUtility.calculateMD5Base64EncodedByByteArray(actualContents.getBytes());
                AssertJUnit.assertEquals(expectedPayloadChecksum, actualPayloadChecksum);
 
                // validate audit
@@ -380,7 +380,7 @@ public class DistributionDownloadArtifactTest extends ComponentBaseTest {
 
                // validating checksum
                byte[] bytes = actualContents.getBytes();
-               String actualPayloadChecksum = GeneralUtility.calculateMD5ByByteArray(bytes);
+               String actualPayloadChecksum = GeneralUtility.calculateMD5Base64EncodedByByteArray(bytes);
                assertEquals(expectedPayloadChecksum, actualPayloadChecksum);
 
                // validating valid zip
index c069f98..56deb3e 100644 (file)
@@ -189,7 +189,7 @@ public class ImportNewResourceCITest extends ComponentBaseTest {
                                + "  \"icon\": \"router\",\r\n" + "  \"tags\": [\r\n" + "    \"importResource4test\"\r\n" + "  ],\r\n"
                                + "  \"payloadData\": \"" + encodedPayload + "\"\r\n" + "}";
 
-               String md5 = GeneralUtility.calculateMD5ByString(json);
+               String md5 = GeneralUtility.calculateMD5Base64EncodedByString(json);
 
                Map<String, String> headers = new HashMap<String, String>();
                headers.put(Constants.MD5_HEADER, md5);
index 18b2329..d7ac4a5 100644 (file)
@@ -29,9 +29,7 @@ public class ToscaDefinition {
 
        String tosca_definitions_version;
        Map<String, String> metadata;
-//     Map<String, ToscaImportsDefinition> imports;
-//     TODO waiting for answer about imports representation
-       Object imports;
+       List<Map<String, ToscaImportsDefinition>> imports;
        Map<String, ToscaNodeTypesDefinition> node_types;
        ToscaTopologyTemplateDefinition topology_template;
 
@@ -39,54 +37,49 @@ public class ToscaDefinition {
                super();
        }
 
-       @Override
-       public String toString() {
-               return "ToscaDefinition [tosca_definitions_version=" + tosca_definitions_version + ", metadata=" + metadata + ", imports=" + imports + ", node_types=" + node_types + ", topology_template=" + topology_template + "]";
-       }
 
-       public String getTosca_definitions_version() {
-               return tosca_definitions_version;
-       }
 
-       public void setTosca_definitions_version(String tosca_definitions_version) {
+       public ToscaDefinition(String tosca_definitions_version, Map<String, String> metadata, List<Map<String, ToscaImportsDefinition>> imports, Map<String, ToscaNodeTypesDefinition> node_types,
+                       ToscaTopologyTemplateDefinition topology_template) {
+               super();
                this.tosca_definitions_version = tosca_definitions_version;
+               this.metadata = metadata;
+               this.imports = imports;
+               this.node_types = node_types;
+               this.topology_template = topology_template;
        }
 
+
+
        public Map<String, String> getMetadata() {
                return metadata;
        }
 
+
+
        public void setMetadata(Map<String, String> metadata) {
                this.metadata = metadata;
        }
 
-       
 
-       
-//     public Map<String,ToscaImportsDefinition> getImports() {
-//             return (Map<String, ToscaImportsDefinition>) imports;
-//     }
-//
-//     public void setImports(Map<String,ToscaImportsDefinition> imports) {
-//             this.imports = imports;
-//     }
-//     
-//     public List<ToscaImportsDefinition> getImports() {
-//             return (List<ToscaImportsDefinition>) imports;
-//     }
-//
-//     public void setImports(List<ToscaImportsDefinition> imports) {
-//             this.imports = imports;
-//     }
-
-       public Object getImports() {
+
+       public List<Map<String, ToscaImportsDefinition>> getImports() {
                return imports;
        }
 
-       public void setImports(Object imports) {
+       public void setImports(List<Map<String, ToscaImportsDefinition>> imports) {
                this.imports = imports;
        }
 
+       public String getTosca_definitions_version() {
+               return tosca_definitions_version;
+       }
+
+       public void setTosca_definitions_version(String tosca_definitions_version) {
+               this.tosca_definitions_version = tosca_definitions_version;
+       }
+
+       
        public Map<String, ToscaNodeTypesDefinition> getNode_types() {
                return node_types;
        }
@@ -109,9 +102,7 @@ public class ToscaDefinition {
        public static TypeDescription getTypeDescription(){
         TypeDescription typeDescription = new TypeDescription(ToscaDefinition.class);
         typeDescription.putMapPropertyType("metadata", String.class, String.class);
-//        TODO Andrey imports format
-        typeDescription.putMapPropertyType("imports", String.class, ToscaImportsDefinition.class);
-//        typeDescription.putListPropertyType("imports", List.class);
+        typeDescription.putListPropertyType("imports", Map.class);
         typeDescription.putMapPropertyType("node_types", String.class, ToscaNodeTypesDefinition.class);
        return typeDescription;
        }
index dc3c407..e305151 100644 (file)
@@ -35,17 +35,17 @@ public class ToscaGroupsTopologyTemplateDefinition {
        private Map<String, Object> interfaces;
        private List<String> members;
 //     private Map<String, String> metadata;
-       private ToscaGroupsMetadataDefinition metadata;
+       private ToscaServiceGroupsMetadataDefinition metadata;
 
        public ToscaGroupsTopologyTemplateDefinition() {
                super();
        }
 
-       public ToscaGroupsMetadataDefinition getMetadata() {
+       public ToscaServiceGroupsMetadataDefinition getMetadata() {
                return metadata;
        }
 
-       public void setMetadata(ToscaGroupsMetadataDefinition metadata) {
+       public void setMetadata(ToscaServiceGroupsMetadataDefinition metadata) {
                this.metadata = metadata;
        }
 
index d62e33e..a5070b8 100644 (file)
 
 package org.openecomp.sdc.ci.tests.tosca.datatypes;
 
+import org.yaml.snakeyaml.TypeDescription;
+
 public class ToscaImportsDefinition {
 
+       private String name;
        private String file;
        private String repository;
        private String namespace_uri;
@@ -32,17 +35,21 @@ public class ToscaImportsDefinition {
                // TODO Auto-generated constructor stub
        }
 
-       public ToscaImportsDefinition(String file, String repository, String namespace_uri, String namespace_prefix) {
+       public ToscaImportsDefinition(String name, String file, String repository, String namespace_uri, String namespace_prefix) {
                super();
+               this.name = name;
                this.file = file;
                this.repository = repository;
                this.namespace_uri = namespace_uri;
                this.namespace_prefix = namespace_prefix;
        }
 
-       @Override
-       public String toString() {
-               return "ToscaImportsDefinition [file=" + file + ", repository=" + repository + ", namespace_uri=" + namespace_uri + ", namespace_prefix=" + namespace_prefix + "]";
+       public String getName() {
+               return name;
+       }
+
+       public void setName(String name) {
+               this.name = name;
        }
 
        public String getFile() {
@@ -76,6 +83,13 @@ public class ToscaImportsDefinition {
        public void setNamespace_prefix(String namespace_prefix) {
                this.namespace_prefix = namespace_prefix;
        }
+
+       //gets Type description for Yaml snake
+       public static TypeDescription getTypeDescription(){
+        TypeDescription typeDescription = new TypeDescription(ToscaImportsDefinition.class);
+       return typeDescription;
+       }
+
        
        
 }
index 6f9590f..45feade 100644 (file)
@@ -22,6 +22,8 @@ package org.openecomp.sdc.ci.tests.tosca.datatypes;
 
 import java.util.Map;
 
+import org.yaml.snakeyaml.TypeDescription;
+
 public class ToscaInputsTopologyTemplateDefinition {
        
        private Map<String,Map<String,Object>> inputs;
@@ -40,6 +42,10 @@ public class ToscaInputsTopologyTemplateDefinition {
        }
        
        
-       
+       //gets Type description for Yaml snake
+       public static TypeDescription getTypeDescription(){
+        TypeDescription typeDescription = new TypeDescription(ToscaInputsTopologyTemplateDefinition.class);
+       return typeDescription;
+       }
 
 }
diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaMetadataDefinition.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/datatypes/ToscaMetadataDefinition.java
new file mode 100644 (file)
index 0000000..ceba7ad
--- /dev/null
@@ -0,0 +1,196 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.sdc.ci.tests.tosca.datatypes;
+
+import org.yaml.snakeyaml.TypeDescription;
+
+public class ToscaMetadataDefinition {
+
+       private String invariantUUID;
+       private String UUID;
+       private String name;
+       private String description;
+       private String type;
+       private String category;
+       private String subcategory;
+       private String resourceVendor;
+       private String resourceVendorRelease;
+       private String resourceVendorModelNumber;
+       private String serviceType;
+       private String serviceRole;
+       private String serviceEcompNaming;
+       private String ecompGeneratedNaming;
+       private String namingPolicy;
+       
+       public ToscaMetadataDefinition(String invariantUUID, String uUID, String name, String description, String type, String category, String subcategory, String resourceVendor, String resourceVendorRelease, String resourceVendorModelNumber,
+                       String serviceType, String serviceRole, String serviceEcompNaming, String ecompGeneratedNaming, String namingPolicy) {
+               super();
+               this.invariantUUID = invariantUUID;
+               UUID = uUID;
+               this.name = name;
+               this.description = description;
+               this.type = type;
+               this.category = category;
+               this.subcategory = subcategory;
+               this.resourceVendor = resourceVendor;
+               this.resourceVendorRelease = resourceVendorRelease;
+               this.resourceVendorModelNumber = resourceVendorModelNumber;
+               this.serviceType = serviceType;
+               this.serviceRole = serviceRole;
+               this.serviceEcompNaming = serviceEcompNaming;
+               this.ecompGeneratedNaming = ecompGeneratedNaming;
+               this.namingPolicy = namingPolicy;
+       }
+
+       public String getInvariantUUID() {
+               return invariantUUID;
+       }
+
+       public void setInvariantUUID(String invariantUUID) {
+               this.invariantUUID = invariantUUID;
+       }
+
+       public String getUUID() {
+               return UUID;
+       }
+
+       public void setUUID(String uUID) {
+               UUID = uUID;
+       }
+
+       public String getName() {
+               return name;
+       }
+
+       public void setName(String name) {
+               this.name = name;
+       }
+
+       public String getDescription() {
+               return description;
+       }
+
+       public void setDescription(String description) {
+               this.description = description;
+       }
+
+       public String getType() {
+               return type;
+       }
+
+       public void setType(String type) {
+               this.type = type;
+       }
+
+       public String getCategory() {
+               return category;
+       }
+
+       public void setCategory(String category) {
+               this.category = category;
+       }
+
+       public String getSubcategory() {
+               return subcategory;
+       }
+
+       public void setSubcategory(String subcategory) {
+               this.subcategory = subcategory;
+       }
+
+       public String getResourceVendor() {
+               return resourceVendor;
+       }
+
+       public void setResourceVendor(String resourceVendor) {
+               this.resourceVendor = resourceVendor;
+       }
+
+       public String getResourceVendorRelease() {
+               return resourceVendorRelease;
+       }
+
+       public void setResourceVendorRelease(String resourceVendorRelease) {
+               this.resourceVendorRelease = resourceVendorRelease;
+       }
+
+       public String getResourceVendorModelNumber() {
+               return resourceVendorModelNumber;
+       }
+
+       public void setResourceVendorModelNumber(String resourceVendorModelNumber) {
+               this.resourceVendorModelNumber = resourceVendorModelNumber;
+       }
+
+       public String getServiceType() {
+               return serviceType;
+       }
+
+       public void setServiceType(String serviceType) {
+               this.serviceType = serviceType;
+       }
+
+       public String getServiceRole() {
+               return serviceRole;
+       }
+
+       public void setServiceRole(String serviceRole) {
+               this.serviceRole = serviceRole;
+       }
+
+       public String getServiceEcompNaming() {
+               return serviceEcompNaming;
+       }
+
+       public void setServiceEcompNaming(String serviceEcompNaming) {
+               this.serviceEcompNaming = serviceEcompNaming;
+       }
+
+       public String getEcompGeneratedNaming() {
+               return ecompGeneratedNaming;
+       }
+
+       public void setEcompGeneratedNaming(String ecompGeneratedNaming) {
+               this.ecompGeneratedNaming = ecompGeneratedNaming;
+       }
+
+       public String getNamingPolicy() {
+               return namingPolicy;
+       }
+
+       public void setNamingPolicy(String namingPolicy) {
+               this.namingPolicy = namingPolicy;
+       }
+
+       @Override
+       public String toString() {
+               return "ToscaMetadataDefinition [invariantUUID=" + invariantUUID + ", UUID=" + UUID + ", name=" + name + ", description=" + description + ", type=" + type + ", category=" + category + ", subcategory=" + subcategory
+                               + ", resourceVendor=" + resourceVendor + ", resourceVendorRelease=" + resourceVendorRelease + ", resourceVendorModelNumber=" + resourceVendorModelNumber + ", serviceType=" + serviceType + ", serviceRole=" + serviceRole
+                               + ", serviceEcompNaming=" + serviceEcompNaming + ", ecompGeneratedNaming=" + ecompGeneratedNaming + ", namingPolicy=" + namingPolicy + "]";
+       }
+       
+       //gets Type description for Yaml snake
+       public static TypeDescription getTypeDescription(){
+        TypeDescription typeDescription = new TypeDescription(ToscaMetadataDefinition.class);
+       return typeDescription;
+       }
+       
+}
@@ -20,7 +20,7 @@
 
 package org.openecomp.sdc.ci.tests.tosca.datatypes;
 
-public class ToscaGroupsMetadataDefinition {
+public class ToscaServiceGroupsMetadataDefinition {
 
        private String vfModuleModelName;
        private String vfModuleModelInvariantUUID;
@@ -28,7 +28,7 @@ public class ToscaGroupsMetadataDefinition {
        private String vfModuleModelUUID;
        private String vfModuleModelVersion;
        
-       public ToscaGroupsMetadataDefinition() {
+       public ToscaServiceGroupsMetadataDefinition() {
                super();
                // TODO Auto-generated constructor stub
        }
diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/model/ToscaMetadataFieldsPresentationEnum.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/tosca/model/ToscaMetadataFieldsPresentationEnum.java
new file mode 100644 (file)
index 0000000..cdea2ff
--- /dev/null
@@ -0,0 +1,74 @@
+package org.openecomp.sdc.ci.tests.tosca.model;
+
+public class ToscaMetadataFieldsPresentationEnum {
+
+       public enum ToscaMetadataFieldsEnum {
+//             general
+               INVARIANT_UUID                         ("invariantUUID",                    ComponentTypeEnum.RESOURCE_SERVICE_NODE_TEMPLATE.value), 
+               UUID                                   ("UUID",                             ComponentTypeEnum.RESOURCE_SERVICE_NODE_TEMPLATE.value), 
+               NAME                                   ("name",                             ComponentTypeEnum.RESOURCE_SERVICE_NODE_TEMPLATE.value),
+               DESCRIPTION                            ("description",                      ComponentTypeEnum.RESOURCE_SERVICE_NODE_TEMPLATE.value), 
+               CATEGORY                               ("category",                         ComponentTypeEnum.RESOURCE_SERVICE_NODE_TEMPLATE.value),
+               TYPE                                   ("type",                             ComponentTypeEnum.RESOURCE_SERVICE_NODE_TEMPLATE.value),
+       
+//             resource
+               SUBCATEGORY                            ("subcategory",                      ComponentTypeEnum.RESOURCE_NODE_TEMPLATE.value), 
+               RESOURCE_VENDOR_NAME                   ("resourceVendor",                   ComponentTypeEnum.RESOURCE_NODE_TEMPLATE.value), 
+               RESOURCE_VENDOR_RELEASE                ("resourceVendorRelease",            ComponentTypeEnum.RESOURCE_NODE_TEMPLATE.value),
+               RESOURCE_VENDOR_MODEL_NUMBER           ("resourceVendorModelNumber",        ComponentTypeEnum.RESOURCE_NODE_TEMPLATE.value),
+               
+//             service
+               SERVICE_TYPE                           ("serviceType",                      ComponentTypeEnum.SERVICE.value), 
+               SERVICE_ROLE                           ("serviceRole",                      ComponentTypeEnum.SERVICE.value), 
+               SERVICE_ECOMP_NAMING                   ("serviceEcompNaming",               ComponentTypeEnum.SERVICE.value),
+               ECOMP_GENERATED_NAMING                 ("ecompGeneratedNaming",             ComponentTypeEnum.SERVICE.value),
+               NAMING_POLICY                          ("namingPolicy",                     ComponentTypeEnum.SERVICE.value),
+               
+//             node_template
+               CUSTOMIZATION_UUID                     ("customizationUUID",                ComponentTypeEnum.NODE_TEMPLATE.value), 
+               VERSION                                ("version",                          ComponentTypeEnum.RESOURCE_GROUP_NODE_TEMPLATE.value), 
+               
+//             service group:
+               VF_MODULE_MODEL_NAME                   ("vfModuleModelName",                ComponentTypeEnum.RESOURCE_GROUP_SERVICE_GROUP.value), 
+               VF_MODULE_MODEL_INVARIANT_UUID         ("vfModuleModelInvariantUUID",       ComponentTypeEnum.RESOURCE_GROUP_SERVICE_GROUP.value), 
+               VF_MODULE_MODEL_UUID                   ("vfModuleModelUUID",                ComponentTypeEnum.RESOURCE_GROUP_SERVICE_GROUP.value),
+               VF_MODULE_MODEL_VERSION                ("vfModuleModelVersion",             ComponentTypeEnum.RESOURCE_GROUP_SERVICE_GROUP.value),
+               
+               VF_MODULE_MODEL_CUSTOMIZATION_UUID     ("vfModuleModelCustomizationUUID",   ComponentTypeEnum.SERVICE_GROUP.value)
+               ;
+               
+               
+               
+               public String value;
+               public String componentTypes;
+       
+               private ToscaMetadataFieldsEnum(String value, String componentTypes) {
+                       this.value = value;
+                       this.componentTypes = componentTypes;
+               }
+               
+       }
+       
+
+       public enum ComponentTypeEnum {
+//             RESOURCE_SERVICE_NODE_TEMPLATE_RESOURCE_GROUP("resource, service, nodeTemplate, resourceGroup"), 
+               RESOURCE_SERVICE_NODE_TEMPLATE("resource, service, nodeTemplate"),
+               RESOURCE_NODE_TEMPLATE("resource, nodeTemplate"),
+               SERVICE("service"),
+               NODE_TEMPLATE("nodeTemplate"),
+               RESOURCE_GROUP_NODE_TEMPLATE("resourceGroup, nodeTemplate"),
+               SERVICE_GROUP("serviceGroup"),
+               RESOURCE_GROUP_SERVICE_GROUP("resourceGroup, serviceGroup"),
+               
+       ;
+       
+               private String value;
+
+               private ComponentTypeEnum(String value) {
+                       this.value = value;
+               }
+               
+       }
+       
+       
+}
index 3bae41f..5926798 100644 (file)
@@ -29,12 +29,13 @@ import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.Map;
-import java.util.Set;
 
-import org.openecomp.sdc.ci.tests.datatypes.enums.ToscaKeysEnum;
 import org.openecomp.sdc.ci.tests.datatypes.enums.UserRoleEnum;
 import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaDefinition;
 import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaGroupsTopologyTemplateDefinition;
+import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaImportsDefinition;
+import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaInputsTopologyTemplateDefinition;
+import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaMetadataDefinition;
 import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaNodeTemplatesTopologyTemplateDefinition;
 import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaParameterConstants;
 import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaSubstitutionMappingsDefinition;
@@ -42,12 +43,10 @@ import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaTopologyTemplateDefinitio
 import org.openecomp.sdc.ci.tests.utils.general.ElementFactory;
 import org.openecomp.sdc.ci.tests.utils.rest.BaseRestUtils;
 import org.openecomp.sdc.ci.tests.utils.rest.ImportRestUtils;
-import org.openecomp.sdc.ci.tests.utils.validation.CsarValidationUtils;
 import org.openecomp.sdc.common.rest.api.RestResponseAsByteArray;
 import org.openecomp.sdc.common.util.ZipUtil;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.yaml.snakeyaml.TypeDescription;
 import org.yaml.snakeyaml.Yaml;
 import org.yaml.snakeyaml.constructor.Constructor;
 import org.yaml.snakeyaml.introspector.PropertyUtils;
@@ -158,7 +157,9 @@ public class ToscaParserUtils {
        toscaStructure.addTypeDescription(ToscaNodeTemplatesTopologyTemplateDefinition.getTypeDescription());
        toscaStructure.addTypeDescription(ToscaGroupsTopologyTemplateDefinition.getTypeDescription());
        toscaStructure.addTypeDescription(ToscaSubstitutionMappingsDefinition.getTypeDescription());
-       
+       toscaStructure.addTypeDescription(ToscaImportsDefinition.getTypeDescription());
+       toscaStructure.addTypeDescription(ToscaMetadataDefinition.getTypeDescription());
+       toscaStructure.addTypeDescription(ToscaInputsTopologyTemplateDefinition.getTypeDescription());
 //     Skip properties which are found in YAML, but not found in POJO
        PropertyUtils propertyUtils = new PropertyUtils();
        propertyUtils.setSkipMissingProperties(true);
index 17148ce..58ab9f3 100644 (file)
@@ -39,6 +39,7 @@ import org.apache.commons.lang3.tuple.Pair;
 import org.aspectj.apache.bcel.classfile.Code;
 import org.json.JSONException;
 import org.openecomp.sdc.be.datatypes.elements.ConsumerDataDefinition;
+import org.openecomp.sdc.be.datatypes.enums.ComponentTypeEnum;
 import org.openecomp.sdc.be.datatypes.enums.ResourceTypeEnum;
 import org.openecomp.sdc.be.model.ArtifactDefinition;
 import org.openecomp.sdc.be.model.Component;
@@ -50,6 +51,7 @@ import org.openecomp.sdc.be.model.Resource;
 import org.openecomp.sdc.be.model.Service;
 import org.openecomp.sdc.be.model.User;
 import org.openecomp.sdc.ci.tests.api.Urls;
+import org.openecomp.sdc.ci.tests.config.Config;
 import org.openecomp.sdc.ci.tests.datatypes.ArtifactReqDetails;
 import org.openecomp.sdc.ci.tests.datatypes.ComponentInstanceReqDetails;
 import org.openecomp.sdc.ci.tests.datatypes.ImportReqDetails;
@@ -67,6 +69,7 @@ import org.openecomp.sdc.ci.tests.datatypes.enums.UserRoleEnum;
 import org.openecomp.sdc.ci.tests.datatypes.http.HttpHeaderEnum;
 import org.openecomp.sdc.ci.tests.datatypes.http.HttpRequest;
 import org.openecomp.sdc.ci.tests.datatypes.http.RestResponse;
+import org.openecomp.sdc.ci.tests.utils.Utils;
 import org.openecomp.sdc.ci.tests.utils.rest.ArtifactRestUtils;
 import org.openecomp.sdc.ci.tests.utils.rest.BaseRestUtils;
 import org.openecomp.sdc.ci.tests.utils.rest.ComponentInstanceRestUtils;
@@ -134,6 +137,25 @@ public final class AtomicOperationUtils {
                }
        }
 
+       public static Either<Resource, RestResponse> createResourceByResourceDetails(ResourceReqDetails resourceDetails, UserRoleEnum userRole, Boolean validateState) {
+               try {
+                       User defaultUser = ElementFactory.getDefaultUser(userRole);
+                       RestResponse resourceResp = ResourceRestUtils.createResource(resourceDetails, defaultUser);
+
+                       if (validateState) {
+                               assertTrue(resourceResp.getErrorCode() == ResourceRestUtils.STATUS_CODE_CREATED);
+                       }
+
+                       if (resourceResp.getErrorCode() == ResourceRestUtils.STATUS_CODE_CREATED) {
+                               Resource resourceResponseObject = ResponseParser.convertResourceResponseToJavaObject(resourceResp.getResponse());
+                               return Either.left(resourceResponseObject);
+                       }
+                       return Either.right(resourceResp);
+               } catch (Exception e) {
+                       throw new AtomicOperationException(e);
+               }
+       }
+       
        public static Either<Resource, RestResponse> createResourcesByTypeNormTypeAndCatregory(ResourceTypeEnum resourceType, NormativeTypesEnum normativeTypes, ResourceCategoryEnum resourceCategory, UserRoleEnum userRole, Boolean validateState)
                        throws Exception {
                User defaultUser = ElementFactory.getDefaultUser(userRole);
@@ -206,6 +228,20 @@ public final class AtomicOperationUtils {
                return Either.right(createServiceResp);
        }
 
+       public static Either<Service, RestResponse> createCustomService(ServiceReqDetails serviceDetails, UserRoleEnum userRole, Boolean validateState) throws Exception {
+               User defaultUser = ElementFactory.getDefaultUser(userRole);
+               RestResponse createServiceResp = ServiceRestUtils.createService(serviceDetails, defaultUser);
+
+               if (validateState) {
+                       assertTrue(createServiceResp.getErrorCode() == ServiceRestUtils.STATUS_CODE_CREATED);
+               }
+
+               if (createServiceResp.getErrorCode() == ResourceRestUtils.STATUS_CODE_CREATED) {
+                       Service serviceResponseObject = ResponseParser.convertServiceResponseToJavaObject(createServiceResp.getResponse());
+                       return Either.left(serviceResponseObject);
+               }
+               return Either.right(createServiceResp);
+       }
        // *********** PRODUCT ****************
 
        public static Either<Product, RestResponse> createDefaultProduct(UserRoleEnum userRole, Boolean validateState) throws Exception {
@@ -713,16 +749,21 @@ public final class AtomicOperationUtils {
                }
        }
        
-       public static Either<String, RestResponse> getServiceToscaArtifactPayload(Service service, String artifactType) throws Exception {
+       public static Either<String, RestResponse> getComponenetArtifactPayload(Component component, String artifactType) throws Exception {
 
-               String url = String.format(Urls.UI_DOWNLOAD_SERVICE_ARTIFACT, "localhost", "8080", service.getUniqueId(), service.getToscaArtifacts().get(artifactType).getUniqueId());
-               String userId = service.getLastUpdaterUserId();
+               String url;
+               Config config = Utils.getConfig();
+               if(component.getComponentType().toString().toUpperCase().equals(ComponentTypeEnum.SERVICE.getValue().toUpperCase())){
+                       url = String.format(Urls.UI_DOWNLOAD_SERVICE_ARTIFACT, config.getCatalogBeHost(), config.getCatalogBePort(), component.getUniqueId(), component.getToscaArtifacts().get(artifactType).getUniqueId());
+               }else{
+                       url = String.format(Urls.UI_DOWNLOAD_RESOURCE_ARTIFACT, config.getCatalogBeHost(), config.getCatalogBePort(), component.getUniqueId(), component.getToscaArtifacts().get(artifactType).getUniqueId());
+               }
+               String userId = component.getLastUpdaterUserId();
                Map<String, String> headersMap = new HashMap<String, String>();
                headersMap.put(HttpHeaderEnum.CONTENT_TYPE.getValue(), "application/json");
                headersMap.put(HttpHeaderEnum.CACHE_CONTROL.getValue(), "no-cache");
                headersMap.put(HttpHeaderEnum.AUTHORIZATION.getValue(), basicAuthentication);
                headersMap.put(HttpHeaderEnum.X_ECOMP_INSTANCE_ID.getValue(), "ci");
-//             headersMap.put("X-ECOMP-InstanceID", "test");
                if (userId != null) {
                        headersMap.put(HttpHeaderEnum.USER_ID.getValue(), userId);
                }
@@ -735,4 +776,6 @@ public final class AtomicOperationUtils {
 
        }
 
+       
+       
 }
index 5c23b5f..ddca429 100644 (file)
@@ -293,7 +293,7 @@ public class ElementFactory {
                tags.add("serviceTag1");
                tags.add(serviceName);
                String description = "service Description";
-               String icon = "myIcon";
+               String icon = "defaulticon";
 
                ServiceReqDetails serviceDetails = new ServiceReqDetails(serviceName, category.getValue(), tags, description, contactId, icon);
 
@@ -979,7 +979,7 @@ public class ElementFactory {
                return requirementDef;
        }
 
-       private static String generateUUIDforSufix() {
+       public static String generateUUIDforSufix() {
 
                String uniqueSufix = UUID.randomUUID().toString();
                String[] split = uniqueSufix.split("-");
index e08ef65..ec8fd40 100644 (file)
@@ -78,7 +78,7 @@ public class ResourceRestUtils extends BaseRestUtils {
 
                Gson gson = new Gson();
                String userBodyJson = gson.toJson(resourceDetails);
-               String calculateMD5 = GeneralUtility.calculateMD5ByString(userBodyJson);
+               String calculateMD5 = GeneralUtility.calculateMD5Base64EncodedByString(userBodyJson);
                headersMap.put(HttpHeaderEnum.Content_MD5.getValue(), calculateMD5);
                HttpRequest http = new HttpRequest();
                // System.out.println(url);
@@ -490,7 +490,7 @@ public class ResourceRestUtils extends BaseRestUtils {
 
                Gson gson = new Gson();
                String userBodyJson = gson.toJson(resourceDetails);
-               String calculateMD5 = GeneralUtility.calculateMD5ByString(userBodyJson);
+               String calculateMD5 = GeneralUtility.calculateMD5Base64EncodedByString(userBodyJson);
                headersMap.put(HttpHeaderEnum.Content_MD5.getValue(), calculateMD5);
                HttpRequest http = new HttpRequest();
                RestResponse updateResourceResponse = http.httpSendPut(url, userBodyJson, headersMap);
index 10f573c..19d7d72 100644 (file)
@@ -48,7 +48,7 @@ public class ResourceRestUtilsExternalAPI extends BaseRestUtils {
 
                Gson gson = new Gson();
                String userBodyJson = gson.toJson(resourceDetails);
-               String calculateMD5 = GeneralUtility.calculateMD5ByString(userBodyJson);
+               String calculateMD5 = GeneralUtility.calculateMD5Base64EncodedByString(userBodyJson);
                headersMap.put(HttpHeaderEnum.Content_MD5.getValue(), calculateMD5);
                headersMap.put(HttpHeaderEnum.AUTHORIZATION.getValue(), authorizationHeader);
                headersMap.put(HttpHeaderEnum.X_ECOMP_INSTANCE_ID.getValue(), "ci");
index 61b7ea1..9ba6953 100644 (file)
@@ -3377,7 +3377,7 @@ public class CRUDExternalAPI extends ComponentBaseTest {
                httppost.addHeader(HttpHeaderEnum.ACCEPT.getValue(), acceptHeaderDate);
                httppost.addHeader(HttpHeaderEnum.USER_ID.getValue(), sdncUserDetails.getUserId());
                if (addMd5Header) {
-                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5ByString(jsonBody));
+                       httppost.addHeader(HttpHeaderEnum.Content_MD5.getValue(), GeneralUtility.calculateMD5Base64EncodedByString(jsonBody));
                }
                StringEntity input = new StringEntity(jsonBody);
                input.setContentType("application/json");
index 41c1212..06e55bc 100644 (file)
@@ -120,7 +120,7 @@ public class AddComponentInstancesArtifactsInCsar extends SetupCDTest {
                
                ResourceGeneralPage.getLeftMenu().moveToToscaArtifactsScreen();
                ToscaArtifactsPage.downloadCsar();
-               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir();
+               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir();
                Map<String, Object> combineHeatArtifacstWithFolderArtifacsToMap = ArtifactFromCsar.getVFCArtifacts(latestFilefromDir.getAbsolutePath());
                
                compareArtifactFromFileStructureToArtifactsFromJavaObject(artifacts, combineHeatArtifacstWithFolderArtifacsToMap);
index 9ea1b72..3fb1529 100644 (file)
@@ -133,7 +133,7 @@ public class MIBsArtifactsOnResourceInstance extends SetupCDTest {
        @DataProvider(name="mibsArtifacsOnResourceInstanceShouldOnlyHaveDownloadOption") 
        public static Object[][] dataProviderMibsArtifacsOnResourceInstanceShouldOnlyHaveDownloadOption() {
                return new Object[][] {
-                       {"mibs1vFW_VFC.yml", ResourceTypeEnum.VFC},
+//                     {"mibs1vFW_VFC.yml", ResourceTypeEnum.VFC},
                        // TODO: delete comment below when we will have support for VL on canvas
 //                     {"mibs1VL.yml", ResourceTypeEnum.VL},
                        {"mibs1CP.yml", ResourceTypeEnum.CP}
@@ -145,9 +145,9 @@ public class MIBsArtifactsOnResourceInstance extends SetupCDTest {
        @Test(dataProvider="mibsArtifacsOnResourceInstanceShouldOnlyHaveDownloadOption")
        public void mibsArtifacsOnResourceInstanceShouldOnlyHaveDownloadOption(String fileName, ResourceTypeEnum resourceTypeEnum) throws Exception {
                
-               if(resourceTypeEnum.equals(ResourceTypeEnum.CP)){
-                       throw new SkipException("Open bug 322930");                     
-               }
+//             if(resourceTypeEnum.equals(ResourceTypeEnum.CP)){
+//                     throw new SkipException("Open bug 322930");                     
+//             }
 
                setLog(fileName);
                
@@ -174,7 +174,7 @@ public class MIBsArtifactsOnResourceInstance extends SetupCDTest {
                
                // 4. Create VF.
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                // 5. Click on composition.
                ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
@@ -212,7 +212,7 @@ public class MIBsArtifactsOnResourceInstance extends SetupCDTest {
 
                // 1. Create VF.
                ResourceReqDetails resourceMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(resourceMetaData, getUser());
+               ResourceUIUtils.createVF(resourceMetaData, getUser());
                        
                // 2. Upload MIBs artifacts - SNMP_TRAP & SNMP_POLL.
                ResourceGeneralPage.getLeftMenu().moveToDeploymentArtifactScreen();
index 9d460b0..2195af9 100644 (file)
@@ -53,7 +53,7 @@ public class NewArtifactTypeGuide extends SetupCDTest {
                String filePath = FileHandling.getFilePath(folder);
 
                ResourceReqDetails resourceMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(resourceMetaData, getUser());
+               ResourceUIUtils.createVF(resourceMetaData, getUser());
                        
                ResourceGeneralPage.getLeftMenu().moveToInformationalArtifactScreen();
                
index 1f85ec2..df68a18 100644 (file)
@@ -81,7 +81,7 @@ public class RemoveRestrictionOfDeploymentArtifacts extends SetupCDTest {
        @Test
        public void createServiceWithInformationalArtifacts() throws Exception {
                ResourceReqDetails resourceMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(resourceMetaData, getUser());
+               ResourceUIUtils.createVF(resourceMetaData, getUser());
                
                ResourceGeneralPage.getLeftMenu().moveToInformationalArtifactScreen();
                                
index 4e9770c..8e669b1 100644 (file)
@@ -22,6 +22,7 @@ package org.openecomp.sdc.ci.tests.US;
 
 import java.io.File;
 import java.text.SimpleDateFormat;
+import java.util.Arrays;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.Map;
@@ -35,6 +36,8 @@ import org.openecomp.sdc.ci.tests.utilities.FileHandling;
 import org.openecomp.sdc.ci.tests.utils.ToscaParserUtils;
 import org.testng.Assert;
 
+import fj.data.Array;
+
 
 
 
@@ -195,8 +198,11 @@ public class Testing {
 //        }
         System.out.println("Finished");
         System.out.println("get service start " + new SimpleDateFormat("yyyy/MM/dd HH:mm:ss").format(new Date()));
+        
+        
+    
        }
-       
+
        
        
 
index e7d9334..64caee8 100644 (file)
@@ -85,7 +85,7 @@ public class VfModule extends SetupCDTest {
                String vspName = createVendorSoftwareProduct.left;
                //
                DownloadManager.downloadCsarByNameFromVSPRepository(vspName, createVendorSoftwareProduct.right.get("vspId"));
-               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir();
+               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir();
                List<TypeHeatMetaDefinition> listTypeHeatMetaDefinition = CsarParserUtils.getListTypeHeatMetaDefinition(latestFilefromDir);
                //
                getExtendTest().log(Status.INFO, String.format("Searching for onboarded %s", vnfFile));
@@ -133,7 +133,7 @@ public class VfModule extends SetupCDTest {
                GeneralUIUtils.clickOnElementByTestId("breadcrumbs-button-1");
                ResourceGeneralPage.getLeftMenu().moveToToscaArtifactsScreen();
                GeneralUIUtils.clickOnElementByTestId(ToscaArtifactsScreenEnum.TOSCA_TEMPLATE.getValue());
-               latestFilefromDir = FileHandling.getLastModifiedFileFromDir();
+               latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir();
                
 //             verification
                Service service = AtomicOperationUtils.getServiceObjectByNameAndVersion(UserRoleEnum.DESIGNER, serviceMetadata.getName(), serviceMetadata.getVersion());
index 71c2612..677eb8c 100644 (file)
@@ -57,7 +57,7 @@ public class Vf_Tests_UI extends SetupCDTest{
        public void uploadHeatEnvVFLevel() throws Exception {
                
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
        }
        
index 291a1db..6fcede0 100644 (file)
@@ -80,7 +80,7 @@ public class extendNode_TemplatePropertiesWithDefaultValues extends SetupCDTest
                        ServiceUIUtils.createService(serviceMetadata, getUser());
                } else {
                        ResourceReqDetails resourceMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-                       ResourceUIUtils.createResource(resourceMetaData, getUser());
+                       ResourceUIUtils.createVF(resourceMetaData, getUser());
                }
                
                ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();            
@@ -163,7 +163,7 @@ public class extendNode_TemplatePropertiesWithDefaultValues extends SetupCDTest
                        ServiceUIUtils.createService(serviceMetadata, getUser());
                } else {
                        ResourceReqDetails resourceMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-                       ResourceUIUtils.createResource(resourceMetaData, getUser());
+                       ResourceUIUtils.createVF(resourceMetaData, getUser());
                }
                
                ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();            
index f63be6c..6903750 100644 (file)
@@ -1,17 +1,22 @@
 package org.openecomp.sdc.ci.tests.dataProvider;
 
+import java.io.File;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 
+import org.openecomp.sdc.ci.tests.execute.sanity.ToscaValidationTest;
+import org.openecomp.sdc.ci.tests.execute.setup.SetupCDTest;
 import org.openecomp.sdc.ci.tests.utilities.FileHandling;
 import org.openecomp.sdc.ci.tests.utilities.OnboardingUtils;
 import org.testng.annotations.DataProvider;
+import org.testng.annotations.Factory;
 
 public class OnbordingDataProviders {
 
        protected static String filepath = FileHandling.getVnfRepositoryPath();
        
+//     -----------------------dataProviders-----------------------------------------   
        @DataProvider(name = "randomVNF_List", parallel = false)
        private static final Object[][] randomVnfList() throws Exception {
                int randomElementNumber = 3; //how many VNFs to onboard randomly
@@ -30,6 +35,13 @@ public class OnbordingDataProviders {
                return provideData(fileNamesFromFolder, filepath);
        }
        
+//     -----------------------factories-----------------------------------------
+       @Factory(dataProvider = "VNF_List")
+       public Object[] OnbordingDataProviders(String filepath, String vnfFile){
+               return new Object[] { new ToscaValidationTest(filepath, vnfFile)};
+       }
+       
+       
        
 //     -----------------------methods-----------------------------------------
        public static Object[][] provideData(List<String> fileNamesFromFolder, String filepath) {
index fd6980f..f2e46b2 100644 (file)
@@ -36,7 +36,8 @@ public final class DataTestIdEnum {
                IMPORT_VF("importVFbutton"), 
                IMPORT_VFC_FILE("file-importVFCbutton"), 
                IMPORT_VF_FILE("file-importVFbutton"),
-               BUTTON_ADD_PRODUCT("createProductButton");
+               BUTTON_ADD_PRODUCT("createProductButton"),
+               BUTTON_ADD_PNF("createPNFButton"), ;
 
                private String value;
 
diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/VendorSoftwareProductObject.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/VendorSoftwareProductObject.java
new file mode 100644 (file)
index 0000000..fbdb88e
--- /dev/null
@@ -0,0 +1,102 @@
+package org.openecomp.sdc.ci.tests.datatypes;
+
+public class VendorSoftwareProductObject {
+
+       private String vendorName;
+       private String vspId;
+       private String category;
+       private String subCategory;
+       private String componentId;
+       private String description;
+       private String attContact;
+       private String vspName;
+       
+       public VendorSoftwareProductObject() {
+               super();
+               // TODO Auto-generated constructor stub
+       }
+
+       public VendorSoftwareProductObject(String vendorName, String vspId, String category, String subCategory, String componentId, String description, String attContact) {
+               super();
+               this.vendorName = vendorName;
+               this.vspId = vspId;
+               this.category = category;
+               this.subCategory = subCategory;
+               this.componentId = componentId;
+               this.description = description;
+               this.attContact = attContact;
+       }
+
+       
+       public String getVspName() {
+               return vspName;
+       }
+
+       public void setVspName(String vspName) {
+               this.vspName = vspName;
+       }
+
+       public String getVendorName() {
+               return vendorName;
+       }
+
+       public void setVendorName(String vendorName) {
+               this.vendorName = vendorName;
+       }
+
+       public String getVspId() {
+               return vspId;
+       }
+
+       public void setVspId(String vspId) {
+               this.vspId = vspId;
+       }
+
+       public String getCategory() {
+               return category;
+       }
+
+       public void setCategory(String category) {
+               this.category = category;
+       }
+
+       public String getSubCategory() {
+               return subCategory;
+       }
+
+       public void setSubCategory(String subCategory) {
+               this.subCategory = subCategory;
+       }
+
+       public String getComponentId() {
+               return componentId;
+       }
+
+       public void setComponentId(String componentId) {
+               this.componentId = componentId;
+       }
+
+       public String getDescription() {
+               return description;
+       }
+
+       public void setDescription(String description) {
+               this.description = description;
+       }
+
+       public String getAttContact() {
+               return attContact;
+       }
+
+       public void setAttContact(String attContact) {
+               this.attContact = attContact;
+       }
+
+       @Override
+       public String toString() {
+               return "VendorSoftwareProductObject [vendorName=" + vendorName + ", vspId=" + vspId + ", category=" + category + ", subCategory=" + subCategory + ", componentId=" + componentId + ", description=" + description + ", attContact="
+                               + attContact + "]";
+       }
+       
+       
+}
index f842136..0e09059 100644 (file)
@@ -229,7 +229,7 @@ public class AdminUserManagment extends SetupCDTest {
                reloginWithNewRole(UserRoleEnum.DESIGNER);
                ResourceReqDetails resourceMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
                ExtentTestActions.log(Status.INFO, "Creating a new VF named " + resourceMetaData.getName());
-               ResourceUIUtils.createResource(resourceMetaData, getUser());
+               ResourceUIUtils.createVF(resourceMetaData, getUser());
                ResourceGeneralPage.clickSubmitForTestingButton(resourceMetaData.getName());
                Resource resourceObjectByNameAndVersion = AtomicOperationUtils.getResourceObjectByNameAndVersion(UserRoleEnum.DESIGNER, resourceMetaData.getName(), "0.1");
                ExtentTestActions.log(Status.INFO, "Getting the VF to 'In Testing' state.");
index f0bc6f7..5533eb3 100644 (file)
@@ -197,7 +197,7 @@ public class CatalogLeftPanelTest extends  SetupCDTest{
        public void lastUpdatedResource() throws Exception{
                // create resource 
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.clickCheckinButton(vfMetaData.getName());
                CatalogUIUtilitis.clickTopMenuButton(TopMenuButtonsEnum.CATALOG);
@@ -210,7 +210,7 @@ public class CatalogLeftPanelTest extends  SetupCDTest{
        public void fromCatalogCheckout() throws Exception{
                // create resource 
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.clickCheckinButton(vfMetaData.getName());
                CatalogUIUtilitis.clickTopMenuButton(TopMenuButtonsEnum.CATALOG);
index d2c787e..5d1dfea 100644 (file)
@@ -192,7 +192,7 @@ public class Categories extends SetupCDTest {
                SubCategoryDefinition subCategoryDefinition = categoryDefinition.getSubcategories().get(0);
                subCategoryDefinition.setName(newSubCategory);
                
-               ResourceUIUtils.createResource(resourceMetaData, getUser());
+               ResourceUIUtils.createVF(resourceMetaData, getUser());
                
        
        }
index b8b7bd7..7dd3279 100644 (file)
@@ -307,7 +307,7 @@ public class CustomizationUUID extends SetupCDTest {
 
        public ResourceReqDetails createNewResourceWithArtifactSubmitForTesting() throws Exception {
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
 
                ResourceGeneralPage.getLeftMenu().moveToDeploymentArtifactScreen();
 
index c9dcf2a..f32709e 100644 (file)
@@ -24,17 +24,13 @@ import static org.testng.AssertJUnit.assertEquals;
 
 import java.awt.AWTException;
 import java.io.File;
-import java.io.FileOutputStream;
-import java.nio.charset.StandardCharsets;
 import java.sql.Timestamp;
-import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.UUID;
 
-import org.bouncycastle.util.encoders.Base64;
 import org.openecomp.sdc.be.model.ComponentInstance;
 import org.openecomp.sdc.be.model.Resource;
 import org.openecomp.sdc.be.model.Service;
@@ -42,21 +38,21 @@ import org.openecomp.sdc.be.model.User;
 import org.openecomp.sdc.ci.tests.dataProvider.OnbordingDataProviders;
 import org.openecomp.sdc.ci.tests.datatypes.AmdocsLicenseMembers;
 import org.openecomp.sdc.ci.tests.datatypes.ResourceReqDetails;
+import org.openecomp.sdc.ci.tests.datatypes.VendorSoftwareProductObject;
 import org.openecomp.sdc.ci.tests.datatypes.enums.LifeCycleStatesEnum;
 import org.openecomp.sdc.ci.tests.datatypes.enums.UserRoleEnum;
 import org.openecomp.sdc.ci.tests.datatypes.http.RestResponse;
 import org.openecomp.sdc.ci.tests.utilities.FileHandling;
+import org.openecomp.sdc.ci.tests.utilities.OnboardingUtillViaApis;
 import org.openecomp.sdc.ci.tests.utilities.OnboardingUtils;
 import org.openecomp.sdc.ci.tests.utils.general.AtomicOperationUtils;
 import org.openecomp.sdc.ci.tests.utils.general.ElementFactory;
-import org.openecomp.sdc.ci.tests.utils.rest.ResourceRestUtils;
 import org.openecomp.sdc.ci.tests.utils.rest.ResponseParser;
 import org.slf4j.LoggerFactory;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
 import com.clearspring.analytics.util.Pair;
-import com.google.gson.Gson;
 
 import ch.qos.logback.classic.Level;
 import ch.qos.logback.classic.LoggerContext;
@@ -66,11 +62,11 @@ public class OnboardViaApis{
        
 
        private static final String FULL_PATH = "C://tmp//CSARs//";
-       
+       protected static String filepath = FileHandling.getVnfRepositoryPath();
        
 //-------------------------------------------------------------------------------------------------------
        User sdncDesignerDetails1 = ElementFactory.getDefaultUser(UserRoleEnum.DESIGNER);
-       ResourceReqDetails resourceDetails;
+//     ResourceReqDetails resourceDetails;
        Timestamp timestamp = new Timestamp(System.currentTimeMillis());
         
         
@@ -80,7 +76,7 @@ public class OnboardViaApis{
                lc.getLogger("org.apache").setLevel(Level.OFF);
                lc.getLogger("org.*").setLevel(Level.OFF);
                lc.getLogger("org.openecomp.sdc.ci.tests.datatypes.http.HttpRequest").setLevel(Level.OFF);
-               resourceDetails = ElementFactory.getDefaultResource();
+//             resourceDetails = ElementFactory.getDefaultResource();
        }
                
        @Test(dataProviderClass = OnbordingDataProviders.class, dataProvider = "VNF_List")
@@ -95,7 +91,7 @@ public class OnboardViaApis{
                timestamp = new Timestamp(System.currentTimeMillis());
                System.err.println(timestamp + " Starting download service csar file: " + vnfFile);
                File file = new File(fullFileName);
-               downloadToscaCsarToDirectory(service, file);
+               OnboardingUtillViaApis.downloadToscaCsarToDirectory(service, file);
                timestamp = new Timestamp(System.currentTimeMillis());
                System.err.println(timestamp + " Finished download service csar file: " + vnfFile);
                System.out.println("end");
@@ -106,8 +102,6 @@ public class OnboardViaApis{
        @Test
        public void onboardingAndParser() throws Exception {
                Service service = null;
-               String filepath = getFilePath();
-//             Object[] fileNamesFromFolder = FileHandling.getZipFileNamesFromFolder(filepath);
                List<String> fileNamesFromFolder = FileHandling.getZipFileNamesFromFolder(filepath);
                String vnfFile = fileNamesFromFolder.get(7);
                System.err.println(timestamp + " Starting test with VNF: " + vnfFile);
@@ -119,49 +113,19 @@ public class OnboardViaApis{
 //        convertServiceDistributionStatusToObject.
        }
        
-       public static String getFilePath() {
-               String filepath = System.getProperty("filepath");
-               if (filepath == null && System.getProperty("os.name").contains("Windows")) {
-                       filepath = FileHandling.getResourcesFilesPath() +"VNFs";
-               }
-               
-               else if(filepath.isEmpty() && !System.getProperty("os.name").contains("Windows")){
-                               filepath = FileHandling.getBasePath() + File.separator + "Files" + File.separator +"VNFs";
-               }
-               return filepath;
-       }
        
-       public static void downloadToscaCsarToDirectory(Service service, File file) {
-               try {
-                       Either<String,RestResponse> serviceToscaArtifactPayload = AtomicOperationUtils.getServiceToscaArtifactPayload(service, "assettoscacsar");
-                       if(serviceToscaArtifactPayload.left().value() != null){
-                               Gson gson = new Gson();
-                               @SuppressWarnings("unchecked")
-                               Map<String, String> fromJson = gson.fromJson(serviceToscaArtifactPayload.left().value(), Map.class);
-                               String string = fromJson.get("base64Contents").toString();
-                               byte[] byteArray = Base64.decode(string.getBytes(StandardCharsets.UTF_8));
-                               File downloadedFile = new File(file.getAbsolutePath());
-                               FileOutputStream fos = new FileOutputStream(downloadedFile);
-                               fos.write(byteArray);
-                               fos.flush();
-                               fos.close();
-                       }
-                       
-               } catch (Exception e) {
-                       // TODO Auto-generated catch block
-                       e.printStackTrace();
-               }
-               
-       }
+
        
        public Service runOnboardViaApisOnly(String filepath, String vnfFile) throws Exception, AWTException {
                Timestamp timestamp = new Timestamp(System.currentTimeMillis());
                System.err.println(timestamp + " Starting onboard VNF: " + vnfFile);
-               Pair<String,Map<String,String>> onboardAndValidate = onboardAndValidateViaApi(filepath, vnfFile, sdncDesignerDetails1);
-               String vspName = onboardAndValidate.left;
+               Pair<String, VendorSoftwareProductObject> createVendorSoftwareProduct = OnboardingUtillViaApis.createVspViaApis(filepath, vnfFile, sdncDesignerDetails1);
+               String vspName = createVendorSoftwareProduct.left;
+               VendorSoftwareProductObject vendorSoftwareProductObject = createVendorSoftwareProduct.right;
                timestamp = new Timestamp(System.currentTimeMillis());
                System.err.println(timestamp + " Finished onboard VNF: " + vnfFile);
-               Resource resource = AtomicOperationUtils.getResourceObject(resourceDetails.getUniqueId());
+               ResourceReqDetails resourceReqDetails = OnboardingUtillViaApis.prepareOnboardedResourceDetailsBeforeCreate(vendorSoftwareProductObject, vspName);
+               Resource resource = OnboardingUtillViaApis.createResourceFromVSP(resourceReqDetails, vspName);
                
                AtomicOperationUtils.changeComponentState(resource, UserRoleEnum.DESIGNER, LifeCycleStatesEnum.CERTIFY, true);
                resource = AtomicOperationUtils.getResourceObject(resource.getUniqueId());
@@ -175,27 +139,9 @@ public class OnboardViaApis{
        
        
        
-       public Pair<String, Map<String, String>> onboardAndValidateViaApi(String filepath, String vnfFile, User user) throws Exception {
-       
-               AmdocsLicenseMembers amdocsLicenseMembers = createVendorLicense(user);
-               Pair<String, Map<String, String>> createVendorSoftwareProduct = createVendorSoftwareProduct(vnfFile, filepath, user, amdocsLicenseMembers);
-               String vspName = createVendorSoftwareProduct.left;
-               List<String> tags = new ArrayList<>();
-               tags.add(vspName);
-               Map<String, String> map = createVendorSoftwareProduct.right;
-               
-               resourceDetails.setCsarUUID(map.get("vspId"));
-               resourceDetails.setCsarVersion("1.0");
-               resourceDetails.setName(vspName);
-               resourceDetails.setTags(tags);
-               resourceDetails.setResourceType(map.get("componentType"));
-               resourceDetails.setVendorName(map.get("vendorName"));
-               resourceDetails.setVendorRelease("1.0");
-               resourceDetails.setResourceType("VF");
-               RestResponse createResource = ResourceRestUtils.createResource(resourceDetails, sdncDesignerDetails1);
-               
-               return createVendorSoftwareProduct;
-       }
+
+
+
        
        public static Pair<String, Map<String, String>> createVendorSoftwareProduct(String HeatFileName, String filepath, User user, AmdocsLicenseMembers amdocsLicenseMembers)
                        throws Exception {
diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/PNF.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/PNF.java
new file mode 100644 (file)
index 0000000..0bb315a
--- /dev/null
@@ -0,0 +1,296 @@
+package org.openecomp.sdc.ci.tests.execute.sanity;
+
+import java.util.List;
+
+import org.openecomp.sdc.be.dao.api.ActionStatus;
+import org.openecomp.sdc.be.datatypes.enums.ResourceTypeEnum;
+import org.openecomp.sdc.be.model.LifecycleStateEnum;
+import org.openecomp.sdc.ci.tests.datatypes.ArtifactInfo;
+import org.openecomp.sdc.ci.tests.datatypes.CanvasElement;
+import org.openecomp.sdc.ci.tests.datatypes.CanvasManager;
+import org.openecomp.sdc.ci.tests.datatypes.LifeCycleStateEnum;
+import org.openecomp.sdc.ci.tests.datatypes.ResourceReqDetails;
+import org.openecomp.sdc.ci.tests.datatypes.enums.ArtifactTypeEnum;
+import org.openecomp.sdc.ci.tests.datatypes.enums.NormativeTypesEnum;
+import org.openecomp.sdc.ci.tests.datatypes.enums.ResourceCategoryEnum;
+import org.openecomp.sdc.ci.tests.datatypes.enums.UserRoleEnum;
+import org.openecomp.sdc.ci.tests.execute.setup.SetupCDTest;
+import org.openecomp.sdc.ci.tests.pages.CompositionPage;
+import org.openecomp.sdc.ci.tests.pages.GeneralPageElements;
+import org.openecomp.sdc.ci.tests.pages.InformationalArtifactPage;
+import org.openecomp.sdc.ci.tests.pages.PropertiesPage;
+import org.openecomp.sdc.ci.tests.pages.ResourceGeneralPage;
+import org.openecomp.sdc.ci.tests.pages.TesterOperationPage;
+import org.openecomp.sdc.ci.tests.pages.ToscaArtifactsPage;
+import org.openecomp.sdc.ci.tests.utilities.ArtifactUIUtils;
+import org.openecomp.sdc.ci.tests.utilities.FileHandling;
+import org.openecomp.sdc.ci.tests.utilities.GeneralUIUtils;
+import org.openecomp.sdc.ci.tests.utilities.ResourceUIUtils;
+import org.openecomp.sdc.ci.tests.utils.general.ElementFactory;
+import org.openecomp.sdc.ci.tests.utils.rest.ResourceRestUtils;
+import org.openecomp.sdc.ci.tests.utils.validation.ErrorValidationUtils;
+import org.openecomp.sdc.ci.tests.verificator.VfVerificator;
+import org.openqa.selenium.By;
+import org.openqa.selenium.WebElement;
+import org.testng.AssertJUnit;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import com.aventstack.extentreports.Status;
+
+public class PNF extends SetupCDTest {
+       
+       private String filePath;
+       @BeforeClass
+       public void beforeClass(){
+               filePath = FileHandling.getFilePath("");
+       }
+       
+       @BeforeMethod
+       public void beforeTest(){
+               System.out.println("File repository is : " + filePath);
+               getExtendTest().log(Status.INFO, "File repository is : " + filePath);
+       }
+               
+       @Test
+       public void updatePNF() throws Exception {
+
+               ResourceReqDetails pnfMetaData = createPNFWithGenerateName();
+
+               // update Resource
+               ResourceReqDetails updatedResource = new ResourceReqDetails();
+               updatedResource.setName("ciUpdatedName");
+               updatedResource.setDescription("kuku");
+               updatedResource.setVendorName("updatedVendor");
+               updatedResource.setVendorRelease("updatedRelease");
+               updatedResource.setContactId("ab0001");
+               updatedResource.setCategories(pnfMetaData.getCategories());
+               updatedResource.setVersion("0.1");
+               updatedResource.setResourceType(ResourceTypeEnum.VF.getValue());
+               List<String> newTags = pnfMetaData.getTags();
+               newTags.remove(pnfMetaData.getName());
+               newTags.add(updatedResource.getName());
+               updatedResource.setTags(newTags);
+               ResourceUIUtils.updateResource(updatedResource, getUser());
+
+               VfVerificator.verifyVFMetadataInUI(updatedResource);
+               VfVerificator.verifyVFUpdated(updatedResource, getUser());
+       }
+       
+       @Test
+       public void addUpdateDeleteInformationalArtifactPNFTest() throws Exception {
+               ResourceReqDetails pnfMetaData = createPNFWithGenerateName();
+
+               ResourceGeneralPage.getLeftMenu().moveToInformationalArtifactScreen();
+               
+               ArtifactInfo informationalArtifact = new ArtifactInfo(filePath, "asc_heat 0 2.yaml", "kuku", "artifact1", "OTHER");
+               InformationalArtifactPage.clickAddNewArtifact();
+               ArtifactUIUtils.fillAndAddNewArtifactParameters(informationalArtifact);
+               
+               AssertJUnit.assertTrue("artifact table does not contain artifacts uploaded", InformationalArtifactPage.checkElementsCountInTable(1));
+               
+               String newDescription = "new description";
+               InformationalArtifactPage.clickEditArtifact(informationalArtifact.getArtifactLabel());
+               InformationalArtifactPage.artifactPopup().insertDescription(newDescription);
+               InformationalArtifactPage.artifactPopup().clickDoneButton();
+               String actualArtifactDescription = InformationalArtifactPage.getArtifactDescription(informationalArtifact.getArtifactLabel());
+               AssertJUnit.assertTrue("artifact description is not updated", newDescription.equals(actualArtifactDescription));
+               
+               InformationalArtifactPage.clickDeleteArtifact(informationalArtifact.getArtifactLabel());
+               InformationalArtifactPage.clickOK();
+               AssertJUnit.assertTrue("artifact "+ informationalArtifact.getArtifactLabel() + "is not deleted", InformationalArtifactPage.checkElementsCountInTable(0));
+       }
+       
+       @Test
+       public void addPropertiesToVfcInstanceInPNFTest() throws Exception {
+               
+               String fileName = "CP.yml";
+               ResourceReqDetails atomicResourceMetaData = ElementFactory.getDefaultResourceByTypeNormTypeAndCatregory(ResourceTypeEnum.CP, NormativeTypesEnum.ROOT, ResourceCategoryEnum.NETWORK_L2_3_ROUTERS, getUser());
+               
+               try{
+                       ResourceUIUtils.importVfc(atomicResourceMetaData, filePath, fileName, getUser());
+                       ResourceGeneralPage.clickCheckinButton(atomicResourceMetaData.getName());
+       
+                       ResourceReqDetails pnfMetaData = createPNFWithGenerateName();
+       
+                       ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
+                       CanvasManager vfCanvasManager = CanvasManager.getCanvasManager();
+                       CompositionPage.searchForElement(atomicResourceMetaData.getName());
+                       CanvasElement cpElement = vfCanvasManager.createElementOnCanvas(atomicResourceMetaData.getName());
+       
+                       vfCanvasManager.clickOnCanvaElement(cpElement);
+                       CompositionPage.showPropertiesAndAttributesTab();
+                       List<WebElement> properties = CompositionPage.getProperties();
+                       String propertyValue = "abc123";
+                       for (int i = 0; i < 2; i++) {
+                               WebElement findElement = properties.get(i).findElement(By.className("i-sdc-designer-sidebar-section-content-item-property-and-attribute-label"));
+                               findElement.click();
+                               PropertiesPage.getPropertyPopup().insertPropertyDefaultValue(propertyValue);
+                               PropertiesPage.getPropertyPopup().clickSave();                          
+                               
+                               findElement = properties.get(i).findElement(By.className("i-sdc-designer-sidebar-section-content-item-property-value"));
+                               AssertJUnit.assertTrue(findElement.getText().equals(propertyValue));
+                       }
+               }
+               finally{
+                       ResourceRestUtils.deleteResourceByNameAndVersion(atomicResourceMetaData.getName(), "0.1");
+               }
+       }
+       
+       @Test
+       public void changeInstanceVersionPNFTest() throws Exception{
+               
+               ResourceReqDetails atomicResourceMetaData = null;
+               ResourceReqDetails pnfMetaData = null;
+               CanvasManager vfCanvasManager;
+               CanvasElement cpElement = null;
+               String fileName = "CP.yml";
+               try{
+                       atomicResourceMetaData = ElementFactory.getDefaultResourceByTypeNormTypeAndCatregory(ResourceTypeEnum.CP, NormativeTypesEnum.ROOT, ResourceCategoryEnum.NETWORK_L2_3_ROUTERS, getUser());
+                       ResourceUIUtils.importVfc(atomicResourceMetaData, filePath, fileName, getUser());
+                       ResourceGeneralPage.clickSubmitForTestingButton(atomicResourceMetaData.getName());
+                       
+                       pnfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.PNF, getUser());
+                       ResourceUIUtils.createPNF(pnfMetaData, getUser());
+                       ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
+                       vfCanvasManager = CanvasManager.getCanvasManager();
+                       CompositionPage.searchForElement(atomicResourceMetaData.getName());
+                       cpElement = vfCanvasManager.createElementOnCanvas(atomicResourceMetaData.getName());
+                       
+               
+                       CompositionPage.clickSubmitForTestingButton(pnfMetaData.getName());
+                       assert(false);
+               }
+               catch(Exception e){ 
+                       String errorMessage = GeneralUIUtils.getWebElementByClassName("w-sdc-modal-caption").getText();
+                       String checkUIResponseOnError = ErrorValidationUtils.checkUIResponseOnError(ActionStatus.VALIDATED_RESOURCE_NOT_FOUND.name());
+                       AssertJUnit.assertTrue(errorMessage.contains(checkUIResponseOnError));
+                       
+                       
+                       reloginWithNewRole(UserRoleEnum.TESTER);
+                       GeneralUIUtils.findComponentAndClick(atomicResourceMetaData.getName());
+                       TesterOperationPage.certifyComponent(atomicResourceMetaData.getName());
+                       
+                       reloginWithNewRole(UserRoleEnum.DESIGNER);
+                       GeneralUIUtils.findComponentAndClick(pnfMetaData.getName());
+                       ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
+                       vfCanvasManager = CanvasManager.getCanvasManager();
+                       CompositionPage.changeComponentVersion(vfCanvasManager, cpElement, "1.0");
+                       
+                       //verfication
+                       VfVerificator.verifyInstanceVersion(pnfMetaData, getUser(), atomicResourceMetaData.getName(), "1.0");
+               }
+                       
+               finally{
+                       ResourceRestUtils.deleteResourceByNameAndVersion(atomicResourceMetaData.getName(), "1.0");
+               }
+               
+       }
+       
+       @Test
+       public void verifyToscaArtifactsExistPNFTest() throws Exception{
+               ResourceReqDetails pnfMetaData = createPNFWithGenerateName();
+               
+               final int numOfToscaArtifacts = 2;
+               ResourceGeneralPage.getLeftMenu().moveToToscaArtifactsScreen();
+               AssertJUnit.assertTrue(ToscaArtifactsPage.checkElementsCountInTable(numOfToscaArtifacts));
+               
+               for(int i = 0; i < numOfToscaArtifacts; i++){
+                       String typeFromScreen = ToscaArtifactsPage.getArtifactType(i);
+                       AssertJUnit.assertTrue(typeFromScreen.equals(ArtifactTypeEnum.TOSCA_CSAR.getType()) || typeFromScreen.equals(ArtifactTypeEnum.TOSCA_TEMPLATE.getType()));
+               }
+               
+               ToscaArtifactsPage.clickSubmitForTestingButton(pnfMetaData.getName());
+               VfVerificator.verifyToscaArtifactsInfo(pnfMetaData, getUser());
+       }       
+       
+       @Test
+       public void pnfCertificationTest() throws Exception{
+               ResourceReqDetails pnfMetaData = createPNFWithGenerateName();
+               
+               String vfName = pnfMetaData.getName();
+               
+               ResourceGeneralPage.clickCheckinButton(vfName);
+               GeneralUIUtils.findComponentAndClick(vfName);
+               ResourceGeneralPage.clickSubmitForTestingButton(vfName);
+               
+               reloginWithNewRole(UserRoleEnum.TESTER);
+               GeneralUIUtils.findComponentAndClick(vfName);
+               TesterOperationPage.certifyComponent(vfName);
+               
+               pnfMetaData.setVersion("1.0");
+               VfVerificator.verifyVFLifecycle(pnfMetaData, getUser(), LifecycleStateEnum.CERTIFIED);
+               
+               reloginWithNewRole(UserRoleEnum.DESIGNER);
+               GeneralUIUtils.findComponentAndClick(vfName);
+               VfVerificator.verifyVfLifecycleInUI(LifeCycleStateEnum.CERTIFIED);
+       }
+       
+       @Test
+       public void deletePNFCheckedoutTest() throws Exception{
+               ResourceReqDetails pnfMetaData = createPNFWithGenerateName();
+               
+               GeneralPageElements.clickTrashButtonAndConfirm();
+               
+               pnfMetaData.setVersion("0.1");
+               VfVerificator.verifyVfDeleted(pnfMetaData, getUser());
+       }
+       
+       @Test
+       public void revertPNFMetadataTest() throws Exception{
+               ResourceReqDetails pnfMetaData = createPNFWithGenerateName();
+               
+               ResourceReqDetails pvfRevertDetails = new ResourceReqDetails();
+               pvfRevertDetails.setName("ciUpdatedName");
+               pvfRevertDetails.setDescription("kuku");
+               pvfRevertDetails.setCategories(pnfMetaData.getCategories());
+               pvfRevertDetails.setVendorName("updatedVendor");
+               pvfRevertDetails.setVendorRelease("updatedRelease");
+               ResourceUIUtils.fillResourceGeneralInformationPage(pvfRevertDetails, getUser(), false);
+               
+               GeneralPageElements.clickRevertButton();
+               
+               VfVerificator.verifyVFMetadataInUI(pnfMetaData);                
+       }
+       
+       @Test
+       public void checkoutVfTest() throws Exception{
+               ResourceReqDetails pnfMetaData = createPNFWithGenerateName();
+               
+               ResourceGeneralPage.clickCheckinButton(pnfMetaData.getName());
+               GeneralUIUtils.findComponentAndClick(pnfMetaData.getName());
+               GeneralPageElements.clickCheckoutButton();
+               
+               pnfMetaData.setVersion("0.2");
+               VfVerificator.verifyVFLifecycle(pnfMetaData, getUser(), LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+               VfVerificator.verifyVfLifecycleInUI(LifeCycleStateEnum.CHECKOUT);
+               
+               ResourceGeneralPage.clickSubmitForTestingButton(pnfMetaData.getName());
+               
+               reloginWithNewRole(UserRoleEnum.TESTER);
+               GeneralUIUtils.findComponentAndClick(pnfMetaData.getName());
+               TesterOperationPage.certifyComponent(pnfMetaData.getName());
+               
+               reloginWithNewRole(UserRoleEnum.DESIGNER);
+               GeneralUIUtils.findComponentAndClick(pnfMetaData.getName());
+               ResourceGeneralPage.clickCheckoutButton();
+               
+               pnfMetaData.setVersion("1.1");
+               pnfMetaData.setUniqueId(null);
+               VfVerificator.verifyVFLifecycle(pnfMetaData, getUser(), LifecycleStateEnum.NOT_CERTIFIED_CHECKOUT);
+               VfVerificator.verifyVfLifecycleInUI(LifeCycleStateEnum.CHECKOUT);
+       }
+       
+       public ResourceReqDetails createPNFWithGenerateName() throws Exception {
+               ResourceReqDetails pnfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.PNF, getUser());
+               ResourceUIUtils.createPNF(pnfMetaData, getUser());
+               return pnfMetaData;
+       }
+       
+       @Override
+       protected UserRoleEnum getRole() {
+               return UserRoleEnum.DESIGNER;
+       }
+
+}
index 339f929..54656d8 100644 (file)
@@ -188,7 +188,7 @@ public class Service extends SetupCDTest {
        public void submitServiceForTestingWithNonCertifiedAsset() throws Exception{
 
                ResourceReqDetails atomicResourceMetaData = ElementFactory.getDefaultResourceByTypeNormTypeAndCatregory(ResourceTypeEnum.VF, NormativeTypesEnum.ROOT, ResourceCategoryEnum.NETWORK_L2_3_ROUTERS, getUser());
-               ResourceUIUtils.createResource(atomicResourceMetaData, getUser());
+               ResourceUIUtils.createVF(atomicResourceMetaData, getUser());
                ResourceGeneralPage.clickSubmitForTestingButton(atomicResourceMetaData.getName());
                
                ServiceReqDetails serviceMetadata = ElementFactory.getDefaultService();
@@ -496,7 +496,7 @@ public class Service extends SetupCDTest {
 
 
        public CanvasElement createServiceWithRiArtifact(ResourceReqDetails atomicResourceMetaData, ServiceReqDetails serviceMetadata, ArtifactInfo artifact) throws Exception, AWTException {
-               ResourceUIUtils.createResource(atomicResourceMetaData, getUser());
+               ResourceUIUtils.createVF(atomicResourceMetaData, getUser());
                ResourceGeneralPage.clickSubmitForTestingButton(atomicResourceMetaData.getName());
                
                ServiceUIUtils.createService(serviceMetadata, getUser());
diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/ToscaValidation.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/ToscaValidation.java
deleted file mode 100644 (file)
index 293547f..0000000
+++ /dev/null
@@ -1,77 +0,0 @@
-/*-
- * ============LICENSE_START=======================================================
- * SDC
- * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
- * ================================================================================
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * 
- *      http://www.apache.org/licenses/LICENSE-2.0
- * 
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- * ============LICENSE_END=========================================================
- */
-
-package org.openecomp.sdc.ci.tests.execute.sanity;
-
-import java.util.HashMap;
-import java.util.Map;
-
-import org.testng.annotations.BeforeClass;
-import org.testng.annotations.Test;
-
-public class ToscaValidation{
-       
-       
-       @BeforeClass
-       public void precondition(){
-               
-               Map<String, Map<String, Object>> expected = new HashMap<String, Map<String, Object>>();
-               
-               //import amdocs VNF and download csar
-               
-               //parse downloaded csar and add it to expected object
-               
-               //create VF base on VNF imported from previous step - declare all inputs
-               
-               //certify VF  and download csar
-               
-               //parse downloaded csar and add it to expected object
-               
-               //create service add VF  - declare all inputs
-               
-               //certify service and download csar
-               
-               //parse downloaded csar and add it to expected object
-               
-                               
-       }
-       
-       @Test
-       public void validateMetaData(){
-               
-               
-               
-               
-       }
-       
-       @Test
-       public void validatePropertiesInputs(){
-               
-               
-               
-       }
-       
-       
-       
-       
-
-       
-
-}
diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/ToscaValidationTest.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/ToscaValidationTest.java
new file mode 100644 (file)
index 0000000..d70f5e8
--- /dev/null
@@ -0,0 +1,334 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.sdc.ci.tests.execute.sanity;
+
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.junit.Rule;
+import org.junit.rules.TemporaryFolder;
+import org.openecomp.sdc.be.datatypes.enums.ComponentTypeEnum;
+import org.openecomp.sdc.be.model.Component;
+import org.openecomp.sdc.be.model.ComponentInstance;
+import org.openecomp.sdc.be.model.Resource;
+import org.openecomp.sdc.be.model.Service;
+import org.openecomp.sdc.be.model.User;
+import org.openecomp.sdc.ci.tests.dataProvider.OnbordingDataProviders;
+import org.openecomp.sdc.ci.tests.datatypes.ResourceReqDetails;
+import org.openecomp.sdc.ci.tests.datatypes.ServiceReqDetails;
+import org.openecomp.sdc.ci.tests.datatypes.VendorSoftwareProductObject;
+import org.openecomp.sdc.ci.tests.datatypes.enums.LifeCycleStatesEnum;
+import org.openecomp.sdc.ci.tests.datatypes.enums.UserRoleEnum;
+import org.openecomp.sdc.ci.tests.datatypes.http.RestResponse;
+import org.openecomp.sdc.ci.tests.execute.setup.SetupCDTest;
+import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaDefinition;
+import org.openecomp.sdc.ci.tests.tosca.model.ToscaMetadataFieldsPresentationEnum;
+import org.openecomp.sdc.ci.tests.utilities.DownloadManager;
+import org.openecomp.sdc.ci.tests.utilities.FileHandling;
+import org.openecomp.sdc.ci.tests.utilities.OnboardingUtillViaApis;
+import org.openecomp.sdc.ci.tests.utils.ToscaParserUtils;
+import org.openecomp.sdc.ci.tests.utils.general.AtomicOperationUtils;
+import org.openecomp.sdc.ci.tests.utils.general.ElementFactory;
+import org.openecomp.sdc.ci.tests.verificator.ToscaValidation;
+import org.openecomp.sdc.tosca.parser.api.ISdcCsarHelper;
+import org.openecomp.sdc.tosca.parser.exceptions.SdcToscaParserException;
+import org.openecomp.sdc.tosca.parser.impl.SdcToscaParserFactory;
+import org.openecomp.sdc.toscaparser.api.NodeTemplate;
+import org.openecomp.sdc.toscaparser.api.elements.Metadata;
+import org.testng.Assert;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import com.aventstack.extentreports.Status;
+import com.clearspring.analytics.util.Pair;
+
+import fj.data.Either;
+
+
+public class ToscaValidationTest extends SetupCDTest{
+       
+       ToscaDefinition toscaMainAmdocsDefinition, toscaMainVfDefinition, toscaMainServiceDefinition;
+       protected String vnfFile;
+       protected String filepath;
+       protected File filesFolder;
+       protected SdcToscaParserFactory factory = SdcToscaParserFactory.getInstance();
+       protected ISdcCsarHelper fdntCsarHelper;
+       protected ResourceReqDetails resourceReqDetails;
+       protected Resource resource;
+       protected ServiceReqDetails serviceReqDetails;
+       protected Service service;
+       protected ComponentInstance componentInstanceDefinition;
+       User user = ElementFactory.getDefaultUser(UserRoleEnum.DESIGNER);
+       File importToscaFilesFolder = new File("C:/Git_work/sdc/catalog-be/src/main/resources/import/tosca/");
+
+       File dataTypesLocation = new File(importToscaFilesFolder.getPath() + "/data-types/dataTypes.yml");
+
+       File genericVfFileLocation = new File(importToscaFilesFolder.getPath() + "/heat-types/Generic_VF/Generic_VF.yml");
+       File genericVfcFileLocation = new File (importToscaFilesFolder.getPath() + "/heat-types/Generic_VFC/Generic_VFC.yml");
+       File genericPnfFileLocation = new File (importToscaFilesFolder.getPath() + "/heat-types/Generic_PNF/Generic_PNF.yml");
+       File genericServiceFileLocation = new File (importToscaFilesFolder.getPath() + "/heat-types/Generic_Service/Generic_Service.yml");
+
+//     Map<String, DataTypeDefinition> parseDataTypesYaml = FileHandling.parseDataTypesYaml(dataTypesLocation.getAbsoluteFile().toString());
+       
+//     toscaMainAmdocsDefinition = ToscaParserUtils.parseToscaMainYamlToJavaObjectByCsarLocation(new File(filesFolder.getPath() + amdocsCsarFileName));
+//     toscaMainVfDefinition = ToscaParserUtils.parseToscaMainYamlToJavaObjectByCsarLocation(new File(filesFolder.getPath() + VfCsarFileName));
+//     toscaMainServiceDefinition = ToscaParserUtils.parseToscaMainYamlToJavaObjectByCsarLocation(new File(filesFolder.getPath() + serviceCsarFileName));
+//     ToscaTopologyTemplateDefinition topologyTemplate = toscaMainAmdocsDefinition.getTopology_template();
+//     ToscaDefinition objectHelper = ToscaParserUtils.parseToscaYamlToJavaObject(genericVfFileLocation);
+       
+
+       public ToscaValidationTest(String filepath, String vnfFile) {
+               this.filepath = filepath;
+               this.vnfFile = vnfFile;
+       }
+
+
+       @BeforeClass
+       
+       public void precondition() throws Exception{
+//--------------------------GENERAL--------------------------------
+               setLog(vnfFile);
+               filesFolder = new File(SetupCDTest.getWindowTest().getDownloadDirectory());
+//--------------------------AMDOCS--------------------------------             
+               Pair<String, VendorSoftwareProductObject> createVendorSoftwareProduct = OnboardingUtillViaApis.createVspViaApis(filepath, vnfFile, user);
+               VendorSoftwareProductObject vendorSoftwareProductObject = createVendorSoftwareProduct.right;
+               vendorSoftwareProductObject.setVspName(createVendorSoftwareProduct.left);
+               DownloadManager.downloadCsarByNameFromVSPRepository(vendorSoftwareProductObject.getVspName(), vendorSoftwareProductObject.getVspId(), false);
+               File amdocsCsarFileName = FileHandling.getLastModifiedFileNameFromDir(filesFolder.getAbsolutePath());
+               toscaMainAmdocsDefinition = ToscaParserUtils.parseToscaMainYamlToJavaObjectByCsarLocation(amdocsCsarFileName);
+               
+//TODO--------------------------AMDOCS DOWNLOAD VIA APIS--------------------------------
+
+//--------------------------VF--------------------------------
+//             create VF base on VNF imported from previous step - have, resourceReqDetails object include part of resource metadata
+               resourceReqDetails = OnboardingUtillViaApis.prepareOnboardedResourceDetailsBeforeCreate(vendorSoftwareProductObject, vendorSoftwareProductObject.getVspName());
+               resource = OnboardingUtillViaApis.createResourceFromVSP(resourceReqDetails, vendorSoftwareProductObject.getVspName());
+               resource = (Resource) AtomicOperationUtils.changeComponentState(resource, UserRoleEnum.DESIGNER, LifeCycleStatesEnum.CERTIFY, true).getLeft();
+               File VfCsarFileName = new File(File.separator + "VfCsar_" + ElementFactory.generateUUIDforSufix() + ".csar");
+               OnboardingUtillViaApis.downloadToscaCsarToDirectory(resource, new File(filesFolder.getPath() + VfCsarFileName));
+               toscaMainVfDefinition = ToscaParserUtils.parseToscaMainYamlToJavaObjectByCsarLocation(new File(filesFolder.getPath() + VfCsarFileName));
+
+//--------------------------SERVICE--------------------------------    
+               serviceReqDetails = OnboardingUtillViaApis.prepareServiceDetailsBeforeCreate(user);
+               service = AtomicOperationUtils.createCustomService(serviceReqDetails, UserRoleEnum.DESIGNER, true).left().value();
+               
+               Either<ComponentInstance, RestResponse> addComponentInstanceToComponentContainer = AtomicOperationUtils.addComponentInstanceToComponentContainer(resource, service, UserRoleEnum.DESIGNER, true);
+               componentInstanceDefinition = addComponentInstanceToComponentContainer.left().value();
+//             TODO declare all VFi inputs + add all generic
+               service = (Service) AtomicOperationUtils.changeComponentState(service, UserRoleEnum.DESIGNER, LifeCycleStatesEnum.CERTIFY, true).getLeft();
+               File ServiceCsarFileName = new File(File.separator + "ServiceCsar_" + ElementFactory.generateUUIDforSufix() + ".csar");
+               OnboardingUtillViaApis.downloadToscaCsarToDirectory(service, new File(filesFolder.getPath() + ServiceCsarFileName));
+               toscaMainServiceDefinition = ToscaParserUtils.parseToscaMainYamlToJavaObjectByCsarLocation(new File(filesFolder.getPath() + ServiceCsarFileName));
+               
+//--------------------------verification against Pavel Parser--------------------------------
+               
+               SetupCDTest.getExtendTest().log(Status.INFO, "Tosca parser is going to convert service csar file to ISdcCsarHelper object...");
+               fdntCsarHelper = factory.getSdcCsarHelper(filesFolder.getPath() + ServiceCsarFileName);
+
+       }
+       
+
+       //--------------------------Metadata verification--------------------------------       
+//--------------------------Resource--------------------------------   
+       
+       @Test()
+       public void validateVfMetadata() throws Exception{
+               setLog(vnfFile);
+               SetupCDTest.getExtendTest().log(Status.INFO, "validateVfMetadata " + vnfFile);
+               //add resource metadata to expected object
+               toscaMainAmdocsDefinition = addAndGenerateResourceMetadataToExpectedObject(toscaMainAmdocsDefinition, resourceReqDetails, resource);
+               Either<Boolean,Map<String,Object>> resourceToscaMetadataValidator = ToscaValidation.resourceToscaMetadataValidator(toscaMainAmdocsDefinition, toscaMainVfDefinition);
+               Assert.assertFalse(!resourceToscaMetadataValidator.left().value().equals(true), "Found error/s on Vf metadata verification");
+               
+       }
+       
+       @Test()
+       public void validateResourceNodeTemplateMetadata() throws Exception{
+               setLog(vnfFile);
+               SetupCDTest.getExtendTest().log(Status.INFO, "validateResourceNodeTemplateMetadata " + vnfFile);
+               Map<String, Map<String, String>> generateReosurceNodeTemplateMetadataToExpectedObject = generateResourceNodeTemplateMetadataToExpectedObject(resource);
+               Boolean resourceToscaMetadataValidator = ToscaValidation.resourceToscaNodeTemplateMetadataValidator(generateReosurceNodeTemplateMetadataToExpectedObject, toscaMainVfDefinition);
+               Assert.assertFalse(!resourceToscaMetadataValidator.equals(true), "Found error/s on Resource Node Template metadata verification");
+       }
+
+//--------------------------Service--------------------------------    
+       @Test()
+       public void validateServiceMetadata() throws Exception{
+               setLog(vnfFile);
+               SetupCDTest.getExtendTest().log(Status.INFO, "validateServiceMetadata " + vnfFile);
+               Map<String, String> generateServiceMetadataToExpectedObject = generateServiceMetadataToExpectedObject(serviceReqDetails, service);
+               Either<Boolean,Map<String, Object>> serviceToscaMetadataValidator = ToscaValidation.serviceToscaMetadataValidator(generateServiceMetadataToExpectedObject, toscaMainServiceDefinition);
+               Assert.assertFalse(!serviceToscaMetadataValidator.left().value().equals(true), "Found error/s on Service metadata verification");
+       }
+
+
+       @Test()
+       public void validateServiceNodeTemplateMetadata() throws Exception{
+               setLog(vnfFile);
+               SetupCDTest.getExtendTest().log(Status.INFO, "validateServiceNodeTemplateMetadata " + vnfFile);
+               Map<String, String> generateServiceNodeTemplateMetadataToExpectedObject = generateServiceNodeTemplateMetadataToExpectedObject(resourceReqDetails, resource, componentInstanceDefinition);
+               Either<Boolean,Map<String, Object>> serviceToscaMetadataValidator = ToscaValidation.componentToscaNodeTemplateMetadataValidator(generateServiceNodeTemplateMetadataToExpectedObject, toscaMainServiceDefinition, componentInstanceDefinition.getName(), ComponentTypeEnum.SERVICE);
+               Assert.assertFalse(!serviceToscaMetadataValidator.left().value().equals(true), "Found error/s on Service Node Template metadata verification");
+       }
+
+//--------------------------Service verification against Pavel Parser--------------------------------
+       @Test()
+       public void validateServiceMetadataUsingParser() throws Exception{
+               setLog(vnfFile);
+               SetupCDTest.getExtendTest().log(Status.INFO, "validateServiceMetadataUsingParser " + vnfFile);
+               Map<String, String> generateServiceMetadataToExpectedObject = generateServiceMetadataToExpectedObject(serviceReqDetails, service);
+               Metadata serviceMetadata = fdntCsarHelper.getServiceMetadata();
+               Either<Boolean,Map<String, Object>> serviceToscaMetadataValidatorAgainstParser = ToscaValidation.serviceToscaMetadataValidatorAgainstParser(generateServiceMetadataToExpectedObject, serviceMetadata);
+               Assert.assertFalse(!serviceToscaMetadataValidatorAgainstParser.left().value().equals(true), "Found error/s on Service metadata verification");
+       }
+
+       @Test()
+       public void validateServiceNodeTemplateMetadataUsingParser() throws Exception{
+               setLog(vnfFile);
+               SetupCDTest.getExtendTest().log(Status.INFO, "validateServiceMetadataUsingParser " + vnfFile);
+               Map<String, String> generateServiceNodeTemplateMetadataToExpectedObject = generateServiceNodeTemplateMetadataToExpectedObject(resourceReqDetails, resource, componentInstanceDefinition);
+               List<NodeTemplate> serviceNodeTemplates = fdntCsarHelper.getServiceNodeTemplates();
+               Metadata serviceNodeTemplateMetadata = serviceNodeTemplates.get(0).getMetaData();
+               Either<Boolean,Map<String, Object>> serviceNodeTemplateToscaMetadataValidatorAgainstParser = ToscaValidation.serviceToscaMetadataValidatorAgainstParser(generateServiceNodeTemplateMetadataToExpectedObject, serviceNodeTemplateMetadata);
+               Assert.assertFalse(!serviceNodeTemplateToscaMetadataValidatorAgainstParser.left().value().equals(true), "Found error/s on Service metadata verification");
+       }
+
+       
+       
+       //--------------------------Input verification--------------------------------
+       
+       //--------------------------Resource--------------------------------
+       
+       
+       //--------------------------Service--------------------------------
+       
+       
+       //--------------------------Service verification against Pavel Parser--------------------------------
+       
+       
+       
+       
+       
+       
+       
+       
+       
+       @Override
+    protected UserRoleEnum getRole() {
+               return UserRoleEnum.DESIGNER;
+    }
+
+
+
+
+       public static ToscaDefinition addAndGenerateResourceMetadataToExpectedObject(ToscaDefinition toscaDefinition, ResourceReqDetails resourceReqDetails, Component component) {
+               
+               Map<String, String> metadata = convertResourceMetadataToMap(resourceReqDetails, component);
+               toscaDefinition.setMetadata(metadata);
+               return toscaDefinition;
+       }
+
+
+       public static Map<String, String> convertResourceMetadataToMap(ResourceReqDetails resourceReqDetails, Component component) {
+               Map<String, String> metadata = new HashMap<>();
+               
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.CATEGORY.value, resourceReqDetails.getCategories().get(0).getName());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.DESCRIPTION.value, resourceReqDetails.getDescription());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.INVARIANT_UUID.value, component.getInvariantUUID());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.TYPE.value, "VF");
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.UUID.value, component.getUUID());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.NAME.value, component.getName());
+               
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.RESOURCE_VENDOR_NAME.value, resourceReqDetails.getVendorName());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.RESOURCE_VENDOR_MODEL_NUMBER.value, resourceReqDetails.getResourceVendorModelNumber());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.RESOURCE_VENDOR_RELEASE.value, resourceReqDetails.getVendorRelease());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.SUBCATEGORY.value, resourceReqDetails.getCategories().get(0).getSubcategories().get(0).getName());
+               return metadata;
+       }
+       
+       public static Map<String, String> convertResourceNodeTemplateMetadataToMap(ComponentInstance componentInstance) throws Exception{
+               
+               Resource resource = AtomicOperationUtils.getResourceObject(componentInstance.getComponentUid());
+               Map<String, String> metadata = new HashMap<>();
+               
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.CATEGORY.value, resource.getCategories().get(0).getName());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.DESCRIPTION.value, resource.getDescription());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.INVARIANT_UUID.value, resource.getInvariantUUID());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.TYPE.value, resource.getResourceType().toString());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.UUID.value, resource.getUUID());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.NAME.value, resource.getName());
+               
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.RESOURCE_VENDOR_NAME.value, resource.getVendorName());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.RESOURCE_VENDOR_MODEL_NUMBER.value, resource.getResourceVendorModelNumber());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.RESOURCE_VENDOR_RELEASE.value, resource.getVendorRelease());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.SUBCATEGORY.value, resource.getCategories().get(0).getSubcategories().get(0).getName());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.CUSTOMIZATION_UUID.value, componentInstance.getCustomizationUUID());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.VERSION.value, componentInstance.getComponentVersion());
+               
+               return metadata;
+               
+       }
+       public static Map<String, String> generateServiceNodeTemplateMetadataToExpectedObject(ResourceReqDetails resourceReqDetails, Component component, ComponentInstance componentInstanceDefinition) {
+               
+               Map<String, String> metadata = convertResourceMetadataToMap(resourceReqDetails, component);
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.CUSTOMIZATION_UUID.value, componentInstanceDefinition.getCustomizationUUID());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.VERSION.value, componentInstanceDefinition.getComponentVersion());
+               
+               return metadata;
+       }
+       
+       public static Map<String, Map<String, String>> generateResourceNodeTemplateMetadataToExpectedObject(Component component) throws Exception {
+               
+               Map<String, Map<String, String>> resourcesNodeTemplateMetadataMap = new HashMap<>();
+               if(component.getComponentInstances() != null && component.getComponentInstances().size() != 0){
+                       for (ComponentInstance componentInstance:component.getComponentInstances()){
+                               Map<String, String> metadata = convertResourceNodeTemplateMetadataToMap(componentInstance);
+                               resourcesNodeTemplateMetadataMap.put(componentInstance.getName(), metadata);
+                       }
+               }
+               return resourcesNodeTemplateMetadataMap;
+       }
+       
+       public static Map<String, String> generateServiceMetadataToExpectedObject(ServiceReqDetails serviceReqDetails, Component component) {
+               
+               Map<String, String> metadata = new HashMap<>();
+               
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.CATEGORY.value, serviceReqDetails.getCategories().get(0).getName());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.DESCRIPTION.value, serviceReqDetails.getDescription());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.INVARIANT_UUID.value, component.getInvariantUUID());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.TYPE.value, "Service");
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.UUID.value, component.getUUID());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.NAME.value, component.getName());
+               
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.SERVICE_TYPE.value, serviceReqDetails.getServiceType());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.SERVICE_ROLE.value, serviceReqDetails.getServiceRole());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.NAMING_POLICY.value, serviceReqDetails.getNamingPolicy());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.ECOMP_GENERATED_NAMING.value, serviceReqDetails.getEcompGeneratedNaming().toString());
+               metadata.put(ToscaMetadataFieldsPresentationEnum.ToscaMetadataFieldsEnum.SERVICE_ECOMP_NAMING.value, serviceReqDetails.getEcompGeneratedNaming().toString());//equals to ECOMP_GENERATED_NAMING
+               
+               return metadata;
+       }
+       
+
+       
+}
index 8763d67..730cc1c 100644 (file)
@@ -107,7 +107,7 @@ public class Vf extends SetupCDTest {
 
                // create Resource
                ResourceReqDetails resourceMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(resourceMetaData, getUser());
+               ResourceUIUtils.createVF(resourceMetaData, getUser());
 
                // update Resource
                ResourceReqDetails updatedResource = new ResourceReqDetails();
@@ -144,7 +144,7 @@ public class Vf extends SetupCDTest {
        
                        reloginWithNewRole(UserRoleEnum.DESIGNER);
                        ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-                       ResourceUIUtils.createResource(vfMetaData, getUser());
+                       ResourceUIUtils.createVF(vfMetaData, getUser());
        
                        DeploymentArtifactPage.getLeftMenu().moveToCompositionScreen();
                        CanvasManager canvasManager = CanvasManager.getCanvasManager();
@@ -168,7 +168,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void addUpdateDeleteDeploymentArtifactToVfTest() throws Exception {
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
 
                ResourceGeneralPage.getLeftMenu().moveToDeploymentArtifactScreen();
 
@@ -199,7 +199,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void addUpdateDeleteInformationalArtifact() throws Exception {
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
 
                ResourceGeneralPage.getLeftMenu().moveToInformationalArtifactScreen();
                
@@ -233,7 +233,7 @@ public class Vf extends SetupCDTest {
                        ResourceGeneralPage.clickCheckinButton(atomicResourceMetaData.getName());
        
                        ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-                       ResourceUIUtils.createResource(vfMetaData, getUser());
+                       ResourceUIUtils.createVF(vfMetaData, getUser());
        
                        ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
                        CanvasManager vfCanvasManager = CanvasManager.getCanvasManager();
@@ -274,7 +274,7 @@ public class Vf extends SetupCDTest {
                        ResourceGeneralPage.clickSubmitForTestingButton(atomicResourceMetaData.getName());
                        
                        vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-                       ResourceUIUtils.createResource(vfMetaData, getUser());
+                       ResourceUIUtils.createVF(vfMetaData, getUser());
                        ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
                        vfCanvasManager = CanvasManager.getCanvasManager();
                        CompositionPage.searchForElement(atomicResourceMetaData.getName());
@@ -314,7 +314,7 @@ public class Vf extends SetupCDTest {
        @Test(enabled = false)
        public void addUpdateDeleteSimplePropertiesToVfTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                        
                ResourceGeneralPage.getLeftMenu().moveToPropertiesScreen();
                List<PropertyTypeEnum> propertyList = Arrays.asList(PropertyTypeEnum.STRING, PropertyTypeEnum.INTEGER);
@@ -340,7 +340,7 @@ public class Vf extends SetupCDTest {
        @Test(enabled = false)
        public void vfcInstancesInputScreenTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
                CanvasManager vfCanvasManager = CanvasManager.getCanvasManager();
@@ -380,7 +380,7 @@ public class Vf extends SetupCDTest {
        public void addAllInformationalArtifactPlaceholdersInVfTest() throws Exception{
                
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByTypeNormTypeAndCatregory(ResourceTypeEnum.VF, NormativeTypesEnum.ROOT, ResourceCategoryEnum.NETWORK_L2_3_ROUTERS, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
 
                ResourceGeneralPage.getLeftMenu().moveToInformationalArtifactScreen();
                
@@ -394,7 +394,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void verifyToscaArtifactsExist() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                final int numOfToscaArtifacts = 2;
                ResourceGeneralPage.getLeftMenu().moveToToscaArtifactsScreen();
@@ -429,7 +429,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void vfCertificationTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                String vfName = vfMetaData.getName();
                
@@ -452,7 +452,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void deleteVfCheckedoutTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                GeneralPageElements.clickTrashButtonAndConfirm();
                
@@ -463,7 +463,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void revertVfMetadataTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceReqDetails vfRevertDetails = new ResourceReqDetails();
                vfRevertDetails.setName("ciUpdatedName");
@@ -482,7 +482,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void addDeploymentArtifactInCompositionScreenTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
                
@@ -499,7 +499,7 @@ public class Vf extends SetupCDTest {
        @Test(enabled = false)
        public void addPropertyInCompositionScreenTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
                
@@ -515,7 +515,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void addDeploymentArtifactAndVerifyInCompositionScreen() throws Exception{               
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.getLeftMenu().moveToDeploymentArtifactScreen();
 
@@ -537,7 +537,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void checkoutVfTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.clickCheckinButton(vfMetaData.getName());
                GeneralUIUtils.findComponentAndClick(vfMetaData.getName());
@@ -566,7 +566,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void deleteInstanceFromVfCanvas() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
                CanvasManager vfCanvasManager = CanvasManager.getCanvasManager();
@@ -582,7 +582,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void changeInstanceNameInVfTest() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                
                ResourceGeneralPage.getLeftMenu().moveToCompositionScreen();
                CanvasManager vfCanvasManager = CanvasManager.getCanvasManager();
@@ -605,7 +605,7 @@ public class Vf extends SetupCDTest {
                ResourceGeneralPage.clickSubmitForTestingButton(atomicResourceMetaData.getName());
                
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                DeploymentArtifactPage.getLeftMenu().moveToCompositionScreen();
                CanvasManager canvasManager = CanvasManager.getCanvasManager();
                CompositionPage.searchForElement(atomicResourceMetaData.getName());
@@ -628,7 +628,7 @@ public class Vf extends SetupCDTest {
        @Test
        public void isDisabledAndReadOnlyInCheckin() throws Exception{
                ResourceReqDetails vfMetaData = ElementFactory.getDefaultResourceByType(ResourceTypeEnum.VF, getUser());
-               ResourceUIUtils.createResource(vfMetaData, getUser());
+               ResourceUIUtils.createVF(vfMetaData, getUser());
                ResourceGeneralPage.clickCheckinButton(vfMetaData.getName());
                GeneralUIUtils.findComponentAndClick(vfMetaData.getName());
                
@@ -660,7 +660,7 @@ public class Vf extends SetupCDTest {
                OnboardingUtils.onboardAndValidate(FileHandling.getVnfRepositoryPath(), vnfFile, getUser());
                ResourceGeneralPage.getLeftMenu().moveToToscaArtifactsScreen();
                GeneralUIUtils.clickOnElementByTestId(ToscaArtifactsScreenEnum.TOSCA_MODEL.getValue());
-               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir();
+               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir();
                ToscaDefinition toscaDefinition = VfModuleVerificator.getToscaTemplate(latestFilefromDir.getAbsolutePath());
                VfModuleVerificator.validateSpecificModulePropertiesFromFile(toscaDefinition);
        }
index 86e81df..2faeedc 100644 (file)
@@ -194,7 +194,7 @@ public class VfArtifacts extends SetupCDTest{
                        if (DeploymentArtifactPage.getArtifactType(deploymentArtifcatsList.get(i)).equalsIgnoreCase(ArtifactTypeEnum.HEAT.getType())) {
                                DeploymentArtifactPage.clickDownloadEnvArtifact(deploymentArtifcatsList.get(i));
                                GeneralUIUtils.ultimateWait();
-                               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir(downloadDirPath);
+                               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir(downloadDirPath);
                                ArtifactUIUtils.compareYamlFilesByPattern(latestFilefromDir, currentZipEnvfiles.get(deploymentArtifcatsList.get(i)), PARAMETERS);
                                }
                }
@@ -218,7 +218,7 @@ public class VfArtifacts extends SetupCDTest{
                        if (DeploymentArtifactPage.getArtifactType(deploymentArtifcatsList.get(i)).equalsIgnoreCase(ArtifactTypeEnum.HEAT.getType())) {
                                DeploymentArtifactPage.clickDownloadEnvArtifact(deploymentArtifcatsList.get(i));
                                GeneralUIUtils.ultimateWait();
-                               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir(downloadDirPath);
+                               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir(downloadDirPath);
                                ArtifactUIUtils.compareYamlFilesByPattern(latestFilefromDir,currentZipEnvfiles.get(deploymentArtifcatsList.get(i)), PARAMETERS);
                        }
                }
@@ -243,7 +243,7 @@ public class VfArtifacts extends SetupCDTest{
                        if (GeneralUIUtils.isElementVisibleByTestId(GeneralUIUtils.getDataTestIdAttributeValue(deploymentArtifcatsList.get(i)))) {
                                CompositionPage.clickDownloadEnvArtifactComposition(fileName).click();
                                GeneralUIUtils.ultimateWait();
-                               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir(downloadDirPath);
+                               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir(downloadDirPath);
                                ArtifactUIUtils.compareYamlFilesByPattern(latestFilefromDir,currentZipEnvfiles.get(fileName), PARAMETERS);
                        }
                }
@@ -290,7 +290,7 @@ public class VfArtifacts extends SetupCDTest{
                                for (HeatParameterDataDefinition param : heatEnvUpdatedParameters.get(i).getHeatParameterDefinition()) {
                                        mapExpectedProperties.put(param.getName(), ArtifactUIUtils.getValue(param));
                                }
-                               ArtifactUIUtils.compareYamlParametersByPattern(mapExpectedProperties, FileHandling.getLastModifiedFileFromDir(downloadDirPath), PARAMETERS);
+                               ArtifactUIUtils.compareYamlParametersByPattern(mapExpectedProperties, FileHandling.getLastModifiedFileNameFromDir(downloadDirPath), PARAMETERS);
                        }
         }
        }
@@ -306,7 +306,7 @@ public class VfArtifacts extends SetupCDTest{
                GeneralUIUtils.moveToStep(StepsEnum.DEPLOYMENT_ARTIFACT);
                for(Entry<String, File> envFileEntry : generatedEnvFileList.entrySet()){
                        GeneralUIUtils.clickOnElementByTestId(DataTestIdEnum.ArtifactPageEnum.DOWNLOAD_ARTIFACT_ENV.getValue()+envFileEntry.getKey());
-                       ArtifactUIUtils.compareYamlFilesByPattern(envFileEntry.getValue(), FileHandling.getLastModifiedFileFromDir(), PARAMETERS);
+                       ArtifactUIUtils.compareYamlFilesByPattern(envFileEntry.getValue(), FileHandling.getLastModifiedFileNameFromDir(), PARAMETERS);
                        if(true){
                                throw new SkipException("Test skipped, new artifact version design should be developed");
                        }
@@ -331,7 +331,7 @@ public class VfArtifacts extends SetupCDTest{
                for(Entry<String, File> envFileEntry : generatedUpdatedEnvFileList.entrySet()){
 //                     TODO test will pass on case all objects on deployment view are visible 
                        GeneralUIUtils.clickOnElementByTestId(DataTestIdEnum.ArtifactPageEnum.DOWNLOAD_ARTIFACT_ENV.getValue()+envFileEntry.getKey());
-                       ArtifactUIUtils.compareYamlFilesByPattern(envFileEntry.getValue(), FileHandling.getLastModifiedFileFromDir(), PARAMETERS);
+                       ArtifactUIUtils.compareYamlFilesByPattern(envFileEntry.getValue(), FileHandling.getLastModifiedFileNameFromDir(), PARAMETERS);
                        if(true){
                                throw new SkipException("Test skipped, new artifact version design should be developed");
                        }
@@ -357,7 +357,7 @@ public class VfArtifacts extends SetupCDTest{
                GeneralUIUtils.moveToStep(StepsEnum.DEPLOYMENT_ARTIFACT);
                for(Entry<String, File> envFileEntry : generatedUpdatedSecondTimeEnvFileList.entrySet()){
                        GeneralUIUtils.clickOnElementByTestId(DataTestIdEnum.ArtifactPageEnum.DOWNLOAD_ARTIFACT_ENV.getValue()+envFileEntry.getKey());
-                       ArtifactUIUtils.compareYamlFilesByPattern(envFileEntry.getValue(), FileHandling.getLastModifiedFileFromDir(), PARAMETERS);
+                       ArtifactUIUtils.compareYamlFilesByPattern(envFileEntry.getValue(), FileHandling.getLastModifiedFileNameFromDir(), PARAMETERS);
                        if(true){
                                throw new SkipException("Test skipped, new artifact version design should be developed");
                        }
index 10ae6cb..21aa572 100644 (file)
@@ -159,7 +159,8 @@ public abstract class SetupCDTest extends DriverFactory {
        public void setBrowserBeforeTest(java.lang.reflect.Method method, ITestContext context) throws Exception {
                
                boolean emptyDataProvider = method.getAnnotation(Test.class).dataProvider().isEmpty();
-               if (emptyDataProvider) {
+               String className = method.getDeclaringClass().getName();
+               if (emptyDataProvider && !className.contains("ToscaValidationTest") ) {
                        System.out.println("ExtentReport instance started from BeforeMethod...");
                        String suiteName = ExtentManager.getSuiteName(context);
                        if (suiteName.equals(suiteNameXml.TESTNG_FAILED_XML_NAME.getValue())) {
index 9caeee8..ae86923 100644 (file)
@@ -104,7 +104,7 @@ public class HomePage extends GeneralPageElements {
        public static File downloadVspCsarToDefaultDirectory(String vspName) throws Exception {
                GeneralUIUtils.getWebElementByTestID(DataTestIdEnum.MainMenuButtonsFromInsideFrame.HOME_BUTTON.getValue()).click();
                DownloadManager.downloadCsarByNameFromVSPRepository(vspName, "");
-               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir();
+               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir();
                return latestFilefromDir;
        }
        
index c06a51c..1abae85 100644 (file)
@@ -478,7 +478,7 @@ public final class ArtifactUIUtils {
 
                String heatDisplayName = pairToUpdate.getHeatArtifactDisplayName();
                GeneralUIUtils.clickOnElementByTestId(DataTestIdEnum.ArtifactPageEnum.DOWNLOAD_ARTIFACT_ENV.getValue()+heatDisplayName);
-               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir();
+               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir();
                
                String pattern = PARAMETERS;
                Map<String, Object> mapUpdetedEnvFile = FileHandling.parseYamlFileToMapByPattern(updateEnvFile, pattern);
index ceada39..f4264ff 100644 (file)
@@ -68,8 +68,11 @@ public class DownloadManager {
         * @param vspName
         * @throws Exception
         */
-       public static void downloadCsarByNameFromVSPRepository(String vspName, String vspId) throws Exception{
-           FileHandling.cleanCurrentDownloadDir();
+       public static void downloadCsarByNameFromVSPRepository(String vspName, String vspId, Boolean isDelete) throws Exception{
+               
+               if(isDelete){
+                       FileHandling.cleanCurrentDownloadDir();
+               }
                HomePage.showVspRepository();
                boolean vspFound = HomePage.searchForVSP(vspName);
                if (vspFound){
@@ -88,6 +91,10 @@ public class DownloadManager {
                }
        }
        
+       public static void downloadCsarByNameFromVSPRepository(String vspName, String vspId) throws Exception{
+               downloadCsarByNameFromVSPRepository(vspName, vspId, true);
+       }
+       
 //     AttFtpClient instance = AttFtpClient.getInstance();
 //     
 //      String server = "localhost";
index 4fe1938..8c2556d 100644 (file)
@@ -264,11 +264,19 @@ public class FileHandling {
        }
        
 
-       public static synchronized File getLastModifiedFileFromDir() throws Exception{
-               return getLastModifiedFileFromDir(SetupCDTest.getWindowTest().getDownloadDirectory());
+       /**
+        * @return last modified file name from default directory
+        * @throws Exception
+        */
+       public static synchronized File getLastModifiedFileNameFromDir() throws Exception{
+               return getLastModifiedFileNameFromDir(SetupCDTest.getWindowTest().getDownloadDirectory());
        }
        
-       public static synchronized File getLastModifiedFileFromDir(String dirPath){
+       /**
+        * @param dirPath
+        * @return last modified file name from dirPath directory
+        */
+       public static synchronized File getLastModifiedFileNameFromDir(String dirPath){
            File dir = new File(dirPath);
            File[] files = dir.listFiles();
            if (files == null) {
@@ -397,7 +405,7 @@ public class FileHandling {
        
        public static String getMD5OfFile(File file) throws IOException {
                String content = FileUtils.readFileToString(file);
-               String md5 = GeneralUtility.calculateMD5ByString(content);
+               String md5 = GeneralUtility.calculateMD5Base64EncodedByString(content);
                return md5;
        }
        
diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/OnboardingUtillViaApis.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/OnboardingUtillViaApis.java
new file mode 100644 (file)
index 0000000..6abce99
--- /dev/null
@@ -0,0 +1,298 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.openecomp.sdc.ci.tests.utilities;
+
+import static org.testng.AssertJUnit.assertTrue;
+
+import java.io.BufferedInputStream;
+import java.io.BufferedOutputStream;
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.bouncycastle.util.encoders.Base64;
+import org.openecomp.sdc.be.model.Component;
+import org.openecomp.sdc.be.model.Resource;
+import org.openecomp.sdc.be.model.User;
+import org.openecomp.sdc.ci.tests.api.Urls;
+import org.openecomp.sdc.ci.tests.config.Config;
+import org.openecomp.sdc.ci.tests.datatypes.AmdocsLicenseMembers;
+import org.openecomp.sdc.ci.tests.datatypes.ResourceReqDetails;
+import org.openecomp.sdc.ci.tests.datatypes.ServiceReqDetails;
+import org.openecomp.sdc.ci.tests.datatypes.VendorSoftwareProductObject;
+import org.openecomp.sdc.ci.tests.datatypes.enums.ResourceCategoryEnum;
+import org.openecomp.sdc.ci.tests.datatypes.enums.ServiceCategoriesEnum;
+import org.openecomp.sdc.ci.tests.datatypes.enums.UserRoleEnum;
+import org.openecomp.sdc.ci.tests.datatypes.http.HttpHeaderEnum;
+import org.openecomp.sdc.ci.tests.datatypes.http.HttpRequest;
+import org.openecomp.sdc.ci.tests.datatypes.http.RestResponse;
+import org.openecomp.sdc.ci.tests.utils.Utils;
+import org.openecomp.sdc.ci.tests.utils.general.AtomicOperationUtils;
+import org.openecomp.sdc.ci.tests.utils.general.ElementFactory;
+import org.openecomp.sdc.ci.tests.utils.rest.BaseRestUtils;
+
+import com.clearspring.analytics.util.Pair;
+import com.google.gson.Gson;
+
+import fj.data.Either;
+
+public class OnboardingUtillViaApis {
+
+       protected static Map<String, String> prepareHeadersMap(String userId) {
+               Map<String, String> headersMap = new HashMap<String, String>();
+               headersMap.put(HttpHeaderEnum.CONTENT_TYPE.getValue(), "application/json");
+               headersMap.put(HttpHeaderEnum.ACCEPT.getValue(), "application/json");
+               headersMap.put(HttpHeaderEnum.USER_ID.getValue(), userId);
+               return headersMap;
+       }
+       
+       public static Pair<String, VendorSoftwareProductObject> createVspViaApis(String filepath, String vnfFile, User user) throws Exception {
+               
+               VendorSoftwareProductObject vendorSoftwareProductObject = new VendorSoftwareProductObject();
+               
+               AmdocsLicenseMembers amdocsLicenseMembers = OnboardingUtils.createVendorLicense(user);
+               Pair<String, Map<String, String>> createVendorSoftwareProduct = OnboardingUtils.createVendorSoftwareProduct(vnfFile, filepath, user, amdocsLicenseMembers);
+               Map<String, String> map = createVendorSoftwareProduct.right;
+               vendorSoftwareProductObject.setAttContact(map.get("attContact"));
+               vendorSoftwareProductObject.setCategory(map.get("category"));
+               vendorSoftwareProductObject.setComponentId(map.get("componentId"));
+               vendorSoftwareProductObject.setDescription(map.get("description"));
+               vendorSoftwareProductObject.setSubCategory(map.get("subCategory"));
+               vendorSoftwareProductObject.setVendorName(map.get("vendorName"));
+               vendorSoftwareProductObject.setVspId(map.get("vspId"));
+               Pair<String, VendorSoftwareProductObject> pair = new Pair<String, VendorSoftwareProductObject>(createVendorSoftwareProduct.left, vendorSoftwareProductObject);
+               return pair;
+       }
+       
+/*     public static Resource createResourceFromVSP(Pair<String, Map<String, String>> createVendorSoftwareProduct, String vspName) throws Exception {
+               List<String> tags = new ArrayList<>();
+               tags.add(vspName);
+               Map<String, String> map = createVendorSoftwareProduct.right;
+               ResourceReqDetails resourceDetails = new ResourceReqDetails();
+               resourceDetails.setCsarUUID(map.get("vspId"));
+               resourceDetails.setCsarVersion("1.0");
+               resourceDetails.setName(vspName);
+               resourceDetails.setTags(tags);
+               resourceDetails.setDescription(map.get("description"));
+               resourceDetails.setResourceType(map.get("componentType"));
+               resourceDetails.addCategoryChain(ResourceCategoryEnum.GENERIC_DATABASE.getCategory(), ResourceCategoryEnum.GENERIC_DATABASE.getSubCategory());
+               resourceDetails.setVendorName(map.get("vendorName"));
+               resourceDetails.setVendorRelease("1.0");
+               resourceDetails.setResourceType("VF");
+               resourceDetails.setResourceVendorModelNumber("666");
+               resourceDetails.setContactId(map.get("attContact"));
+               resourceDetails.setIcon("defaulticon");
+               Resource resource = AtomicOperationUtils.createResourceByResourceDetails(resourceDetails, UserRoleEnum.DESIGNER, true).left().value();
+               
+               return resource; 
+       }*/
+       public static Resource createResourceFromVSP(ResourceReqDetails resourceDetails, String vspName) throws Exception {
+//             List<String> tags = new ArrayList<>();
+//             tags.add(vspName);
+//             Map<String, String> map = createVendorSoftwareProduct.right;
+//             ResourceReqDetails resourceDetails = new ResourceReqDetails();
+//             resourceDetails.setCsarUUID(map.get("vspId"));
+//             resourceDetails.setCsarVersion("1.0");
+//             resourceDetails.setName(vspName);
+//             resourceDetails.setTags(tags);
+//             resourceDetails.setDescription(map.get("description"));
+//             resourceDetails.setResourceType(map.get("componentType"));
+//             resourceDetails.addCategoryChain(ResourceCategoryEnum.GENERIC_DATABASE.getCategory(), ResourceCategoryEnum.GENERIC_DATABASE.getSubCategory());
+//             resourceDetails.setVendorName(map.get("vendorName"));
+//             resourceDetails.setVendorRelease("1.0");
+//             resourceDetails.setResourceType("VF");
+//             resourceDetails.setResourceVendorModelNumber("666");
+//             resourceDetails.setContactId(map.get("attContact"));
+//             resourceDetails.setIcon("defaulticon");
+               Resource resource = AtomicOperationUtils.createResourceByResourceDetails(resourceDetails, UserRoleEnum.DESIGNER, true).left().value();
+               
+               return resource; 
+       }
+       public static void downloadToscaCsarToDirectory(Component component, File file) {
+               try {
+                       Either<String, RestResponse> componentToscaArtifactPayload = AtomicOperationUtils.getComponenetArtifactPayload(component, "assettoscacsar");
+                       if(componentToscaArtifactPayload.left().value() != null){
+                               convertPayloadToFile(componentToscaArtifactPayload.left().value(), file);
+                       }
+               } catch (Exception e) {
+                       // TODO Auto-generated catch block
+                       e.printStackTrace();
+               }
+       }
+       
+//     public static void convertPayloadToFile(String payload, File file, boolean isBased64, boolean isSdcFormat) throws IOException{
+//             
+//             Gson gson = new Gson();
+//             byte[] byteArray = null;
+//             Map<String, String> fromJson;
+//             @SuppressWarnings("unchecked")
+//             String string = null;// = fromJson.get("base64Contents").toString();
+//             if(isSdcFormat){
+//                     fromJson = gson.fromJson(payload, Map.class);
+//                     string = fromJson.get("base64Contents").toString();
+//             }else if (isBased64) {
+//                     byteArray = Base64.decode(string.getBytes(StandardCharsets.UTF_8));
+//             }else{
+//                     byteArray = payload.getBytes(StandardCharsets.UTF_8);
+//             }
+//             File downloadedFile = new File(file.getAbsolutePath());
+//             FileOutputStream fos = new FileOutputStream(downloadedFile);
+//             fos.write(byteArray);
+//             fos.flush();
+//             fos.close();
+//             
+//     }
+
+       public static void convertPayloadToFile(String payload, File file) throws IOException{
+               
+               Gson gson = new Gson();
+               @SuppressWarnings("unchecked")
+               Map<String, String> fromJson = gson.fromJson(payload, Map.class);
+               String string = fromJson.get("base64Contents").toString();
+               byte[] byteArray = Base64.decode(string.getBytes(StandardCharsets.UTF_8));
+               File downloadedFile = new File(file.getAbsolutePath());
+               FileOutputStream fos = new FileOutputStream(downloadedFile);
+               fos.write(byteArray);
+               fos.flush();
+               fos.close();
+       }
+       
+       
+       public static void convertPayloadToZipFile(String payload, File file) throws IOException{
+               
+               byte[] byteArray = payload.getBytes(StandardCharsets.ISO_8859_1);
+               File downloadedFile = new File(file.getAbsolutePath());
+               FileOutputStream fos = new FileOutputStream(downloadedFile);
+               fos.write(byteArray);
+               fos.flush();
+               fos.close();
+               
+               
+//             ZipOutputStream fos = null;
+//             
+//             
+//             for (Charset charset : Charset.availableCharsets().values()) {
+//                     try{
+//             //              System.out.println("How to do it???");
+//                             File downloadedFile = new File(file.getAbsolutePath() + "_" + charset +".csar");
+//                             fos = new ZipOutputStream(new FileOutputStream(downloadedFile));
+//                             byte[] byteArray = payload.getBytes(charset);
+//                             fos.write(byteArray);
+//                             fos.flush();
+//                             
+//                     }
+//                     catch(Exception e){
+//                             fos.close();
+//                     }
+//             }
+               System.out.println("");
+               
+//             ZipInputStream zipStream = new ZipInputStream(new ByteArrayInputStream(byteArray));
+//             ZipEntry entry = null;
+//             while ((entry = zipStream.getNextEntry()) != null) {
+//
+//                 String entryName = entry.getName();
+//
+//                 FileOutputStream out = new FileOutputStream(file+"/"+entryName);
+//
+//                 byte[] byteBuff = new byte[4096];
+//                 int bytesRead = 0;
+//                 while ((bytesRead = zipStream.read(byteBuff)) != -1)
+//                 {
+//                     out.write(byteBuff, 0, bytesRead);
+//                 }
+//
+//                 out.close();
+//                 zipStream.closeEntry();
+//             }
+//             zipStream.close();
+//             
+               
+               
+               
+               BufferedInputStream bis = new BufferedInputStream(new ByteArrayInputStream(payload.getBytes(StandardCharsets.ISO_8859_1)));
+               String filePath = file.toString();
+               BufferedOutputStream bos = new BufferedOutputStream(new FileOutputStream(new File(filePath)));
+               int inByte;
+               while((inByte = bis.read()) != -1) bos.write(inByte);
+               bis.close();
+               bos.close();
+       }
+       
+       public static Either<String, RestResponse> getVendorSoftwareProduct(String vspId, User user, Boolean validateState) throws Exception {
+
+               Config config = Utils.getConfig();
+               String url = String.format(Urls.GET_VENDOR_SOFTWARE_PRODUCT, config.getCatalogBeHost(), config.getCatalogBePort(), vspId);
+               String userId = user.getUserId();
+               Map<String, String> headersMap = prepareHeadersMap(userId);
+               headersMap.put(HttpHeaderEnum.X_ECOMP_REQUEST_ID_HEADER.getValue(), "123456");
+               headersMap.put(HttpHeaderEnum.ACCEPT.getValue(), "*/*");
+               headersMap.put("Accept-Encoding", "gzip, deflate, br");
+               HttpRequest http = new HttpRequest();
+               RestResponse response = http.httpSendGet(url, headersMap);
+               if (validateState) {
+                       assertTrue("add property to resource failed: " + response.getResponseMessage(), response.getErrorCode() == BaseRestUtils.STATUS_CODE_SUCCESS);
+               }
+               if (response.getErrorCode() != BaseRestUtils.STATUS_CODE_SUCCESS && response.getResponse().getBytes() == null && response.getResponse().getBytes().length == 0) {
+                       return Either.right(response);
+               }
+               return Either.left(response.getResponse());
+               
+       }
+       
+       public static ResourceReqDetails prepareOnboardedResourceDetailsBeforeCreate(VendorSoftwareProductObject vendorSoftwareProductObject, String vspName) {
+
+               List<String> tags = new ArrayList<>();
+               tags.add(vspName);
+               ResourceReqDetails resourceDetails = new ResourceReqDetails();
+               resourceDetails.setCsarUUID(vendorSoftwareProductObject.getVspId());
+               resourceDetails.setCsarVersion("1.0");
+               resourceDetails.setName(vspName);
+               resourceDetails.setTags(tags);
+               resourceDetails.setDescription(vendorSoftwareProductObject.getDescription());
+               resourceDetails.addCategoryChain(ResourceCategoryEnum.GENERIC_DATABASE.getCategory(), ResourceCategoryEnum.GENERIC_DATABASE.getSubCategory());
+               resourceDetails.setVendorName(vendorSoftwareProductObject.getVendorName());
+               resourceDetails.setVendorRelease("1.0");
+               resourceDetails.setResourceType("VF");
+               resourceDetails.setResourceVendorModelNumber("666");
+               resourceDetails.setContactId(vendorSoftwareProductObject.getAttContact());
+               resourceDetails.setIcon("defaulticon");
+               
+               return resourceDetails;
+       }
+       
+       public static ServiceReqDetails prepareServiceDetailsBeforeCreate(User user) {
+
+               ServiceReqDetails serviceDetails = ElementFactory.getDefaultService(ServiceCategoriesEnum.NETWORK_L4, user);
+               serviceDetails.setServiceType("MyServiceType");
+               serviceDetails.setServiceRole("MyServiceRole");
+               serviceDetails.setNamingPolicy("MyServiceNamingPolicy");
+               serviceDetails.setEcompGeneratedNaming(false);
+               
+               return serviceDetails;
+       }
+}
index 398e1f1..b4f834a 100644 (file)
@@ -56,6 +56,7 @@ import org.openecomp.sdc.ci.tests.datatypes.AmdocsLicenseMembers;
 import org.openecomp.sdc.ci.tests.datatypes.DataTestIdEnum;
 import org.openecomp.sdc.ci.tests.datatypes.HeatMetaFirstLevelDefinition;
 import org.openecomp.sdc.ci.tests.datatypes.LifeCycleStateEnum;
+import org.openecomp.sdc.ci.tests.datatypes.VendorSoftwareProductObject;
 import org.openecomp.sdc.ci.tests.datatypes.http.HttpHeaderEnum;
 import org.openecomp.sdc.ci.tests.datatypes.http.HttpRequest;
 import org.openecomp.sdc.ci.tests.datatypes.http.RestResponse;
@@ -520,21 +521,6 @@ public class OnboardingUtils {
                return new Pair<RestResponse, Map<String, String>>(response, vspMetadta);
        }
        
-/*     public static RestResponse getVendorSoftwareProduct(Map vspObject, User user) throws Exception {
-               Config config = Utils.getConfig();
-               String url = String.format("http://%s:%s/onboarding-api/v1.0/vendor-software-products/" + vspObject.get("vspId"),
-                               config.getCatalogBeHost(), config.getCatalogBePort());
-
-               String userId = user.getUserId();
-
-               Map<String, String> headersMap = prepareHeadersMap(userId);
-               HttpRequest http = new HttpRequest();
-
-               RestResponse response = http.httpsSendGet(url, headersMap);
-
-               return response;
-       }*/
-       
        public static RestResponse validateUpload(String vspid, User user) throws Exception {
                Config config = Utils.getConfig();
                String url = String.format("http://%s:%s/onboarding-api/v1.0/vendor-software-products/%s/versions/0.1/orchestration-template-candidate/process",
@@ -748,7 +734,7 @@ public class OnboardingUtils {
                String vspName = createVendorSoftwareProduct.left;
                
                DownloadManager.downloadCsarByNameFromVSPRepository(vspName, createVendorSoftwareProduct.right.get("vspId"));
-               File latestFilefromDir = FileHandling.getLastModifiedFileFromDir();
+               File latestFilefromDir = FileHandling.getLastModifiedFileNameFromDir();
                
                ExtentTestActions.log(Status.INFO, String.format("Searching for onboarded %s", vnfFile));
                HomePage.showVspRepository();
@@ -810,19 +796,19 @@ public class OnboardingUtils {
 
 }
 
-enum SnmpTypeEnum{
-       SNMP_POLL ("snmp"),
-       SNMP_TRAP ("snmp-trap");
+       enum SnmpTypeEnum{
+               SNMP_POLL ("snmp"),
+               SNMP_TRAP ("snmp-trap");
+               
+               private String value;
        
-       private String value;
-
-       public String getValue() {
-               return value;
-       }
-
-       private SnmpTypeEnum(String value) {
-               this.value = value;
-       }
+               public String getValue() {
+                       return value;
+               }
        
+               private SnmpTypeEnum(String value) {
+                       this.value = value;
+       }
        
 }
+
index c76bf4b..1eaa626 100644 (file)
@@ -539,30 +539,41 @@ public final class ResourceUIUtils {
                return getCreatedResource;
        }
 
+       /**
+        * @deprecated Use {@link #createVF(ResourceReqDetails,User)} instead
+        */
        public static  void createResource(ResourceReqDetails resource, User user) throws Exception {
+               createVF(resource, user);
+       }
+
+       public static  void createVF(ResourceReqDetails resource, User user) throws Exception {
                ExtentTestActions.log(Status.INFO, "Going to create a new VF.");
+               createResource(resource, user,  DataTestIdEnum.Dashboard.BUTTON_ADD_VF);
+       }
+
+       public static void createResource(ResourceReqDetails resource, User user, DataTestIdEnum.Dashboard button) {
                WebElement addVFButton = null;
         try {
                        GeneralUIUtils.ultimateWait();
                        try{
                                GeneralUIUtils.hoverOnAreaByClassName("w-sdc-dashboard-card-new");
-                               addVFButton = GeneralUIUtils.getWebElementByTestID(DataTestIdEnum.Dashboard.BUTTON_ADD_VF.getValue());
+                               addVFButton = GeneralUIUtils.getWebElementByTestID(button.getValue());
                        }
                        catch (Exception e){
                                File imageFilePath = GeneralUIUtils.takeScreenshot(null, SetupCDTest.getScreenshotFolder(), "Warning_" + resource.getName());
                                final String absolutePath = new File(SetupCDTest.getReportFolder()).toURI().relativize(imageFilePath.toURI()).getPath();
-                               SetupCDTest.getExtendTest().log(Status.WARNING, "Add VF button is not visible after hover on import area of Home page, moving on ..." + SetupCDTest.getExtendTest().addScreenCaptureFromPath(absolutePath));
+                               SetupCDTest.getExtendTest().log(Status.WARNING, "Add button is not visible after hover on import area of Home page, moving on ..." + SetupCDTest.getExtendTest().addScreenCaptureFromPath(absolutePath));
                                showButtonsADD();
-                               addVFButton = GeneralUIUtils.getWebElementByTestID(DataTestIdEnum.Dashboard.BUTTON_ADD_VF.getValue());
+                               addVFButton = GeneralUIUtils.getWebElementByTestID(button.getValue());
                        }
                        addVFButton.click();
                                GeneralUIUtils.ultimateWait();
                } 
         catch (Exception e ) {
-               SetupCDTest.getExtendTest().log(Status.WARNING, String.format("Exeption catched on ADD VF button, retrying ... "));
+               SetupCDTest.getExtendTest().log(Status.WARNING, String.format("Exeption catched on ADD button, retrying ... "));
                GeneralUIUtils.hoverOnAreaByClassName("w-sdc-dashboard-card-new");
                        GeneralUIUtils.ultimateWait();
-                       GeneralUIUtils.getWebElementByTestID(DataTestIdEnum.Dashboard.BUTTON_ADD_VF.getValue()).click();
+                       GeneralUIUtils.getWebElementByTestID(button.getValue()).click();
                        GeneralUIUtils.ultimateWait();
         }
                fillResourceGeneralInformationPage(resource, user, true);
@@ -1140,4 +1151,9 @@ public final class ResourceUIUtils {
                SetupCDTest.getExtendTest().log(Status.INFO, String.format("Clicking on %s %s", textToClick, customizationFoLogLocal));
                GeneralUIUtils.clickOnElementByText(textToClick);
        }
+       
+       public static  void createPNF(ResourceReqDetails resource, User user) throws Exception {
+               ExtentTestActions.log(Status.INFO, "Going to create a new PNF.");
+               createResource(resource, user, DataTestIdEnum.Dashboard.BUTTON_ADD_PNF);
+       }
 }
diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/verificator/ToscaValidation.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/verificator/ToscaValidation.java
new file mode 100644 (file)
index 0000000..5afb94f
--- /dev/null
@@ -0,0 +1,125 @@
+package org.openecomp.sdc.ci.tests.verificator;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.openecomp.sdc.be.datatypes.enums.ComponentTypeEnum;
+import org.openecomp.sdc.ci.tests.execute.setup.SetupCDTest;
+import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaDefinition;
+import org.openecomp.sdc.toscaparser.api.elements.Metadata;
+
+import com.aventstack.extentreports.Status;
+
+import fj.data.Either;
+
+public class ToscaValidation {
+
+       
+       /**
+        * @param expectedToscaDefinition
+        * @param actualToscaDefinition
+        * @return true if all validation success else return error map
+        */
+       public static Either<Boolean, Map<String, Object>> resourceToscaMetadataValidator(ToscaDefinition expectedToscaDefinition, ToscaDefinition actualToscaDefinition){
+               
+               SetupCDTest.getExtendTest().log(Status.INFO, "Going to validate resource TOSCA metadata...");
+               Map<String, String> expectedMetadata = expectedToscaDefinition.getMetadata();
+               Map<String, String> actualMetadata = actualToscaDefinition.getMetadata();
+               Either<Boolean, Map<String, Object>> resourceToscaMetadataValidator = compareMapData(expectedMetadata, actualMetadata);
+               if(resourceToscaMetadataValidator.isLeft()){
+                       SetupCDTest.getExtendTest().log(Status.INFO, "Resource TOSCA metadata verification success");
+               }else{
+                       SetupCDTest.getExtendTest().log(Status.ERROR, "Resource TOSCA metadata verification failed" + resourceToscaMetadataValidator.right().value());
+               }
+               return resourceToscaMetadataValidator;
+       }
+
+       public static Boolean resourceToscaNodeTemplateMetadataValidator(Map<String, Map<String, String>> expectedMetadata, ToscaDefinition actualToscaDefinition){
+               boolean isTestFailed = true;
+               for(String nodeTemplateName : expectedMetadata.keySet()){
+                       Either<Boolean,Map<String,Object>> serviceToscaMetadataValidator = componentToscaNodeTemplateMetadataValidator(expectedMetadata.get(nodeTemplateName), actualToscaDefinition, nodeTemplateName, ComponentTypeEnum.RESOURCE);
+                       if(serviceToscaMetadataValidator.left().value() == false){
+                               isTestFailed = false;
+                       }
+               }
+               return isTestFailed;
+       }
+       
+       public static Either<Boolean, Map<String, Object>> serviceToscaMetadataValidator(Map<String, String> expectedMetadata, ToscaDefinition actualToscaDefinition){
+               
+               SetupCDTest.getExtendTest().log(Status.INFO, "Going to validate service TOSCA metadata...");
+               Map<String, String> actualMetadata = actualToscaDefinition.getMetadata();
+               Either<Boolean,Map<String,Object>> serviceToscaMetadataValidator = compareMapData(expectedMetadata, actualMetadata);
+               if(serviceToscaMetadataValidator.isLeft()){
+                       SetupCDTest.getExtendTest().log(Status.INFO, "Service TOSCA metadata verification success");
+               }else{
+                       SetupCDTest.getExtendTest().log(Status.ERROR, "Service TOSCA metadata verification failed" + serviceToscaMetadataValidator.right().value().toString());
+               }
+               return serviceToscaMetadataValidator;
+       }
+
+       public static Either<Boolean, Map<String, Object>> componentToscaNodeTemplateMetadataValidator(Map<String, String> expectedMetadata, ToscaDefinition actualToscaDefinition, String nodeTemplateName, ComponentTypeEnum componentType){
+               
+               SetupCDTest.getExtendTest().log(Status.INFO, "Going to validate "+ componentType.getValue() + " node template TOSCA metadata...");
+               Map<String, String> actualMetadata = actualToscaDefinition.getTopology_template().getNode_templates().get(nodeTemplateName).getMetadata();
+               Either<Boolean,Map<String,Object>> componentToscaMetadataValidator = compareMapData(expectedMetadata, actualMetadata);
+               if(componentToscaMetadataValidator.isLeft()){
+                       SetupCDTest.getExtendTest().log(Status.INFO, componentType.getValue() + "  TOSCA node template metadata verification success");
+               }else{
+                       SetupCDTest.getExtendTest().log(Status.ERROR, componentType.getValue() + "  TOSCA node template metadata verification failed" + componentToscaMetadataValidator.right().value().toString());
+               }
+               return componentToscaMetadataValidator;
+       }
+       
+       public static Either<Boolean, Map<String, Object>> serviceToscaMetadataValidatorAgainstParser(Map<String, String> expectedMetadata, Metadata actualMetadata){
+               
+               SetupCDTest.getExtendTest().log(Status.INFO, "Going to validate service TOSCA metadata...");
+
+               Either<Boolean,Map<String,Object>> serviceToscaMetadataValidator = compareMetadataUsingToscaParser(expectedMetadata, actualMetadata);
+               if(serviceToscaMetadataValidator.isLeft()){
+                       SetupCDTest.getExtendTest().log(Status.INFO, "Service TOSCA metadata verification vs. tosca parser success");
+               }else{
+                       SetupCDTest.getExtendTest().log(Status.ERROR, "Service TOSCA metadata verification vs. tosca parser failed" + serviceToscaMetadataValidator.right().value().toString());
+               }
+               return serviceToscaMetadataValidator;
+       }
+
+       
+       public static Either<Boolean, Map<String, Object>> compareMapData(Map<String, String> expectedMetadata, Map<String, String> actualMetadata) {
+               Either.left(false);
+               Map<String, Object> errorMap = new HashMap<>();
+               for(String key : expectedMetadata.keySet()){
+                       boolean isError = compaireValue(expectedMetadata.get(key), actualMetadata.get(key));
+                       if(!isError){
+                               errorMap.put("Data key["+key+"]", "expected: " + expectedMetadata.get(key) + ", actual: " + actualMetadata.get(key));
+                       }
+               }
+               if(errorMap != null && !errorMap.isEmpty()){
+                       return Either.right(errorMap);
+               }
+               return Either.left(true);
+       }
+       
+       public static Either<Boolean, Map<String, Object>> compareMetadataUsingToscaParser(Map<String, String> expectedMetadata, Metadata actualMetadata) {
+               Map<String, Object> errorMap = new HashMap<>();
+               for(String key : expectedMetadata.keySet()){
+                       boolean isError = compaireValue(expectedMetadata.get(key), actualMetadata.getValue(key));
+                       if(!isError){
+                               errorMap.put("Data key["+key+"]", "expected: " + expectedMetadata.get(key) + ", actual: " + actualMetadata.getValue(key));
+                       }
+               }
+               if(errorMap != null && !errorMap.isEmpty()){
+                       return Either.right(errorMap);
+               }
+               return Either.left(true);
+       }
+       
+       private static boolean compaireValue(String expected, String actual) {
+               
+               return expected.equals(actual) ? true : false;
+               
+       }
+       
+       
+       
+}
index 7f01b86..9426fc1 100644 (file)
@@ -38,7 +38,7 @@ import org.openecomp.sdc.be.model.Service;
 import org.openecomp.sdc.ci.tests.datatypes.TypeHeatMetaDefinition;
 import org.openecomp.sdc.ci.tests.execute.setup.SetupCDTest;
 import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaDefinition;
-import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaGroupsMetadataDefinition;
+import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaServiceGroupsMetadataDefinition;
 import org.openecomp.sdc.ci.tests.tosca.datatypes.ToscaGroupsTopologyTemplateDefinition;
 import org.openecomp.sdc.ci.tests.utils.ToscaParserUtils;
 
@@ -75,7 +75,7 @@ public class VfModuleVerificator {
                for (Map.Entry<String, ToscaGroupsTopologyTemplateDefinition> groupTopologyTemplateDefinition : groups.entrySet()) {
                        String key = groupTopologyTemplateDefinition.getKey();
                        GroupInstance groupInstanceObject = getGroupInstanceByKey(key, service);
-                       ToscaGroupsMetadataDefinition metadata = groupTopologyTemplateDefinition.getValue().getMetadata();
+                       ToscaServiceGroupsMetadataDefinition metadata = groupTopologyTemplateDefinition.getValue().getMetadata();
                        assertNotNull("groupInstanceObject is null", groupInstanceObject);
                        assertTrue("expected vfModuleModelName " + groupInstanceObject.getGroupName() + ", actual " + metadata.getVfModuleModelName(), groupInstanceObject.getGroupName().equals(metadata.getVfModuleModelName()));
                        assertTrue("expected vfModuleModelInvariantUUID " + groupInstanceObject.getInvariantUUID() + ", actual " + metadata.getVfModuleModelInvariantUUID(), groupInstanceObject.getInvariantUUID().equals(metadata.getVfModuleModelInvariantUUID()));
diff --git a/ui-ci/src/main/resources/ci/testSuites/toscaValidationSuite.xml b/ui-ci/src/main/resources/ci/testSuites/toscaValidationSuite.xml
new file mode 100644 (file)
index 0000000..6114517
--- /dev/null
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd">
+<suite name="uitests" configfailurepolicy="continue" parallel="instances" thread-count="2" data-provider-thread-count="2">
+ <parameter name="makeDistribution"  value="false"/>
+
+  <test name="OnbordingDataProviders">
+    <classes>
+       
+               <class name="org.openecomp.sdc.ci.tests.dataProvider.OnbordingDataProviders">
+                         <methods>
+                               <include name="OnbordingDataProviders"/>
+                               <!-- <exclude name="onboardVNFShotFlow"/>
+                               <exclude name="onboardRandomVNFsTest"/> -->
+                         </methods>
+               </class>
+       <!--    <class name="org.openecomp.sdc.ci.tests.execute.sanity.Onboard">
+                         <methods>
+                               <include name="onboardRandomVNFsTest"/>
+                         </methods>
+               </class> -->
+                                               
+    </classes>
+  </test> <!-- uitests -->
+</suite> <!-- uisuite -->
\ No newline at end of file