Merge "Flatten the CDS grpc request payload"
authorLiam Fallon <liam.fallon@est.tech>
Thu, 24 Oct 2019 13:18:20 +0000 (13:18 +0000)
committerGerrit Code Review <gerrit@onap.org>
Thu, 24 Oct 2019 13:18:20 +0000 (13:18 +0000)
12 files changed:
models-examples/src/main/resources/policytypes/onap.policies.optimization.AffinityPolicy.yaml
models-examples/src/main/resources/policytypes/onap.policies.optimization.DistancePolicy.yaml
models-examples/src/main/resources/policytypes/onap.policies.optimization.HpaPolicy.yaml
models-examples/src/main/resources/policytypes/onap.policies.optimization.OptimizationPolicy.yaml
models-examples/src/main/resources/policytypes/onap.policies.optimization.PciPolicy.yaml
models-examples/src/main/resources/policytypes/onap.policies.optimization.QueryPolicy.yaml
models-examples/src/main/resources/policytypes/onap.policies.optimization.SubscriberPolicy.yaml
models-examples/src/main/resources/policytypes/onap.policies.optimization.Vim_fit.yaml
models-examples/src/main/resources/policytypes/onap.policies.optimization.VnfPolicy.yaml
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/concepts/ToscaPolicyTypeFilterTest.java
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/provider/AuthorativeToscaProviderPolicyTypeTest.java
models-tosca/src/test/resources/onap.policies.NoVersion.yaml [new file with mode: 0644]

index ce2538c..abac219 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.AffinityPolicy:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          applicableResources:
             type: list
index 4137fc7..3c9150d 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.DistancePolicy:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          applicableResources:
             type: list
index 62bc4af..dbb5e9e 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.HpaPolicy:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          flavorFeatures:
             type: list
index f8652dd..e03ceee 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.OptimizationPolicy:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          objective:
             type: list
index 5efb8f2..097a5f1 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.PciPolicy:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          pciProperties:
             type: list
index 778d24b..41b923a 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.QueryPolicy:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          queryProperties:
             type: list
index e821aae..010a153 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.SubscriberPolicy:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          subscriberProperties:
             type: policy.data.subscriberProperties_properties
index d2b4ef6..b70dddb 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.Vim_fit:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          applicableResources:
             type: list
index f825f44..18a0ccf 100644 (file)
@@ -2,6 +2,7 @@ tosca_definitions_version: tosca_simple_yaml_1_0_0
 policy_types:
    onap.policies.optimization.VnfPolicy:
       derived_from: onap.policies.Optimization
+      version: 1.0.0
       properties:
          applicableResources:
             type: list
index 28836a9..d9ffec5 100644 (file)
@@ -144,19 +144,19 @@ public class ToscaPolicyTypeFilterTest {
         List<ToscaPolicyType> filteredList = filter.filter(typeList);
         assertEquals(20, filteredList.size());
         assertEquals(VERSION_100, filteredList.get(0).getVersion());
-        assertEquals(VERSION_000, filteredList.get(11).getVersion());
+        assertEquals(VERSION_100, filteredList.get(11).getVersion());
 
         typeList.get(12).setVersion("2.0.0");
         filteredList = filter.filter(typeList);
         assertEquals(20, filteredList.size());
         assertEquals("2.0.0", filteredList.get(11).getVersion());
-        assertEquals(VERSION_000, filteredList.get(18).getVersion());
+        assertEquals(VERSION_100, filteredList.get(18).getVersion());
 
         typeList.get(12).setVersion(VERSION_100);
         filteredList = filter.filter(typeList);
         assertEquals(20, filteredList.size());
         assertEquals(VERSION_100, filteredList.get(0).getVersion());
-        assertEquals(VERSION_000, filteredList.get(18).getVersion());
+        assertEquals(VERSION_100, filteredList.get(18).getVersion());
     }
 
     @Test
@@ -175,12 +175,12 @@ public class ToscaPolicyTypeFilterTest {
 
         filter = ToscaPolicyTypeFilter.builder().version(VERSION_000).build();
         filteredList = filter.filter(typeList);
-        assertEquals(9, filteredList.size());
+        assertEquals(1, filteredList.size());
 
         filter = ToscaPolicyTypeFilter.builder().name("onap.policies.optimization.Vim_fit").version(VERSION_000)
                 .build();
         filteredList = filter.filter(typeList);
-        assertEquals(1, filteredList.size());
+        assertEquals(0, filteredList.size());
 
         filter = ToscaPolicyTypeFilter.builder().name("onap.policies.optimization.Vim_fit").version("0.0.1").build();
         filteredList = filter.filter(typeList);
index d77b52d..20b8e5d 100644 (file)
@@ -56,8 +56,8 @@ import org.yaml.snakeyaml.Yaml;
  */
 public class AuthorativeToscaProviderPolicyTypeTest {
     private static final String VERSION = "version";
-    private static final String POLICY_AFFINITY_VERSION0 = "onap.policies.optimization.AffinityPolicy:0.0.0";
-    private static final String POLICY_AFFINITY = "onap.policies.optimization.AffinityPolicy";
+    private static final String POLICY_AFFINITY_VERSION0 = "onap.policies.NoVersion:0.0.0";
+    private static final String POLICY_AFFINITY = "onap.policies.NoVersion";
     private static final String MISSING_POLICY_TYPES = "no policy types specified on service template";
     private static final String DAO_IS_NULL = "dao is marked @NonNull but is null";
     private static final String VERSION_000 = "0.0.0";
@@ -74,7 +74,7 @@ public class AuthorativeToscaProviderPolicyTypeTest {
     @BeforeClass
     public static void readPolicyDefinition() {
         String yamlString =
-                ResourceUtils.getResourceAsString("policytypes/onap.policies.optimization.AffinityPolicy.yaml");
+                ResourceUtils.getResourceAsString("src/test/resources/onap.policies.NoVersion.yaml");
 
         Object yamlObject = new Yaml().load(yamlString);
         yamlAsJsonString = new GsonBuilder().setPrettyPrinting().create().toJson(yamlObject);
diff --git a/models-tosca/src/test/resources/onap.policies.NoVersion.yaml b/models-tosca/src/test/resources/onap.policies.NoVersion.yaml
new file mode 100644 (file)
index 0000000..7d1262b
--- /dev/null
@@ -0,0 +1,30 @@
+tosca_definitions_version: tosca_simple_yaml_1_0_0
+policy_types:
+   onap.policies.NoVersion:
+      derived_from: onap.policies.Optimization
+      properties:
+         applicableResources:
+            type: list
+            required: true
+            entry_schema:
+               type: string
+               constraints:
+               -  valid_values:
+                  - any
+                  - all
+         affinityProperties:
+            type: policy.data.affinityProperties_properties
+            required: true
+data_types:
+   policy.data.affinityProperties_properties:
+      derived_from: tosca.nodes.Root
+      properties:
+         qualifier:
+            type: string
+            constraints:
+            -  valid_values:
+               - same
+               - different
+         category:
+            type: string
+            required: true
\ No newline at end of file