AbstractTemplateServlet- fix null test for "tags"

Issue-ID: SDC-4397
Signed-off-by: shikha0203 <shivani.khare@est.tech>
Change-Id: Ia95e76c5ddbed740cbfbab581b0d8fdc56e90194

diff --git a/catalog-be/src/main/java/org/openecomp/sdc/be/externalapi/servlet/AbstractTemplateServlet.java b/catalog-be/src/main/java/org/openecomp/sdc/be/externalapi/servlet/AbstractTemplateServlet.java
index 19b2c34..411e0dc 100644 (file)
--- a/catalog-be/src/main/java/org/openecomp/sdc/be/externalapi/servlet/AbstractTemplateServlet.java
+++ b/catalog-be/src/main/java/org/openecomp/sdc/be/externalapi/servlet/AbstractTemplateServlet.java
@@ -26,6 +26,7 @@ import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.servers.Server;
 import io.swagger.v3.oas.annotations.tags.Tag;
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.List;
 import javax.inject.Inject;
 import javax.servlet.http.HttpServletRequest;
@@ -38,6 +39,8 @@ import javax.ws.rs.Produces;
 import javax.ws.rs.core.Context;
 import javax.ws.rs.core.MediaType;
 import javax.ws.rs.core.Response;
+
+import org.apache.commons.collections.CollectionUtils;
 import org.openecomp.sdc.be.components.impl.AbstractTemplateBusinessLogic;
 import org.openecomp.sdc.be.components.impl.ComponentInstanceBusinessLogic;
 import org.openecomp.sdc.be.components.impl.ElementBusinessLogic;
@@ -226,13 +229,16 @@ public class AbstractTemplateServlet extends AbstractValidationsServlet {
         log.debug("getServiceAbstractStatus: Service Fetching Success");
         Service service = (Service) assetTypeData.left().value().get(0);
         List<String> tags = service.getTags();
-        if (tags != null && !tags.isEmpty()) {
+        if (CollectionUtils.isNotEmpty(tags)) {
+
             for (int i = tags.size() - 1; i >= 0; i--) {
                 String tag = tags.get(i);
                 if (service.getName().equals(tag)) {
                     tags.remove(tag);
                 }
             }
+        } else {
+            tags = new ArrayList<>();
         }
         service.setName(copyServiceInfo.getNewServiceName());
         tags.add(copyServiceInfo.getNewServiceName());