Fix 5 critical SonarCloud bugs

Bugs taken from SonarCloud

Change-Id: Ie03e63a0ad4da7358a591c22ee2acf0c8cd97598
Issue-ID: SDC-3529
Signed-off-by: eschcam <cameron.scholes@est.tech>

diff --git a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less
index 1772170..38effe8 100644 (file)
--- a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less
+++ b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less
@@ -27,7 +27,7 @@
       height: 24px
     }
 
-    loader {
+    .loader {
       top: 20px;
     }
   }
@@ -124,4 +124,4 @@
   position: absolute;
   top: 10px;
   cursor: pointer;
-}
\ No newline at end of file
+}

diff --git a/catalog-ui/src/app/ng2/components/ui/modal/modal.component.less b/catalog-ui/src/app/ng2/components/ui/modal/modal.component.less
index 03b2a70..7adb0e4 100644 (file)
--- a/catalog-ui/src/app/ng2/components/ui/modal/modal.component.less
+++ b/catalog-ui/src/app/ng2/components/ui/modal/modal.component.less
@@ -1,7 +1,7 @@
 @import '../../../../../assets/styles/variables';
 @import '../../../../../assets/styles/mixins';
 @import '../../../../../assets/styles/sprite-old';
-/deep/ modal {
+/deep/ .modal {
     display: none;
 }
 

diff --git a/catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less b/catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less
index f7b18b1..db60be5 100644 (file)
--- a/catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less
+++ b/catalog-ui/src/app/ng2/components/ui/tabs/tabs.component.less
@@ -1,6 +1,6 @@
 @import '../../../../../assets/styles/variables';
 
-tab {
+.tab {
     height: 100%;
 }
 

diff --git a/catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less b/catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less
index 386d243..1095542 100644 (file)
--- a/catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less
+++ b/catalog-ui/src/app/ng2/pages/attributes-outputs/attributes-outputs.page.component.less
@@ -17,12 +17,6 @@
   height: 100%;
 }
 
-/deep/ tabs {
-  display: flex;
-  flex-direction: column;
-  height: 100%;
-}
-
 .attributes-outputs-page {
   height: 100%;
   font-family: @font-opensans-regular;
@@ -39,6 +33,9 @@
     min-width: 930px;
 
     /deep/ .tabs {
+      display: flex;
+      flex-direction: row;
+      height: 100%;
       width: 33%;
       text-align: center;
     }

diff --git a/catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less b/catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less
index 1c62758..31c5a72 100644 (file)
--- a/catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less
+++ b/catalog-ui/src/app/ng2/pages/properties-assignment/properties-assignment.page.component.less
@@ -11,8 +11,10 @@
 @ng2-title-font-size:16px;
 @ng2-text-font-size: 14px;
 
-:host { display:block; height: 100%; }
-/deep/ tabs {display:flex; flex-direction:column; height:100%; }
+:host {
+    display:block;
+    height: 100%;
+}
 
 .properties-assignment-page {
     height: 100%;
@@ -32,6 +34,9 @@
         /deep/ .tabs {
             width:18%;
             text-align:center;
+            display:flex;
+            flex-direction:row;
+            height:100%;
         }
 
         /deep/ .tab {
@@ -99,7 +104,7 @@
             }
 
         }
-        
+
         .clear-filter{
             cursor: pointer;
             color:#009fdb;