import com.att.eelf.configuration.EELFLogger;
import com.att.eelf.configuration.EELFManager;
import org.onap.appc.Constants;
-import org.onap.appc.adapter.chef.impl.ChefAdapterImpl;
+import org.onap.appc.adapter.chef.impl.ChefAdapterFactory;
import org.onap.appc.configuration.Configuration;
import org.onap.appc.configuration.ConfigurationFactory;
import org.onap.appc.i18n.Msg;
*/
private Configuration configuration = ConfigurationFactory.getConfiguration();
+
/**
* Called when this bundle is started so the Framework can perform the bundle-specific activities necessary to start
* this bundle. This method can be used to register services or to allocate any resources that this bundle needs.
String appName = readApplicationNameFromProperties();
logger.info(Msg.COMPONENT_INITIALIZING, appName, ADAPTER_NAME);
- adapter = new ChefAdapterImpl();
+ adapter = new ChefAdapterFactory().create();
if (registration == null) {
logger.info(Msg.REGISTERING_SERVICE, appName, ADAPTER_NAME,
ChefAdapter.class.getSimpleName());
import org.onap.appc.adapter.chef.chefclient.impl.ChefApiClientImpl;
import org.onap.appc.adapter.chef.chefclient.impl.ChefApiHeaderFactory;
-public final class ChefApiClientFactory {
+public class ChefApiClientFactory {
private HttpClient httpClient = HttpClients.createDefault();
private ChefApiHeaderFactory chefApiHeaderFactory = new ChefApiHeaderFactory();
--- /dev/null
+/*
+ * ============LICENSE_START=======================================================
+ * ONAP : APPC
+ * ================================================================================
+ * Copyright (C) 2018 Nokia. All rights reserved.
+ * =============================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.appc.adapter.chef.impl;
+
+import org.onap.appc.adapter.chef.ChefAdapter;
+import org.onap.appc.adapter.chef.chefclient.ChefApiClientFactory;
+
+public class ChefAdapterFactory {
+
+ public ChefAdapter create() {
+ return new ChefAdapterImpl(new ChefApiClientFactory(), new PrivateKeyChecker());
+ }
+}
*/
package org.onap.appc.adapter.chef.impl;
-import java.io.File;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
-import java.util.Properties;
import org.apache.commons.lang.StringUtils;
import org.apache.http.HttpEntity;
import org.apache.http.HttpResponse;
private static final String CHEF_SERVER_RESULT_MSG_STR = "chefServerResult.message";
private static final String CHEF_ACTION_STR = "chefAction";
private static final String NODE_LIST_STR = "NodeList";
- private ChefApiClientFactory chefApiClientFactory = new ChefApiClientFactory();
+ private final ChefApiClientFactory chefApiClientFactory;
+ private final PrivateKeyChecker privateKeyChecker;
- /**
- * This default constructor is used as a work around because the activator wasnt getting called
- */
- public ChefAdapterImpl() {
+ ChefAdapterImpl(ChefApiClientFactory chefApiClientFactory, PrivateKeyChecker privateKeyChecker) {
+ this.chefApiClientFactory = chefApiClientFactory;
+ this.privateKeyChecker = privateKeyChecker;
logger.info("Initialize Chef Adapter");
}
JSONObject envJ = new JSONObject(env);
String envName = envJ.getString("name");
String message;
- if (privateKeyCheck()) {
+ if (privateKeyChecker.doesExist(clientPrivatekey)) {
// update the details of an environment on the Chef server.
ChefApiClient chefApiClient = chefApiClientFactory.create(chefserver, organizations, username, clientPrivatekey);
ChefResponse chefResponse = chefApiClient.put("/environments/" + envName, env);
rc.isAlive();
code = 200;
String message = null;
- if (privateKeyCheck()) {
+ if (privateKeyChecker.doesExist(clientPrivatekey)) {
ChefApiClient cac = chefApiClientFactory.create(chefserver, organizations, username, clientPrivatekey);
for (String nodeName: nodes) {
for (String node : nodes) {
String chefAction = "/nodes/" + node;
String message;
- if (privateKeyCheck()) {
+ if (privateKeyChecker.doesExist(clientPrivatekey)) {
ChefResponse chefResponse = getApiMethod(chefAction);
code = chefResponse.getStatusCode();
message = chefResponse.getBody();
}
}
- private Boolean privateKeyCheck() {
- File f = new File(clientPrivatekey);
- if (f.exists()) {
- logger.info("Key exists");
- return true;
- } else {
- logger.info("Key doesn't exists");
- return false;
- }
- }
-
@SuppressWarnings("nls")
@Override
public void retrieveData(Map<String, String> params, SvcLogicContext ctx) {
int code;
String message;
- if (privateKeyCheck()) {
+ if (privateKeyChecker.doesExist(clientPrivatekey)) {
ChefResponse chefResponse = getApiMethod(chefAction);
code = chefResponse.getStatusCode();
message = chefResponse.getBody();
rc.isAlive();
int code;
String message;
- if (privateKeyCheck()) {
+ if (privateKeyChecker.doesExist(clientPrivatekey)) {
ChefApiClient chefApiClient = chefApiClientFactory.create(chefserver, organizations, username, clientPrivatekey);
ChefResponse chefResponse = chefApiClient.put(chefAction, chefNodeStr);
int code;
String message;
// should load pem from somewhere else
- if (privateKeyCheck()) {
+ if (privateKeyChecker.doesExist(clientPrivatekey)) {
ChefApiClient chefApiClient = chefApiClientFactory.create(chefserver, organizations, username, clientPrivatekey);
// need pass path into it
rc.isAlive();
int code;
String message;
- if (privateKeyCheck()) {
+ if (privateKeyChecker.doesExist(clientPrivatekey)) {
ChefApiClient chefApiClient = chefApiClientFactory.create(chefserver, organizations, username, clientPrivatekey);
ChefResponse chefResponse = chefApiClient.delete(chefAction);
code = chefResponse.getStatusCode();
SvcLogicContext svcLogic = rc.getSvcLogicContext();
String codeStr = "server".equals(target) ? CHEF_SERVER_RESULT_CODE_STR : CHEF_CLIENT_RESULT_CODE_STR;
- String messageStr = "client".equals(target) ? CHEF_SERVER_RESULT_MSG_STR : CHEF_CLIENT_RESULT_MSG_STR;
+ String messageStr = "client".equals(target) ? CHEF_CLIENT_RESULT_MSG_STR : CHEF_SERVER_RESULT_MSG_STR;
svcLogic.setStatus(OUTCOME_SUCCESS);
svcLogic.setAttribute(codeStr, Integer.toString(code));
--- /dev/null
+/*
+ * ============LICENSE_START=======================================================
+ * ONAP : APPC
+ * ================================================================================
+ * Copyright (C) 2018 Nokia. All rights reserved.
+ * =============================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.appc.adapter.chef.impl;
+
+import com.att.eelf.configuration.EELFLogger;
+import com.att.eelf.configuration.EELFManager;
+import java.io.File;
+
+class PrivateKeyChecker {
+
+ private static final EELFLogger logger = EELFManager.getInstance().getLogger(PrivateKeyChecker.class);
+
+ Boolean doesExist(String clientPrivateKeyPath) {
+ File f = new File(clientPrivateKeyPath);
+ if (f.exists()) {
+ logger.info("Key exists");
+ return true;
+ } else {
+ logger.info("Key doesn't exists");
+ return false;
+ }
+ }
+}
\ No newline at end of file
SvcLogicContext svcLogicContext = new SvcLogicContext();
// WHEN
- ChefAdapter chefAdapter = new ChefAdapterImpl();
+ ChefAdapter chefAdapter = new ChefAdapterFactory().create();
chefAdapter.retrieveData(params, svcLogicContext);
// THEN
SvcLogicContext svcLogicContext = new SvcLogicContext();
// WHEN
- ChefAdapter chefAdapter = new ChefAdapterImpl();
+ ChefAdapter chefAdapter = new ChefAdapterFactory().create();
chefAdapter.retrieveData(params, svcLogicContext);
// THEN
SvcLogicContext svcLogicContext = new SvcLogicContext();
// WHEN
- ChefAdapter chefAdapter = new ChefAdapterImpl();
+ ChefAdapter chefAdapter = new ChefAdapterFactory().create();
chefAdapter.retrieveData(params, svcLogicContext);
// THEN
--- /dev/null
+/*
+ * ============LICENSE_START=======================================================
+ * ONAP : APPC
+ * ================================================================================
+ * Copyright (C) 2018 Nokia. All rights reserved.
+ * =============================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.appc.adapter.chef.impl;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.BDDMockito.verifyZeroInteractions;
+
+import com.google.common.collect.ImmutableMap;
+import java.util.Map;
+import java.util.function.Consumer;
+import java.util.function.Supplier;
+import org.apache.http.HttpStatus;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.runners.MockitoJUnitRunner;
+import org.onap.appc.adapter.chef.ChefAdapter;
+import org.onap.appc.adapter.chef.chefclient.ChefApiClientFactory;
+import org.onap.appc.adapter.chef.chefclient.api.ChefApiClient;
+import org.onap.appc.adapter.chef.chefclient.api.ChefResponse;
+import org.onap.ccsdk.sli.core.sli.SvcLogicContext;
+import org.onap.ccsdk.sli.core.sli.SvcLogicException;
+
+@RunWith(MockitoJUnitRunner.class)
+public class ChefAdapterImplHttpMethodTest {
+
+ private static final String CLIENT_PRIVATE_KEY_PATH = "/opt/onap/appc/chef/localhost/onap/testclient.pem";
+ private static final String RESULT_CODE_ATTR_KEY = "chefServerResult.code";
+ private static final String RESULT_MESSAGE_ATTR_KEY = "chefServerResult.message";
+ private static final String EXPECTED_RESPONSE_MSG = "chefResponseMessage";
+ private static final String ACTION_PARAM = "action";
+ private static final String REQUEST_BODY_DATA = "requestBodyData";
+ private static final Map<String, String> PARAMS = ImmutableMap
+ .of("username", "testclient",
+ "serverAddress", "localhost",
+ "organizations", "onap",
+ "chefAction", ACTION_PARAM,
+ "chefRequestBody", REQUEST_BODY_DATA);
+ @Mock
+ private PrivateKeyChecker privateKeyChecker;
+ @Mock
+ private ChefApiClientFactory chefApiClientFactory;
+ @Mock
+ private ChefApiClient chefApiClient;
+
+ private ChefAdapter chefAdapter;
+ private SvcLogicContext svcLogicContext;
+
+ @Before
+ public void setUp() {
+ chefAdapter = new ChefAdapterImpl(chefApiClientFactory, privateKeyChecker);
+ svcLogicContext = new SvcLogicContext();
+ }
+
+ @Test
+ public void chefGet_shouldExecuteHttpClient_andSetChefResponseInContext_whenPrivateKeyFileExists() {
+ assertSuccessfulChefHttpCallFor(() -> chefApiClient.get(ACTION_PARAM), this::chefGet);
+ }
+
+ @Test
+ public void chefGet_shouldNotExecuteHttpClient_andSetErrorResponseInContext_whenPrivateKeyFileDoesNotExist() {
+ assertNoChefCallOccurFor(this::chefGet);
+ }
+
+ @Test
+ public void chefDelete_shouldExecuteHttpClient_andSetChefResponseInContext_whenPrivateKeyFileExists() {
+ assertSuccessfulChefHttpCallFor(() -> chefApiClient.delete(ACTION_PARAM), this::chefDelete);
+ }
+
+ @Test
+ public void chefDelete_shouldNotExecuteHttpClient_andSetErrorResponseInContext_whenPrivateKeyFileDoesNotExist() {
+ assertNoChefCallOccurFor(this::chefDelete);
+ }
+
+ @Test
+ public void chefPut_shouldExecuteHttpClient_andSetChefResponseInContext_whenPrivateKeyFileExists() {
+ assertSuccessfulChefHttpCallFor(() -> chefApiClient.put(ACTION_PARAM, REQUEST_BODY_DATA), this::chefPut);
+ }
+
+ @Test
+ public void chefPut_shouldNotExecuteHttpClient_andSetErrorResponseInContext_whenPrivateKeyFileDoesNotExist() {
+ assertNoChefCallOccurFor(this::chefPut);
+ }
+
+ @Test
+ public void chefPost_shouldExecuteHttpClient_andSetChefResponseInContext_whenPrivateKeyFileExists() {
+ assertSuccessfulChefHttpCallFor(() -> chefApiClient.post(ACTION_PARAM, REQUEST_BODY_DATA), this::chefPost);
+ }
+
+ @Test
+ public void chefPost_shouldNotExecuteHttpClient_andSetErrorResponseInContext_whenPrivateKeyFileDoesNotExist() {
+ assertNoChefCallOccurFor(this::chefPost);
+ }
+
+ public void assertSuccessfulChefHttpCallFor(Supplier<ChefResponse> responseSupplier,
+ Consumer<ChefAdapter> chefAdapterCall) {
+ // GIVEN
+ given(privateKeyChecker.doesExist(CLIENT_PRIVATE_KEY_PATH)).willReturn(true);
+ given(chefApiClientFactory.create("https://localhost/organizations/onap",
+ "onap",
+ "testclient",
+ CLIENT_PRIVATE_KEY_PATH)).willReturn(chefApiClient);
+ given(responseSupplier.get()).willReturn(ChefResponse.create(HttpStatus.SC_OK, EXPECTED_RESPONSE_MSG));
+
+ // WHEN
+ chefAdapterCall.accept(chefAdapter);
+
+ // THEN
+ assertThat(svcLogicContext.getStatus()).isEqualTo("success");
+ assertThat(svcLogicContext.getAttribute(RESULT_CODE_ATTR_KEY)).isEqualTo(Integer.toString(HttpStatus.SC_OK));
+ assertThat(svcLogicContext.getAttribute(RESULT_MESSAGE_ATTR_KEY)).isEqualTo(EXPECTED_RESPONSE_MSG);
+ }
+
+ public void assertNoChefCallOccurFor(Consumer<ChefAdapter> chefAdapterCall) {
+ // GIVEN
+ given(privateKeyChecker.doesExist(CLIENT_PRIVATE_KEY_PATH)).willReturn(false);
+
+ // WHEN
+ chefAdapterCall.accept(chefAdapter);
+
+ // THEN
+ verifyZeroInteractions(chefApiClient);
+ assertThat(svcLogicContext.getStatus()).isEqualTo("success");
+ assertThat(svcLogicContext.getAttribute(RESULT_CODE_ATTR_KEY))
+ .isEqualTo(Integer.toString(HttpStatus.SC_INTERNAL_SERVER_ERROR));
+ assertThat(svcLogicContext.getAttribute(RESULT_MESSAGE_ATTR_KEY)).isEqualTo(
+ "Cannot find the private key in the APPC file system, please load the private key to "
+ + CLIENT_PRIVATE_KEY_PATH);
+ }
+
+ public void chefGet(ChefAdapter chefAdapter) {
+ try {
+ chefAdapter.chefGet(PARAMS, svcLogicContext);
+ } catch (SvcLogicException e) {
+ e.printStackTrace();
+ }
+ }
+
+ public void chefDelete(ChefAdapter chefAdapter) {
+ try {
+ chefAdapter.chefDelete(PARAMS, svcLogicContext);
+ } catch (SvcLogicException e) {
+ e.printStackTrace();
+ }
+ }
+
+ public void chefPost(ChefAdapter chefAdapter) {
+ try {
+ chefAdapter.chefPost(PARAMS, svcLogicContext);
+ } catch (SvcLogicException e) {
+ e.printStackTrace();
+ }
+ }
+
+ public void chefPut(ChefAdapter chefAdapter) {
+ try {
+ chefAdapter.chefPut(PARAMS, svcLogicContext);
+ } catch (SvcLogicException e) {
+ e.printStackTrace();
+ }
+ }
+}
\ No newline at end of file
SvcLogicContext svcLogicContext = new SvcLogicContext();
// WHEN
- ChefAdapter chefAdapter = new ChefAdapterImpl();
+ ChefAdapter chefAdapter = new ChefAdapterFactory().create();
chefAdapter.nodeObejctBuilder(params, svcLogicContext);
// THEN
SvcLogicContext svcLogicContext = new SvcLogicContext();
// WHEN
- ChefAdapter chefAdapter = new ChefAdapterImpl();
+ ChefAdapter chefAdapter = new ChefAdapterFactory().create();
chefAdapter.combineStrings(params, svcLogicContext);
// THEN
--- /dev/null
+/*
+ * ============LICENSE_START=======================================================
+ * ONAP : APPC
+ * ================================================================================
+ * Copyright (C) 2018 Nokia. All rights reserved.
+ * =============================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.appc.adapter.chef.impl;
+
+import static junit.framework.TestCase.assertFalse;
+import static junit.framework.TestCase.assertTrue;
+
+import org.junit.Test;
+
+public class PrivateKeyCheckerTest {
+
+ @Test
+ public void doesExist_shouldReturnTrue_whenFileExists() {
+ String pemFilePath = getClass().getResource("/testclient.pem").getPath();
+ assertTrue(new PrivateKeyChecker().doesExist(pemFilePath));
+ }
+
+ @Test
+ public void doesExist_shouldReturnFalse_whenFileDoesNotExist() {
+ assertFalse(new PrivateKeyChecker().doesExist("dummyPemFile"));
+ }
+
+}
\ No newline at end of file
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
+import org.onap.appc.adapter.chef.ChefAdapter;
import org.onap.appc.exceptions.APPCException;
import com.att.cdp.exceptions.ZoneException;
import org.onap.ccsdk.sli.core.sli.SvcLogicContext;
public class TestChefAdapterImpl {
private SvcLogicContext svcContext;
- private ChefAdapterImpl adapter;
+ private ChefAdapter adapter;
private Map<String, String> params;
private String getAttribute;
@Before
public void setup() {
- adapter = new ChefAdapterImpl();
+ adapter = new ChefAdapterFactory().create();
params = new HashMap<>();
params.put("pemPath",
"/src/test/resources/testclient.pem");
Code Review / appc.git / commitdiff