Sonar major issues

 Replace with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?id=org.onap.so%3Aso&open=AWSynF0AwGn37JfbvuI9&resolved=false&rules=squid%3AS2293
Location: src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/service/ServicePluginFactory.java
Line: L216 L218 L220 L223 L265 L281 L294

Change-Id: I413e046f87435b6b5225a2202f03ab2c3232e807
Issue-ID: SO-757
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>

diff --git a/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/service/ServicePluginFactory.java b/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/service/ServicePluginFactory.java
index 344d8cd..96768ba 100644 (file)
--- a/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/service/ServicePluginFactory.java
+++ b/bpmn/MSOInfrastructureBPMN/src/main/java/org/openecomp/mso/bpmn/infrastructure/workflow/service/ServicePluginFactory.java
@@ -213,14 +213,14 @@ public class ServicePluginFactory {
        }
 
        private List<Object> queryTerminalPointsFromServiceProviderSystem(String srcLocation, String dstLocation) {
-               Map<String, String> locationSrc = new HashMap<String, String>();
+               Map<String, String> locationSrc = new HashMap<>();
                locationSrc.put("location", srcLocation);
-               Map<String, String> locationDst = new HashMap<String, String>();
+               Map<String, String> locationDst = new HashMap<>();
                locationDst.put("location", dstLocation);
-               List<Map<String, String>> locations = new ArrayList<Map<String, String>>();
+               List<Map<String, String>> locations = new ArrayList<>();
                locations.add(locationSrc);
                locations.add(locationDst);
-               List<Object> returnList = new ArrayList<Object>();
+               List<Object> returnList = new ArrayList<>();
                String reqContent = getJsonString(locations);
                String url = getThirdSPEndPoint();
                String responseContent = sendRequest(url, "POST", reqContent);
@@ -262,7 +262,7 @@ public class ServicePluginFactory {
                Map<String, Object> serviceObject = (Map<String, Object>) uuiObject.get("service");
                Map<String, Object> serviceParametersObject = (Map<String, Object>) serviceObject.get("parameters");
                Map<String, Object> serviceRequestInputs = (Map<String, Object>) serviceParametersObject.get("requestInputs");
-               Map<String, Object> oofQueryObject = new HashMap<String, Object>();
+               Map<String, Object> oofQueryObject = new HashMap<>();
                List<Object> resources = (List<Object>) serviceParametersObject.get("resources");
                oofQueryObject.put("src-access-provider-id", serviceRequestInputs.get("inner-src-access-provider-id"));
                oofQueryObject.put("src-access-client-id", serviceRequestInputs.get("inner-src-access-client-id"));
@@ -278,7 +278,7 @@ public class ServicePluginFactory {
                String url = getOOFCalcEndPoint();
                String responseContent = sendRequest(url, "POST", oofRequestReq);
 
-               List<Object> returnList = new ArrayList<Object>();
+               List<Object> returnList = new ArrayList<>();
                if (null != responseContent) {
                        returnList = getJsonObject(responseContent, List.class);
                }
@@ -291,7 +291,7 @@ public class ServicePluginFactory {
        }
        
        private Map<String, Object> getReturnRoute(List<Object> returnList){
-               Map<String, Object> returnRoute = new HashMap<String,Object>();
+               Map<String, Object> returnRoute = new HashMap<>();
                for(Object returnVpn :returnList){
                        Map<String, Object> returnVpnInfo = (Map<String, Object>) returnVpn;
                    String accessTopoId = (String)returnVpnInfo.get("access-topology-id");