Unit test fails when port number occupied 29/107729/1
authorliamfallon <liam.fallon@est.tech>
Fri, 15 May 2020 10:15:11 +0000 (11:15 +0100)
committerliamfallon <liam.fallon@est.tech>
Fri, 15 May 2020 10:15:15 +0000 (11:15 +0100)
If the port specified in the allocateAddress() is occupied, the method
returns the next highest available port. The unit test is changed to
reflect this behaviour.

Issue-ID: POLICY-1916
Change-Id: I02f63476d5f8f3ef2b2363afb3e23de04264e810
Signed-off-by: liamfallon <liam.fallon@est.tech>
core/core-infrastructure/src/test/java/org/onap/policy/apex/core/infrastructure/messaging/MessagingUtilsTest.java

index 91b34e2..9eaaeee 100644 (file)
@@ -19,7 +19,9 @@
  */
 package org.onap.policy.apex.core.infrastructure.messaging;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
 
 import java.io.IOException;
 import java.net.InetAddress;
@@ -32,30 +34,31 @@ public class MessagingUtilsTest {
 
     @Test
     public void testCheckPort() throws UnknownHostException, IOException {
-        assertEquals(1,MessagingUtils.checkPort(1));
-        assertEquals(1,MessagingUtils.findPort(1));
+        assertEquals(1, MessagingUtils.checkPort(1));
+        assertEquals(1, MessagingUtils.findPort(1));
     }
 
     @Test(expected = IllegalArgumentException.class)
     public void testIllegalArgumentException() {
-        assertEquals(1,MessagingUtils.findPort(65536));
+        assertEquals(1, MessagingUtils.findPort(65536));
     }
 
     @Test
     public void testGetHost() throws UnknownHostException {
         InetAddress host = InetAddress.getLocalHost();
-        assertEquals(host,MessagingUtils.getHost());
+        assertEquals(host, MessagingUtils.getHost());
     }
 
     @Test
     public void testValidAllocateAddress() throws UnknownHostException {
         assertNotNull(MessagingUtils.getLocalHostLanAddress());
-        assertEquals(3306,MessagingUtils.allocateAddress(3306));
+        int allocatedPort = MessagingUtils.allocateAddress(3306);
+        assertTrue(allocatedPort >= 3306 && allocatedPort < 65536);
     }
 
     @Test(expected = IllegalArgumentException.class)
     public void testInvalidAllocateAddress() {
-        assertEquals(1,MessagingUtils.allocateAddress(1));
+        assertEquals(1, MessagingUtils.allocateAddress(1));
     }
 
     @Test