fixed sonar issue in SNIROResponse.java

fixed sonar issue as detailed in SO-976

Issue-ID: SO-976
Change-Id: If9710595248969bf72a55cfda759067439e6d2d4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>

diff --git a/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/sdncrest/SNIROResponse.java b/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/sdncrest/SNIROResponse.java
index 72a2328..4c85241 100644 (file)
--- a/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/sdncrest/SNIROResponse.java
+++ b/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/sdncrest/SNIROResponse.java
@@ -4,6 +4,8 @@
  * ================================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
+ * Modifications Copyright (C) 2018 IBM.
+ * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -65,7 +67,7 @@ public class SNIROResponse {
 
                String bpUrl = env.getProperty(Constants.BPEL_REST_URL_PROP, ""); 
 
-               if (bpUrl == null || bpUrl.equals("")) {
+               if (bpUrl == null || ("").equals(bpUrl)) {
                        String error = "Missing configuration for: " + Constants.BPEL_REST_URL_PROP;
                        LOGGER.error(MessageEnum.RA_SDNC_MISS_CONFIG_PARAM, Constants.BPEL_REST_URL_PROP, "SDNC", "",
                                MsoLogger.ErrorCode.DataError, "Missing config param");