Merge "Controller Blueprints Microservice"
authorDan Timoney <dt5972@att.com>
Tue, 4 Sep 2018 15:14:26 +0000 (15:14 +0000)
committerGerrit Code Review <gerrit@onap.org>
Tue, 4 Sep 2018 15:14:26 +0000 (15:14 +0000)
42 files changed:
ms/controllerblueprints/application/src/test/java/org/onap/ccsdk/apps/controllerblueprints/ControllerBluprintsApplicationTest.java
ms/controllerblueprints/modules/core/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/BluePrintConstants.kt
ms/controllerblueprints/modules/core/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/service/BluePrintEnhancerService.kt
ms/controllerblueprints/modules/core/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/service/BluePrintRepoService.kt
ms/controllerblueprints/modules/core/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/utils/JacksonReactorUtils.kt [new file with mode: 0644]
ms/controllerblueprints/modules/core/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/utils/JacksonUtils.kt
ms/controllerblueprints/modules/core/src/test/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/service/BluePrintRepoFileServiceTest.kt
ms/controllerblueprints/modules/core/src/test/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/utils/JacksonReactorUtilsTest.kt [new file with mode: 0644]
ms/controllerblueprints/modules/resource-dict/load/resource_dictionary/db-source.json
ms/controllerblueprints/modules/resource-dict/load/resource_dictionary/default-source.json
ms/controllerblueprints/modules/resource-dict/load/resource_dictionary/input-source.json
ms/controllerblueprints/modules/resource-dict/load/resource_dictionary/mdsal-source.json
ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/ResourceDictionaryConstants.kt
ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceAssignmentEnhancerService.kt [new file with mode: 0644]
ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceAssignmentValidationService.kt
ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceDefinitionRepoService.kt [new file with mode: 0644]
ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceDefinitionValidationService.kt
ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/utils/BulkResourceSequencingUtils.kt
ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/utils/ResourceDictionaryUtils.kt
ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/ResourceDefinitionTest.java
ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceAssignmentEnhancerServiceTest.java [new file with mode: 0644]
ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceAssignmentValidationServiceTest.kt
ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceDefinitionRepoServiceTest.java [new file with mode: 0644]
ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/utils/ResourceDictionaryUtilsTest.java
ms/controllerblueprints/modules/resource-dict/src/test/resources/enrich/simple-enrich.json [new file with mode: 0644]
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/AutoResourceMappingService.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/BluePrintEnhancerService.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelCreateService.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/DataBaseInitService.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/SchemaGeneratorService.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ServiceTemplateService.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ConfigModelContent.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ResourceDictionary.java
ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/utils/ConfigModelUtils.java
ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/common/SchemaGeneratorServiceTest.java
ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/rs/ConfigModelRestTest.java
ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/rs/ModelTypeRestTest.java
ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/rs/ResourceDictionaryRestTest.java
ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/rs/ServiceTemplateRestTest.java
ms/controllerblueprints/modules/service/src/test/java/org/onap/ccsdk/apps/controllerblueprints/service/validator/ServiceTemplateValidationTest.java

index 26b943b..32d06d2 100644 (file)
@@ -21,8 +21,8 @@ import org.junit.Before;
 import org.junit.Test;\r
 import org.junit.runner.RunWith;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModel;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.beans.factory.annotation.Autowired;\r
 import org.springframework.boot.test.context.SpringBootTest;\r
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;\r
@@ -35,7 +35,7 @@ import static org.assertj.core.api.Assertions.assertThat;
 @RunWith(SpringRunner.class)\r
 @SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT)\r
 public class ControllerBluprintsApplicationTest {\r
-    private static Logger log = LoggerFactory.getLogger(ControllerBluprintsApplicationTest.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ControllerBluprintsApplicationTest.class);\r
 \r
     @Autowired\r
     private TestRestTemplate restTemplate;\r
index 85f1579..2e3edb6 100644 (file)
@@ -54,6 +54,8 @@ object BluePrintConstants {
     const val PATH_ATTRIBUTES: String = "attributes"\r
     const val PATH_ARTIFACTS: String = "artifacts"\r
 \r
+    const val MODEL_DIR_MODEL_TYPE: String = "model_type"\r
+\r
     const val MODEL_DEFINITION_TYPE_NODE_TYPE: String = "node_type"\r
     const val MODEL_DEFINITION_TYPE_ARTIFACT_TYPE: String = "artifact_type"\r
     const val MODEL_DEFINITION_TYPE_CAPABILITY_TYPE: String = "capability_type"\r
index c90d659..f38c317 100644 (file)
@@ -23,6 +23,7 @@ import org.onap.ccsdk.apps.controllerblueprints.core.data.*
 import org.onap.ccsdk.apps.controllerblueprints.core.format\r
 import com.att.eelf.configuration.EELFLogger\r
 import com.att.eelf.configuration.EELFManager\r
+import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonReactorUtils\r
 import java.io.Serializable\r
 \r
 /**\r
@@ -35,14 +36,23 @@ interface BluePrintEnhancerService : Serializable {
     @Throws(BluePrintException::class)\r
     fun enhance(content: String): ServiceTemplate\r
 \r
-    @Throws(BluePrintException::class)\r
-    fun enhance(serviceTemplate: ServiceTemplate): ServiceTemplate\r
-\r
     /**\r
      * Read Blueprint from CSAR structure Directory\r
      */\r
     @Throws(BluePrintException::class)\r
     fun enhance(fileName: String, basePath: String): ServiceTemplate\r
+\r
+    @Throws(BluePrintException::class)\r
+    fun enhance(serviceTemplate: ServiceTemplate): ServiceTemplate\r
+\r
+    @Throws(BluePrintException::class)\r
+    fun enrichNodeTemplate(nodeTemplateName: String, nodeTemplate: NodeTemplate)\r
+\r
+    @Throws(BluePrintException::class)\r
+    fun enrichNodeType(nodeTypeName: String, nodeType: NodeType)\r
+\r
+    @Throws(BluePrintException::class)\r
+    fun enrichPropertyDefinition(propertyName: String, propertyDefinition: PropertyDefinition)\r
 }\r
 \r
 open class BluePrintEnhancerDefaultService(val bluePrintRepoService: BluePrintRepoService) : BluePrintEnhancerService {\r
@@ -51,20 +61,25 @@ open class BluePrintEnhancerDefaultService(val bluePrintRepoService: BluePrintRe
 \r
     lateinit var serviceTemplate: ServiceTemplate\r
 \r
+    @Throws(BluePrintException::class)\r
     override fun enhance(content: String): ServiceTemplate {\r
-        TODO("not implemented") //To change body of created functions use File | Settings | File Templates.\r
+        return JacksonReactorUtils.readValueFromFile(content, ServiceTemplate::class.java).map { serviceTemplate ->\r
+            enhance(serviceTemplate!!)\r
+        }.block()!!\r
     }\r
 \r
+    @Throws(BluePrintException::class)\r
     override fun enhance(fileName: String, basePath: String): ServiceTemplate {\r
         TODO("not implemented") //To change body of created functions use File | Settings | File Templates.\r
     }\r
 \r
+    @Throws(BluePrintException::class)\r
     override fun enhance(serviceTemplate: ServiceTemplate): ServiceTemplate {\r
         this.serviceTemplate = serviceTemplate\r
         initialCleanUp()\r
         enrichTopologyTemplate(serviceTemplate)\r
 \r
-       // log.info("Enriched Blueprint :\n {}", JacksonUtils.getJson(serviceTemplate, true))\r
+        // log.info("Enriched Blueprint :\n {}", JacksonUtils.getJson(serviceTemplate, true))\r
         return this.serviceTemplate\r
     }\r
 \r
@@ -79,6 +94,7 @@ open class BluePrintEnhancerDefaultService(val bluePrintRepoService: BluePrintRe
 \r
     }\r
 \r
+    @Throws(BluePrintException::class)\r
     open fun enrichTopologyTemplate(serviceTemplate: ServiceTemplate) {\r
         serviceTemplate.topologyTemplate?.let { topologyTemplate ->\r
             enrichTopologyTemplateInputs(topologyTemplate)\r
@@ -86,6 +102,7 @@ open class BluePrintEnhancerDefaultService(val bluePrintRepoService: BluePrintRe
         }\r
     }\r
 \r
+    @Throws(BluePrintException::class)\r
     open fun enrichTopologyTemplateInputs(topologyTemplate: TopologyTemplate) {\r
         topologyTemplate.inputs?.let { inputs ->\r
             enrichPropertyDefinitions(inputs)\r
@@ -99,7 +116,7 @@ open class BluePrintEnhancerDefaultService(val bluePrintRepoService: BluePrintRe
     }\r
 \r
     @Throws(BluePrintException::class)\r
-    open fun enrichNodeTemplate(nodeTemplateName: String, nodeTemplate: NodeTemplate) {\r
+    override fun enrichNodeTemplate(nodeTemplateName: String, nodeTemplate: NodeTemplate) {\r
         val nodeTypeName = nodeTemplate.type\r
         // Get NodeType from Repo and Update Service Template\r
         val nodeType = populateNodeType(nodeTypeName)\r
@@ -111,7 +128,8 @@ open class BluePrintEnhancerDefaultService(val bluePrintRepoService: BluePrintRe
         enrichNodeTemplateArtifactDefinition(nodeTemplateName, nodeTemplate)\r
     }\r
 \r
-    open fun enrichNodeType(nodeTypeName: String, nodeType: NodeType) {\r
+    @Throws(BluePrintException::class)\r
+    override fun enrichNodeType(nodeTypeName: String, nodeType: NodeType) {\r
 \r
         // NodeType Property Definitions\r
         enrichNodeTypeProperties(nodeTypeName, nodeType)\r
@@ -132,7 +150,7 @@ open class BluePrintEnhancerDefaultService(val bluePrintRepoService: BluePrintRe
 \r
     open fun enrichNodeTypeRequirements(nodeTypeName: String, nodeType: NodeType) {\r
 \r
-        nodeType.requirements?.forEach { requirementDefinitionName, requirementDefinition ->\r
+        nodeType.requirements?.forEach { _, requirementDefinition ->\r
             // Populate Requirement Node\r
             requirementDefinition.node?.let { requirementNodeTypeName ->\r
                 // Get Requirement NodeType from Repo and Update Service Template\r
@@ -187,7 +205,8 @@ open class BluePrintEnhancerDefaultService(val bluePrintRepoService: BluePrintRe
         }\r
     }\r
 \r
-    open fun enrichPropertyDefinition(propertyName: String, propertyDefinition: PropertyDefinition) {\r
+    @Throws(BluePrintException::class)\r
+    override fun enrichPropertyDefinition(propertyName: String, propertyDefinition: PropertyDefinition) {\r
         val propertyType = propertyDefinition.type\r
         if (BluePrintTypes.validPrimitiveTypes().contains(propertyType)) {\r
 \r
index 8d2557c..e1d1eac 100644 (file)
 \r
 package org.onap.ccsdk.apps.controllerblueprints.core.service\r
 \r
-import com.google.common.base.Preconditions\r
-import org.apache.commons.io.FileUtils\r
-import org.apache.commons.lang3.StringUtils\r
 import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintConstants\r
 import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintException\r
 import org.onap.ccsdk.apps.controllerblueprints.core.data.*\r
-import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils\r
 import com.att.eelf.configuration.EELFLogger\r
 import com.att.eelf.configuration.EELFManager\r
+import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonReactorUtils\r
 import reactor.core.publisher.Mono\r
 import java.io.File\r
 import java.io.Serializable\r
@@ -57,15 +54,15 @@ interface BluePrintRepoService : Serializable {
 }\r
 \r
 \r
-class BluePrintRepoFileService(val basePath: String) : BluePrintRepoService {\r
+open class BluePrintRepoFileService(modelTypePath: String) : BluePrintRepoService {\r
 \r
-    private val log: EELFLogger = EELFManager.getInstance().getLogger(this::class.toString())\r
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(BluePrintRepoFileService::class.toString())\r
 \r
-    private val dataTypePath = basePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_DATA_TYPE)\r
-    private val nodeTypePath = basePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_NODE_TYPE)\r
-    private val artifactTypePath = basePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_ARTIFACT_TYPE)\r
-    private val capabilityTypePath = basePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_CAPABILITY_TYPE)\r
-    private val relationshipTypePath = basePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_RELATIONSHIP_TYPE)\r
+    private val dataTypePath = modelTypePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_DATA_TYPE)\r
+    private val nodeTypePath = modelTypePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_NODE_TYPE)\r
+    private val artifactTypePath = modelTypePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_ARTIFACT_TYPE)\r
+    private val capabilityTypePath = modelTypePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_CAPABILITY_TYPE)\r
+    private val relationshipTypePath = modelTypePath.plus(BluePrintConstants.PATH_DIVIDER).plus(BluePrintConstants.MODEL_DEFINITION_TYPE_RELATIONSHIP_TYPE)\r
     private val extension = ".json"\r
 \r
     override fun getDataType(dataTypeName: String): Mono<DataType>? {\r
@@ -98,17 +95,6 @@ class BluePrintRepoFileService(val basePath: String) : BluePrintRepoService {
     }\r
 \r
     private fun <T> getModelType(fileName: String, valueType: Class<T>): Mono<T> {\r
-        return getFileContent(fileName).map { content ->\r
-            Preconditions.checkArgument(StringUtils.isNotBlank(content),\r
-                    String.format("Failed to get model content for file (%s)", fileName))\r
-\r
-            JacksonUtils.readValue(content, valueType)\r
-                    ?: throw BluePrintException(String.format("Failed to get model file from content for file (%s)", fileName))\r
-\r
-        }\r
-    }\r
-\r
-    private fun getFileContent(fileName: String): Mono<String> {\r
-        return Mono.just(FileUtils.readFileToString(File(fileName), Charset.defaultCharset()))\r
+        return JacksonReactorUtils.readValueFromFile(fileName, valueType)\r
     }\r
 }
\ No newline at end of file
diff --git a/ms/controllerblueprints/modules/core/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/utils/JacksonReactorUtils.kt b/ms/controllerblueprints/modules/core/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/utils/JacksonReactorUtils.kt
new file mode 100644 (file)
index 0000000..0ed9017
--- /dev/null
@@ -0,0 +1,108 @@
+/*\r
+ *  Copyright Â© 2017-2018 AT&T Intellectual Property.\r
+ *\r
+ *  Licensed under the Apache License, Version 2.0 (the "License");\r
+ *  you may not use this file except in compliance with the License.\r
+ *  You may obtain a copy of the License at\r
+ *\r
+ *      http://www.apache.org/licenses/LICENSE-2.0\r
+ *\r
+ *  Unless required by applicable law or agreed to in writing, software\r
+ *  distributed under the License is distributed on an "AS IS" BASIS,\r
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r
+ *  See the License for the specific language governing permissions and\r
+ *  limitations under the License.\r
+ */\r
+\r
+package org.onap.ccsdk.apps.controllerblueprints.core.utils\r
+\r
+import com.att.eelf.configuration.EELFLogger\r
+import com.att.eelf.configuration.EELFManager\r
+import com.fasterxml.jackson.databind.JsonNode\r
+import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper\r
+import reactor.core.publisher.Mono\r
+import reactor.core.publisher.toMono\r
+\r
+object JacksonReactorUtils {\r
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(this::class.toString())\r
+\r
+    @JvmStatic\r
+    fun getContent(fileName: String): Mono<String> {\r
+        return JacksonUtils.getContent(fileName).toMono()\r
+    }\r
+\r
+    @JvmStatic\r
+    fun getClassPathFileContent(fileName: String): Mono<String> {\r
+        return JacksonUtils.getClassPathFileContent(fileName).toMono()\r
+    }\r
+\r
+    @JvmStatic\r
+    fun <T> readValue(content: String, valueType: Class<T>): Mono<T> {\r
+        return Mono.just(jacksonObjectMapper().readValue(content, valueType))\r
+    }\r
+\r
+    @JvmStatic\r
+    fun jsonNode(content: String): Mono<JsonNode> {\r
+        return Mono.just(jacksonObjectMapper().readTree(content))\r
+    }\r
+\r
+    @JvmStatic\r
+    fun getJson(any: kotlin.Any, pretty: Boolean = false): Mono<String> {\r
+        return Mono.just(JacksonUtils.getJson(any, pretty))\r
+    }\r
+\r
+    @JvmStatic\r
+    fun <T> getListFromJson(content: String, valueType: Class<T>): Mono<List<T>> {\r
+        val objectMapper = jacksonObjectMapper()\r
+        val javaType = objectMapper.typeFactory.constructCollectionType(List::class.java, valueType)\r
+        return objectMapper.readValue<List<T>>(content, javaType).toMono()\r
+    }\r
+\r
+    @JvmStatic\r
+    fun <T> readValueFromFile(fileName: String, valueType: Class<T>): Mono<T> {\r
+        return getContent(fileName)\r
+                .flatMap { content ->\r
+                    readValue(content, valueType)\r
+                }\r
+    }\r
+\r
+    @JvmStatic\r
+    fun <T> readValueFromClassPathFile(fileName: String, valueType: Class<T>): Mono<T> {\r
+        return getClassPathFileContent(fileName)\r
+                .flatMap { content ->\r
+                    readValue(content, valueType)\r
+                }\r
+    }\r
+\r
+    @JvmStatic\r
+    fun jsonNodeFromFile(fileName: String): Mono<JsonNode> {\r
+        return getContent(fileName)\r
+                .flatMap { content ->\r
+                    jsonNode(content)\r
+                }\r
+    }\r
+\r
+    @JvmStatic\r
+    fun jsonNodeFromClassPathFile(fileName: String): Mono<JsonNode> {\r
+        return getClassPathFileContent(fileName)\r
+                .flatMap { content ->\r
+                    jsonNode(content)\r
+                }\r
+    }\r
+\r
+    @JvmStatic\r
+    fun <T> getListFromFile(fileName: String, valueType: Class<T>): Mono<List<T>> {\r
+        return getContent(fileName)\r
+                .flatMap { content ->\r
+                    getListFromJson(content, valueType)\r
+                }\r
+    }\r
+\r
+    @JvmStatic\r
+    fun <T> getListFromClassPathFile(fileName: String, valueType: Class<T>): Mono<List<T>> {\r
+        return getClassPathFileContent(fileName)\r
+                .flatMap { content ->\r
+                    getListFromJson(content, valueType)\r
+                }\r
+    }\r
+}
\ No newline at end of file
index 7e72744..5075e72 100644 (file)
@@ -23,9 +23,6 @@ import com.fasterxml.jackson.annotation.JsonInclude
 import com.fasterxml.jackson.core.type.TypeReference\r
 import com.fasterxml.jackson.databind.JsonNode\r
 import com.fasterxml.jackson.databind.SerializationFeature\r
-import com.fasterxml.jackson.databind.node.ArrayNode\r
-import com.fasterxml.jackson.databind.node.NullNode\r
-import com.fasterxml.jackson.databind.node.ObjectNode\r
 import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper\r
 import org.apache.commons.io.FileUtils\r
 import org.apache.commons.io.IOUtils\r
@@ -52,6 +49,17 @@ object JacksonUtils {
         return jacksonObjectMapper().readValue(content, valueType)\r
     }\r
 \r
+    @JvmStatic\r
+    fun getContent(fileName: String): String {\r
+        return File(fileName).readText(Charsets.UTF_8)\r
+    }\r
+\r
+    @JvmStatic\r
+    fun getClassPathFileContent(fileName: String): String {\r
+        return IOUtils.toString(JacksonUtils::class.java.classLoader\r
+                .getResourceAsStream(fileName), Charset.defaultCharset())\r
+    }\r
+\r
     @JvmStatic\r
     fun <T> readValueFromFile(fileName: String, valueType: Class<T>): T? {\r
         val content: String = FileUtils.readFileToString(File(fileName), Charset.defaultCharset())\r
@@ -61,8 +69,7 @@ object JacksonUtils {
 \r
     @JvmStatic\r
     fun <T> readValueFromClassPathFile(fileName: String, valueType: Class<T>): T? {\r
-        val content: String = IOUtils.toString(JacksonUtils::class.java.classLoader.getResourceAsStream(fileName), Charset.defaultCharset())\r
-                ?: throw BluePrintException(String.format("Failed to read json file : %s", fileName))\r
+        val content: String = getClassPathFileContent(fileName)\r
         return readValue(content, valueType)\r
     }\r
 \r
@@ -71,8 +78,7 @@ object JacksonUtils {
 \r
     @JvmStatic\r
     fun jsonNodeFromClassPathFile(fileName: String): JsonNode {\r
-        val content: String = IOUtils.toString(JacksonUtils::class.java.classLoader.getResourceAsStream(fileName), Charset.defaultCharset())\r
-                ?: throw BluePrintException(String.format("Failed to read json file : %s", fileName))\r
+        val content: String = getClassPathFileContent(fileName)\r
         return jsonNode(content)\r
     }\r
 \r
@@ -119,8 +125,7 @@ object JacksonUtils {
 \r
     @JvmStatic\r
     fun <T> getListFromClassPathFile(fileName: String, valueType: Class<T>): List<T>? {\r
-        val content: String = IOUtils.toString(JacksonUtils::class.java.classLoader.getResourceAsStream(fileName), Charset.defaultCharset())\r
-                ?: throw BluePrintException(String.format("Failed to read json file : %s", fileName))\r
+        val content: String = getClassPathFileContent(fileName)\r
         return getListFromJson(content, valueType)\r
     }\r
 \r
@@ -144,39 +149,25 @@ object JacksonUtils {
     @JvmStatic\r
     fun checkJsonNodeValueOfPrimitiveType(primitiveType: String, jsonNode: JsonNode): Boolean {\r
         when (primitiveType) {\r
-            BluePrintConstants.DATA_TYPE_STRING -> {\r
-                return jsonNode.isTextual\r
-            }\r
-            BluePrintConstants.DATA_TYPE_BOOLEAN -> {\r
-                return jsonNode.isBoolean\r
-            }\r
-            BluePrintConstants.DATA_TYPE_INTEGER -> {\r
-                return jsonNode.isInt\r
-            }\r
-            BluePrintConstants.DATA_TYPE_FLOAT -> {\r
-                return jsonNode.isDouble\r
-            }\r
-            BluePrintConstants.DATA_TYPE_TIMESTAMP -> {\r
-                return jsonNode.isTextual\r
-            }\r
-            else ->\r
-                return false\r
+            BluePrintConstants.DATA_TYPE_STRING -> return jsonNode.isTextual\r
+            BluePrintConstants.DATA_TYPE_BOOLEAN -> return jsonNode.isBoolean\r
+            BluePrintConstants.DATA_TYPE_INTEGER -> return jsonNode.isInt\r
+            BluePrintConstants.DATA_TYPE_FLOAT -> return jsonNode.isDouble\r
+            BluePrintConstants.DATA_TYPE_TIMESTAMP -> return jsonNode.isTextual\r
+            else -> return false\r
         }\r
     }\r
 \r
     @JvmStatic\r
     fun checkJsonNodeValueOfCollectionType(type: String, jsonNode: JsonNode): Boolean {\r
         when (type) {\r
-            BluePrintConstants.DATA_TYPE_LIST ->\r
-                return jsonNode.isArray\r
-            BluePrintConstants.DATA_TYPE_MAP ->\r
-                return jsonNode.isContainerNode\r
-            else ->\r
-                return false\r
+            BluePrintConstants.DATA_TYPE_LIST -> return jsonNode.isArray\r
+            BluePrintConstants.DATA_TYPE_MAP -> return jsonNode.isContainerNode\r
+            else -> return false\r
         }\r
 \r
     }\r
-\r
+/*\r
     @JvmStatic\r
     fun populatePrimitiveValues(key: String, value: Any, primitiveType: String, objectNode: ObjectNode) {\r
         if (BluePrintConstants.DATA_TYPE_BOOLEAN == primitiveType) {\r
@@ -253,4 +244,5 @@ object JacksonUtils {
             objectNode.set(key, nodeValue)\r
         }\r
     }\r
+    */\r
 }
\ No newline at end of file
index 081f4fe..88aea91 100644 (file)
@@ -28,30 +28,30 @@ import kotlin.test.assertNotNull
  */\r
 class BluePrintRepoFileServiceTest {\r
 \r
-    val basePath = "load/model_type"\r
+    private val basePath = "load/model_type"\r
     private val bluePrintEnhancerRepoFileService = BluePrintRepoFileService(basePath)\r
 \r
     @Test\r
     fun testGetDataType() {\r
-        val dataType = bluePrintEnhancerRepoFileService.getDataType("dt-v4-aggregate")\r
+        val dataType = bluePrintEnhancerRepoFileService.getDataType("dt-v4-aggregate")?.block()\r
         assertNotNull(dataType, "Failed to get DataType from repo")\r
     }\r
 \r
     @Test\r
     fun testGetNodeType() {\r
-        val nodeType = bluePrintEnhancerRepoFileService.getNodeType("component-resource-assignment")\r
+        val nodeType = bluePrintEnhancerRepoFileService.getNodeType("component-resource-assignment")?.block()\r
         assertNotNull(nodeType, "Failed to get NodeType from repo")\r
     }\r
 \r
     @Test\r
     fun testGetArtifactType() {\r
-        val nodeType = bluePrintEnhancerRepoFileService.getArtifactType("artifact-template-velocity")\r
+        val nodeType = bluePrintEnhancerRepoFileService.getArtifactType("artifact-template-velocity")?.block()\r
         assertNotNull(nodeType, "Failed to get ArtifactType from repo")\r
     }\r
 \r
     @Test(expected = FileNotFoundException::class)\r
     fun testModelNotFound() {\r
-        val dataType = bluePrintEnhancerRepoFileService.getDataType("dt-not-found")\r
+        val dataType = bluePrintEnhancerRepoFileService.getDataType("dt-not-found")?.block()\r
         assertNotNull(dataType, "Failed to get DataType from repo")\r
     }\r
 }
\ No newline at end of file
diff --git a/ms/controllerblueprints/modules/core/src/test/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/utils/JacksonReactorUtilsTest.kt b/ms/controllerblueprints/modules/core/src/test/kotlin/org/onap/ccsdk/apps/controllerblueprints/core/utils/JacksonReactorUtilsTest.kt
new file mode 100644 (file)
index 0000000..d13caa5
--- /dev/null
@@ -0,0 +1,51 @@
+/*\r
+ *  Copyright Â© 2017-2018 AT&T Intellectual Property.\r
+ *\r
+ *  Licensed under the Apache License, Version 2.0 (the "License");\r
+ *  you may not use this file except in compliance with the License.\r
+ *  You may obtain a copy of the License at\r
+ *\r
+ *      http://www.apache.org/licenses/LICENSE-2.0\r
+ *\r
+ *  Unless required by applicable law or agreed to in writing, software\r
+ *  distributed under the License is distributed on an "AS IS" BASIS,\r
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r
+ *  See the License for the specific language governing permissions and\r
+ *  limitations under the License.\r
+ */\r
+\r
+package org.onap.ccsdk.apps.controllerblueprints.core.utils\r
+\r
+import com.att.eelf.configuration.EELFLogger\r
+import com.att.eelf.configuration.EELFManager\r
+import org.junit.Test\r
+import org.onap.ccsdk.apps.controllerblueprints.core.data.ServiceTemplate\r
+import java.io.FileNotFoundException\r
+import kotlin.test.assertEquals\r
+import kotlin.test.assertNotNull\r
+\r
+class JacksonReactorUtilsTest {\r
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(this::class.toString())\r
+    @Test\r
+    fun testReadValues() {\r
+\r
+        val serviceTemplate = JacksonReactorUtils.readValueFromFile("load/blueprints/baseconfiguration/Definitions/activation-blueprint.json",\r
+                ServiceTemplate::class.java).block()\r
+\r
+        assertNotNull(serviceTemplate, "Failed to simple transform Service Template")\r
+        assertEquals(true, serviceTemplate is ServiceTemplate, "failed to get Service Template instance")\r
+\r
+        val jsonContent = JacksonReactorUtils.getJson(serviceTemplate!!, true).block()\r
+        assertNotNull(jsonContent, "Failed to get json content")\r
+\r
+        val jsonNode = JacksonReactorUtils.jsonNodeFromFile("load/blueprints/baseconfiguration/Definitions/activation-blueprint.json")\r
+                .block()\r
+        assertNotNull(jsonContent, "Failed to get json Node")\r
+    }\r
+\r
+    @Test(expected = FileNotFoundException::class)\r
+    fun testReadValuesFailure() {\r
+        JacksonReactorUtils.jsonNodeFromFile("load/blueprints/not-found.json")\r
+                .block()\r
+    }\r
+}
\ No newline at end of file
index 91921b6..1c47f37 100644 (file)
@@ -1,6 +1,6 @@
 {\r
   "tags": "v4-ip-type, tosca.datatypes.Root, data_type, brindasanth@onap.com",\r
-  "name": "v4-ip-type",\r
+  "name": "default-source",\r
   "property" :{\r
     "description": "name of the ",\r
     "type": "string"\r
index c34c252..676d92f 100644 (file)
@@ -1,5 +1,5 @@
 {\r
-       "name": "action-name",\r
+       "name": "input-source",\r
        "property" :{\r
                "description": "name of the ",\r
                "type": "string"\r
index 413d904..b49146a 100644 (file)
@@ -1,6 +1,6 @@
 {\r
   "tags": "oam-local-ipv4-address",\r
-  "name": "oam-local-ipv4-address",\r
+  "name": "mdsal-source",\r
   "property" :{\r
     "description": "based on service-instance-id,network-role,v4-ip-type and vm-type get the ipv4-gateway-prefix from the SDN-GC mdsal",\r
     "type": "string"\r
index 9b89f6f..aa6a9fb 100644 (file)
@@ -25,6 +25,8 @@ object ResourceDictionaryConstants {
     const val SOURCE_DEFAULT = "default"
     const val SOURCE_DB = "db"
 
+    const val MODEL_DIR_RESOURCE_DEFINITION: String = "resource_dictionary"
+
     const val PROPERTY_TYPE = "type"
     const val PROPERTY_INPUT_KEY_MAPPING = "input-key-mapping"
     const val PROPERTY_OUTPUT_KEY_MAPPING = "output-key-mapping"
diff --git a/ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceAssignmentEnhancerService.kt b/ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceAssignmentEnhancerService.kt
new file mode 100644 (file)
index 0000000..c5a78a9
--- /dev/null
@@ -0,0 +1,86 @@
+/*\r
+ *  Copyright Â© 2017-2018 AT&T Intellectual Property.\r
+ *\r
+ *  Licensed under the Apache License, Version 2.0 (the "License");\r
+ *  you may not use this file except in compliance with the License.\r
+ *  You may obtain a copy of the License at\r
+ *\r
+ *      http://www.apache.org/licenses/LICENSE-2.0\r
+ *\r
+ *  Unless required by applicable law or agreed to in writing, software\r
+ *  distributed under the License is distributed on an "AS IS" BASIS,\r
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r
+ *  See the License for the specific language governing permissions and\r
+ *  limitations under the License.\r
+ */\r
+\r
+package org.onap.ccsdk.apps.controllerblueprints.resource.dict.service\r
+\r
+import com.att.eelf.configuration.EELFLogger\r
+import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintException\r
+import org.onap.ccsdk.apps.controllerblueprints.core.data.ServiceTemplate\r
+import org.onap.ccsdk.apps.controllerblueprints.core.service.BluePrintEnhancerDefaultService\r
+import org.onap.ccsdk.apps.controllerblueprints.core.service.BluePrintEnhancerService\r
+import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment\r
+import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceDefinition\r
+import com.att.eelf.configuration.EELFManager\r
+\r
+/**\r
+ * ResourceAssignmentEnhancerService.\r
+ *\r
+ * @author Brinda Santh\r
+ */\r
+interface ResourceAssignmentEnhancerService {\r
+\r
+    @Throws(BluePrintException::class)\r
+    fun enhanceBluePrint(bluePrintEnhancerService: BluePrintEnhancerService,\r
+                         resourceAssignments: List<ResourceAssignment>)\r
+\r
+    @Throws(BluePrintException::class)\r
+    fun enhanceBluePrint(resourceAssignments: List<ResourceAssignment>): ServiceTemplate\r
+}\r
+\r
+/**\r
+ * ResourceAssignmentEnhancerDefaultService.\r
+ *\r
+ * @author Brinda Santh\r
+ */\r
+open class ResourceAssignmentEnhancerDefaultService(private val resourceDefinitionRepoService: ResourceDefinitionRepoService)\r
+    : ResourceAssignmentEnhancerService {\r
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(ResourceAssignmentValidationDefaultService::class.java)\r
+\r
+    /**\r
+     * Get the defined source instance from the ResourceAssignment,\r
+     * then get the NodeType of the Sources assigned\r
+     */\r
+    override fun enhanceBluePrint(bluePrintEnhancerService: BluePrintEnhancerService,\r
+                                  resourceAssignments: List<ResourceAssignment>) {\r
+\r
+        // Iterate the Resource Assignment and\r
+        resourceAssignments.map { resourceAssignment ->\r
+            val dictionaryName = resourceAssignment.dictionaryName!!\r
+            val dictionarySource = resourceAssignment.dictionarySource!!\r
+            log.info("Enriching Assignment name({}), dictionary name({}), source({})", resourceAssignment.name,\r
+                    dictionaryName, dictionarySource)\r
+            // Get the Resource Definition from Repo\r
+            val resourceDefinition: ResourceDefinition = getResourceDefinition(dictionaryName)\r
+\r
+            val sourceNodeTemplate = resourceDefinition.sources.get(dictionarySource)\r
+\r
+            // Enrich as NodeTemplate\r
+            bluePrintEnhancerService.enrichNodeTemplate(dictionarySource, sourceNodeTemplate!!)\r
+        }\r
+    }\r
+\r
+    override fun enhanceBluePrint(resourceAssignments: List<ResourceAssignment>): ServiceTemplate {\r
+        val bluePrintEnhancerService = BluePrintEnhancerDefaultService(resourceDefinitionRepoService)\r
+        bluePrintEnhancerService.serviceTemplate = ServiceTemplate()\r
+        bluePrintEnhancerService.initialCleanUp()\r
+        enhanceBluePrint(bluePrintEnhancerService, resourceAssignments)\r
+        return bluePrintEnhancerService.serviceTemplate\r
+    }\r
+\r
+    private fun getResourceDefinition(name: String): ResourceDefinition {\r
+        return resourceDefinitionRepoService.getResourceDefinition(name)!!.block()!!\r
+    }\r
+}
\ No newline at end of file
index 4578aca..228b39e 100644 (file)
 
 package org.onap.ccsdk.apps.controllerblueprints.resource.dict.service
 
+import com.att.eelf.configuration.EELFLogger
 import org.apache.commons.collections.CollectionUtils
 import org.apache.commons.lang3.StringUtils
 import org.apache.commons.lang3.text.StrBuilder
 import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintException
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.TopologicalSortingUtils
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment
-import org.slf4j.LoggerFactory
+import com.att.eelf.configuration.EELFManager
 import java.io.Serializable
 
 /**
@@ -42,7 +43,7 @@ interface ResourceAssignmentValidationService : Serializable {
  * @author Brinda Santh
  */
 open class ResourceAssignmentValidationDefaultService : ResourceAssignmentValidationService {
-    private val log = LoggerFactory.getLogger(ResourceAssignmentValidationDefaultService::class.java)
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(ResourceAssignmentValidationDefaultService::class.java)
 
     open var resourceAssignmentMap: Map<String, ResourceAssignment> = hashMapOf()
     open val validationMessage = StrBuilder()
diff --git a/ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceDefinitionRepoService.kt b/ms/controllerblueprints/modules/resource-dict/src/main/kotlin/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceDefinitionRepoService.kt
new file mode 100644 (file)
index 0000000..d51338c
--- /dev/null
@@ -0,0 +1,61 @@
+/*\r
+ *  Copyright Â© 2017-2018 AT&T Intellectual Property.\r
+ *\r
+ *  Licensed under the Apache License, Version 2.0 (the "License");\r
+ *  you may not use this file except in compliance with the License.\r
+ *  You may obtain a copy of the License at\r
+ *\r
+ *      http://www.apache.org/licenses/LICENSE-2.0\r
+ *\r
+ *  Unless required by applicable law or agreed to in writing, software\r
+ *  distributed under the License is distributed on an "AS IS" BASIS,\r
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r
+ *  See the License for the specific language governing permissions and\r
+ *  limitations under the License.\r
+ */\r
+\r
+package org.onap.ccsdk.apps.controllerblueprints.resource.dict.service\r
+\r
+import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintConstants\r
+import org.onap.ccsdk.apps.controllerblueprints.core.service.BluePrintRepoFileService\r
+import org.onap.ccsdk.apps.controllerblueprints.core.service.BluePrintRepoService\r
+import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonReactorUtils\r
+import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceDefinition\r
+import reactor.core.publisher.Mono\r
+/**\r
+ * ResourceDefinitionRepoService.\r
+ *\r
+ * @author Brinda Santh\r
+ */\r
+interface ResourceDefinitionRepoService : BluePrintRepoService {\r
+\r
+    fun getResourceDefinition(resourceDefinitionName: String): Mono<ResourceDefinition>?\r
+}\r
+\r
+/**\r
+ * ResourceDefinitionFileRepoService.\r
+ *\r
+ * @author Brinda Santh\r
+ */\r
+open class ResourceDefinitionFileRepoService : BluePrintRepoFileService,\r
+        ResourceDefinitionRepoService {\r
+\r
+    private var resourceDefinitionPath: String\r
+    private val extension = ".json"\r
+\r
+    constructor(basePath: String) : this(basePath,\r
+            basePath.plus(BluePrintConstants.PATH_DIVIDER)\r
+                    .plus(BluePrintConstants.MODEL_DIR_MODEL_TYPE))\r
+\r
+    constructor(basePath: String, modelTypePath: String) : super(modelTypePath) {\r
+        resourceDefinitionPath = basePath.plus("/resource_dictionary")\r
+    }\r
+\r
+    override fun getResourceDefinition(resourceDefinitionName: String): Mono<ResourceDefinition>? {\r
+\r
+        val fileName = resourceDefinitionPath.plus(BluePrintConstants.PATH_DIVIDER)\r
+                .plus(resourceDefinitionName).plus(extension)\r
+\r
+        return JacksonReactorUtils.readValueFromFile(fileName, ResourceDefinition::class.java)\r
+    }\r
+}\r
index 1defa53..14855d4 100644 (file)
@@ -17,6 +17,7 @@
 
 package org.onap.ccsdk.apps.controllerblueprints.resource.dict.service
 
+import com.att.eelf.configuration.EELFLogger
 import com.fasterxml.jackson.databind.JsonNode
 import com.google.common.base.Preconditions
 import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintException
@@ -29,7 +30,7 @@ import org.onap.ccsdk.apps.controllerblueprints.core.service.BluePrintExpression
 import org.onap.ccsdk.apps.controllerblueprints.core.service.BluePrintRepoService
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceDefinition
-import org.slf4j.LoggerFactory
+import com.att.eelf.configuration.EELFManager
 import java.io.Serializable
 /**
  * ResourceDefinitionValidationService.
@@ -49,7 +50,7 @@ interface ResourceDefinitionValidationService : Serializable {
  */
 open class ResourceDefinitionDefaultValidationService(private val bluePrintRepoService: BluePrintRepoService) : ResourceDefinitionValidationService {
 
-    private val log = LoggerFactory.getLogger(ResourceDefinitionValidationService::class.java)
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(ResourceDefinitionValidationService::class.java)
 
     override fun validate(resourceDefinition: ResourceDefinition) {
         Preconditions.checkNotNull(resourceDefinition, "Failed to get Resource Definition")
index 82fbd3a..747639c 100644 (file)
 \r
 package org.onap.ccsdk.apps.controllerblueprints.resource.dict.utils\r
 \r
+import com.att.eelf.configuration.EELFLogger\r
 import org.apache.commons.collections.CollectionUtils\r
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.TopologicalSortingUtils\r
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment\r
-import org.slf4j.LoggerFactory\r
+import com.att.eelf.configuration.EELFManager\r
 import java.util.ArrayList\r
 /**\r
  * BulkResourceSequencingUtils.\r
@@ -27,7 +28,7 @@ import java.util.ArrayList
  * @author Brinda Santh\r
  */\r
 object BulkResourceSequencingUtils {\r
-    private val log = LoggerFactory.getLogger(BulkResourceSequencingUtils::class.java)\r
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(BulkResourceSequencingUtils::class.java)\r
 \r
     @JvmStatic\r
     fun process(resourceAssignments: MutableList<ResourceAssignment>): List<List<ResourceAssignment>> {\r
index 733a443..a3456cd 100644 (file)
@@ -16,6 +16,7 @@
 
 package org.onap.ccsdk.apps.controllerblueprints.resource.dict.utils
 
+import com.att.eelf.configuration.EELFLogger
 import com.fasterxml.jackson.databind.JsonNode
 import com.fasterxml.jackson.databind.node.NullNode
 import org.apache.commons.collections.MapUtils
@@ -25,11 +26,11 @@ import org.onap.ccsdk.apps.controllerblueprints.core.data.NodeTemplate
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceDefinition
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceDictionaryConstants
-import org.slf4j.LoggerFactory
+import com.att.eelf.configuration.EELFManager
 
 
 object ResourceDictionaryUtils {
-    private val log = LoggerFactory.getLogger(ResourceDictionaryUtils::class.java)
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(ResourceDictionaryUtils::class.java)
 
     @JvmStatic
     fun populateSourceMapping(resourceAssignment: ResourceAssignment,
index 3e68d09..fde8000 100644 (file)
@@ -20,12 +20,12 @@ package org.onap.ccsdk.apps.controllerblueprints.resource.dict;
 import org.junit.Assert;\r
 import org.junit.Test;\r
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 \r
 public class ResourceDefinitionTest {\r
-    private Logger log = LoggerFactory.getLogger(ResourceDefinitionTest.class);\r
-    String basePath = "load/resource_dictionary";\r
+    private EELFLogger log = EELFManager.getInstance().getLogger(ResourceDefinitionTest.class);\r
+    private String basePath = "load/resource_dictionary";\r
 \r
     @Test\r
     public void testDictionaryDefinitionInputSource(){\r
diff --git a/ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceAssignmentEnhancerServiceTest.java b/ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceAssignmentEnhancerServiceTest.java
new file mode 100644 (file)
index 0000000..57c8509
--- /dev/null
@@ -0,0 +1,48 @@
+/*\r
+ *  Copyright Â© 2017-2018 AT&T Intellectual Property.\r
+ *\r
+ *  Licensed under the Apache License, Version 2.0 (the "License");\r
+ *  you may not use this file except in compliance with the License.\r
+ *  You may obtain a copy of the License at\r
+ *\r
+ *      http://www.apache.org/licenses/LICENSE-2.0\r
+ *\r
+ *  Unless required by applicable law or agreed to in writing, software\r
+ *  distributed under the License is distributed on an "AS IS" BASIS,\r
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r
+ *  See the License for the specific language governing permissions and\r
+ *  limitations under the License.\r
+ */\r
+\r
+package org.onap.ccsdk.apps.controllerblueprints.resource.dict.service;\r
+\r
+import org.junit.Assert;\r
+import org.junit.Test;\r
+import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintException;\r
+import org.onap.ccsdk.apps.controllerblueprints.core.data.ServiceTemplate;\r
+import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonReactorUtils;\r
+import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment;\r
+\r
+import java.util.List;\r
+\r
+/**\r
+ * ResourceAssignmentEnhancerService.\r
+ *\r
+ * @author Brinda Santh\r
+ */\r
+public class ResourceAssignmentEnhancerServiceTest {\r
+\r
+    @Test\r
+    public void testEnhanceBluePrint() throws BluePrintException {\r
+\r
+        List<ResourceAssignment> resourceAssignments = JacksonReactorUtils\r
+                .getListFromClassPathFile("enrich/simple-enrich.json", ResourceAssignment.class).block();\r
+        Assert.assertNotNull("Failed to get Resource Assignment", resourceAssignments);\r
+        ResourceDefinitionRepoService resourceDefinitionRepoService = new ResourceDefinitionFileRepoService("load");\r
+        ResourceAssignmentEnhancerService resourceAssignmentEnhancerService =\r
+                new ResourceAssignmentEnhancerDefaultService(resourceDefinitionRepoService);\r
+        ServiceTemplate serviceTemplate = resourceAssignmentEnhancerService.enhanceBluePrint(resourceAssignments);\r
+        Assert.assertNotNull("Failed to get Enriched service Template", serviceTemplate);\r
+    }\r
+}\r
+\r
index 4d8301f..6216d5b 100644 (file)
 \r
 package org.onap.ccsdk.apps.controllerblueprints.resource.dict.service\r
 \r
+import com.att.eelf.configuration.EELFLogger\r
 import org.junit.Assert\r
 import org.junit.Test\r
 import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintException\r
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils\r
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment\r
-import org.slf4j.LoggerFactory\r
+import com.att.eelf.configuration.EELFManager\r
 /**\r
  * ResourceAssignmentValidationServiceTest.\r
  *\r
  * @author Brinda Santh\r
  */\r
 class ResourceAssignmentValidationServiceTest {\r
-    private val log = LoggerFactory.getLogger(ResourceAssignmentValidationServiceTest::class.java)\r
+    private val log: EELFLogger = EELFManager.getInstance().getLogger(ResourceAssignmentValidationServiceTest::class.java)\r
     @Test\r
     fun testValidateSuccess() {\r
         log.info("**************** testValidateSuccess *****************")\r
diff --git a/ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceDefinitionRepoServiceTest.java b/ms/controllerblueprints/modules/resource-dict/src/test/java/org/onap/ccsdk/apps/controllerblueprints/resource/dict/service/ResourceDefinitionRepoServiceTest.java
new file mode 100644 (file)
index 0000000..1772277
--- /dev/null
@@ -0,0 +1,36 @@
+/*\r
+ *  Copyright Â© 2017-2018 AT&T Intellectual Property.\r
+ *\r
+ *  Licensed under the Apache License, Version 2.0 (the "License");\r
+ *  you may not use this file except in compliance with the License.\r
+ *  You may obtain a copy of the License at\r
+ *\r
+ *      http://www.apache.org/licenses/LICENSE-2.0\r
+ *\r
+ *  Unless required by applicable law or agreed to in writing, software\r
+ *  distributed under the License is distributed on an "AS IS" BASIS,\r
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r
+ *  See the License for the specific language governing permissions and\r
+ *  limitations under the License.\r
+ */\r
+\r
+package org.onap.ccsdk.apps.controllerblueprints.resource.dict.service;\r
+\r
+import org.junit.Assert;\r
+import org.junit.Test;\r
+import org.onap.ccsdk.apps.controllerblueprints.core.data.NodeType;\r
+import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceDefinition;\r
+\r
+public class ResourceDefinitionRepoServiceTest {\r
+\r
+    @Test\r
+    public void testGetResourceDefinition() throws Exception{\r
+        ResourceDefinitionRepoService resourceDefinitionRepoService = new ResourceDefinitionFileRepoService("load");\r
+        ResourceDefinition resourceDefinition = resourceDefinitionRepoService\r
+                .getResourceDefinition("db-source").block();\r
+        Assert.assertNotNull("Failed to get Resource Definition db-source", resourceDefinition);\r
+\r
+        NodeType nodeType = resourceDefinitionRepoService.getNodeType("source-db").block();\r
+        Assert.assertNotNull("Failed to get Node Type source-db", resourceDefinition);\r
+    }\r
+}
\ No newline at end of file
index 5ee5617..13bf819 100644 (file)
@@ -27,8 +27,8 @@ import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils;
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment;\r
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceDefinition;\r
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceDictionaryConstants;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 \r
 import java.util.HashMap;\r
 import java.util.Map;\r
@@ -38,12 +38,13 @@ import java.util.Map;
  * @author Brinda Santh\r
  */\r
 public class ResourceDictionaryUtilsTest {\r
-    private static final Logger log = LoggerFactory.getLogger(ResourceDictionaryUtilsTest.class);\r
+    private static final EELFLogger log = EELFManager.getInstance().getLogger(ResourceDictionaryUtilsTest.class);\r
 \r
     @Test\r
     public void testPopulateSourceMapping() {\r
 \r
         ResourceAssignment resourceAssignment = new ResourceAssignment();\r
+        resourceAssignment.setName("sample-assignment");\r
         ResourceDefinition resourceDefinition = new ResourceDefinition();\r
         Map<String, NodeTemplate> sources = new HashMap<>();\r
         resourceDefinition.setSources(sources);\r
diff --git a/ms/controllerblueprints/modules/resource-dict/src/test/resources/enrich/simple-enrich.json b/ms/controllerblueprints/modules/resource-dict/src/test/resources/enrich/simple-enrich.json
new file mode 100644 (file)
index 0000000..641da80
--- /dev/null
@@ -0,0 +1,37 @@
+[\r
+  {\r
+    "name": "rs-db-source",\r
+    "input-param": true,\r
+    "property": {\r
+      "type": "string",\r
+      "required": true\r
+    },\r
+    "dictionary-name": "db-source",\r
+    "dictionary-source": "db",\r
+    "dependencies": [\r
+      "input-source"\r
+    ]\r
+  },\r
+  {\r
+    "name": "ra-default-source",\r
+    "input-param": true,\r
+    "property": {\r
+      "type": "string",\r
+      "required": true\r
+    },\r
+    "dictionary-name": "default-source",\r
+    "dictionary-source": "default",\r
+    "dependencies": []\r
+  },\r
+  {\r
+    "name": "ra-input-source",\r
+    "input-param": true,\r
+    "property": {\r
+      "type": "string",\r
+      "required": true\r
+    },\r
+    "dictionary-name": "input-source",\r
+    "dictionary-source": "input",\r
+    "dependencies": []\r
+  }\r
+]\r
index 5eba4fc..428c524 100644 (file)
@@ -29,8 +29,8 @@ import org.onap.ccsdk.apps.controllerblueprints.resource.dict.utils.ResourceDict
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ResourceDictionary;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.model.AutoMapResponse;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.repository.ResourceDictionaryRepository;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.stereotype.Service;\r
 \r
 import java.util.ArrayList;\r
@@ -49,7 +49,7 @@ import java.util.Map;
 @SuppressWarnings("unused")\r
 public class AutoResourceMappingService {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(AutoResourceMappingService.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(AutoResourceMappingService.class);\r
 \r
     private ResourceDictionaryRepository dataDictionaryRepository;\r
 \r
index 28be75e..8e98f94 100644 (file)
@@ -29,8 +29,8 @@ import org.onap.ccsdk.apps.controllerblueprints.core.service.BluePrintEnhancerDe
 import org.onap.ccsdk.apps.controllerblueprints.core.service.BluePrintRepoService;\r
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils;\r
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.stereotype.Service;\r
 \r
 import java.util.HashMap;\r
@@ -46,7 +46,7 @@ import java.util.Map;
 @Service\r
 public class BluePrintEnhancerService extends BluePrintEnhancerDefaultService {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(BluePrintEnhancerService.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(BluePrintEnhancerService.class);\r
 \r
     private Map<String, DataType> recipeDataTypes = new HashMap<>();\r
 \r
@@ -55,7 +55,7 @@ public class BluePrintEnhancerService extends BluePrintEnhancerDefaultService {
     }\r
 \r
     @Override\r
-    public void enrichTopologyTemplate(@NotNull ServiceTemplate serviceTemplate) {\r
+    public void enrichTopologyTemplate(@NotNull ServiceTemplate serviceTemplate) throws BluePrintException{\r
         super.enrichTopologyTemplate(serviceTemplate);\r
 \r
         // Update the Recipe Inputs and DataTypes\r
@@ -143,7 +143,7 @@ public class BluePrintEnhancerService extends BluePrintEnhancerDefaultService {
     }\r
 \r
     private Map<String, PropertyDefinition> getCapabilityMappingProperties(String nodeTemplateName,\r
-                                                                           NodeTemplate nodeTemplate) {\r
+                                                                           NodeTemplate nodeTemplate) throws BluePrintException {\r
 \r
         Map<String, PropertyDefinition> dataTypeProperties = null;\r
         if (nodeTemplate != null && MapUtils.isNotEmpty(nodeTemplate.getCapabilities())) {\r
index 9c1a045..3c92f7e 100644 (file)
@@ -31,8 +31,8 @@ import org.onap.ccsdk.apps.controllerblueprints.service.common.ApplicationConsta
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModel;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModelContent;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.repository.ConfigModelRepository;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.stereotype.Service;\r
 \r
 import java.io.IOException;\r
@@ -52,7 +52,7 @@ import java.util.Optional;
 @Service\r
 public class ConfigModelCreateService {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(ConfigModelCreateService.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ConfigModelCreateService.class);\r
 \r
     private ConfigModelRepository configModelRepository;\r
     private ConfigModelValidatorService configModelValidatorService;\r
index b729e3e..534394a 100644 (file)
@@ -29,8 +29,8 @@ import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModel;
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModelContent;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.repository.ConfigModelContentRepository;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.repository.ConfigModelRepository;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.stereotype.Service;\r
 import org.springframework.transaction.annotation.Transactional;\r
 \r
@@ -49,7 +49,7 @@ import java.util.Optional;
 @Service\r
 public class ConfigModelService {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(ConfigModelService.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ConfigModelService.class);\r
 \r
     private ConfigModelRepository configModelRepository;\r
     private ConfigModelContentRepository configModelContentRepository;\r
@@ -57,14 +57,14 @@ public class ConfigModelService {
 \r
     /**\r
      * This is a ConfigModelService constructor.\r
-     * \r
-     * @param configModelRepository\r
-     * @param configModelContentRepository\r
-     * @param configModelCreateService\r
+     *\r
+     * @param configModelRepository        configModelRepository\r
+     * @param configModelContentRepository configModelContentRepository\r
+     * @param configModelCreateService     configModelCreateService\r
      */\r
     public ConfigModelService(ConfigModelRepository configModelRepository,\r
-            ConfigModelContentRepository configModelContentRepository,\r
-            ConfigModelCreateService configModelCreateService) {\r
+                              ConfigModelContentRepository configModelContentRepository,\r
+                              ConfigModelCreateService configModelCreateService) {\r
         this.configModelRepository = configModelRepository;\r
         this.configModelContentRepository = configModelContentRepository;\r
         this.configModelCreateService = configModelCreateService;\r
@@ -72,10 +72,10 @@ public class ConfigModelService {
 \r
     /**\r
      * This is a getInitialConfigModel method\r
-     * \r
-     * @param templateName\r
+     *\r
+     * @param templateName templateName\r
      * @return ConfigModel\r
-     * @throws BluePrintException\r
+     * @throws BluePrintException BluePrintException\r
      */\r
     public ConfigModel getInitialConfigModel(String templateName) throws BluePrintException {\r
         ConfigModel configModel = null;\r
@@ -100,10 +100,10 @@ public class ConfigModelService {
 \r
     /**\r
      * This is a saveConfigModel method\r
-     * \r
-     * @param configModel\r
+     *\r
+     * @param configModel configModel\r
      * @return ConfigModel\r
-     * @throws BluePrintException\r
+     * @throws BluePrintException BluePrintException\r
      */\r
     public ConfigModel saveConfigModel(ConfigModel configModel) throws BluePrintException {\r
         return this.configModelCreateService.saveConfigModel(configModel);\r
@@ -111,10 +111,10 @@ public class ConfigModelService {
 \r
     /**\r
      * This is a publishConfigModel method\r
-     * \r
-     * @param id\r
+     *\r
+     * @param id id\r
      * @return ConfigModel\r
-     * @throws BluePrintException\r
+     * @throws BluePrintException BluePrintException\r
      */\r
     public ConfigModel publishConfigModel(Long id) throws BluePrintException {\r
         return this.configModelCreateService.publishConfigModel(id);\r
@@ -122,8 +122,8 @@ public class ConfigModelService {
 \r
     /**\r
      * This is a searchConfigModels method\r
-     * \r
-     * @param tags\r
+     *\r
+     * @param tags tags\r
      * @return ConfigModel\r
      */\r
     public List<ConfigModel> searchConfigModels(String tags) {\r
@@ -138,9 +138,9 @@ public class ConfigModelService {
 \r
     /**\r
      * This is a getConfigModelByNameAndVersion method\r
-     * \r
-     * @param name\r
-     * @param version\r
+     *\r
+     * @param name    name\r
+     * @param version version\r
      * @return ConfigModel\r
      */\r
     public ConfigModel getConfigModelByNameAndVersion(String name, String version) {\r
@@ -159,8 +159,8 @@ public class ConfigModelService {
 \r
     /**\r
      * This is a getConfigModel method\r
-     * \r
-     * @param id\r
+     *\r
+     * @param id id\r
      * @return ConfigModel\r
      */\r
     public ConfigModel getConfigModel(Long id) {\r
@@ -176,9 +176,9 @@ public class ConfigModelService {
 \r
     /**\r
      * This method returns clone of the given model id, by masking the other unrelated fields\r
-     * \r
-     * @param id\r
-     * @return\r
+     *\r
+     * @param id id\r
+     * @return ConfigModel\r
      */\r
 \r
     public ConfigModel getCloneConfigModel(Long id) {\r
@@ -232,8 +232,8 @@ public class ConfigModelService {
 \r
     /**\r
      * This is a deleteConfigModel method\r
-     * \r
-     * @param id\r
+     *\r
+     * @param id id\r
      */\r
 \r
     @Transactional\r
index 89d4829..4e7c391 100644 (file)
@@ -22,6 +22,7 @@ import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.io.IOUtils;\r
 import org.apache.commons.lang3.StringUtils;\r
 import org.apache.commons.lang3.text.StrBuilder;\r
+import org.jetbrains.annotations.NotNull;\r
 import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintConstants;\r
 import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintException;\r
 import org.onap.ccsdk.apps.controllerblueprints.core.data.ArtifactType;\r
@@ -33,8 +34,8 @@ import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModel;
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ModelType;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ResourceDictionary;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.utils.ConfigModelUtils;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.beans.factory.annotation.Autowired;\r
 import org.springframework.beans.factory.annotation.Value;\r
 import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;\r
@@ -58,7 +59,7 @@ import java.util.List;
 @ConditionalOnProperty(name = "blueprints.load.initial-data", havingValue = "true")\r
 public class DataBaseInitService {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(DataBaseInitService.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(DataBaseInitService.class);\r
     @Value("${blueprints.load.path}")\r
     private String modelLoadPath;\r
     private ModelTypeService modelTypeService;\r
@@ -91,6 +92,7 @@ public class DataBaseInitService {
     }\r
 \r
     @PostConstruct\r
+    @SuppressWarnings("unused")\r
     private void initDatabase() {\r
         log.info("loading Blueprints from DIR : {}", modelLoadPath);\r
         dataTypePath = modelLoadPath + "/model_type/data_type";\r
@@ -263,7 +265,7 @@ public class DataBaseInitService {
         }\r
     }\r
 \r
-    private void loadDataType(Resource file, StrBuilder errorBuilder) {\r
+    private void loadDataType(@NotNull Resource file, StrBuilder errorBuilder) {\r
         try {\r
             log.trace("Loading Data Type: {}", file.getFilename());\r
             String dataKey = file.getFilename().replace(".json", "");\r
index a75651f..04a95fd 100644 (file)
@@ -24,8 +24,8 @@ import org.onap.ccsdk.apps.controllerblueprints.core.data.DataType;
 import org.onap.ccsdk.apps.controllerblueprints.core.data.ServiceTemplate;\r
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.common.SwaggerGenerator;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 \r
 import java.util.HashMap;\r
 import java.util.Map;\r
@@ -39,7 +39,7 @@ import java.util.Map;
  */\r
 \r
 public class SchemaGeneratorService {\r
-    private static Logger log = LoggerFactory.getLogger(SchemaGeneratorService.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(SchemaGeneratorService.class);\r
 \r
     private Map<String, DataType> dataTypes;\r
 \r
index 3e3c8e2..898647e 100644 (file)
@@ -81,7 +81,7 @@ public class ServiceTemplateService {
      * @param serviceTemplate serviceTemplate\r
      * @return ServiceTemplate\r
      */\r
-    public ServiceTemplate enrichServiceTemplate(ServiceTemplate serviceTemplate) {\r
+    public ServiceTemplate enrichServiceTemplate(ServiceTemplate serviceTemplate) throws BluePrintException {\r
         this.bluePrintEnhancerService.enhance(serviceTemplate);\r
         return serviceTemplate;\r
     }\r
index 60b3ed6..ae374a7 100644 (file)
@@ -76,12 +76,11 @@ public class ConfigModelContent {
 \r
     @Override\r
     public String toString() {\r
-        StringBuilder builder = new StringBuilder("[");\r
-        builder.append("id = " + id);\r
-        builder.append(", name = " + name);\r
-        builder.append(", contentType = " + contentType);\r
-        builder.append("]");\r
-        return builder.toString();\r
+        String builder = "[" + "id = " + id +\r
+                ", name = " + name +\r
+                ", contentType = " + contentType +\r
+                "]";\r
+        return builder;\r
     }\r
 \r
     @Override\r
index eaa335b..cb8d229 100644 (file)
@@ -82,17 +82,16 @@ public class ModelType implements Serializable {
 \r
     @Override\r
     public String toString() {\r
-        StringBuilder buffer = new StringBuilder("[");\r
-        buffer.append(", modelName = " + modelName);\r
-        buffer.append(", derivedFrom = " + derivedFrom);\r
-        buffer.append(", definitionType = " + definitionType);\r
-        buffer.append(", description = " + description);\r
-        buffer.append(", creationDate = " + creationDate);\r
-        buffer.append(", version = " + version);\r
-        buffer.append(", updatedBy = " + updatedBy);\r
-        buffer.append(", tags = " + tags);\r
-        buffer.append("]");\r
-        return buffer.toString();\r
+        String buffer = "[" + ", modelName = " + modelName +\r
+                ", derivedFrom = " + derivedFrom +\r
+                ", definitionType = " + definitionType +\r
+                ", description = " + description +\r
+                ", creationDate = " + creationDate +\r
+                ", version = " + version +\r
+                ", updatedBy = " + updatedBy +\r
+                ", tags = " + tags +\r
+                "]";\r
+        return buffer;\r
     }\r
 \r
     public String getModelName() {\r
index 4875868..c884622 100644 (file)
@@ -92,20 +92,19 @@ public class ResourceDictionary implements Serializable {
 \r
     @Override\r
     public String toString() {\r
-        StringBuilder buffer = new StringBuilder("[");\r
-        buffer.append(", name = " + name);\r
-        buffer.append(", resourcePath = " + resourcePath);\r
-        buffer.append(", resourceType = " + resourceType);\r
-        buffer.append(", dataType = " + dataType);\r
-        buffer.append(", entrySchema = " + entrySchema);\r
-        buffer.append(", validValues = " + validValues);\r
-        buffer.append(", definition =" + definition);\r
-        buffer.append(", description = " + description);\r
-        buffer.append(", updatedBy = " + updatedBy);\r
-        buffer.append(", tags = " + tags);\r
-        buffer.append(", creationDate = " + creationDate);\r
-        buffer.append("]");\r
-        return buffer.toString();\r
+        String buffer = "[" + ", name = " + name +\r
+                ", resourcePath = " + resourcePath +\r
+                ", resourceType = " + resourceType +\r
+                ", dataType = " + dataType +\r
+                ", entrySchema = " + entrySchema +\r
+                ", validValues = " + validValues +\r
+                ", definition =" + definition +\r
+                ", description = " + description +\r
+                ", updatedBy = " + updatedBy +\r
+                ", tags = " + tags +\r
+                ", creationDate = " + creationDate +\r
+                "]";\r
+        return buffer;\r
     }\r
 \r
     public String getResourcePath() {\r
index bfc89b4..dc24c3b 100644 (file)
@@ -27,8 +27,8 @@ import org.onap.ccsdk.apps.controllerblueprints.core.data.ToscaMetaData;
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.BluePrintMetadataUtils;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModel;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModelContent;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 \r
 import java.io.File;\r
 import java.io.IOException;\r
@@ -43,7 +43,7 @@ public class ConfigModelUtils {
 \r
     }\r
 \r
-    private static Logger log = LoggerFactory.getLogger(ConfigModelUtils.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ConfigModelUtils.class);\r
 \r
     public static ConfigModel getConfigModel(String blueprintPath) throws Exception {\r
         Preconditions.checkArgument(StringUtils.isNotBlank(blueprintPath), "Blueprint Path is missing");\r
index f846e9a..b70651f 100644 (file)
@@ -22,8 +22,8 @@ import org.junit.FixMethodOrder;
 import org.junit.Test;\r
 import org.junit.runners.MethodSorters;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.SchemaGeneratorService;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 \r
 import java.io.File;\r
 import java.nio.charset.Charset;\r
@@ -32,7 +32,7 @@ import java.nio.charset.Charset;
 @FixMethodOrder(MethodSorters.NAME_ASCENDING)\r
 public class SchemaGeneratorServiceTest {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(SchemaGeneratorServiceTest.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(SchemaGeneratorServiceTest.class);\r
 \r
     @Test\r
     public void test01GenerateSwaggerData() throws Exception {\r
index a4a787b..4fa827c 100644 (file)
@@ -22,8 +22,8 @@ import org.junit.runners.MethodSorters;
 import org.onap.ccsdk.apps.controllerblueprints.TestApplication;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModel;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.utils.ConfigModelUtils;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.beans.factory.annotation.Autowired;\r
 import org.springframework.boot.test.context.SpringBootTest;\r
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;\r
@@ -38,7 +38,7 @@ import java.util.List;
 @FixMethodOrder(MethodSorters.NAME_ASCENDING)\r
 public class ConfigModelRestTest {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(ConfigModelRestTest.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ConfigModelRestTest.class);\r
 \r
     @Autowired\r
     ConfigModelRest configModelRest;\r
index 08bfeb1..8e88f0a 100644 (file)
@@ -23,8 +23,8 @@ import org.junit.runners.MethodSorters;
 import org.onap.ccsdk.apps.controllerblueprints.TestApplication;\r
 import org.onap.ccsdk.apps.controllerblueprints.core.BluePrintConstants;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ModelType;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.beans.factory.annotation.Autowired;\r
 import org.springframework.boot.test.context.SpringBootTest;\r
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;\r
@@ -40,7 +40,7 @@ import java.util.List;
 @ContextConfiguration(classes = {TestApplication.class})\r
 @FixMethodOrder(MethodSorters.NAME_ASCENDING)\r
 public class ModelTypeRestTest {\r
-    private static Logger log = LoggerFactory.getLogger(ModelTypeRestTest.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ModelTypeRestTest.class);\r
     @Autowired\r
     ModelTypeRest modelTypeRest;\r
 \r
index ec036ee..8bb1f0b 100644 (file)
@@ -25,8 +25,8 @@ import org.junit.runner.RunWith;
 import org.junit.runners.MethodSorters;\r
 import org.onap.ccsdk.apps.controllerblueprints.TestApplication;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ResourceDictionary;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.beans.factory.annotation.Autowired;\r
 import org.springframework.boot.test.context.SpringBootTest;\r
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;\r
@@ -44,7 +44,7 @@ import java.util.List;
 @FixMethodOrder(MethodSorters.NAME_ASCENDING)\r
 public class ResourceDictionaryRestTest {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(ResourceDictionaryRestTest.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ResourceDictionaryRestTest.class);\r
 \r
     @Autowired\r
     protected ResourceDictionaryRest resourceDictionaryRest;\r
index fdc68e4..217eb8f 100644 (file)
@@ -30,8 +30,8 @@ import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils;
 import org.onap.ccsdk.apps.controllerblueprints.resource.dict.ResourceAssignment;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.domain.ConfigModelContent;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.model.AutoMapResponse;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 import org.springframework.beans.factory.annotation.Autowired;\r
 import org.springframework.boot.test.context.SpringBootTest;\r
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;\r
@@ -49,7 +49,7 @@ import java.util.List;
 @FixMethodOrder(MethodSorters.NAME_ASCENDING)\r
 public class ServiceTemplateRestTest {\r
 \r
-    private static Logger log = LoggerFactory.getLogger(ServiceTemplateRestTest.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ServiceTemplateRestTest.class);\r
     @Autowired\r
     ModelTypeRest modelTypeRest;\r
 \r
index e41e90a..93ea4c4 100644 (file)
@@ -23,15 +23,15 @@ import org.junit.Test;
 import org.onap.ccsdk.apps.controllerblueprints.core.data.ServiceTemplate;\r
 import org.onap.ccsdk.apps.controllerblueprints.core.utils.JacksonUtils;\r
 import org.onap.ccsdk.apps.controllerblueprints.service.utils.ConfigModelUtils;\r
-import org.slf4j.Logger;\r
-import org.slf4j.LoggerFactory;\r
+import com.att.eelf.configuration.EELFLogger;\r
+import com.att.eelf.configuration.EELFManager;\r
 \r
 import java.io.File;\r
 import java.nio.charset.Charset;\r
 import java.util.List;\r
 \r
 public class ServiceTemplateValidationTest {\r
-    private static Logger log = LoggerFactory.getLogger(ServiceTemplateValidationTest.class);\r
+    private static EELFLogger log = EELFManager.getInstance().getLogger(ServiceTemplateValidationTest.class);\r
 \r
     @Test\r
     public void testBluePrintDirs() {\r