Handle no pservers case on lock check

Check for null return value from pservers query

Issue-ID: SO-2184
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I34c71601e694241a6d3cfefa8227200e715e2ed3

diff --git a/common/src/main/java/org/onap/so/client/aai/AAIValidatorImpl.java b/common/src/main/java/org/onap/so/client/aai/AAIValidatorImpl.java
index 95ed01e..96844ff 100644 (file)
--- a/common/src/main/java/org/onap/so/client/aai/AAIValidatorImpl.java
+++ b/common/src/main/java/org/onap/so/client/aai/AAIValidatorImpl.java
@@ -47,10 +47,12 @@ public class AAIValidatorImpl implements AAIValidator {
         List<Pserver> pservers;
         boolean isLocked = false;
         pservers = client.getPhysicalServerByVnfId(vnfId);
-        for (Pserver pserver : pservers) {
-            if (pserver.isInMaint()) {
-                isLocked = true;
-                return isLocked;
+        if (pservers != null) {
+            for (Pserver pserver : pservers) {
+                if (pserver.isInMaint()) {
+                    isLocked = true;
+                    return isLocked;
+                }
             }
         }
         return isLocked;

diff --git a/common/src/test/java/org/onap/so/client/aai/AAIValidatorTest.java b/common/src/test/java/org/onap/so/client/aai/AAIValidatorTest.java
index 5fa2ff0..b91d0e7 100644 (file)
--- a/common/src/test/java/org/onap/so/client/aai/AAIValidatorTest.java
+++ b/common/src/test/java/org/onap/so/client/aai/AAIValidatorTest.java
@@ -90,6 +90,13 @@ public class AAIValidatorTest {
         assertEquals(false, locked);
     }
 
+    @Test
+    public void test_IsPhysicalServerLocked_NoServers_False() throws IOException {
+        when(client.getPhysicalServerByVnfId(vnfName)).thenReturn(null);
+        boolean locked = validator.isPhysicalServerLocked(vnfName);
+        assertEquals(false, locked);
+    }
+
     @Test
     public void test_IsVNFLocked_False() {
         when(client.getVnfByName(vnfName)).thenReturn(createGenericVnfs(false));