Fix Sonar violations - AgglomerateConfiguration 57/27057/2
authorojasdubey <ojas.dubey@amdocs.com>
Wed, 27 Dec 2017 14:17:44 +0000 (19:47 +0530)
committerVitaly Emporopulo <Vitaliy.Emporopulo@amdocs.com>
Wed, 27 Dec 2017 15:40:06 +0000 (15:40 +0000)
1. Fixed major sonar violations configuration management core
- AgglomerateConfiguration

Change-Id: I1f79df3a1d256aeb45b82d344c507d40f6b83026
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
common/openecomp-common-configuration-management/openecomp-configuration-management-core/src/main/java/org/openecomp/config/impl/AgglomerateConfiguration.java

index d50948c..9556b48 100644 (file)
@@ -21,10 +21,11 @@ public class AgglomerateConfiguration extends DatabaseConfiguration {
    * @return the property value
    */
   public Object getPropertyValue(String key) {
-    Object objToReturn = null;
+    Object objToReturn;
     objToReturn = store.get(key);
     if (objToReturn == null && !store.containsKey(key)) {
-      store.put(key, objToReturn = super.getProperty(key));
+      objToReturn = super.getProperty(key);
+      store.put(key, objToReturn);
     }
     return objToReturn;
   }