Sonar fix: ModelType.java

Fixed sonar issues/code-smells across this file.

Issue-ID: CCSDK-771
Change-Id: I9a36c9b5a955cfa027de3a2c002634ac1755d68d
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>

diff --git a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java
index d8fea60..33c7ae4 100644 (file)
--- a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java
+++ b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java
@@ -84,7 +84,7 @@ public class ModelType implements Serializable {
 \r
     @Override\r
     public String toString() {\r
-        String buffer = "[" + ", modelName = " + modelName +\r
+        return "[" + ", modelName = " + modelName +\r
                 ", derivedFrom = " + derivedFrom +\r
                 ", definitionType = " + definitionType +\r
                 ", description = " + description +\r
@@ -93,7 +93,6 @@ public class ModelType implements Serializable {
                 ", updatedBy = " + updatedBy +\r
                 ", tags = " + tags +\r
                 "]";\r
-        return buffer;\r
     }\r
 \r
     public String getModelName() {\r