Fix Sonar NicDaoZusammenImpl

Fixed reported sonar issues

Change-Id: Id0b925a8e01ac6aa40f48f4e9c1efa018b4155b1
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>

diff --git a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/NicDaoZusammenImpl.java b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/NicDaoZusammenImpl.java
index 268e254..b3f9a52 100644 (file)
--- a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/NicDaoZusammenImpl.java
+++ b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/NicDaoZusammenImpl.java
@@ -37,7 +37,7 @@ public class NicDaoZusammenImpl implements NicDao {
 
   @Override
   public void registerVersioning(String versionableEntityType) {
-
+    // registerVersioning is not implemented for NicDaoZusammenImpl
   }
 
   @Override
@@ -48,10 +48,10 @@ public class NicDaoZusammenImpl implements NicDao {
 
   private Collection<NicEntity> listNics(SessionContext context, ElementContext elementContext,
                                          NicEntity nic) {
-    ElementToNicConvertor convertor = new ElementToNicConvertor();
     return zusammenAdaptor.listElementsByName(context, elementContext, new Id(nic.getComponentId()),
         ElementType.Nics.name())
-        .stream().map(convertor::convert)
+        .stream()
+        .map(new ElementToNicConvertor()::convert)
         .map(nicEntity -> {
           nicEntity.setComponentId(nicEntity.getComponentId());
           nicEntity.setVspId(nic.getVspId());
@@ -199,7 +199,7 @@ public class NicDaoZusammenImpl implements NicDao {
 
   @Override
   public void deleteByVspId(String vspId, Version version) {
-
+    // deleteByVspId not implemented for NicDaoZusammenImpl
   }
 
   private ZusammenElement nicToZusammen(NicEntity nic, Action action) {