CodeCoverage improvement for dcaegen2-services-slice-analysis-ms

Issue-ID: DCAEGEN2-3157
Signed-off-by: zhaoyh6 <zhaoyh6@asiainfo.com>
Change-Id: I54d579f3b045db61dbc7cdbbd0f90fe56fd21b27

diff --git a/components/slice-analysis-ms/ChangeLog.md b/components/slice-analysis-ms/ChangeLog.md
index 08bc5b5..f3a6910 100644 (file)
--- a/components/slice-analysis-ms/ChangeLog.md
+++ b/components/slice-analysis-ms/ChangeLog.md
@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [1.1.4] - 2022/07/28
          - [DCAEGEN2-3120](https://jira.onap.org/browse/DCAEGEN2-3120) - Enhance sliceanalysis MS to use DCAE SDK dmaap-client lib
+         - [DCAEGEN2-3157](https://jira.onap.org/browse/DCAEGEN2-3157) - CodeCoverage improvement for dcaegen2-services-slice-analysis-ms
 
 ## [1.1.3] - 2022/05/11
          - [DCAEGEN2-3156](https://jira.onap.org/browse/DCAEGEN2-3156) - Fix bug in fetching PM data from DES

diff --git a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/AggregatedConfigTest.java b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/AggregatedConfigTest.java
index c8d999e..e9097ad 100644 (file)
--- a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/AggregatedConfigTest.java
+++ b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/AggregatedConfigTest.java
@@ -21,6 +21,7 @@
 
 package org.onap.slice.analysis.ms.models;
 
+import nl.jqno.equalsverifier.EqualsVerifier;
 import org.apache.commons.lang3.StringUtils;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -30,6 +31,8 @@ import org.powermock.modules.junit4.PowerMockRunnerDelegate;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.junit4.SpringRunner;
 
+import javax.validation.constraints.NotEmpty;
+
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -72,4 +75,10 @@ public class AggregatedConfigTest {
         assertTrue(StringUtils.isNotBlank(aggregatedConfig.toString()));
         assertTrue(aggregatedConfig.hashCode() != 0);
     }
+    @Test
+    public void equalsContract() {
+        EqualsVerifier.simple().forClass(AggregatedConfig.class)
+                .withIgnoredAnnotations(NotEmpty.class)
+                .verify();
+    }
 }

diff --git a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigDetailsTest.java b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigDetailsTest.java
index b843df5..c1f3000 100644 (file)
--- a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigDetailsTest.java
+++ b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigDetailsTest.java
@@ -21,6 +21,7 @@
 
 package org.onap.slice.analysis.ms.models;
 
+import nl.jqno.equalsverifier.EqualsVerifier;
 import org.apache.commons.lang3.StringUtils;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -30,6 +31,8 @@ import org.powermock.modules.junit4.PowerMockRunnerDelegate;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.junit4.SpringRunner;
 
+import javax.validation.constraints.NotEmpty;
+
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -70,4 +73,11 @@ public class SliceConfigDetailsTest {
         assertTrue(StringUtils.isNotBlank(sliceConfigDetails.toString()));
         assertTrue(sliceConfigDetails.hashCode() != 0);
     }
+
+    @Test
+    public void equalsContract() {
+        EqualsVerifier.simple().forClass(SliceConfigDetails.class)
+                .withIgnoredAnnotations(NotEmpty.class)
+                .verify();
+    }
 }

diff --git a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigRequestTest.java b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigRequestTest.java
index f688bb6..bccc9b6 100644 (file)
--- a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigRequestTest.java
+++ b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigRequestTest.java
@@ -21,6 +21,7 @@
 
 package org.onap.slice.analysis.ms.models;
 
+import nl.jqno.equalsverifier.EqualsVerifier;
 import org.apache.commons.lang3.StringUtils;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -30,6 +31,7 @@ import org.powermock.modules.junit4.PowerMockRunnerDelegate;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.junit4.SpringRunner;
 
+import javax.validation.constraints.NotEmpty;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -76,4 +78,10 @@ public class SliceConfigRequestTest {
         assertTrue(StringUtils.isNotBlank(sliceConfigRequest.toString()));
         assertTrue(sliceConfigRequest.hashCode() != 0);
     }
+    @Test
+    public void equalsContract() {
+        EqualsVerifier.simple().forClass(SliceConfigRequest.class)
+                .withIgnoredAnnotations(NotEmpty.class)
+                .verify();
+    }
 }

diff --git a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigResponseTest.java b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigResponseTest.java
index 78c42da..c8373c8 100644 (file)
--- a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigResponseTest.java
+++ b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/SliceConfigResponseTest.java
@@ -21,6 +21,7 @@
 
 package org.onap.slice.analysis.ms.models;
 
+import nl.jqno.equalsverifier.EqualsVerifier;
 import org.apache.commons.lang3.StringUtils;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -30,6 +31,7 @@ import org.powermock.modules.junit4.PowerMockRunnerDelegate;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.junit4.SpringRunner;
 
+import javax.validation.constraints.NotEmpty;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -70,4 +72,10 @@ public class SliceConfigResponseTest {
         assertTrue(StringUtils.isNotBlank(sliceConfigResponse.toString()));
         assertTrue(sliceConfigResponse.hashCode() != 0);
     }
+    @Test
+    public void equalsContract() {
+        EqualsVerifier.simple().forClass(SliceConfigResponse.class)
+                .withIgnoredAnnotations(NotEmpty.class)
+                .verify();
+    }
 }

diff --git a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/RelationshipListTest.java b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/RelationshipListTest.java
index 5e7640f..8ecd395 100644 (file)
--- a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/RelationshipListTest.java
+++ b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/RelationshipListTest.java
@@ -24,6 +24,7 @@ package org.onap.slice.analysis.ms.models.aai;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.gson.JsonArray;
+import nl.jqno.equalsverifier.EqualsVerifier;
 import org.apache.commons.lang3.StringUtils;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -110,4 +111,9 @@ public class RelationshipListTest {
         assertTrue(relationshipList1.equals(relationshipList));
         assertTrue(StringUtils.isNotBlank(relationshipList.toString()));
     }
+    @Test
+    public void equalsContract() {
+        EqualsVerifier.simple().forClass(RelationshipList.class)
+                .verify();
+    }
 }

diff --git a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/RelationshipTest.java b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/RelationshipTest.java
index 3bd563b..764671a 100644 (file)
--- a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/RelationshipTest.java
+++ b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/RelationshipTest.java
@@ -24,6 +24,7 @@ package org.onap.slice.analysis.ms.models.aai;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.gson.JsonArray;
+import nl.jqno.equalsverifier.EqualsVerifier;
 import org.apache.commons.lang3.StringUtils;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -97,4 +98,10 @@ public class RelationshipTest {
         assertTrue(StringUtils.isNotBlank(relationship1.toString()));
 
     }
+
+    @Test
+    public void equalsContract() {
+        EqualsVerifier.simple().forClass(Relationship.class)
+                .verify();
+    }
 }

diff --git a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/ServiceInstanceTest.java b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/ServiceInstanceTest.java
index 3a55016..8f27590 100644 (file)
--- a/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/ServiceInstanceTest.java
+++ b/components/slice-analysis-ms/src/test/java/org/onap/slice/analysis/ms/models/aai/ServiceInstanceTest.java
@@ -21,6 +21,7 @@
 
 package org.onap.slice.analysis.ms.models.aai;
 
+import nl.jqno.equalsverifier.EqualsVerifier;
 import org.apache.commons.lang3.StringUtils;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -101,4 +102,10 @@ public class ServiceInstanceTest {
         assertTrue(serviceInstance1.equals(serviceInstance));
         assertTrue(StringUtils.isNotBlank(serviceInstance.toString()));
     }
+
+    @Test
+    public void equalsContract() {
+        EqualsVerifier.simple().forClass(ServiceInstance.class)
+                .verify();
+    }
 }