[TEST] Do not show "No execution start time..." error log message for skipped substeps 77/125177/1
authorMichal Jagiello <michal.jagiello@t-mobile.pl>
Thu, 21 Oct 2021 10:49:07 +0000 (10:49 +0000)
committerMichal Jagiello <michal.jagiello@t-mobile.pl>
Thu, 21 Oct 2021 10:49:07 +0000 (10:49 +0000)
If one of the step fails and there are more substeps in the scenario then they won't be executed.
During the report creation in the code the status of these steps were not checked and the confusing
error message was logged.
That change provide additional check if the step was skipped (not executed).

Issue-ID: TEST-368
Signed-off-by: Michal Jagiello <michal.jagiello@t-mobile.pl>
Change-Id: Id1ea95229b2fd5cf3107d423f356f02dab437669

src/onaptests/steps/base.py

index 4d6858d..97c9159 100644 (file)
@@ -187,8 +187,9 @@ class BaseStep(ABC):
                     )
                 else:
                     if not self._start_execution_time:
-                        self._logger.error("No execution start time saved for %s step. Fix it by call `super.execute()` "
-                                           "in step class `execute()` method definition", self.name)
+                        if execution_status != ReportStepStatus.NOT_EXECUTED:
+                            self._logger.error("No execution start time saved for %s step. Fix it by call `super.execute()` "
+                                               "in step class `execute()` method definition", self.name)
                         self._start_execution_time = time.time()
                     self._execution_report = Report(
                         step_description=f"[{self.component}] {self.name}: {self.description}",