removed code smells in some components

removed code smells in some components

Issue-ID: PORTAL-813
Change-Id: Ie0c630d2a4fd704a5273302d6deb1915e9a160f6
Signed-off-by: Indrijeet Kumar <indriku1@in.ibm.com>

diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportRuntime.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportRuntime.java
index d10826a..c62e1f0 100644 (file)
--- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportRuntime.java
+++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportRuntime.java
@@ -1129,9 +1129,6 @@ public class ReportRuntime extends ReportWrapper implements Cloneable, Serializa
                Vector visibleCols = new Vector(reportCols.size());
                Vector formatProcessors = new Vector(reportCols.size());
 
-               // ColumnHeaderRow chr = new ColumnHeaderRow();
-               // rd.reportColumnHeaderRows.addColumnHeaderRow(chr);
-               // chr.setRowHeight("30");
         int count =0 ;
                ReportFormFields rff = getReportFormFields();
                ReportFormFields childReportFormFields = null;
@@ -1189,7 +1186,6 @@ public class ReportRuntime extends ReportWrapper implements Cloneable, Serializa
                                                        }
                                                }
                                        }
-                               //}
                                
                                String widthInPxls = dc.getDisplayWidthInPxls();
                                
@@ -1446,7 +1442,6 @@ public class ReportRuntime extends ReportWrapper implements Cloneable, Serializa
                                                        }
                                                }
                                        }
-                               //}
                                
                                String widthInPxls = dc.getDisplayWidthInPxls();
                                

diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResult.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResult.java
index b68acec..82d3f76 100644 (file)
--- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResult.java
+++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResult.java
@@ -68,13 +68,6 @@ public class ReportSearchResult extends SearchResult {
                                "Are you sure you want to create a copy of this report?", AppUtils
                                                .getImgFolderURL()
                                                + "modify_icon.gif", "13", "12", true, false, false));
-               /*addColumn(new SearchResultColumn("  Schedule  ", "5%", "Center",
-                               "document." + HTML_FORM + "." + AppConstants.RI_ACTION
-                                               + ".value='report.schedule_only';", "Schedule report", HTML_FORM,
-                               null, AppUtils
-                                               .getImgFolderURL()
-                                               + "calendar_icon.gif", "13", "12", true, false, false));
-                                               */
 
                addColumn(new SearchResultColumn("edit","  Edit  ", "5%", "Center",
                                "document." + HTML_FORM + "." + AppConstants.RI_ACTION

diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultField.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultField.java
index 9f32eeb..7d74f59 100644 (file)
--- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultField.java
+++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultField.java
@@ -216,17 +216,6 @@ public class SearchResultField extends org.onap.portalsdk.analytics.RaptorObject
                return (displayValue.length() == 0) ? " " : displayValue;
        }
 
-       /*public String getAlignmentHtml() {
-               return (alignment.length() == 0) ? "" : (" align=" + alignment);
-       }*/
-
-       /*public String getDisplayValueLinkHtml() {
-               if (nvl(drillDownLink).length() == 0)
-                       return getDisplayValueHtml();
-               else
-                       return getDrillDownLink();
-       } // getDisplayValueLinkHtml*/
-
        public String getColumnId() {
                return columnId;
        }

diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultRow.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultRow.java
index 9bb5c7d..d141eb4 100644 (file)
--- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultRow.java
+++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultRow.java
@@ -65,8 +65,6 @@ class ColumnContent {
 }
 public class SearchResultRow extends ArrayList {
        
-
-       //private SearchResultField searchresultField;
        private int nextElemIdx = 0;
 
        public void resetNext() {