Merge this if statement with the nested one 87/98087/2
authoranushadasari <danush10@in.ibm.com>
Thu, 7 Nov 2019 07:18:23 +0000 (12:48 +0530)
committerIttay Stern <ittay.stern@att.com>
Sun, 24 Nov 2019 16:34:58 +0000 (16:34 +0000)
Merging collapsible if statements increases the code's readability.

Issue-ID: VID-699
Change-Id: Icb52f1e1fcaec6ebfec3711c32c4cfcca9582af6
Signed-off-by: anushadasari <danush10@in.ibm.com>
vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js

index 6d8dde8..4b6b0f4 100755 (executable)
             var isVfc = false;\r
 \r
             _.map($scope.service.model.vnfs, function (value, key) {\r
-                if (value.uuid == vnf.uuid) {\r
-                    if (!_.isEmpty(value.vfcInstanceGroups)) {\r
+                if (value.uuid == vnf.uuid && !_.isEmpty(value.vfcInstanceGroups)) {\r
                         isVfc = true;\r
                         var queryData = {\r
                             serviceModelId: $scope.service.model.service.uuid,\r
                         $scope.$broadcast(COMPONENT.IFRAME_DIALOG, queryData);\r
                         return;\r
                     }\r
-                }\r
             });\r
 \r
             DataService.setSubscriberName($scope.service.instance.subscriberName);\r