Fixing Sonar blocker

1 . Fixing Sonar blocker which already existed in VersionManagerImpl
2 . As part of foundation changes refactoring, the versioning features used
by Action Library code was moved to ActionVersioningManagerImpl

Change-Id: I7b56d63c1e85e8dda1d4948c590ce577826cfe99
Issue-ID: SDC-1039
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>

diff --git a/openecomp-be/lib/openecomp-sdc-versioning-lib/openecomp-sdc-versioning-core/src/main/java/org/openecomp/sdc/versioning/impl/ActionVersioningManagerImpl.java b/openecomp-be/lib/openecomp-sdc-versioning-lib/openecomp-sdc-versioning-core/src/main/java/org/openecomp/sdc/versioning/impl/ActionVersioningManagerImpl.java
index 0763ad9..11c5226 100644 (file)
--- a/openecomp-be/lib/openecomp-sdc-versioning-lib/openecomp-sdc-versioning-core/src/main/java/org/openecomp/sdc/versioning/impl/ActionVersioningManagerImpl.java
+++ b/openecomp-be/lib/openecomp-sdc-versioning-lib/openecomp-sdc-versioning-core/src/main/java/org/openecomp/sdc/versioning/impl/ActionVersioningManagerImpl.java
@@ -146,11 +146,11 @@ public class ActionVersioningManagerImpl implements ActionVersioningManager {
     }
     if (viewableVersions != null) {
       viewableVersions.forEach(version -> version.setStatus(status));
+      versionInfo.setViewableVersions(toSortedList(viewableVersions));
+      versionInfo.setFinalVersions(getFinalVersions(viewableVersions));
     }
     versionInfo.setActiveVersion(activeVersion);
     versionInfo.setLatestFinalVersion(latestFinalVersion);
-    versionInfo.setViewableVersions(toSortedList(viewableVersions));
-    versionInfo.setFinalVersions(getFinalVersions(viewableVersions));
     if (candidate != null) {
       candidate.getVersion().setStatus(status);
       versionInfo.setLockingUser(candidate.getUser());