Fixed sonar issue i PolicyFinderServiceImpl.java

Fixed major sonar issues
Issue-ID: CCSDK-819
Change-Id: I2347aa5f234b33231b7782e6a51d0ba5a1b60dfd
Signed-off-by: ezhil <ezhrajam@in.ibm.com>

diff --git a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/service/extinf/impl/PolicyFinderServiceImpl.java b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/service/extinf/impl/PolicyFinderServiceImpl.java
index b30ac0e..ce7e3fd 100644 (file)
--- a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/service/extinf/impl/PolicyFinderServiceImpl.java
+++ b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/service/extinf/impl/PolicyFinderServiceImpl.java
@@ -85,8 +85,7 @@ public class PolicyFinderServiceImpl implements PolicyFinder {
     GetConfigResponse getConfig(String policyName) throws Exception {
         GetConfigRequest getConfigRequest = new GetConfigRequest();
         getConfigRequest.setPolicyName(policyName);
-        GetConfigResponse getConfigResponse = makeOutboundCall(getConfigRequest, GetConfigResponse.class);
-        return getConfigResponse;
+        return (makeOutboundCall(getConfigRequest, GetConfigResponse.class));
     }
 
     <T, R> GetConfigResponse makeOutboundCall(T request, Class<R> response) throws Exception {
@@ -97,7 +96,8 @@ public class PolicyFinderServiceImpl implements PolicyFinder {
             ResponseEntity<Object> resp = getRestTemplate().exchange(re, Object.class);
             if (HttpStatus.OK.equals(resp.getStatusCode())) {
                 ObjectMapper objectmapper = new ObjectMapper();
-                System.out.println(objectmapper.writeValueAsString(resp.getBody()));
+                log.info(objectmapper.writeValueAsString(resp.getBody()));
+                //System.out.println(objectmapper.writeValueAsString(resp.getBody()));
                 List<Map<Object, Object>> respObj = objectmapper.readValue(
                                 objectmapper.writeValueAsString(resp.getBody()),
                                                 new TypeReference<List<Map<Object, Object>>>() {});