fix alarm clear information analysis bug

Change-Id: Iafa4a7bd89e231bd0c9c5d0901a0a477d48b8e80
Issue-ID: USECASEUI-119
Signed-off-by: zhangab <zhanganbing@chinamobile.com>

diff --git a/server/src/main/java/org/onap/usecaseui/server/service/impl/AlarmsHeaderServiceImpl.java b/server/src/main/java/org/onap/usecaseui/server/service/impl/AlarmsHeaderServiceImpl.java
index 2c63fdc..d290708 100755 (executable)
--- a/server/src/main/java/org/onap/usecaseui/server/service/impl/AlarmsHeaderServiceImpl.java
+++ b/server/src/main/java/org/onap/usecaseui/server/service/impl/AlarmsHeaderServiceImpl.java
@@ -375,7 +375,6 @@ public class AlarmsHeaderServiceImpl implements AlarmsHeaderService {
             Query q=session.createQuery("update AlarmsHeader set status=:status, startEpochMicrosecCleared=:startEpochMicrosecCleared  ,lastEpochMicroSecCleared=:lastEpochMicroSecCleared    where eventName=:eventName and reportingEntityName=:reportingEntityName and specificProblem =:specificProblem");\r
 \r
             q.setString("status",status);\r
-            q.setDate("date",date);\r
 \r
             q.setString("startEpochMicrosecCleared",startEpochMicrosecCleared);\r
             q.setString("lastEpochMicroSecCleared",lastEpochMicroSecCleared);\r

diff --git a/server/src/main/java/org/onap/usecaseui/server/service/impl/AlarmsInformationServiceImpl.java b/server/src/main/java/org/onap/usecaseui/server/service/impl/AlarmsInformationServiceImpl.java
index b1d8d07..f5d590a 100755 (executable)
--- a/server/src/main/java/org/onap/usecaseui/server/service/impl/AlarmsInformationServiceImpl.java
+++ b/server/src/main/java/org/onap/usecaseui/server/service/impl/AlarmsInformationServiceImpl.java
@@ -56,7 +56,6 @@ public class AlarmsInformationServiceImpl implements AlarmsInformationService {
                                if (null == alarmsInformation) {\r
                                        logger.error("alarmsInformation saveAlarmsInformation alarmsInformation is null!");\r
                                }\r
-                               logger.info("AlarmsInformationServiceImpl saveAlarmsInformation: alarmsInformation={}", alarmsInformation);\r
                                Transaction tx = session.beginTransaction();\r
                                session.save(alarmsInformation);\r
                                tx.commit();\r
@@ -75,7 +74,6 @@ public class AlarmsInformationServiceImpl implements AlarmsInformationService {
                        if (null == alarmsInformation) {\r
                                logger.error("alarmsInformation updateAlarmsInformation alarmsInformation is null!");\r
                        }\r
-                       logger.info("AlarmsInformationServiceImpl updateAlarmsInformation: alarmsInformation={}", alarmsInformation);\r
                        Transaction tx = session.beginTransaction();\r
                        session.update(alarmsInformation);\r
                        tx.commit();\r
@@ -92,7 +90,6 @@ public class AlarmsInformationServiceImpl implements AlarmsInformationService {
                try(Session session = getSession()){\r
                        StringBuffer hql = new StringBuffer("select count(*) from AlarmsInformation a where 1=1");\r
                        if (null == alarmsInformation) {\r
-                               logger.error("AlarmsInformationServiceImpl getAllCount alarmsInformation is null!");\r
                        }else {\r
                                if(null!=alarmsInformation.getName()) {\r
                                        String ver=alarmsInformation.getName();\r
@@ -153,7 +150,6 @@ public class AlarmsInformationServiceImpl implements AlarmsInformationService {
                                        hql.append(" and a.startEpochMicrosec between :startTime and :endTime");\r
                                }\r
                        }\r
-                       logger.info("AlarmsInformationServiceImpl queryAlarmsInformation: alarmsInformation={}", alarmsInformation);\r
                        Query query = session.createQuery(hql.toString());\r
                        if(null!=alarmsInformation.getStartEpochMicroSec() || alarmsInformation.getLastEpochMicroSec()!= null) {\r
                                query.setString("startTime",alarmsInformation.getStartEpochMicroSec());\r
@@ -179,7 +175,6 @@ public class AlarmsInformationServiceImpl implements AlarmsInformationService {
        public List<AlarmsInformation> queryId(String[] id) {\r
                try {\r
                        if(id.length==0) {\r
-                               logger.error("AlarmsInformationServiceImpl queryId is null!");\r
                        }\r
                        List<AlarmsInformation> list = new ArrayList<AlarmsInformation>();\r
                        Session session = getSession();\r

diff --git a/server/src/main/java/org/onap/usecaseui/server/service/impl/PerformanceHeaderServiceImpl.java b/server/src/main/java/org/onap/usecaseui/server/service/impl/PerformanceHeaderServiceImpl.java
index 4a5815a..9a30b21 100755 (executable)
--- a/server/src/main/java/org/onap/usecaseui/server/service/impl/PerformanceHeaderServiceImpl.java
+++ b/server/src/main/java/org/onap/usecaseui/server/service/impl/PerformanceHeaderServiceImpl.java
@@ -57,7 +57,6 @@ public class PerformanceHeaderServiceImpl implements PerformanceHeaderService {
                                logger.error("PerformanceHeaderServiceImpl savePerformanceHeader performanceHeder is null!");\r
                                return "0";\r
                        }\r
-                       logger.info("PerformanceHeaderServiceImpl savePerformanceHeader: performanceHeder={}", performanceHeder);\r
                        Transaction tx = session.beginTransaction();\r
                        session.save(performanceHeder);\r
                        tx.commit();\r
@@ -76,7 +75,6 @@ public class PerformanceHeaderServiceImpl implements PerformanceHeaderService {
                                logger.error("PerformanceHeaderServiceImpl updatePerformanceHeader performanceHeder is null!");\r
                                return "0";\r
                        }\r
-                       logger.info("PerformanceHeaderServiceImpl updatePerformanceHeader: performanceHeder={}", performanceHeder);\r
                        Transaction tx = session.beginTransaction();\r
                        session.update(performanceHeder);\r
                        tx.commit();\r
@@ -92,7 +90,6 @@ public class PerformanceHeaderServiceImpl implements PerformanceHeaderService {
                try(Session session = getSession()){\r
                        StringBuffer hql = new StringBuffer("select count(*) from PerformanceHeader a where 1=1");\r
                        if (null == performanceHeder) {\r
-                               logger.error("PerformanceHeaderServiceImpl getAllCount performanceHeder is null!");\r
                                return 0;\r
                        }else {\r
                                if(null!=performanceHeder.getVersion()) {\r
@@ -190,7 +187,6 @@ public class PerformanceHeaderServiceImpl implements PerformanceHeaderService {
                try(Session session = getSession()){\r
                        StringBuffer hql =new StringBuffer("from PerformanceHeader a where 1=1");\r
                        if (null == performanceHeder) {\r
-                               logger.error("PerformanceHeaderServiceImpl queryPerformanceHeader performanceHeder is null!");\r
                                return page;\r
                        }else {\r
                                if(null!=performanceHeder.getVersion()) {\r
@@ -265,7 +261,6 @@ public class PerformanceHeaderServiceImpl implements PerformanceHeaderService {
                                        hql.append(" and a.startEpochMicrosec between :startTime and :endTime ");\r
                                }\r
                        }\r
-                       logger.info("PerformanceHeaderServiceImpl queryPerformanceHeader: performanceHeder={}", performanceHeder);\r
                        Query query = session.createQuery(hql.toString());\r
                        if(null!=performanceHeder.getStartEpochMicrosec() && null!=performanceHeder.getLastEpochMicroSec()) {\r
                                query.setString("startTime",performanceHeder.getStartEpochMicrosec()).setString("endTime",performanceHeder.getLastEpochMicroSec());\r
@@ -291,7 +286,6 @@ public class PerformanceHeaderServiceImpl implements PerformanceHeaderService {
                try(Session session = getSession()) {\r
                        List<PerformanceHeader> list = new ArrayList<PerformanceHeader>();\r
                        if(id.length==0) {\r
-                               logger.error("PerformanceHeaderServiceImpl queryId is null!");\r
                                return list;\r
                        }\r
                        Query query = session.createQuery("from PerformanceHeader a where a.eventName IN (:alist)");\r

diff --git a/server/src/main/java/org/onap/usecaseui/server/service/impl/PerformanceInformationServiceImpl.java b/server/src/main/java/org/onap/usecaseui/server/service/impl/PerformanceInformationServiceImpl.java
index 858bf8b..a1d5561 100755 (executable)
--- a/server/src/main/java/org/onap/usecaseui/server/service/impl/PerformanceInformationServiceImpl.java
+++ b/server/src/main/java/org/onap/usecaseui/server/service/impl/PerformanceInformationServiceImpl.java
@@ -59,9 +59,7 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
        public String savePerformanceInformation(PerformanceInformation performanceInformation) {\r
        try(Session session = getSession()) {\r
                        if (null == performanceInformation) {\r
-                               logger.error("performanceInformation savePerformanceInformation performanceInformation is null!");\r
                        }\r
-                       logger.info("PerformanceInformationServiceImpl savePerformanceInformation: performanceInformation={}", performanceInformation);\r
                        Transaction tx = session.beginTransaction();\r
                        session.save(performanceInformation);\r
                        tx.commit();\r
@@ -77,7 +75,6 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
        public String updatePerformanceInformation(PerformanceInformation performanceInformation) {\r
                try(Session session = getSession()) {\r
                        if (null == performanceInformation) {\r
-                               logger.error("performanceInformation updatePerformanceInformation performanceInformation is null!");\r
                        }\r
                        logger.info("PerformanceInformationServiceImpl updatePerformanceInformation: performanceInformation={}", performanceInformation);\r
                        Transaction tx = session.beginTransaction();\r
@@ -95,7 +92,6 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
                try(Session session = getSession()){\r
                        StringBuffer hql = new StringBuffer("select count(*) from PerformanceInformation a where 1=1");\r
                        if (null == performanceInformation) {\r
-                               logger.error("AlarmsInformationServiceImpl getAllCount performanceInformation is null!");\r
                        }else {\r
                                if(null!=performanceInformation.getName()) {\r
                                        String ver=performanceInformation.getName();\r
@@ -138,7 +134,6 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
                try(Session session = getSession()){\r
                        StringBuffer hql =new StringBuffer("from PerformanceInformation a where 1=1 ");\r
                        if (null == performanceInformation) {\r
-                               logger.error("AlarmsInformationServiceImpl queryPerformanceInformation performanceInformation is null!");\r
                        }else {\r
                                if(null!=performanceInformation.getName()) {\r
                                        String ver=performanceInformation.getName();\r
@@ -156,7 +151,6 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
                                        hql.append(" and a.startEpochMicrosec between :startTime and :endTime");\r
                                }\r
                        }\r
-                       logger.info("PerformanceInformationServiceImpl queryPerformanceInformation: performanceInformation={}", performanceInformation);\r
                        Query query = session.createQuery(hql.toString());\r
                        if(null!=performanceInformation.getStartEpochMicrosec() || performanceInformation.getLastEpochMicroSec()!= null) {\r
                                query.setString("startTime",performanceInformation.getStartEpochMicrosec());\r
@@ -183,7 +177,6 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
        public List<PerformanceInformation> queryId(String[] id) {\r
                try(Session session = getSession()) {\r
                        if(id.length==0) {\r
-                               logger.error("PerformanceInformationServiceImpl queryId is null!");\r
                        }\r
                        List<PerformanceInformation> list = new ArrayList<>();\r
                        Query query = session.createQuery("from PerformanceInformation a where a.sourceId IN (:alist)");\r
@@ -203,7 +196,6 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
                        List<PerformanceInformation> list = new ArrayList<>();\r
                        Query query = session.createQuery("from PerformanceInformation a where a.sourceId = :sourceId and a.createTime BETWEEN :startDate and :endDate");\r
                        list = query.setParameter("sourceId",sourceId).setParameter("startDate", startDate).setParameter("endDate",endDate).list();\r
-                       logger.info("PerformanceInformationServiceImpl queryDateBetween: list={}", list);\r
                        return list;\r
                } catch (Exception e) {\r
                        logger.error("exception occurred while performing PerformanceInformationServiceImpl queryDateBetween. Details:" + e.getMessage());\r
@@ -218,7 +210,6 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
                        int sum = 0;\r
                        Query query = session.createQuery("select sum(a.value) from PerformanceInformation a where a.sourceId = :sourceId and a.name = :name and a.createTime BETWEEN :startDate and :endDate");\r
                        sum = Integer.parseInt(query.setParameter("sourceId",sourceId).setParameter("name",name).setParameter("startDate", startDate).setParameter("endDate",endDate).uniqueResult().toString());\r
-                       logger.info("PerformanceInformationServiceImpl queryDataBetweenSum: sum={}", sum);\r
                        return sum;\r
                } catch (Exception e) {\r
                        logger.error("exception occurred while performing PerformanceInformationServiceImpl queryDataBetweenSum. Details:" + e.getMessage());\r
@@ -284,7 +275,7 @@ public class PerformanceInformationServiceImpl implements PerformanceInformation
                 hql += " and a.name = :name ";\r
             }\r
             if (startTime != null && !"".equals(startTime) && endTime != null && !"".equals(endTime)){\r
-                hql += " and a.startEpochMicrosec between :startTime and :endTime ";\r
+               hql += " and (CASE WHEN a.startEpochMicrosec=0 THEN a.lastEpochMicroSec ELSE a.startEpochMicrosec END) between :startTime and :endTime ";\r
             }\r
             Query query = session.createQuery(hql);\r
             if (sourceId != null && !"".equals(sourceId)){\r

diff --git a/server/src/main/java/org/onap/usecaseui/server/util/DmaapSubscriber.java b/server/src/main/java/org/onap/usecaseui/server/util/DmaapSubscriber.java
index 040417e..9b64ab6 100644 (file)
--- a/server/src/main/java/org/onap/usecaseui/server/util/DmaapSubscriber.java
+++ b/server/src/main/java/org/onap/usecaseui/server/util/DmaapSubscriber.java
@@ -173,9 +173,9 @@ public class DmaapSubscriber implements Runnable {
                     if (k2.equals("priority"))
                         alarm_header.setPriority(v2.toString());
                     if (k2.equals("startEpochMicrosec"))
-                        alarm_header.setStartEpochMicrosec(v2.toString().substring(0, 13));
+                        alarm_header.setStartEpochMicrosec(this.getTime(v2.toString()));
                     if (k2.equals("lastEpochMicrosec"))
-                        alarm_header.setLastEpochMicroSec(v2.toString().substring(0, 13));
+                        alarm_header.setLastEpochMicroSec(this.getTime(v2.toString()));
                     if (k2.equals("sequence"))
                         alarm_header.setSequence(v2.toString());
                 });
@@ -211,7 +211,7 @@ public class DmaapSubscriber implements Runnable {
                 });
             }
         });
-        if (alarm_header.getEventName() != null){
+        if (alarm_header.getEventName() != null&&(alarm_header.getStartEpochMicrosec().length()>=13||alarm_header.getLastEpochMicroSec().length()>=13)){
         Long l = System.currentTimeMillis();
 
         Timestamp date_get = new Timestamp(l);
@@ -264,9 +264,9 @@ public class DmaapSubscriber implements Runnable {
                             if (k2.equals("priority"))
                                 performance_header.setPriority(v2.toString());
                             if (k2.equals("startEpochMicrosec"))
-                                performance_header.setStartEpochMicrosec(v2.toString().substring(0, 13));
+                                performance_header.setStartEpochMicrosec(this.getTime(v2.toString()));
                             if (k2.equals("lastEpochMicrosec"))
-                                performance_header.setLastEpochMicroSec(v2.toString().substring(0, 13));
+                                performance_header.setLastEpochMicroSec(this.getTime(v2.toString()));
                             if (k2.equals("sequence"))
                                 performance_header.setSequence(v2.toString());
                         });
@@ -295,11 +295,21 @@ public class DmaapSubscriber implements Runnable {
                                 }
                             }
                         });
-                        performanceHeaderService.savePerformanceHeader(performance_header);
-                        performance_informations.forEach(ai -> {
-                            performanceInformationService.savePerformanceInformation(ai);
-                        });
+                        if ((performance_header.getStartEpochMicrosec().length()>=13||performance_header.getLastEpochMicroSec().length()>=13)){//时间有效才会进行存储
+                               performanceHeaderService.savePerformanceHeader(performance_header);
+                               performance_informations.forEach(ai -> {
+                                       performanceInformationService.savePerformanceInformation(ai);
+                               });
+                        }
                     }
                 });
     }
+    
+    private String getTime(String time){
+       String result=time;
+       if(time.length()>=13){
+               result=time.substring(0, 13);
+       }
+       return result;
+    }
 }
\ No newline at end of file

diff --git a/standalone/src/main/assembly/bin/run.sh b/standalone/src/main/assembly/bin/run.sh
index 08d659c..25a83d5 100644 (file)
--- a/standalone/src/main/assembly/bin/run.sh
+++ b/standalone/src/main/assembly/bin/run.sh
@@ -21,15 +21,11 @@ echo @RUNHOME@ $RUNHOME
 
 echo "Starting mysql"
 service mysql start
-sleep 10
-echo "run.sh 1"
+sleep 100
 
 SCRIPT="/home/uui/resources/bin/initDB.sh"
-echo "run.sh 2"
 chmod 755 $SCRIPT
-echo "run.sh 3"
-$SCRIPT  root root 3306 127.0.0.1
-echo "run.sh 4"
+$SCRIPT root root 3306 127.0.0.1
 
 echo @JAVA_HOME@ $JAVA_HOME
 JAVA="$JAVA_HOME/bin/java"

diff --git a/standalone/src/main/assembly/resources/bin/initDB.sh b/standalone/src/main/assembly/resources/bin/initDB.sh
index b950492..06d2bfc 100644 (file)
--- a/standalone/src/main/assembly/resources/bin/initDB.sh
+++ b/standalone/src/main/assembly/resources/bin/initDB.sh
@@ -1,4 +1,4 @@
-#! /bin/bash
+#!/bin/bash
 #
 # Copyright (C) 2017 CMCC, Inc. and others. All rights reserved.
 #
@@ -15,21 +15,15 @@
 # limitations under the License.
 #
 
-echo "initDB.sh 1"
 DIRNAME=`dirname $0`
-echo "initDB.sh 2"
 HOME=`cd $DIRNAME/; pwd`
-echo "initDB.sh 3"
 user=$1
 password=$2
 port=$3
 host=$4
-echo "initDB.sh 4"
 echo "start create usecase-ui db"
 sql_path=$HOME/../
-echo "initDB.sh 5"
 mysql -u$user -p$password -P$port -h$host <$sql_path/dbscripts/mysql/usecase-ui-createdb.sql
-echo "initDB.sh 6"
 sql_result=$?
 if [ $sql_result != 0 ] ; then
     echo "failed to create usecase-ui database"