Added close() call for InputStream instance to 63/92763/1
authorOleksandr Moliavko <o.moliavko@samsung.com>
Tue, 6 Aug 2019 08:59:56 +0000 (11:59 +0300)
committerOleksandr Moliavko <o.moliavko@samsung.com>
Tue, 6 Aug 2019 08:59:56 +0000 (11:59 +0300)
remove static analyzer warning about handle
leak in getMsoAaiPassword()

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I2be9cc72f78275a80c6f03d806bea2ad275f23b4

bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/common/util/CryptoHandler.java

index dc2b3be..5c0406c 100644 (file)
@@ -24,6 +24,7 @@
 package org.onap.so.bpmn.common.util;
 
 import java.io.IOException;
+import java.io.InputStream;
 import java.security.GeneralSecurityException;
 import java.util.Properties;
 import org.onap.so.utils.CryptoUtils;
@@ -40,7 +41,10 @@ public class CryptoHandler implements ICryptoHandler {
     public String getMsoAaiPassword() {
         Properties keyProp = new Properties();
         try {
-            keyProp.load(Thread.currentThread().getContextClassLoader().getResourceAsStream("urn.properties"));
+            ClassLoader cl = Thread.currentThread().getContextClassLoader();
+            InputStream rs = cl.getResourceAsStream("urn.properties");
+            keyProp.load(rs);
+            rs.close();
             return CryptoUtils.decrypt((String) keyProp.get(PROPERTY_KEY), MSO_KEY);
         } catch (GeneralSecurityException | IOException e) {
             logger.error(GENERAL_SECURITY_EXCEPTION_PREFIX + e.getMessage(), e);