Remove mockito from TypeUtilsTest 49/106849/2
authorRodrigo Lima <rodrigo.lima@yoppworks.com>
Wed, 29 Apr 2020 19:39:56 +0000 (15:39 -0400)
committerOfir Sonsino <ofir.sonsino@intl.att.com>
Thu, 30 Apr 2020 14:00:18 +0000 (14:00 +0000)
- Remove the use of mockito verify from TypeUtilsTest

Issue-ID: SDC-2993
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I42c9c972cead10afaa3ec299624cf3d26e4d04db

common-be/src/test/java/org/openecomp/sdc/be/utils/TypeUtilsTest.java

index 2f6ddf9..182eede 100644 (file)
 package org.openecomp.sdc.be.utils;
 
 import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.Mockito;
-import org.mockito.junit.MockitoJUnitRunner;
 import org.openecomp.sdc.be.utils.TypeUtils.ToscaTagNamesEnum;
 
 import java.util.HashMap;
 import java.util.Map;
-import java.util.function.Consumer;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
 
-@RunWith(MockitoJUnitRunner.class)
 public class TypeUtilsTest {
 
     private static final String ANY_GROUP = "anyGroup";
 
-    @SuppressWarnings("unchecked")
-    private Consumer<String> anyConsumer = (Consumer<String>) Mockito.spy(Consumer.class);
+    private class DummyClass {
+        private String field;
+
+        public void setField(String field) { this.field = field; }
+        public String getField() { return this.field; }
+    }
 
     @Test
     public void testSetFieldShouldConsumeForJSONContainingParam() {
+        DummyClass dummyObject = new DummyClass();
         Map<String, Object> toscaJson = new HashMap<>();
         toscaJson.put(ToscaTagNamesEnum.GROUPS.getElementName(), ANY_GROUP);
-        TypeUtils.setField(toscaJson, ToscaTagNamesEnum.GROUPS, anyConsumer);
-        Mockito.verify(anyConsumer).accept(ANY_GROUP);
+        TypeUtils.setField(toscaJson, ToscaTagNamesEnum.GROUPS, dummyObject::setField);
+        assertEquals(ANY_GROUP, dummyObject.getField());
     }
 
     @Test
     public void testSetFieldShouldDoNothingForJSONNotContainingParam() {
+        DummyClass dummyObject = new DummyClass();
         Map<String, Object> toscaJson = new HashMap<>();
         toscaJson.put(ToscaTagNamesEnum.GROUPS.getElementName(), ANY_GROUP);
-        TypeUtils.setField(toscaJson, ToscaTagNamesEnum.INPUTS, anyConsumer);
-        Mockito.verifyZeroInteractions(anyConsumer);
+        TypeUtils.setField(toscaJson, ToscaTagNamesEnum.INPUTS, dummyObject::setField);
+        assertNull(dummyObject.getField());
     }
 
 }
\ No newline at end of file