Bugfix - Action mandatory param validation

Fix for actions getting created without passing
mandatory parameters

Change-Id: I3e332d92d0ad99b85d945ab25d7406e916642314
Issue-ID: SDC-1755
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>

diff --git a/openecomp-be/api/openecomp-sdc-rest-webapp/action-library-rest/action-library-rest-services/src/main/java/org/openecomp/sdcrests/action/rest/services/ActionsImpl.java b/openecomp-be/api/openecomp-sdc-rest-webapp/action-library-rest/action-library-rest-services/src/main/java/org/openecomp/sdcrests/action/rest/services/ActionsImpl.java
index 23f1184..2927a7f 100644 (file)
--- a/openecomp-be/api/openecomp-sdc-rest-webapp/action-library-rest/action-library-rest-services/src/main/java/org/openecomp/sdcrests/action/rest/services/ActionsImpl.java
+++ b/openecomp-be/api/openecomp-sdc-rest-webapp/action-library-rest/action-library-rest-services/src/main/java/org/openecomp/sdcrests/action/rest/services/ActionsImpl.java
@@ -97,7 +97,6 @@ import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
@@ -1040,10 +1039,8 @@ public class ActionsImpl implements Actions {
     if (StringUtils.isEmpty(requestJSON) || requestJSON.equals(REQUEST_EMPTY_BODY)) {
       requestBodyErrorMap.put(ACTION_INVALID_REQUEST_BODY_CODE, ACTION_REQUEST_BODY_EMPTY);
     } else {
-      if(requestType == ActionConstants.REQUEST_TYPE_CREATE_ACTION){
-        //placeholder for future implementation
-      }
-      if(requestType == ActionConstants.REQUEST_TYPE_UPDATE_ACTION){
+      if(requestType == ActionConstants.REQUEST_TYPE_CREATE_ACTION
+              || requestType == ActionConstants.REQUEST_TYPE_UPDATE_ACTION){
         //Semantic request specific validations
         Action action = JsonUtil.json2Object(requestJSON, Action.class);
         if(StringUtils.isEmpty(action.getName())){