Moved code inside IF checking for null ptr to prevent crash

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ie759b98828f39fba00ccdb7edcd7fc28e83ea50e

diff --git a/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/client/appc/ApplicationControllerAction.java b/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/client/appc/ApplicationControllerAction.java
index b97b9ac..9828d11 100644 (file)
--- a/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/client/appc/ApplicationControllerAction.java
+++ b/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/client/appc/ApplicationControllerAction.java
@@ -113,9 +113,9 @@ public class ApplicationControllerAction {
                 errorCode = Integer.toString(appCStatus.getCode());
                 errorMessage = appCStatus.getMessage();
 
-            }
-            if (ApplicationControllerSupport.getCategoryOf(appCStatus).equals(StatusCategory.NORMAL)) {
-                errorCode = "0";
+                if (ApplicationControllerSupport.getCategoryOf(appCStatus).equals(StatusCategory.NORMAL)) {
+                    errorCode = "0";
+                }
             }
         } catch (JsonProcessingException e) {
             logger.error("Incorrect Payload format for action request: {}", action.toString(), e);