Major- Replace comparison Operators

The == and != operators do type coercion before comparing values. This is bad because it can mask type errors. For example, it evaluates ' \t\r\n' == 0 as true.

It is best to always use the side-effect-less === and !== operators instead.

Issue-ID: CCSDK-1583
Change-Id: I202ada53b472542261ee69623ea72b52005fdfab
Signed-off-by: anushadasari <danush10@in.ibm.com>

diff --git a/ccsdk-app-overlay/src/main/webapp/app/ccsdk/cloudify/blueprint-controllers.js b/ccsdk-app-overlay/src/main/webapp/app/ccsdk/cloudify/blueprint-controllers.js
index 2590de1..c764165 100644 (file)
--- a/ccsdk-app-overlay/src/main/webapp/app/ccsdk/cloudify/blueprint-controllers.js
+++ b/ccsdk-app-overlay/src/main/webapp/app/ccsdk/cloudify/blueprint-controllers.js
@@ -241,13 +241,13 @@ appDS2.controller('blueprintUploadCtrl', function(
        $scope.ecdapp.validateRequest = function(uploadRequest) {
                if (uploadRequest == null)
                        return "No data found.\nPlease enter some values.";
-               if (uploadRequest.blueprint_id == null || uploadRequest.blueprint_id.trim() == '')
+               if (uploadRequest.blueprint_id == null || uploadRequest.blueprint_id.trim() === '')
                        return "ID is required.\nPlease enter a value.";
-               if (uploadRequest.blueprint_filename == null || uploadRequest.blueprint_filename.trim() == '')
+               if (uploadRequest.blueprint_filename == null || uploadRequest.blueprint_filename.trim() === '')
                        return "File name is required.\nPlease enter a value.";
-               if (uploadRequest.blueprint_filename.toLowerCase().substr(-4) != 'yaml')
+               if (uploadRequest.blueprint_filename.toLowerCase().substr(-4) !== 'yaml')
                        return "File name must end with YAML.\nPlease use that suffix.";
-               if (uploadRequest.zip_url == null || uploadRequest.zip_url.trim() == '')
+               if (uploadRequest.zip_url == null || uploadRequest.zip_url.trim() === '')
                        return "Zip file URL is required.\nPlease enter a value.";
                return null;
        }