Added null checks for getUpdateResInputObj() return value 38/93038/1
authorOleksandr Moliavko <o.moliavko@samsung.com>
Thu, 8 Aug 2019 10:13:29 +0000 (13:13 +0300)
committerOleksandr Moliavko <o.moliavko@samsung.com>
Thu, 8 Aug 2019 10:13:29 +0000 (13:13 +0300)
to prevent crash at toString() calls

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If55fd3b00fe9d2406fe1b2eeda66fa005ce13bc4

bpmn/mso-infrastructure-bpmn/src/test/java/org/onap/so/bpmn/infrastructure/pnf/delegate/CreateAndActivatePnfResourceTest.java

index fc0f51b..91cfa93 100644 (file)
@@ -63,8 +63,9 @@ public class CreateAndActivatePnfResourceTest extends BaseIntegrationTest {
     public void shouldWaitForMessageFromDmaapAndUpdateAaiEntryWhenAaiEntryExists() {
         // given
         variables.put(PNF_CORRELATION_ID, PnfManagementTestImpl.ID_WITH_ENTRY);
-        if (getUpdateResInputObj("OLT") != null) {
-            variables.put("resourceInput", getUpdateResInputObj("OLT").toString());
+        ResourceInput ri = getUpdateResInputObj("OLT");
+        if (ri != null) {
+            variables.put("resourceInput", ri.toString());
         } else {
             variables.put("resourceInput", null);
         }
@@ -86,7 +87,12 @@ public class CreateAndActivatePnfResourceTest extends BaseIntegrationTest {
     public void shouldCreateAaiEntryWaitForMessageFromDmaapAndUpdateAaiEntryWhenNoAaiEntryExists() {
         // given
         variables.put(PNF_CORRELATION_ID, PnfManagementTestImpl.ID_WITHOUT_ENTRY);
-        variables.put("resourceInput", getUpdateResInputObj("OLT").toString());
+        ResourceInput ri = getUpdateResInputObj("OLT");
+        if (ri != null) {
+            variables.put("resourceInput", ri.toString());
+        } else {
+            variables.put("resourceInput", null);
+        }
         // when
         ProcessInstance instance =
                 runtimeService.startProcessInstanceByKey("CreateAndActivatePnfResource", "businessKey", variables);