replace System.out by logger

Fix sonar issues connected to using System.out instead of Logger:
VnfInstantiationNotification,
VnfmAdapterCreationNotification,
VnfmAdapterDeletionNotification

Change-Id: I7385cbbf41c68d752e76c6ad277aec004a3cca8a
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>

diff --git a/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfInstantiationNotification.java b/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfInstantiationNotification.java
index 153970b..9a3cd95 100644 (file)
--- a/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfInstantiationNotification.java
+++ b/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfInstantiationNotification.java
@@ -22,7 +22,8 @@
 
 package org.onap.svnfm.simulator.notifications;
 
-import org.onap.svnfm.simulator.services.SvnfmService;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * 
@@ -31,16 +32,16 @@ import org.onap.svnfm.simulator.services.SvnfmService;
  */
 public class VnfInstantiationNotification implements Runnable {
 
-    SvnfmService svnfmService = new SvnfmService();
+    private static final Logger logger = LoggerFactory.getLogger(VnfInstantiationNotification.class);
 
     @Override
     public void run() {
         try {
             Thread.sleep(10000);
         } catch (final InterruptedException e) {
-            e.printStackTrace();
+            logger.error("Error occured while simulating instantiation ", e);
             Thread.currentThread().interrupt();
         }
-        System.out.println("Instantiation process finished");
+        logger.info("Instantiation process finished");
     }
 }

diff --git a/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfmAdapterCreationNotification.java b/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfmAdapterCreationNotification.java
index ff299ce..39de344 100644 (file)
--- a/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfmAdapterCreationNotification.java
+++ b/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfmAdapterCreationNotification.java
@@ -22,6 +22,9 @@
 
 package org.onap.svnfm.simulator.notifications;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * 
  * @author Lathishbabu Ganesan (lathishbabu.ganesan@est.tech)
@@ -29,15 +32,17 @@ package org.onap.svnfm.simulator.notifications;
  */
 public class VnfmAdapterCreationNotification implements Runnable {
 
+    private static final Logger logger = LoggerFactory.getLogger(VnfmAdapterCreationNotification.class);
+
     @Override
     public void run() {
         try {
             Thread.sleep(10000);
         } catch (final InterruptedException e) {
-            e.printStackTrace();
+            logger.error("Error occured while simulating creation ", e);
             Thread.currentThread().interrupt();
         }
-        System.out.println("Call to VNFM Adapter-Create");
+        logger.info("Call to VNFM Adapter-Create");
     }
 
 }

diff --git a/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfmAdapterDeletionNotification.java b/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfmAdapterDeletionNotification.java
index f7a8eaa..af6064f 100644 (file)
--- a/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfmAdapterDeletionNotification.java
+++ b/vnfm-simulator/vnfm-service/src/main/java/org/onap/svnfm/simulator/notifications/VnfmAdapterDeletionNotification.java
@@ -22,6 +22,9 @@
 
 package org.onap.svnfm.simulator.notifications;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * 
  * @author Lathishbabu Ganesan (lathishbabu.ganesan@est.tech)
@@ -29,15 +32,17 @@ package org.onap.svnfm.simulator.notifications;
  */
 public class VnfmAdapterDeletionNotification implements Runnable {
 
+    private static final Logger logger = LoggerFactory.getLogger(VnfmAdapterDeletionNotification.class);
+
     @Override
     public void run() {
         try {
             Thread.sleep(10000);
         } catch (final InterruptedException e) {
-            e.printStackTrace();
+            logger.error("Error occured while simulating deletion ", e);
             Thread.currentThread().interrupt();
         }
-        System.out.println("Call to VNFM Adapter-Delete");
+        logger.info("Call to VNFM Adapter-Delete");
     }
 
 }