Sonar Fix: ChefApiClientFactory.java

Fixed sonar issues/code-smells across this file

Issue-ID: APPC-1253
Change-Id: Id1060c34f0b99e906dba618d9ea0aebca0fc1beb
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>

diff --git a/appc-adapters/appc-chef-adapter/appc-chef-adapter-bundle/src/main/java/org/onap/appc/adapter/chef/chefclient/ChefApiClientFactory.java b/appc-adapters/appc-chef-adapter/appc-chef-adapter-bundle/src/main/java/org/onap/appc/adapter/chef/chefclient/ChefApiClientFactory.java
index c41142c..9a657c9 100644 (file)
--- a/appc-adapters/appc-chef-adapter/appc-chef-adapter-bundle/src/main/java/org/onap/appc/adapter/chef/chefclient/ChefApiClientFactory.java
+++ b/appc-adapters/appc-chef-adapter/appc-chef-adapter-bundle/src/main/java/org/onap/appc/adapter/chef/chefclient/ChefApiClientFactory.java
@@ -41,6 +41,9 @@ public class ChefApiClientFactory {
 
     private static final EELFLogger logger = EELFManager.getInstance().getLogger(ChefApiClientFactory.class);
 
+    private HttpClient httpClient = createChefHttpClient();
+    private ChefApiHeaderFactory chefApiHeaderFactory = new ChefApiHeaderFactory();
+
     private HttpClient createChefHttpClient() {
         String trustStoreFileName = "/opt/app/bvc/chef/chefServerSSL.jks";
         char[] trustStoreCreds = "adminadmin".toCharArray();
@@ -56,9 +59,6 @@ public class ChefApiClientFactory {
         return null;
     }
 
-    private HttpClient httpClient = createChefHttpClient();
-    private ChefApiHeaderFactory chefApiHeaderFactory = new ChefApiHeaderFactory();
-
     public ChefApiClient create(String endPoint, String organizations, String userId, String pemPath) {
         return new ChefApiClientImpl(httpClient, endPoint, organizations, (methodName, requestPath, body) -> chefApiHeaderFactory
                 .create(methodName, requestPath, body, userId, organizations, pemPath));