nosonar on admin logging level function

Issue-ID: POLICY-3077
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ieae80c77db297271c9de3958d321bfe4b88acce3
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

diff --git a/policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java b/policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java
index 624a604..5ac1d6d 100644 (file)
--- a/policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java
+++ b/policy-management/src/main/java/org/onap/policy/drools/controller/internal/NullDroolsController.java
@@ -26,6 +26,7 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import lombok.NonNull;
+import lombok.ToString;
 import org.onap.policy.common.endpoints.event.comm.TopicSink;
 import org.onap.policy.drools.controller.DroolsController;
 import org.onap.policy.drools.controller.DroolsControllerConstants;
@@ -35,6 +36,7 @@ import org.onap.policy.drools.protocol.coders.TopicCoderFilterConfiguration;
 /**
  * no-op Drools Controller.
  */
+@ToString
 public class NullDroolsController implements DroolsController {
 
     @Override
@@ -152,13 +154,6 @@ public class NullDroolsController implements DroolsController {
         return false;
     }
 
-    @Override
-    public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("NullDroolsController []");
-        return builder.toString();
-    }
-
     @Override
     public void updateToVersion(String newGroupId, String newArtifactId, String newVersion,
             List<TopicCoderFilterConfiguration> decoderConfigurations,

diff --git a/policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java b/policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java
index b5e6067..e3f565d 100644 (file)
--- a/policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java
+++ b/policy-utils/src/main/java/org/onap/policy/drools/utils/logging/LoggerUtil.java
@@ -21,6 +21,7 @@
 package org.onap.policy.drools.utils.logging;
 
 import ch.qos.logback.classic.LoggerContext;
+import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.slf4j.Marker;
 import org.slf4j.MarkerFactory;
@@ -30,6 +31,8 @@ import org.slf4j.MarkerFactory;
  */
 public class LoggerUtil {
 
+    private static final Logger LOGGER = LoggerFactory.getLogger(LoggerUtil.class);
+
     /**
      * Logback configuration file system property.
      */
@@ -86,8 +89,15 @@ public class LoggerUtil {
             throw new IllegalArgumentException("no logger " + loggerName);
         }
 
+        LOGGER.warn("setting {} logger to level {}", loggerName, loggerLevel);
+
         // use the current log level if the string provided cannot be converted to a valid Level.
-        logger.setLevel(ch.qos.logback.classic.Level.toLevel(loggerLevel, logger.getLevel()));
+
+        // NOSONAR: this method is currently used by the telemetry api (which should be authenticated).
+        // It is no more or no less dangerous than an admin changing the logback level on the fly.
+        // This is a controlled admin function that should not cause any risks when the system
+        // is configured properly.
+        logger.setLevel(ch.qos.logback.classic.Level.toLevel(loggerLevel, logger.getLevel()));  // NOSONAR
 
         return logger.getLevel().toString();
     }