optimize catalog api 48/97348/3
authorhewei-cmss <hewei@cmss.chinamobile.com>
Mon, 21 Oct 2019 03:06:41 +0000 (11:06 +0800)
committerhewei-cmss <hewei@cmss.chinamobile.com>
Mon, 21 Oct 2019 06:43:22 +0000 (14:43 +0800)
Issue-ID: VFC-1504

Signed-off-by: hewei-cmss <hewei@cmss.chinamobile.com>
Change-Id: I9cb4f64f365700e1899742bfa17fc42c8919e172

catalog/packages/biz/sdc_vnf_package.py
catalog/packages/biz/service_descriptor.py
catalog/packages/biz/vnf_package.py

index 571c3bb..81e4454 100644 (file)
@@ -217,6 +217,9 @@ class NfPackage(object):
     def get_csars(self):
         csars = []
         nf_pkgs = VnfPackageModel.objects.filter()
+        if not nf_pkgs.exists():
+            logger.debug("NF package infos does not exist.")
+            return []
         for nf_pkg in nf_pkgs:
             ret = self.get_csar(nf_pkg.vnfPackageId)
             csars.append(ret[1])
index 11b6fb3..3814ace 100644 (file)
@@ -20,7 +20,7 @@ import uuid
 from catalog.packages.const import PKG_STATUS
 from catalog.pub.config.config import CATALOG_ROOT_PATH
 from catalog.pub.database.models import ServicePackageModel, VnfPackageModel, PnfPackageModel
-from catalog.pub.exceptions import CatalogException, PackageNotFoundException
+from catalog.pub.exceptions import CatalogException
 from catalog.pub.utils import toscaparser, fileutil
 from catalog.pub.utils.values import ignore_case_get
 
@@ -121,8 +121,8 @@ class ServiceDescriptor(object):
         logger.info('Start to delete ServiceD(%s)...' % serviced_info_id)
         service_pkgs = ServicePackageModel.objects.filter(servicePackageId=serviced_info_id)
         if not service_pkgs.exists():
-            logger.warn('ServiceD(%s) not found.' % serviced_info_id)
-            raise PackageNotFoundException("Service package[%s] not Found." % serviced_info_id)
+            logger.info('ServiceD(%s) not found.' % serviced_info_id)
+            return
         service_pkgs.delete()
         service_pkg_path = os.path.join(CATALOG_ROOT_PATH, serviced_info_id)
         fileutil.delete_dirs(service_pkg_path)
index 585a599..7cba448 100644 (file)
@@ -61,6 +61,9 @@ class VnfPackage(object):
     def query_multiple(self):
         pkgs_info = []
         nf_pkgs = VnfPackageModel.objects.filter()
+        if not nf_pkgs.exists():
+            logger.debug("VNF infos does not exist.")
+            return []
         for nf_pkg in nf_pkgs:
             ret = fill_response_data(nf_pkg)
             pkgs_info.append(ret)