Make `collectNewCapabilities` return an empty Map

- Made `collectNewCapabilities` return an empty HashMap instead of a null value

Issue-ID: SDC-2924
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I58c35135be5a2614c3daeafbd766d53f401f917b

diff --git a/catalog-model/src/main/java/org/openecomp/sdc/be/model/operations/impl/GroupTypeOperation.java b/catalog-model/src/main/java/org/openecomp/sdc/be/model/operations/impl/GroupTypeOperation.java
index a6538dc..ebaaf81 100644 (file)
--- a/catalog-model/src/main/java/org/openecomp/sdc/be/model/operations/impl/GroupTypeOperation.java
+++ b/catalog-model/src/main/java/org/openecomp/sdc/be/model/operations/impl/GroupTypeOperation.java
@@ -232,10 +232,12 @@ public class GroupTypeOperation implements IGroupTypeOperation {
      * @param oldCapabilities
      * @return
      */
-    private Map<String, CapabilityDefinition> collectNewCapabilities(Map<String, CapabilityDefinition> updatedGroupTypeCapabilities, Map<String, CapabilityDefinition> oldCapabilities) {
-        return updatedGroupTypeCapabilities != null? updatedGroupTypeCapabilities.entrySet().stream()
-                .filter(entry -> !oldCapabilities.containsKey(entry.getKey()))
-                .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue) ): null;
+    private Map<String, CapabilityDefinition> collectNewCapabilities(
+        Map<String, CapabilityDefinition> updatedGroupTypeCapabilities,
+        Map<String, CapabilityDefinition> oldCapabilities) {
+        return updatedGroupTypeCapabilities != null ? updatedGroupTypeCapabilities.entrySet().stream()
+            .filter(entry -> !oldCapabilities.containsKey(entry.getKey()))
+            .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)) : new HashMap<>();
     }
 
     private JanusGraphOperationStatus createCapabilities(GroupTypeData groupTypeData, Map<String, CapabilityDefinition> groupCapabilities) {