Rename test classes in apex-pdp/model,core 46/75046/1
authorParshad Patel <pars.patel@samsung.com>
Fri, 21 Dec 2018 06:36:35 +0000 (15:36 +0900)
committerParshad Patel <pars.patel@samsung.com>
Fri, 21 Dec 2018 06:43:34 +0000 (15:43 +0900)
Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes

Issue-ID: POLICY-1263
Change-Id: I6cb8d09799d7abd1b50ead1edbc4986649ad4ba7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
21 files changed:
core/core-deployment/src/test/java/org/onap/policy/apex/core/deployment/SupportMessageListenerTester.java [moved from core/core-deployment/src/test/java/org/onap/policy/apex/core/deployment/TestMessageListener.java with 94% similarity]
core/core-engine/src/test/java/org/onap/policy/apex/core/engine/engine/impl/ApexEngineImplTest.java
core/core-engine/src/test/java/org/onap/policy/apex/core/engine/engine/impl/DummyEnEventListener.java [moved from core/core-engine/src/test/java/org/onap/policy/apex/core/engine/engine/impl/BadListener.java with 96% similarity]
core/core-engine/src/test/java/org/onap/policy/apex/core/engine/engine/impl/DummySlowEnEventListener.java [moved from core/core-engine/src/test/java/org/onap/policy/apex/core/engine/engine/impl/SlowListener.java with 96% similarity]
core/core-infrastructure/src/test/java/org/onap/policy/apex/core/infrastructure/messaging/DummyMessageListener.java [moved from core/core-infrastructure/src/test/java/org/onap/policy/apex/core/infrastructure/messaging/TestMessageListener.java with 95% similarity]
core/core-protocols/src/test/java/org/onap/policy/apex/core/protocols/SupportMessageTester.java [moved from core/core-protocols/src/test/java/org/onap/policy/apex/core/protocols/MessageTest.java with 99% similarity]
model/engine-model/src/test/java/org/onap/policy/apex/model/enginemodel/handling/ApexEngineModelTest.java
model/engine-model/src/test/java/org/onap/policy/apex/model/enginemodel/handling/DummyTestApexEngineModelCreator.java [moved from model/engine-model/src/test/java/org/onap/policy/apex/model/enginemodel/handling/TestApexEngineModelCreator.java with 98% similarity]
model/event-model/src/test/java/org/onap/policy/apex/model/eventmodel/handling/ApexEventModelTest.java
model/event-model/src/test/java/org/onap/policy/apex/model/eventmodel/handling/DummyTestApexEventModelCreator.java [moved from model/event-model/src/test/java/org/onap/policy/apex/model/eventmodel/handling/TestApexEventModelCreator.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexApiResultTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestApiResult.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexEditorApiContextAlbumTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestApexEditorApiContextAlbum.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexEditorApiContextSchemaTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestApexEditorApiContextSchema.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexEditorApiEventTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestApexEditorApiEvent.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexEditorApiKeyInfoTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestApexEditorApiKeyInfo.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexEditorApiPolicyTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestApexEditorApiPolicy.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexEditorApiTaskTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestApexEditorApiTask.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ApexModelApiTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestApexModelApi.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ModelFacadeTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestModelFacade.java with 99% similarity]
model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/ModelHandlerFacadeTest.java [moved from model/model-api/src/test/java/org/onap/policy/apex/model/modelapi/TestModelHandlerFacade.java with 99% similarity]
model/policy-model/src/test/java/org/onap/policy/apex/model/policymodel/utils/SupportPolicyModelValidator.java [moved from model/policy-model/src/test/java/org/onap/policy/apex/model/policymodel/utils/PolicyModelValidator.java with 97% similarity]

@@ -29,7 +29,7 @@ import org.onap.policy.apex.core.protocols.Message;
 /**
  * A test message listener.
  */
-public class TestMessageListener implements MessageListener<Message> {
+public class SupportMessageListenerTester implements MessageListener<Message> {
     @Override
     public void onMessage(String messageString) {
         fail("Message should not be received");
index 2a80cf0..6d35adc 100644 (file)
@@ -371,7 +371,7 @@ public class ApexEngineImplTest {
         }
 
         try {
-            engine.addEventListener("badListener", new BadListener());
+            engine.addEventListener("badListener", new DummyEnEventListener());
         } catch (Exception e) {
             fail("test should not throw an exception");
         }
@@ -394,7 +394,7 @@ public class ApexEngineImplTest {
 
         try {
             engine.removeEventListener("badListener");
-            engine.addEventListener("slowListener", new SlowListener());
+            engine.addEventListener("slowListener", new DummySlowEnEventListener());
         } catch (Exception e) {
             fail("test should not throw an exception");
         }
@@ -414,7 +414,7 @@ public class ApexEngineImplTest {
             fail("test should not throw an exception");
         }
 
-        SlowListener slowListener = new SlowListener();
+        DummySlowEnEventListener slowListener = new DummySlowEnEventListener();
         try {
             engine.addEventListener("slowListener", slowListener);
         } catch (Exception e) {
@@ -28,7 +28,7 @@ import org.onap.policy.apex.model.basicmodel.concepts.ApexException;
  * Dummy engine event listener for unit test.
  *
  */
-public class BadListener implements EnEventListener {
+public class DummyEnEventListener implements EnEventListener {
 
     /*
      * (non-Javadoc)
@@ -28,7 +28,7 @@ import org.onap.policy.apex.model.basicmodel.concepts.ApexException;
  * Dummy engine event listener for unit test.
  *
  */
-public class SlowListener implements EnEventListener {
+public class DummySlowEnEventListener implements EnEventListener {
 
     private long waitTime;
 
@@ -33,10 +33,10 @@ import org.slf4j.ext.XLoggerFactory;
  * method is invoked.
  *
  */
-public abstract class TestMessageListener implements MessageListener<String> {
+public abstract class DummyMessageListener implements MessageListener<String> {
 
     /** The Constant logger. */
-    private static final XLogger logger = XLoggerFactory.getXLogger(TestMessageListener.class);
+    private static final XLogger logger = XLoggerFactory.getXLogger(DummyMessageListener.class);
 
     /**
      * On command.
index 32c4ff3..d0b8f3e 100644 (file)
@@ -48,7 +48,7 @@ public class ApexEngineModelTest {
         Class.forName("org.apache.derby.jdbc.EmbeddedDriver").newInstance();
         connection = DriverManager.getConnection("jdbc:derby:memory:apex_test;create=true");
 
-        testApexModel = new TestApexModel<AxEngineModel>(AxEngineModel.class, new TestApexEngineModelCreator());
+        testApexModel = new TestApexModel<AxEngineModel>(AxEngineModel.class, new DummyTestApexEngineModelCreator());
     }
 
     @After
@@ -35,7 +35,7 @@ import org.onap.policy.apex.model.enginemodel.concepts.AxEngineModel;
 import org.onap.policy.apex.model.enginemodel.concepts.AxEngineState;
 import org.onap.policy.apex.model.enginemodel.concepts.AxEngineStats;
 
-public class TestApexEngineModelCreator implements TestApexModelCreator<AxEngineModel> {
+public class DummyTestApexEngineModelCreator implements TestApexModelCreator<AxEngineModel> {
 
     @Override
     public AxEngineModel getModel() {
index aaed3cd..88736d1 100644 (file)
@@ -48,7 +48,7 @@ public class ApexEventModelTest {
         Class.forName("org.apache.derby.jdbc.EmbeddedDriver").newInstance();
         connection = DriverManager.getConnection("jdbc:derby:memory:apex_test;create=true");
 
-        testApexModel = new TestApexModel<AxEventModel>(AxEventModel.class, new TestApexEventModelCreator());
+        testApexModel = new TestApexModel<AxEventModel>(AxEventModel.class, new DummyTestApexEventModelCreator());
     }
 
     @After
@@ -32,7 +32,7 @@ import org.onap.policy.apex.model.eventmodel.concepts.AxEventModel;
 import org.onap.policy.apex.model.eventmodel.concepts.AxEvents;
 import org.onap.policy.apex.model.eventmodel.concepts.AxField;
 
-public class TestApexEventModelCreator implements TestApexModelCreator<AxEventModel> {
+public class DummyTestApexEventModelCreator implements TestApexModelCreator<AxEventModel> {
 
     @Override
     public AxEventModel getModel() {
@@ -35,7 +35,7 @@ import org.onap.policy.apex.model.modelapi.ApexApiResult.Result;
  * Test API results.
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public class TestApiResult {
+public class ApexApiResultTest {
 
     @Test
     public void testApiResult() {
@@ -29,7 +29,7 @@ import org.junit.Test;
  * Context album for API tests.
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public class TestApexEditorApiContextAlbum {
+public class ApexEditorApiContextAlbumTest {
     @Test
     public void testContextAlbumCrud() {
         final ApexModel apexModel = new ApexModelFactory().createApexModel(null, false);
@@ -29,7 +29,7 @@ import org.junit.Test;
  * Context schema for API tests.
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public class TestApexEditorApiContextSchema {
+public class ApexEditorApiContextSchemaTest {
     @Test
     public void testContextSchemaCrud() {
         final ApexModel apexModel = new ApexModelFactory().createApexModel(null, false);
@@ -29,7 +29,7 @@ import org.junit.Test;
  * Test events for API tests.
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public class TestApexEditorApiEvent {
+public class ApexEditorApiEventTest {
     @Test
     public void testEventCrud() {
         final ApexModel apexModel = new ApexModelFactory().createApexModel(null, false);
@@ -29,7 +29,7 @@ import org.junit.Test;
  * Test policies for API tests.
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public class TestApexEditorApiPolicy {
+public class ApexEditorApiPolicyTest {
     @Test
     public void myTestPolicyCrud() {
         final ApexModel apexModel = new ApexModelFactory().createApexModel(null, false);
@@ -29,7 +29,7 @@ import org.junit.Test;
  * Test tasks for API tests.
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public class TestApexEditorApiTask {
+public class ApexEditorApiTaskTest {
     @Test
     public void testTaskCrud() {
         final ApexModel apexModel = new ApexModelFactory().createApexModel(null, false);
@@ -43,7 +43,7 @@ import org.onap.policy.apex.model.utilities.TextFileUtils;
  * Test the apex model API.
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public class TestApexModelApi {
+public class ApexModelApiTest {
     private Connection connection;
 
     @Before
@@ -37,7 +37,7 @@ import org.onap.policy.apex.model.utilities.TextFileUtils;
  * Test the model handler facade.
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public class TestModelHandlerFacade {
+public class ModelHandlerFacadeTest {
 
     @Test
     public void testModelHandlerFacade() throws IOException {