Implement missing code styles 50/112050/3
authorshabs2020 <shabnam.sultana@highstreet-technologies.com>
Wed, 2 Sep 2020 15:04:24 +0000 (17:04 +0200)
committershabs2020 <shabnam.sultana@highstreet-technologies.com>
Wed, 2 Sep 2020 16:54:27 +0000 (18:54 +0200)
One line project element in all pom files and autogenerated block comment removed from the java files

Issue-ID: CCSDK-2719
Signed-off-by: shabs2020 <shabnam.sultana@highstreet-technologies.com>
Change-Id: Icdc64b573517b273e8c65b0f637477483b91a924
Signed-off-by: shabs2020 <shabnam.sultana@highstreet-technologies.com>
sdnr/wt/devicemanager-openroadm/installer/pom.xml
sdnr/wt/devicemanager-openroadm/provider/pom.xml
sdnr/wt/devicemanager-openroadm/provider/src/main/java/org/onap/ccsdk/features/sdnr/wt/devicemanager/openroadm/impl/DeviceManagerOpenroadmImpl.java
sdnr/wt/devicemanager-openroadm/provider/src/main/java/org/onap/ccsdk/features/sdnr/wt/devicemanager/openroadm/impl/OpenroadmDeviceChangeNotificationListener.java
sdnr/wt/devicemanager-openroadm/provider/src/main/java/org/onap/ccsdk/features/sdnr/wt/devicemanager/openroadm/impl/OpenroadmInventoryInput.java
sdnr/wt/devicemanager-openroadm/provider/src/main/java/org/onap/ccsdk/features/sdnr/wt/devicemanager/openroadm/impl/OpenroadmNetworkElement.java

index fb3131c..2750d60 100755 (executable)
@@ -20,7 +20,7 @@
   ~ ============LICENSE_END=======================================================
   ~
   -->
-
+  
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
index 5eeae51..a8f2c91 100644 (file)
@@ -65,6 +65,7 @@
             <version>1.9.10</version>
             <scope>test</scope>
         </dependency>
+
         <!-- end for testing -->
         <dependency>
             <groupId>${project.groupId}</groupId>
index efda889..fc5aaba 100644 (file)
@@ -81,13 +81,13 @@ public class DeviceManagerOpenroadmImpl implements AutoCloseable {
     }
     // end of public methods
 
+    // private methods
     /**
      * Used to close all Services, that should support AutoCloseable Pattern
      *
      * @param toClose
      * @throws Exception
      */
-    // private methods
     private void close(AutoCloseable... toCloseList) {
         for (AutoCloseable element : toCloseList) {
             if (element != null) {
index 32f8cb0..f055c59 100644 (file)
@@ -78,9 +78,7 @@ public class OpenroadmDeviceChangeNotificationListener implements OrgOpenroadmDe
                 sb.append(", ");
             }
             sb.append(edit);
-
             EventlogBuilder eventlogBuilder = new EventlogBuilder();
-
             InstanceIdentifier<?> target = edit.getTarget();
             if (target != null) {
                 eventlogBuilder.setObjectId(target.getPathArguments().toString());
@@ -91,13 +89,11 @@ public class OpenroadmDeviceChangeNotificationListener implements OrgOpenroadmDe
                 eventlogBuilder.setAttributeName(target.getTargetType().getName());
             }
             eventlogBuilder.setNodeId(netconfAccessor.getNodeId().getValue());
-
             eventlogBuilder.setNewValue(String.valueOf(edit.getOperation()));
             eventlogBuilder.setTimestamp(notification.getChangeTime());
             eventlogBuilder.setCounter(counter);
             eventlogBuilder.setSourceType(SourceType.Netconf);
             databaseProvider.writeEventLog(eventlogBuilder.build());
-
             log.info("onDeviceConfigChange (2) {}", sb);
             counter++;
         }
@@ -107,7 +103,6 @@ public class OpenroadmDeviceChangeNotificationListener implements OrgOpenroadmDe
     public void onCreateTechInfoNotification(CreateTechInfoNotification notification) {
         // TODO Auto-generated method stub
         log.info("onCreateTechInfoNotification(1){}", notification);
-
         EventlogBuilder eventlogBuilder = new EventlogBuilder();
         eventlogBuilder.setId(notification.getShelfId()).setAttributeName(notification.getShelfId())
                 .setObjectId(notification.getShelfId()).setNodeId(this.netconfAccessor.getNodeId().getValue())
@@ -115,7 +110,6 @@ public class OpenroadmDeviceChangeNotificationListener implements OrgOpenroadmDe
         databaseProvider.writeEventLog(eventlogBuilder.build());
         log.info("Create-techInfo Notification written ");
         counter++;
-
     }
     // end of public methods
 
index be79c7b..d67db8a 100644 (file)
@@ -45,11 +45,6 @@ public class OpenroadmInventoryInput {
     private final NetconfAccessor accessor;
     // end of variables
 
-    /**
-     * @param netconfAccessor
-     * @param readDevice
-     */
-
     // constructors
     public OpenroadmInventoryInput(NetconfAccessor netconfAccessor, OrgOpenroadmDevice readDevice) {
         this.openRoadmDevice = readDevice;
index 98e5e46..5fa4384 100644 (file)
@@ -110,11 +110,6 @@ public class OpenroadmNetworkElement implements NetworkElement {
         readInterfaceData(device);
         // Writing initial alarms at the time of device registration
         initialAlarmReader.faultService();
-        // faultEventListener.initCurrentProblemStatus(this.netconfAccessor.getNodeId(),
-        // oScaFaultListener.writeFaultData(this.sequenceNumber));
-        // oScaFaultListener.writeAlarmLog(oScaFaultListener.writeFaultData(this.sequenceNumber));
-        // this.sequenceNumber = this.sequenceNumber + 1;
-
         pmDataEntity = this.openRoadmPmData.buildPmDataEntity(this.openRoadmPmData.getPmData(this.netconfAccessor));
         if (!pmDataEntity.isEmpty()) {
             this.databaseService.doWritePerformanceData(pmDataEntity);