sonar fix - FeatureServerPool 30/109530/4
authorTaka Cho <takamune.cho@att.com>
Wed, 24 Jun 2020 20:24:26 +0000 (16:24 -0400)
committerTaka Cho <takamune.cho@att.com>
Fri, 26 Jun 2020 14:49:00 +0000 (10:49 -0400)
- sonar thinks one block of comments are code,
  so changed some syntax in comments
- not more than one break or continue statement

Issue-ID: POLICY-2616
Change-Id: Ia35b73584f5a8492320c4beaa069ba7f903ce268
Signed-off-by: Taka Cho <takamune.cho@att.com>
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/FeatureServerPool.java

index 23da071..cce7a09 100644 (file)
@@ -120,8 +120,8 @@ public class FeatureServerPool
      * Example <field-list>: requestID,CommonHeader.RequestID
      *
      * Table generated from this example has length 2:
-     * table[0] = {"requestID"}
-     * table[1] = {"CommonHeader", "RequestID"}
+     * table 0 is "requestID"
+     * table 1 is "CommonHeader", "RequestID"
      */
     private static HashMap<String, String[][]> topicToPaths = new HashMap<>();
 
@@ -319,17 +319,12 @@ public class FeatureServerPool
                 path[path.length - 1] = fieldName;
             }
             keyword = sco.getString(path);
+
             if (keyword != null) {
-                if (conversionFunctionName == null) {
-                    // We found a keyword -- we don't need to try other paths,
-                    // so we should break out of the loop
-                    break;
+                if (conversionFunctionName != null) {
+                    keyword = Keyword.convertKeyword(keyword, conversionFunctionName);
                 }
-
-                // we have post-processing to do
-                keyword = Keyword.convertKeyword(keyword, conversionFunctionName);
                 if (keyword != null) {
-                    // conversion was successful
                     break;
                 }
             }