Added null check for vMap to prevent static 82/96282/1
authorOleksandr Moliavko <o.moliavko@samsung.com>
Thu, 26 Sep 2019 12:10:51 +0000 (15:10 +0300)
committerOleksandr Moliavko <o.moliavko@samsung.com>
Thu, 26 Sep 2019 12:10:51 +0000 (15:10 +0300)
analyzer warning about potential crash at
vMap.entrySet() call

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I6eacb28c6720b7432fd31faabacd9dc52f0abe60

bpmn/mso-infrastructure-bpmn/src/main/java/org/onap/so/bpmn/common/workflow/service/WorkflowProcessor.java

index d33e7ae..70365b7 100644 (file)
@@ -85,12 +85,14 @@ public class WorkflowProcessor extends ProcessEngineAwareService {
         Map<String, Object> inputVariables = new HashMap<>();
         @SuppressWarnings("unchecked")
         Map<String, Object> vMap = (Map<String, Object>) variableMap.get("variables");
-        for (Map.Entry<String, Object> entry : vMap.entrySet()) {
-            String vName = entry.getKey();
-            Object value = entry.getValue();
-            @SuppressWarnings("unchecked")
-            Map<String, Object> valueMap = (Map<String, Object>) value; // value, type
-            inputVariables.put(vName, valueMap.get("value"));
+        if (vMap != null) {
+            for (Map.Entry<String, Object> entry : vMap.entrySet()) {
+                String vName = entry.getKey();
+                Object value = entry.getValue();
+                @SuppressWarnings("unchecked")
+                Map<String, Object> valueMap = (Map<String, Object>) value; // value, type
+                inputVariables.put(vName, valueMap.get("value"));
+            }
         }
         return inputVariables;
     }