Make use of append instead of string concatenation 79/32779/2
authorMunir Ahmad <munir.ahmad@bell.ca>
Sat, 24 Feb 2018 18:12:56 +0000 (13:12 -0500)
committerMunir Ahmad <munir.ahmad@bell.ca>
Tue, 27 Feb 2018 00:40:10 +0000 (00:40 +0000)
Change-Id: I94ad658026f165ba8b5a74352095188a27ee50e5
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
40 files changed:
adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/cloud/CloudConfigFactory.java
adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoHeatUtils.java
adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoHeatUtilsWithUpdate.java
adapters/mso-catalog-db-adapter/src/main/java/org/openecomp/mso/adapters/catalogdb/catalogrest/QueryAllottedResourceCustomization.java
adapters/mso-catalog-db-adapter/src/main/java/org/openecomp/mso/adapters/catalogdb/catalogrest/QueryServiceNetworks.java
adapters/mso-catalog-db-adapter/src/main/java/org/openecomp/mso/adapters/catalogdb/catalogrest/QueryServiceVnfs.java
adapters/mso-catalog-db-adapter/src/main/java/org/openecomp/mso/adapters/catalogdb/catalogrest/QueryVfModule.java
adapters/mso-catalog-db-adapter/src/main/java/org/openecomp/mso/adapters/catalogdb/catalogrest/QueryVfModules.java
adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/MsoNetworkAdapterImpl.java
adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/MsoVnfAdapterImpl.java
asdc-controller/src/main/java/org/openecomp/mso/asdc/util/ASDCNotificationLogging.java
bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/adapter/vnf/MsoRequest.java
bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/HealthCheckHandler.java
bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/xml/XmlTool.java
common/src/main/java/org/openecomp/mso/logger/MsoLoggingServlet.java
common/src/main/java/org/openecomp/mso/properties/MsoJsonProperties.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/CatalogDatabase.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/HeatEnvironment.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/HeatFiles.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/HeatNestedTemplate.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/HeatTemplateArtifactUuidModelUuid.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/Model.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/ModelRecipe.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/NetworkRecipe.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/Recipe.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/Service.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/ServiceMacroHolder.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/ServiceRecipe.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/ServiceToNetworks.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/ServiceToResourceCustomization.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/TempNetworkHeatTemplateLookup.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/ToscaCsar.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VfModuleCustomization.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VfModuleToHeatFiles.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfComponent.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfComponentsRecipe.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfRecipe.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfResCustomToVfModuleCustom.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfResource.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfResourceCustomization.java

index 8da3b21..2d6d027 100644 (file)
@@ -185,12 +185,12 @@ public class CloudConfigFactory implements Serializable {
             StringBuffer response = new StringBuffer ();
             response.append ("Cloud Sites:\n");
             for (CloudSite site : cloudConfig.getCloudSites ().values ()) {
-                response.append (site.toString () + "\n");
+                response.append(site.toString()).append("\n");
             }
     
             response.append ("\n\nCloud Identity Services:\n");
             for (CloudIdentity identity : cloudConfig.getIdentityServices ().values ()) {
-                response.append (identity.toString () + "\n");
+                response.append(identity.toString()).append("\n");
             }
     
             return Response.status (200).entity (response).build ();
index 20535e9..9fe2d4c 100644 (file)
@@ -1217,18 +1217,18 @@ public class MsoHeatUtils extends MsoCommonUtils {
                } else {
                        for (String key : params.keySet()) {
                                if (params.get(key) instanceof String) {
-                                       sb.append("\n" + key + "=" + (String) params.get(key));
+                                       sb.append("\n").append(key).append("=").append((String) params.get(key));
                                } else if (params.get(key) instanceof JsonNode) {
                                        String jsonStringOut = this.convertNode((JsonNode)params.get(key));
-                                       sb.append("\n" + key + "=" + jsonStringOut);
+                                       sb.append("\n").append(key).append("=").append(jsonStringOut);
                                } else if (params.get(key) instanceof Integer) {
                                        String integerOut = "" + params.get(key);
-                                       sb.append("\n" + key + "=" + integerOut);
+                                       sb.append("\n").append(key).append("=").append(integerOut);
 
                                } else {
                                        try {
                                                String str = params.get(key).toString();
-                                               sb.append("\n" + key + "=" + str);
+                                               sb.append("\n").append(key).append("=").append(str);
                                        } catch (Exception e) {
                                                LOGGER.debug("Exception :",e);
                                        }
@@ -1272,16 +1272,16 @@ public class MsoHeatUtils extends MsoCommonUtils {
                int counter = 0;
                sb.append("OUTPUTS:\n");
                for (String key : outputs.keySet()) {
-                       sb.append("outputs[" + counter++ + "]: " + key + "=");
+                       sb.append("outputs[").append(counter++).append("]: ").append(key).append("=");
                        Object obj = outputs.get(key);
                        if (obj instanceof String) {
-                               sb.append((String)obj +" (a string)");
+                               sb.append((String) obj).append(" (a string)");
                        } else if (obj instanceof JsonNode) {
-                               sb.append(this.convertNode((JsonNode)obj) + " (a JsonNode)");
+                               sb.append(this.convertNode((JsonNode) obj)).append(" (a JsonNode)");
                        } else if (obj instanceof java.util.LinkedHashMap) {
                                try {
                                        String str = JSON_MAPPER.writeValueAsString(obj);
-                                       sb.append(str + " (a java.util.LinkedHashMap)");
+                                       sb.append(str).append(" (a java.util.LinkedHashMap)");
                                } catch (Exception e) {
                                        LOGGER.debug("Exception :",e);
                                        sb.append("(a LinkedHashMap value that would not convert nicely)");
index 2465b30..0e0b9cb 100644 (file)
@@ -365,16 +365,16 @@ public class MsoHeatUtilsWithUpdate extends MsoHeatUtils {
                int counter = 0;
                sb.append("OUTPUTS:\n");
                for (String key : outputs.keySet()) {
-                       sb.append("outputs[" + counter++ + "]: " + key + "=");
+                       sb.append("outputs[").append(counter++).append("]: ").append(key).append("=");
                        Object obj = outputs.get(key);
                        if (obj instanceof String) {
-                               sb.append((String)obj +" (a string)");
+                               sb.append((String) obj).append(" (a string)");
                        } else if (obj instanceof JsonNode) {
-                               sb.append(this.convertNode((JsonNode)obj) + " (a JsonNode)");
+                               sb.append(this.convertNode((JsonNode) obj)).append(" (a JsonNode)");
                        } else if (obj instanceof java.util.LinkedHashMap) {
                                try {
                                        String str = JSON_MAPPER.writeValueAsString(obj);
-                                       sb.append(str + " (a java.util.LinkedHashMap)");
+                                       sb.append(str).append(" (a java.util.LinkedHashMap)");
                                } catch (Exception e) {
                                        LOGGER.debug("Exception :", e);
                                        sb.append("(a LinkedHashMap value that would not convert nicely)");
index 9a82ed2..f7758c3 100644 (file)
@@ -62,30 +62,30 @@ public class QueryAllottedResourceCustomization extends CatalogQuery {
 
        @Override
        public String toString () {
-               StringBuilder buf = new StringBuilder();
+               StringBuilder sb = new StringBuilder();
 
                boolean first = true;
                int i = 1;
                for (AllottedResourceCustomization o : allottedResourceCustomization) {
-                       buf.append(i+"\t");
-                       if (!first) buf.append("\n"); first = false;
-                       buf.append(o);
+                       sb.append(i).append("\t");
+                       if (!first) sb.append("\n"); first = false;
+                       sb.append(o);
                }
-               return buf.toString();
+               return sb.toString();
     }
 
        @Override
        public String JSON2(boolean isArray, boolean isEmbed) {
-               StringBuilder buf = new StringBuilder();
-               if (!isEmbed && isArray) buf.append("{ ");
-               if (isArray) buf.append("\"serviceAllottedResources\": [");
+               StringBuilder sb = new StringBuilder();
+               if (!isEmbed && isArray) sb.append("{ ");
+               if (isArray) sb.append("\"serviceAllottedResources\": [");
                Map<String, String> valueMap = new HashMap<>();
                String sep = "";
                boolean first = true;
 
                if (this.allottedResourceCustomization != null) {
                for (AllottedResourceCustomization o : allottedResourceCustomization) {
-                       if (first) buf.append("\n"); first = false;
+                       if (first) sb.append("\n"); first = false;
 
                                boolean arNull = o.getAllottedResource() == null ? true : false;
        
@@ -104,14 +104,14 @@ public class QueryAllottedResourceCustomization extends CatalogQuery {
                            put(valueMap, "NF_NAMING_CODE",     o.getNfNamingCode());
                            put(valueMap, "PROVIDING_SERVICE_MODEL_INVARIANT_UUID",     o.getProvidingServiceModelInvariantUuid());
 
-            buf.append(sep+ this.setTemplate(template, valueMap));
+            sb.append(sep).append(this.setTemplate(template, valueMap));
             sep = ",\n";
                }
                }
-               if (!first) buf.append("\n");
-               if (isArray) buf.append("]");
-               if (!isEmbed && isArray) buf.append("}");
-               return buf.toString();
+               if (!first) sb.append("\n");
+               if (isArray) sb.append("]");
+               if (!isEmbed && isArray) sb.append("}");
+               return sb.toString();
        }
 
 }
index 59c601e..c04068d 100644 (file)
@@ -67,30 +67,30 @@ public class QueryServiceNetworks extends CatalogQuery {
 
        @Override
        public String toString () {
-               StringBuilder buf = new StringBuilder();
+               StringBuilder sb = new StringBuilder();
 
                boolean first = true;
                int i = 1;
                for (NetworkResourceCustomization o : serviceNetworks) {
-                       buf.append(i+"\t");
-                       if (!first) buf.append("\n"); first = false;
-                       buf.append(o);
+                       sb.append(i).append("\t");
+                       if (!first) sb.append("\n"); first = false;
+                       sb.append(o);
                }
-               return buf.toString();
+               return sb.toString();
     }
 
        @Override
        public String JSON2(boolean isArray, boolean isEmbed) {
-               StringBuilder buf = new StringBuilder();
-               if (!isEmbed && isArray) buf.append("{ ");
-               if (isArray) buf.append("\"serviceNetworks\": [");
-               //if (isArray) buf.append("[");
+               StringBuilder sb = new StringBuilder();
+               if (!isEmbed && isArray) sb.append("{ ");
+               if (isArray) sb.append("\"serviceNetworks\": [");
+
                Map<String, String> valueMap = new HashMap<>();
                String sep = "";
                boolean first = true;
 
                for (NetworkResourceCustomization o : serviceNetworks) {
-                       if (first) buf.append("\n"); first = false;
+                       if (first) sb.append("\n"); first = false;
                        boolean nrNull = o.getNetworkResource() == null ? true : false;
                    put(valueMap, "MODEL_NAME",               nrNull ? null : o.getNetworkResource().getModelName());
                    put(valueMap, "MODEL_UUID",               nrNull ? null : o.getNetworkResource().getModelUUID());
@@ -104,12 +104,12 @@ public class QueryServiceNetworks extends CatalogQuery {
                    put(valueMap, "NETWORK_SCOPE",             o.getNetworkScope());
                    put(valueMap, "NETWORK_TECHNOLOGY",             o.getNetworkTechnology());
 
-            buf.append(sep+ this.setTemplate(template, valueMap));
+            sb.append(sep).append(this.setTemplate(template, valueMap));
             sep = ",\n";
                }
-               if (!first) buf.append("\n");
-               if (isArray) buf.append("]");
-               if (!isEmbed && isArray) buf.append("}");
-               return buf.toString();
+               if (!first) sb.append("\n");
+               if (isArray) sb.append("]");
+               if (!isEmbed && isArray) sb.append("}");
+               return sb.toString();
        }
 }
index cfbb781..f0d4327 100644 (file)
@@ -72,29 +72,29 @@ public class QueryServiceVnfs extends CatalogQuery {
 
        @Override
        public String toString () {
-               StringBuilder buf = new StringBuilder();
+               StringBuilder sb = new StringBuilder();
 
                boolean first = true;
                int i = 1;
                for (VnfResourceCustomization o : serviceVnfs) {
-                       buf.append(i+"\t");
-                       if (!first) buf.append("\n"); first = false;
-                       buf.append(o);
+                       sb.append(i).append("\t");
+                       if (!first) sb.append("\n"); first = false;
+                       sb.append(o);
                }
-               return buf.toString();
+               return sb.toString();
     }
 
        @Override
        public String JSON2(boolean isArray, boolean isEmbed) {
-               StringBuilder buf = new StringBuilder();
-               if (!isEmbed && isArray) buf.append("{ ");
-               if (isArray) buf.append("\"serviceVnfs\": [");
+               StringBuilder sb = new StringBuilder();
+               if (!isEmbed && isArray) sb.append("{ ");
+               if (isArray) sb.append("\"serviceVnfs\": [");
                Map<String, String> valueMap = new HashMap<>();
                String sep = "";
                boolean first = true;
 
                for (VnfResourceCustomization o : serviceVnfs) {
-                       if (first) buf.append("\n"); first = false;
+                       if (first) sb.append("\n"); first = false;
 
                        boolean vrNull = o.getVnfResource() == null ? true : false;
 
@@ -113,12 +113,12 @@ public class QueryServiceVnfs extends CatalogQuery {
                    String subitem = new QueryVfModule(vrNull ? null : o.getVfModuleCustomizations()).JSON2(true, true); 
                    valueMap.put("_VFMODULES_",               subitem.replaceAll("(?m)^", "\t\t"));
 
-            buf.append(sep+ this.setTemplate(template, valueMap));
+            sb.append(sep).append(this.setTemplate(template, valueMap));
             sep = ",\n";
                }
-               if (!first) buf.append("\n");
-               if (isArray) buf.append("]");
-               if (!isEmbed && isArray) buf.append("}");
-               return buf.toString();
+               if (!first) sb.append("\n");
+               if (isArray) sb.append("]");
+               if (!isEmbed && isArray) sb.append("}");
+               return sb.toString();
        }
 }
index b2caa99..fe0f0cb 100644 (file)
@@ -69,28 +69,28 @@ public class QueryVfModule extends CatalogQuery {
 
        @Override
        public String toString () {
-               StringBuilder buf = new StringBuilder();
+               StringBuilder sb = new StringBuilder();
 
                boolean first = true;
                int i = 1;
                for (VfModuleCustomization o : vfModules) {
-                       buf.append(i+"\t");
-                       if (!first) buf.append("\n"); first = false;
-                       buf.append(o);
+                       sb.append(i).append("\t");
+                       if (!first) sb.append("\n"); first = false;
+                       sb.append(o);
                }
-               return buf.toString();
+               return sb.toString();
     }
 
        @Override
        public String JSON2(boolean isArray, boolean x) {
-               StringBuilder buf = new StringBuilder();
-               if (isArray) buf.append("\"vfModules\": [");
+               StringBuilder sb = new StringBuilder();
+               if (isArray) sb.append("\"vfModules\": [");
                Map<String, String> valueMap = new HashMap<>();
                String sep = "";
                boolean first = true;
 
                for (VfModuleCustomization o : vfModules) {
-                       if (first) buf.append("\n"); first = false;
+                       if (first) sb.append("\n"); first = false;
 
                        boolean vfNull = o.getVfModule() == null ? true : false;
                        boolean hasVolumeGroup = false;
@@ -109,11 +109,11 @@ public class QueryVfModule extends CatalogQuery {
                    put(valueMap, "INITIAL_COUNT",            o.getInitialCount());
                    put(valueMap, "HAS_VOLUME_GROUP", hasVolumeGroup);
 
-            buf.append(sep+ this.setTemplate(template, valueMap));
+            sb.append(sep).append(this.setTemplate(template, valueMap));
             sep = ",\n";
                }
-               if (!first) buf.append("\n");
-               if (isArray) buf.append("]");
-               return buf.toString();
+               if (!first) sb.append("\n");
+               if (isArray) sb.append("]");
+               return sb.toString();
        }
 }
index ff71399..00a5caf 100644 (file)
@@ -58,17 +58,17 @@ public class QueryVfModules {
        
        @Override
        public String toString () {
-               StringBuilder buf = new StringBuilder();
+               StringBuilder sb = new StringBuilder();
 
                boolean first = true;
                int i = 1;
                for (VfModule o : vfModules) {
-                       buf.append(i+"\t");
-                       if (!first) buf.append("\n");
+                       sb.append(i).append("\t");
+                       if (!first) sb.append("\n");
                        first = false;
-                       buf.append(o);
+                       sb.append(o);
                }
-               return buf.toString();
+               return sb.toString();
     }
        
        public String toJsonString() {
index f050882..82684bd 100644 (file)
@@ -1747,20 +1747,20 @@ public class MsoNetworkAdapterImpl implements MsoNetworkAdapter {
             stackParams.put (VLANS, csl);
         }
         if (routeTargets != null && !routeTargets.isEmpty()) {
-            StringBuilder buf = new StringBuilder ();
+            StringBuilder sb = new StringBuilder ();
             String sep = "";
             for (String rt : routeTargets) {
                if (!isNullOrEmpty(rt))
                {
                        if (aic3template)
-                               buf.append (sep).append ("target:" + rt);
+                               sb.append(sep).append("target:").append(rt);
                        else
-                               buf.append (sep).append (rt);
+                               sb.append (sep).append (rt);
 
                        sep = ",";
                }
             }
-            String csl = buf.toString ();
+            String csl = sb.toString ();
 
             stackParams.put ("route_targets", csl);
         }
index b8a5d9b..95e62a0 100644 (file)
@@ -508,7 +508,8 @@ public class MsoVnfAdapterImpl implements MsoVnfAdapter {
                     LOGGER.debug("Exception :",e);
                     outputString = "Unable to call toString() on the value for " + str;
                 }
-                sb.append("\t\nitem " + i++ + ": '" + str + "'='" + outputString + "'");
+                sb.append("\t\nitem ").append(i++).append(": '").append(str).append("'='").append(outputString)
+                    .append("'");
             }
         }
         LOGGER.debug(sb.toString());
@@ -524,7 +525,7 @@ public class MsoVnfAdapterImpl implements MsoVnfAdapter {
             sb.append("\tEMPTY");
         } else {
             for (String str : inputs.keySet()) {
-                sb.append("\titem " + i++ + ": " + str + "=" + inputs.get(str));
+                sb.append("\titem ").append(i++).append(": ").append(str).append("=").append(inputs.get(str));
             }
         }
         LOGGER.debug(sb.toString());
@@ -1224,7 +1225,7 @@ public class MsoVnfAdapterImpl implements MsoVnfAdapter {
             int cntr = 0;
             try {
                 for (HeatTemplateParam htp : heatTemplate.getParameters()) {
-                    sb.append("param[" + cntr++ + "]=" + htp.getParamName());
+                    sb.append("param[").append(cntr++).append("]=").append(htp.getParamName());
                     parameterNames.add(htp.getParamName());
                     if (htp.getParamAlias() != null && !"".equals(htp.getParamAlias())) {
                         aliasToParam.put(htp.getParamAlias(), htp.getParamName());
@@ -1443,16 +1444,16 @@ public class MsoVnfAdapterImpl implements MsoVnfAdapter {
 
         StringBuilder sbInit = new StringBuilder();
         sbInit.append("updateVfModule: \n");
-        sbInit.append("cloudSiteId=" + cloudSiteId + "\n");
-        sbInit.append("tenantId=" + tenantId + "\n");
-        sbInit.append("vnfType=" + vnfType + "\n");
-        sbInit.append("vnfVersion=" + vnfVersion + "\n");
-        sbInit.append("vnfName=" + vnfName + "\n");
-        sbInit.append("requestType=" + requestType + "\n");
-        sbInit.append("volumeGroupHeatStackId=" + volumeGroupHeatStackId + "\n");
-        sbInit.append("baseVfHeatStackId=" + baseVfHeatStackId + "\n");
-        sbInit.append("vfModuleStackId=" + vfModuleStackId + "\n");
-        sbInit.append("modelCustomizationUuid=" + modelCustomizationUuid + "\n");
+        sbInit.append("cloudSiteId=").append(cloudSiteId).append("\n");
+        sbInit.append("tenantId=").append(tenantId).append("\n");
+        sbInit.append("vnfType=").append(vnfType).append("\n");
+        sbInit.append("vnfVersion=").append(vnfVersion).append("\n");
+        sbInit.append("vnfName=").append(vnfName).append("\n");
+        sbInit.append("requestType=").append(requestType).append("\n");
+        sbInit.append("volumeGroupHeatStackId=").append(volumeGroupHeatStackId).append("\n");
+        sbInit.append("baseVfHeatStackId=").append(baseVfHeatStackId).append("\n");
+        sbInit.append("vfModuleStackId=").append(vfModuleStackId).append("\n");
+        sbInit.append("modelCustomizationUuid=").append(modelCustomizationUuid).append("\n");
         LOGGER.debug(sbInit.toString());
 
         String mcu = modelCustomizationUuid;
index a7ba013..2080be1 100644 (file)
@@ -311,71 +311,71 @@ public class ASDCNotificationLogging {
                        return "NULL";
                }
 
-               StringBuilder buffer = new StringBuilder("VfModuleMetaData:");
-               buffer.append(System.lineSeparator());
+               StringBuilder stringBuilder = new StringBuilder("VfModuleMetaData:");
+               stringBuilder.append(System.lineSeparator());
 
-               buffer.append("VfModuleModelName:");
-               buffer.append(testNull(moduleMetaData.getVfModuleModelName()));
-               buffer.append(System.lineSeparator());
+               stringBuilder.append("VfModuleModelName:");
+               stringBuilder.append(testNull(moduleMetaData.getVfModuleModelName()));
+               stringBuilder.append(System.lineSeparator());
 
-               buffer.append("VfModuleModelVersion:");
-               buffer.append(testNull(moduleMetaData.getVfModuleModelVersion()));
-               buffer.append(System.lineSeparator());
+               stringBuilder.append("VfModuleModelVersion:");
+               stringBuilder.append(testNull(moduleMetaData.getVfModuleModelVersion()));
+               stringBuilder.append(System.lineSeparator());
 
-               buffer.append("VfModuleModelUUID:");
-               buffer.append(testNull(moduleMetaData.getVfModuleModelUUID()));
-               buffer.append(System.lineSeparator());
+               stringBuilder.append("VfModuleModelUUID:");
+               stringBuilder.append(testNull(moduleMetaData.getVfModuleModelUUID()));
+               stringBuilder.append(System.lineSeparator());
 
-               buffer.append("VfModuleModelInvariantUUID:");
-               buffer.append(testNull(moduleMetaData.getVfModuleModelInvariantUUID()));
-               buffer.append(System.lineSeparator());
+               stringBuilder.append("VfModuleModelInvariantUUID:");
+               stringBuilder.append(testNull(moduleMetaData.getVfModuleModelInvariantUUID()));
+               stringBuilder.append(System.lineSeparator());
 
-               buffer.append("VfModuleModelDescription:");
-               buffer.append(testNull(moduleMetaData.getVfModuleModelDescription()));
-               buffer.append(System.lineSeparator());
+               stringBuilder.append("VfModuleModelDescription:");
+               stringBuilder.append(testNull(moduleMetaData.getVfModuleModelDescription()));
+               stringBuilder.append(System.lineSeparator());
 
-               buffer.append("Artifacts UUID List:");
+               stringBuilder.append("Artifacts UUID List:");
 
                if (moduleMetaData.getArtifacts() != null) {
-                       buffer.append("{");
+                       stringBuilder.append("{");
 
                        for (String artifactUUID:moduleMetaData.getArtifacts()) {
-                               buffer.append(System.lineSeparator());
-                               buffer.append(testNull(artifactUUID));
-                               buffer.append(System.lineSeparator());
-                               buffer.append(",");
+                               stringBuilder.append(System.lineSeparator());
+                               stringBuilder.append(testNull(artifactUUID));
+                               stringBuilder.append(System.lineSeparator());
+                               stringBuilder.append(",");
                        }
-                       buffer.replace(buffer.length()-1,buffer.length(), System.lineSeparator());
-                       buffer.append("}");
-                       buffer.append(System.lineSeparator());
+                       stringBuilder.replace(stringBuilder.length()-1,stringBuilder.length(), System.lineSeparator());
+                       stringBuilder.append("}");
+                       stringBuilder.append(System.lineSeparator());
                } else {
-                       buffer.append("NULL");
+                       stringBuilder.append("NULL");
                }
 
                if (moduleMetaData.getProperties() != null) {
                        Map<String, String> vfModuleMap = moduleMetaData.getProperties();
-                       buffer.append("Properties List:");
-                       buffer.append("{");
+                       stringBuilder.append("Properties List:");
+                       stringBuilder.append("{");
 
                        for (Map.Entry<String, String> entry : vfModuleMap.entrySet()) {
-                               buffer.append(System.lineSeparator());
-                               buffer.append("  " + entry.getKey() + " : " + entry.getValue());
+                               stringBuilder.append(System.lineSeparator());
+                               stringBuilder.append("  ").append(entry.getKey()).append(" : ").append(entry.getValue());
                        }
-                       buffer.replace(buffer.length()-1,buffer.length(), System.lineSeparator());
-                       buffer.append("}");
-                       buffer.append(System.lineSeparator());
+                       stringBuilder.replace(stringBuilder.length()-1,stringBuilder.length(), System.lineSeparator());
+                       stringBuilder.append("}");
+                       stringBuilder.append(System.lineSeparator());
                } else {
-                       buffer.append("NULL");
+                       stringBuilder.append("NULL");
                }
 
 
-               buffer.append(System.lineSeparator());
+               stringBuilder.append(System.lineSeparator());
 
-               buffer.append("isBase:");
-               buffer.append(moduleMetaData.isBase());
-               buffer.append(System.lineSeparator());
+               stringBuilder.append("isBase:");
+               stringBuilder.append(moduleMetaData.isBase());
+               stringBuilder.append(System.lineSeparator());
 
-               return buffer.toString();
+               return stringBuilder.toString();
        }
 
        private static String testNull(Object object) {
index c3912b4..8a9cb95 100644 (file)
@@ -106,9 +106,9 @@ public class MsoRequest {
     @Override
     public String toString() {
         StringBuilder request = new StringBuilder();
-        request.append("<requestId>"+requestId+"</requestId>");
+        request.append("<requestId>").append(requestId).append("</requestId>");
         request.append('\n');
-        request.append("<serviceInstanceId>"+serviceInstanceId+"</serviceInstanceId>");
+        request.append("<serviceInstanceId>").append(serviceInstanceId).append("</serviceInstanceId>");
         return request.toString();
     }
 
index 584ccda..9c79df8 100644 (file)
@@ -240,7 +240,8 @@ public class HealthCheckHandler  {
         //now create a soap request message as follows:
         final StringBuilder payload = new StringBuilder();
         payload.append("\n");
-        payload.append("<soapenv:Envelope xmlns:soapenv=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:req=\"" + adapterNamespace + "/requestsdb\">\n");
+        payload.append("<soapenv:Envelope xmlns:soapenv=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:req=\"")
+            .append(adapterNamespace).append("/requestsdb\">\n");
         payload.append("<soapenv:Header/>\n");
         payload.append("<soapenv:Body>\n");
         payload.append("<req:getSiteStatus>\n");
index fbfe226..f5b9f8d 100644 (file)
@@ -155,7 +155,7 @@ public final class XmlTool {
                                out.append("&amp;");
                                modified = true;
                        } else if (c < 32 || c > 126) {
-                               out.append("&#" + (int)c + ";");
+                               out.append("&#").append((int) c).append(";");
                                modified = true;
                        } else {
                                out.append(c);
@@ -199,7 +199,7 @@ public final class XmlTool {
                                out.append("&amp;");
                                modified = true;
                        } else if (c < 32 || c > 126) {
-                               out.append("&#" + (int)c + ";");
+                               out.append("&#").append((int) c).append(";");
                                modified = true;
                        } else {
                                out.append(c);
index 5687775..dd42efb 100644 (file)
@@ -95,7 +95,8 @@ public class MsoLoggingServlet {
                List <Logger> loggerList = context.getLoggerList();
         for (Logger logger:loggerList) {
                //if (logger.getLevel() != null) {
-                       response.append (logger.getName () + ":" + logger.getLevel () + " (" + logger.getEffectiveLevel () + ")\n");
+                       response.append(logger.getName()).append(":").append(logger.getLevel()).append(" (")
+                    .append(logger.getEffectiveLevel()).append(")\n");
                //}
         }
         return Response.status (200).entity (response).build ();
index cf69e1c..8da155f 100644 (file)
@@ -160,8 +160,8 @@ public class MsoJsonProperties extends AbstractMsoProperties {
        @Override
        public String toString() {
                StringBuilder response = new StringBuilder();
-               response.append("Config file " + propertiesFileName + "(Timer:" + automaticRefreshInMinutes + "mins):"
-                               + System.getProperty("line.separator"));
+               response.append("Config file ").append(propertiesFileName).append("(Timer:").append(automaticRefreshInMinutes)
+            .append("mins):").append(System.getProperty("line.separator"));
                response.append(this.jsonRootNode.toString());
                response.append(System.getProperty("line.separator"));
                response.append(System.getProperty("line.separator"));
index 891b0b2..2207bd7 100644 (file)
@@ -3464,7 +3464,7 @@ public class CatalogDatabase implements Closeable {
                        StringBuilder sb = new StringBuilder("Parameters: ");
                     for (HeatTemplateParam param : paramSet) {
                         param.setHeatTemplateArtifactUuid(heat.getArtifactUuid());
-                        sb.append(param.getParamName() + ", ");
+                        sb.append(param.getParamName()).append(", ");
                     }
                     LOGGER.debug(sb.toString());
                     heat.setParameters (paramSet);
@@ -4883,7 +4883,7 @@ public class CatalogDatabase implements Closeable {
         StringBuilder sb = new StringBuilder();
         if (variables != null) {
                for(Map.Entry<String, String> entry : variables.entrySet()){
-                       sb.append(entry.getKey() + "=" + entry.getValue() + "\n");
+                       sb.append(entry.getKey()).append("=").append(entry.getValue()).append("\n");
                        query.setParameter(entry.getKey(), entry.getValue());
                }
         }
@@ -4934,7 +4934,7 @@ public class CatalogDatabase implements Closeable {
         StringBuilder sb = new StringBuilder();
         if (variables != null) {
                for(Map.Entry<String, String> entry : variables.entrySet()){
-                       sb.append(entry.getKey() + "=" + entry.getValue()+ "\n");
+                       sb.append(entry.getKey()).append("=").append(entry.getValue()).append("\n");
                        query.setParameter(entry.getKey(), entry.getValue());
                }
         }
index dd628bb..fcd9211 100644 (file)
@@ -88,7 +88,7 @@ public class HeatEnvironment extends MavenLikeVersioning implements Serializable
     @Override
        public String toString () {
                StringBuilder sb = new StringBuilder();
-               sb.append ("Artifact UUID=" + this.artifactUuid);
+               sb.append("Artifact UUID=").append(this.artifactUuid);
         sb.append (", name=");
         sb.append (name);
         sb.append (", version=");
index b90578d..ec429c8 100644 (file)
@@ -103,23 +103,23 @@ public class HeatFiles extends MavenLikeVersioning implements Serializable {
        @Override
        public String toString () {
                StringBuilder sb = new StringBuilder();
-               sb.append ("artifactUuid=" + this.artifactUuid);
+               sb.append("artifactUuid=").append(this.artifactUuid);
                if (this.description == null) {
                        sb.append(", description=null");
                } else {
-                       sb.append(", description=" + this.description);
+                       sb.append(", description=").append(this.description);
                }
                if (this.fileName == null) {
                        sb.append(", fileName=null");
                } else {
-                       sb.append(",fileName=" + this.fileName);
+                       sb.append(",fileName=").append(this.fileName);
                }
                if (this.fileBody == null) {
                        sb.append(", fileBody=null");
                } else {
-                       sb.append(",fileBody=" + this.fileBody);
+                       sb.append(",fileBody=").append(this.fileBody);
                }
-               sb.append(", artifactChecksum=" + this.artifactChecksum);
+               sb.append(", artifactChecksum=").append(this.artifactChecksum);
                if (created != null) {
                sb.append (",created=");
                sb.append (DateFormat.getInstance().format(created));
index eec0f41..df06744 100644 (file)
@@ -61,12 +61,12 @@ public class HeatNestedTemplate implements Serializable {
     @Override
     public String toString () {
         StringBuilder sb = new StringBuilder ();
-        sb.append ("ParentTemplateId=" + this.parentTemplateId);
-        sb.append (", ChildTemplateId=" + this.childTemplateId);
+        sb.append("ParentTemplateId=").append(this.parentTemplateId);
+        sb.append(", ChildTemplateId=").append(this.childTemplateId);
         if (this.providerResourceFile == null) {
             sb.append (", providerResourceFile=null");
         } else {
-            sb.append (",providerResourceFile=" + this.providerResourceFile);
+            sb.append(",providerResourceFile=").append(this.providerResourceFile);
         }
         return sb.toString ();
     }
index 2c79d7d..54acf12 100644 (file)
@@ -48,8 +48,8 @@ public class HeatTemplateArtifactUuidModelUuid implements Serializable {
        @Override\r
        public String toString() {\r
                StringBuilder sb = new StringBuilder();\r
-               sb.append("heatTemplateArtifactUuid=" + this.heatTemplateArtifactUuid);\r
-               sb.append(" modelUuid=" + this.modelUuid);\r
+               sb.append("heatTemplateArtifactUuid=").append(this.heatTemplateArtifactUuid);\r
+               sb.append(" modelUuid=").append(this.modelUuid);\r
                return sb.toString();\r
        }\r
        \r
index 77beeb7..96e6c61 100644 (file)
@@ -185,13 +185,13 @@ public class Model extends MavenLikeVersioning implements Serializable {
        public String toString() {
                StringBuilder sb = new StringBuilder();
                sb.append("Model: ");
-               sb.append("modelCustomizationId=" + modelCustomizationId);
-               sb.append(",modelCustomizationName=" + modelCustomizationName);
-               sb.append(",modelInvariantId=" + modelInvariantId);
-               sb.append(",modelName=" + modelName);
-               sb.append(",modelType=" + modelType);
-               sb.append(",modelVersion=" + modelVersion);
-               sb.append(",modelVersionId=" + modelVersionId);
+               sb.append("modelCustomizationId=").append(modelCustomizationId);
+               sb.append(",modelCustomizationName=").append(modelCustomizationName);
+               sb.append(",modelInvariantId=").append(modelInvariantId);
+               sb.append(",modelName=").append(modelName);
+               sb.append(",modelType=").append(modelType);
+               sb.append(",modelVersion=").append(modelVersion);
+               sb.append(",modelVersionId=").append(modelVersionId);
         if (created != null) {
                sb.append (",created=");
                sb.append (DateFormat.getInstance().format(created));
index fddea47..7f8c3db 100644 (file)
@@ -169,12 +169,12 @@ public class ModelRecipe extends MavenLikeVersioning implements Serializable {
        public String toString() {
                StringBuilder sb = new StringBuilder();
                sb.append("ModelRecipe: ");
-               sb.append("modelId=" + modelId.toString());
-               sb.append(",action=" + action);
-               sb.append(",schemaVersion=" + schemaVersion);
-               sb.append(",orchestrationUri=" + orchestrationUri);
-               sb.append(",modelParamXSD=" + modelParamXSD);
-               sb.append(",recipeTimeout=" + recipeTimeout.toString());
+               sb.append("modelId=").append(modelId.toString());
+               sb.append(",action=").append(action);
+               sb.append(",schemaVersion=").append(schemaVersion);
+               sb.append(",orchestrationUri=").append(orchestrationUri);
+               sb.append(",modelParamXSD=").append(modelParamXSD);
+               sb.append(",recipeTimeout=").append(recipeTimeout.toString());
         if (created != null) {
                sb.append (",created=");
                sb.append (DateFormat.getInstance().format(created));
index 9ef1fb6..f25a99c 100644 (file)
@@ -47,8 +47,8 @@ public class NetworkRecipe extends Recipe implements Serializable {
        public String toString () {
                StringBuilder sb = new StringBuilder();
                sb.append(super.toString());
-               sb.append (",modelName=" + modelName);
-               sb.append (",networkParamXSD=" + networkParamXSD);
+               sb.append(",modelName=").append(modelName);
+               sb.append(",networkParamXSD=").append(networkParamXSD);
                return sb.toString();
        }
 }
index 668f666..a425c1e 100644 (file)
@@ -103,8 +103,8 @@ public class Recipe extends MavenLikeVersioning implements Serializable {
        @Override
     public String toString() {
         StringBuilder sb = new StringBuilder();
-        sb.append("RECIPE: " + action);
-        sb.append(",uri=" + orchestrationUri);
+        sb.append("RECIPE: ").append(action);
+        sb.append(",uri=").append(orchestrationUri);
        
         if (created != null) {
                sb.append (",created=");
index beb021a..f518678 100644 (file)
@@ -150,14 +150,17 @@ public class Service extends MavenLikeVersioning implements Serializable {
        @Override
        public String toString() {
                StringBuilder sb = new StringBuilder();
-               sb.append("SERVICE: name=" + modelName + ",modelVersion=" + modelVersion + ",description=" + description+",modelInvariantUUID="+modelInvariantUUID+",toscaCsarArtifactUUID="+toscaCsarArtifactUUID+",serviceType="+serviceType+",serviceRole="+serviceRole);
+               sb.append("SERVICE: name=").append(modelName).append(",modelVersion=").append(modelVersion)
+            .append(",description=").append(description).append(",modelInvariantUUID=").append(modelInvariantUUID)
+            .append(",toscaCsarArtifactUUID=").append(toscaCsarArtifactUUID).append(",serviceType=").append(serviceType)
+            .append(",serviceRole=").append(serviceRole);
                for (String recipeAction : recipes.keySet()) {
                        ServiceRecipe recipe = recipes.get(recipeAction);
-                       sb.append ("\n" + recipe.toString());
+                       sb.append("\n").append(recipe.toString());
                }
                
                for(ServiceToResourceCustomization serviceResourceCustomization : serviceResourceCustomizations) {
-                       sb.append("\n" + serviceResourceCustomization.toString());
+                       sb.append("\n").append(serviceResourceCustomization.toString());
                }
                if (created != null) {
                        sb.append (",created=");
index d4d0507..645626d 100644 (file)
@@ -129,7 +129,7 @@ public class ServiceMacroHolder implements Serializable {
                StringBuilder sb = new StringBuilder();
                sb.append("ServicePlus: ");
                if (this.service != null) {
-                       sb.append("service: " + this.service.toString());
+                       sb.append("service: ").append(this.service.toString());
                } else {
                        sb.append("service: null");
                }
@@ -137,7 +137,7 @@ public class ServiceMacroHolder implements Serializable {
                        int i=0;
                        sb.append("VnfResources: ");
                        for (VnfResourceCustomization vrc : this.vnfResourceCustomizations) {
-                               sb.append(", vnfResourceCustomization[" + i++ + "]:" + vrc.toString());
+                               sb.append(", vnfResourceCustomization[").append(i++).append("]:").append(vrc.toString());
                        }
                } else {
                        sb.append("none");
@@ -146,7 +146,7 @@ public class ServiceMacroHolder implements Serializable {
                        int i=0;
                        sb.append("VnfResources: ");
                        for (VnfResource vr : this.vnfResources) {
-                               sb.append(", vnfResource[" + i++ + "]:" + vr.toString());
+                               sb.append(", vnfResource[").append(i++).append("]:").append(vr.toString());
                        }
                } else {
                        sb.append("none");
@@ -155,14 +155,14 @@ public class ServiceMacroHolder implements Serializable {
                        int i=0;
                        sb.append("NetworkResourceCustomizations:");
                        for (NetworkResourceCustomization nrc : this.networkResourceCustomizations) {
-                               sb.append("NRC[" + i++ + "]: " + nrc.toString());
+                               sb.append("NRC[").append(i++).append("]: ").append(nrc.toString());
                        }
                }
                if (this.allottedResourceCustomizations != null && this.allottedResourceCustomizations.size() > 0) {
                        int i=0;
                        sb.append("AllottedResourceCustomizations:");
                        for (AllottedResourceCustomization arc : this.allottedResourceCustomizations) {
-                               sb.append("ARC[" + i++ + "]: " + arc.toString());
+                               sb.append("ARC[").append(i++).append("]: ").append(arc.toString());
                        }
                }
 
index 3a3cc0a..303570a 100644 (file)
@@ -139,8 +139,8 @@ public class ServiceRecipe extends MavenLikeVersioning implements Serializable {
        @Override
        public String toString() {
                StringBuilder sb = new StringBuilder();
-               sb.append("RECIPE: " + action);
-               sb.append(",uri=" + orchestrationUri);
+               sb.append("RECIPE: ").append(action);
+               sb.append(",uri=").append(orchestrationUri);
         if (created != null) {
                sb.append (",created=");
                sb.append (DateFormat.getInstance().format(created));
index f076e13..a380a58 100644 (file)
@@ -85,8 +85,8 @@ public class ServiceToNetworks implements Serializable {
        public String toString() {
                StringBuilder sb = new StringBuilder();
                sb.append("ServiceToNetworks mapping: ");
-               sb.append("serviceModelUuid=" + this.serviceModelUuid);
-               sb.append(",networkModelCustomizationUuid=" + networkModelCustomizationUuid);
+               sb.append("serviceModelUuid=").append(this.serviceModelUuid);
+               sb.append(",networkModelCustomizationUuid=").append(networkModelCustomizationUuid);
                return sb.toString();
        }
 
index fcd20ef..6d74ab3 100644 (file)
@@ -99,7 +99,8 @@ public class ServiceToResourceCustomization implements Serializable {
        @Override\r
        public String toString() {\r
                StringBuilder sb = new StringBuilder();\r
-               sb.append("ServiceToResourceCustomization: modelType=" + modelType + ",serviceModelUUID=" + serviceModelUUID+",resourceModelCustomizationUUID="+resourceModelCustomizationUUID);\r
+               sb.append("ServiceToResourceCustomization: modelType=").append(modelType).append(",serviceModelUUID=")\r
+            .append(serviceModelUUID).append(",resourceModelCustomizationUUID=").append(resourceModelCustomizationUUID);\r
                if (created != null) {\r
                        sb.append (",created=");\r
                        sb.append (DateFormat.getInstance().format(created));\r
index 20801c1..783fc2d 100644 (file)
@@ -66,10 +66,10 @@ public class TempNetworkHeatTemplateLookup implements Serializable {
        @Override\r
        public String toString() {\r
                StringBuilder sb = new StringBuilder();\r
-               sb.append("NetworkResourceModelName=" + this.networkResourceModelName);\r
-               sb.append("HeatTemplateArtifactUuid=" + this.heatTemplateArtifactUuid);\r
-               sb.append("aicVersionMin=" + this.aicVersionMin);\r
-               sb.append("aicVersionMax=" + this.aicVersionMax);\r
+               sb.append("NetworkResourceModelName=").append(this.networkResourceModelName);\r
+               sb.append("HeatTemplateArtifactUuid=").append(this.heatTemplateArtifactUuid);\r
+               sb.append("aicVersionMin=").append(this.aicVersionMin);\r
+               sb.append("aicVersionMax=").append(this.aicVersionMax);\r
                return sb.toString();\r
        }\r
     @Override\r
index 88a358d..591e648 100644 (file)
@@ -100,9 +100,11 @@ public class ToscaCsar extends MavenLikeVersioning implements Serializable {
        @Override\r
        public String toString() {\r
                StringBuilder sb = new StringBuilder();\r
-               sb.append("TOSCACSAR: artifactUUID=" + artifactUUID + ",name=" + name + ",version=" + version + ",description=" + description+",artifactChecksum="+artifactChecksum+",url="+url);\r
+               sb.append("TOSCACSAR: artifactUUID=").append(artifactUUID).append(",name=").append(name).append(",version=")\r
+            .append(version).append(",description=").append(description).append(",artifactChecksum=")\r
+            .append(artifactChecksum).append(",url=").append(url);\r
                for (Service service : services) {\r
-                       sb.append ("\n" + service.toString());\r
+                       sb.append("\n").append(service.toString());\r
                }\r
                if (created != null) {\r
                        sb.append (",created=");\r
index 4404834..9f2dae5 100644 (file)
@@ -112,16 +112,16 @@ public class VfModuleCustomization implements Serializable {
        @Override\r
        public String toString() {\r
                StringBuilder sb = new StringBuilder();\r
-               sb.append("modelCustomizationUuid=" + this.modelCustomizationUuid);\r
-               sb.append("vfModuleModelUuid=" + this.vfModuleModelUuid);\r
-               sb.append("label=" + this.label);\r
-               sb.append("initalCount=" + this.initialCount);\r
-               sb.append("minInstances=" + this.minInstances);\r
-               sb.append("maxInstances=" + this.maxInstances);\r
-               sb.append("availabilityZoneCount=" + this.availabilityZoneCount);\r
-               sb.append("heatEnvironmentArtifactUuid=" + this.heatEnvironmentArtifactUuid);\r
-               sb.append("volEnvironmentArtifactUuid=" + this.volEnvironmentArtifactUuid);\r
-               sb.append("created=" + this.created);\r
+               sb.append("modelCustomizationUuid=").append(this.modelCustomizationUuid);\r
+               sb.append("vfModuleModelUuid=").append(this.vfModuleModelUuid);\r
+               sb.append("label=").append(this.label);\r
+               sb.append("initalCount=").append(this.initialCount);\r
+               sb.append("minInstances=").append(this.minInstances);\r
+               sb.append("maxInstances=").append(this.maxInstances);\r
+               sb.append("availabilityZoneCount=").append(this.availabilityZoneCount);\r
+               sb.append("heatEnvironmentArtifactUuid=").append(this.heatEnvironmentArtifactUuid);\r
+               sb.append("volEnvironmentArtifactUuid=").append(this.volEnvironmentArtifactUuid);\r
+               sb.append("created=").append(this.created);\r
                return sb.toString();\r
        }\r
     @Override\r
index 63395c2..476283e 100644 (file)
@@ -50,8 +50,8 @@ public class VfModuleToHeatFiles implements Serializable {
     @Override
     public String toString () {
         StringBuilder sb = new StringBuilder ();
-        sb.append ("vfModuleModelUuid=" + this.vfModuleModelUuid);
-        sb.append (", heatFilesArtifactUuid=" + this.heatFilesArtifactUuid);
+        sb.append("vfModuleModelUuid=").append(this.vfModuleModelUuid);
+        sb.append(", heatFilesArtifactUuid=").append(this.heatFilesArtifactUuid);
         return sb.toString ();
     }
 
index 8db4902..e1795e1 100644 (file)
@@ -78,10 +78,10 @@ public class VnfComponent implements Serializable {
     public String toString() {
         StringBuilder sb = new StringBuilder();
         sb.append("VnfComponent: ");
-        sb.append("vnfId=" + vnfId);
-        sb.append(",componentType=" + componentType);
-        sb.append(",heatTemplateId=" + heatTemplateId);
-        sb.append(",heatEnvironmentId=" + heatEnvironmentId);
+        sb.append("vnfId=").append(vnfId);
+        sb.append(",componentType=").append(componentType);
+        sb.append(",heatTemplateId=").append(heatTemplateId);
+        sb.append(",heatEnvironmentId=").append(heatEnvironmentId);
         
         if (created != null) {
                sb.append (",created=");
index 42d6b82..8867170 100644 (file)
@@ -66,10 +66,10 @@ public class VnfComponentsRecipe extends Recipe implements Serializable {
        public String toString () {
                StringBuilder sb = new StringBuilder();
                sb.append(super.toString());
-               sb.append (",vnfComponentParamXSD=" + vnfComponentParamXSD);
-               sb.append (",serviceType=" + getServiceType ());
-               sb.append (",vnfComponentType=" + getVnfComponentType ());
-               sb.append (",vfModuleId=" + getVfModuleModelUUId());
+               sb.append(",vnfComponentParamXSD=").append(vnfComponentParamXSD);
+               sb.append(",serviceType=").append(getServiceType());
+               sb.append(",vnfComponentType=").append(getVnfComponentType());
+               sb.append(",vfModuleId=").append(getVfModuleModelUUId());
                return sb.toString();
        }
 }
index 29e4b89..49865e8 100644 (file)
@@ -58,9 +58,9 @@ public class VnfRecipe extends Recipe implements Serializable {
        public String toString () {
                StringBuilder sb = new StringBuilder();
                sb.append(super.toString());
-               sb.append (",vnfParamXSD=" + vnfParamXSD);
-               sb.append (",serviceType=" + getServiceType ());
-               sb.append (",vfModuleId=" + getVfModuleId ());
+               sb.append(",vnfParamXSD=").append(vnfParamXSD);
+               sb.append(",serviceType=").append(getServiceType());
+               sb.append(",vfModuleId=").append(getVfModuleId());
                return sb.toString();
        }
 }
index 9cd9f1c..7b2364d 100644 (file)
@@ -56,9 +56,9 @@ public class VnfResCustomToVfModuleCustom implements Serializable {
        @Override\r
        public String toString() {\r
                StringBuilder sb = new StringBuilder();\r
-               sb.append("vnfResourceCustModelCustomizationUuid=" + this.vnfResourceCustModelCustomizationUuid);\r
-               sb.append("vfModuleCustModelCustomizationUuid=" + this.vfModuleCustModelCustomizationUuid);\r
-               sb.append("created=" + this.created);\r
+               sb.append("vnfResourceCustModelCustomizationUuid=").append(this.vnfResourceCustModelCustomizationUuid);\r
+               sb.append("vfModuleCustModelCustomizationUuid=").append(this.vfModuleCustModelCustomizationUuid);\r
+               sb.append("created=").append(this.created);\r
                return sb.toString();\r
        }\r
     @Override\r
index 37040d6..f0b990a 100644 (file)
@@ -240,45 +240,45 @@ public class VnfResource extends MavenLikeVersioning implements Serializable {
 
        @Override
        public String toString () {
-               StringBuilder buf = new StringBuilder();
-
-               buf.append("VNF=");
-               buf.append(",modelVersion=");
-               buf.append(modelVersion);
-               buf.append(",mode=");
-               buf.append(orchestrationMode);
-               buf.append(",heatTemplateArtifactUUId=");
-               buf.append(heatTemplateArtifactUUId);
-               buf.append(",envtId=");
-               buf.append(",asdcUuid=");
-               buf.append(",aicVersionMin=");
-               buf.append(this.aicVersionMin);
-               buf.append(",aicVersionMax=");
-               buf.append(this.aicVersionMax);
-        buf.append(",modelInvariantUuid=");
-        buf.append(this.modelInvariantUuid);
-        buf.append(",modelVersion=");
-        buf.append(",modelCustomizationName=");
-        buf.append(",modelName=");
-        buf.append(this.modelName);
-        buf.append(",serviceModelInvariantUUID=");
-               buf.append(",modelCustomizationUuid=");
-        buf.append(",toscaNodeType=");
-        buf.append(toscaNodeType);
+               StringBuilder sb = new StringBuilder();
+
+               sb.append("VNF=");
+               sb.append(",modelVersion=");
+               sb.append(modelVersion);
+               sb.append(",mode=");
+               sb.append(orchestrationMode);
+               sb.append(",heatTemplateArtifactUUId=");
+               sb.append(heatTemplateArtifactUUId);
+               sb.append(",envtId=");
+               sb.append(",asdcUuid=");
+               sb.append(",aicVersionMin=");
+               sb.append(this.aicVersionMin);
+               sb.append(",aicVersionMax=");
+               sb.append(this.aicVersionMax);
+        sb.append(",modelInvariantUuid=");
+        sb.append(this.modelInvariantUuid);
+        sb.append(",modelVersion=");
+        sb.append(",modelCustomizationName=");
+        sb.append(",modelName=");
+        sb.append(this.modelName);
+        sb.append(",serviceModelInvariantUUID=");
+               sb.append(",modelCustomizationUuid=");
+        sb.append(",toscaNodeType=");
+        sb.append(toscaNodeType);
 
                if (created != null) {
-                       buf.append(",created=");
-                       buf.append(DateFormat.getInstance().format(created));
+                       sb.append(",created=");
+                       sb.append(DateFormat.getInstance().format(created));
                }
                
                for(VnfResourceCustomization vrc : vnfResourceCustomizations) {
-                       buf.append("/n" + vrc.toString());
+                       sb.append("/n").append(vrc.toString());
                        }
                
                for(VfModule vfm : vfModules) {
-                       buf.append("/n" + vfm.toString());
+                       sb.append("/n").append(vfm.toString());
                }
-               return buf.toString();
+               return sb.toString();
     }
 
 }
index 8d580fd..151c9e5 100644 (file)
@@ -180,18 +180,18 @@ public class VnfResourceCustomization extends MavenLikeVersioning implements Ser
        @Override
        public String toString() {
                StringBuilder sb = new StringBuilder("VnfResourceCustomization: ");
-               sb.append("ModelCustUuid=" + this.modelCustomizationUuid ); 
-               sb.append(", ModelInstanceName=" + this.modelInstanceName);
-               sb.append(", vnfResourceModelUuid=" + this.vnfResourceModelUUID); 
-               sb.append(", creationTimestamp=" + this.created); 
-               sb.append(", minInstances=" + this.minInstances);
-               sb.append(", maxInstances=" + this.maxInstances);
-               sb.append(", availabilityZoneMaxCount=" + this.availabilityZoneMaxCount);
+               sb.append("ModelCustUuid=").append(this.modelCustomizationUuid);
+               sb.append(", ModelInstanceName=").append(this.modelInstanceName);
+               sb.append(", vnfResourceModelUuid=").append(this.vnfResourceModelUUID);
+               sb.append(", creationTimestamp=").append(this.created);
+               sb.append(", minInstances=").append(this.minInstances);
+               sb.append(", maxInstances=").append(this.maxInstances);
+               sb.append(", availabilityZoneMaxCount=").append(this.availabilityZoneMaxCount);
 //             sb.append(", vnfResource:\n" + this.vnfResource == null ? "null" : this.vnfResource.toString());
-               sb.append(", nfFunction=" + this.nfFunction); 
-               sb.append(", nfType=" + this.nfType);
-               sb.append(", nfRole=" + this.nfRole);
-               sb.append(", nfNamingCode=" + this.nfNamingCode);
+               sb.append(", nfFunction=").append(this.nfFunction);
+               sb.append(", nfType=").append(this.nfType);
+               sb.append(", nfRole=").append(this.nfRole);
+               sb.append(", nfNamingCode=").append(this.nfNamingCode);
                
                return sb.toString();
        }