Remove powermock from ReportManagerTest 40/107740/2
authorRodrigo Lima <rodrigo.lima@yoppworks.com>
Fri, 15 May 2020 13:37:26 +0000 (09:37 -0400)
committerOfir Sonsino <ofir.sonsino@intl.att.com>
Sun, 17 May 2020 07:30:37 +0000 (07:30 +0000)
- Remove powermock reference from ReportManagerTest
- Use Junit 5 imports instead of junit 4

Issue-ID: SDC-3066
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: Iece6e5741d5f2f5bc5db2ec7c85c63948776d601

asdctool/src/test/java/org/openecomp/sdc/asdctool/impl/validator/utils/ReportManagerTest.java

index 6be7f47..e873472 100644 (file)
 
 package org.openecomp.sdc.asdctool.impl.validator.utils;
 
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.Mock;
-import org.mockito.junit.MockitoJUnitRunner;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
 import org.openecomp.sdc.asdctool.impl.validator.config.ValidationConfigManager;
 import org.openecomp.sdc.be.dao.jsongraph.GraphVertex;
-import org.powermock.core.classloader.annotations.PrepareForTest;
-import org.powermock.modules.junit4.PowerMockRunner;
-import org.powermock.modules.junit4.PowerMockRunnerDelegate;
 
 import java.io.File;
 import java.util.Arrays;
 import java.util.List;
-import java.util.Objects;
 import java.util.SortedSet;
 import java.util.TreeSet;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.mockito.Mockito.when;
 
-@RunWith(PowerMockRunner.class)
-@PowerMockRunnerDelegate(MockitoJUnitRunner.class)
-@PrepareForTest({ReportManager.class})
 public class ReportManagerTest {
 
     private static final String VERTEX_1_ID = "testID1";
@@ -79,16 +70,15 @@ public class ReportManagerTest {
         .csvReportFilePath(resourcePath, System::currentTimeMillis);
     private final static String txtReportFilePath = ValidationConfigManager.txtReportFilePath(resourcePath);
 
-    @Mock
-    GraphVertex vertexScanned;
+    private GraphVertex vertexScanned = Mockito.mock(GraphVertex.class);
 
-    @Before
+    @BeforeEach
     public void setup() {
         ReportManager.make(csvReportFilePath, txtReportFilePath);
         successResult.setStatus(true);
     }
 
-    @After
+    @AfterEach
     public void clean() {
         ReportManagerHelper.cleanReports(csvReportFilePath, txtReportFilePath);
     }